68967 2011-09-27 20:31:24 -0700 [chromium] Only initiate the beginFrameAndCommit sequence if a commit has been requested 2011-09-27 21:02:34 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr enne husky kbr nduca vangelis webkit.review.bot oldest_to_newest 474453 0 jamesr 2011-09-27 20:31:24 -0700 [chromium] Only initiate the beginFrameAndCommit sequence if a commit has been requested 474454 1 108954 jamesr 2011-09-27 20:32:27 -0700 Created attachment 108954 Patch 474456 2 jamesr 2011-09-27 20:33:17 -0700 With this patch the CCLayerTreeHost* tests pass with use_threaded_compositing=1 in debug. 474463 3 108954 jamesr 2011-09-27 20:44:16 -0700 Comment on attachment 108954 Patch Gah this is clearly wrong - m_commitRequested can only be accessed from the main thread. Will update... 474464 4 kbr 2011-09-27 20:45:22 -0700 Yes, seemed that you should be looking at the commitRequested argument. 474465 5 108955 jamesr 2011-09-27 20:45:47 -0700 Created attachment 108955 Patch 474466 6 108955 kbr 2011-09-27 20:46:35 -0700 Comment on attachment 108955 Patch That looks better. r=me 474470 7 jamesr 2011-09-27 20:49:40 -0700 Right you are, Ken. Thanks. 474475 8 108955 webkit.review.bot 2011-09-27 21:02:30 -0700 Comment on attachment 108955 Patch Clearing flags on attachment: 108955 Committed r96185: <http://trac.webkit.org/changeset/96185> 474476 9 webkit.review.bot 2011-09-27 21:02:34 -0700 All reviewed patches have been landed. Closing bug. 108954 2011-09-27 20:32:27 -0700 2011-09-27 20:45:43 -0700 Patch bug-68967-20110927203226.patch text/plain 1928 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogOTYxNzMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhNGM2NjlkZjlmMGI4MTU2 MTcyMTMxNzU0NTUzYjIwY2YzNDA1YzAxLi5lMGIyY2E0MjkwZWY5YWQwYTAyYjI2YjY4NzkzOWFk MzU3M2EzYTBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDktMjcgIEphbWVz IFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIE9u bHkgaW5pdGlhdGUgdGhlIGJlZ2luRnJhbWVBbmRDb21taXQgc2VxdWVuY2UgaWYgYSBjb21taXQg aGFzIGJlZW4gcmVxdWVzdGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD02ODk2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFdoZW4gdXBkYXRpbmcgdGhlIHNjaGVkdWxlciBzdGF0ZSwgd2Ugc2hvdWxkIG9u bHkgaW5pdGlhdGUgYSBuZXcgY29tbWl0IGZsb3cgaWYgYSBjb21taXQgaGFzIGJlZW4gcmVxdWVz dGVkIChhcworICAgICAgICBvcHBvc2VkIHRvIG9ubHkgYSByZWRyYXcpLgorCisgICAgICAgIENv dmVyZWQgYnkgdGhlIHVuaXQgdGVzdCBDQ0xheWVyVHJlZUhvc3RUZXN0U2V0TmVlZHNSZWRyYXcg d2l0aCBVU0UoVEhSRUFERURfQ09NUE9TSVRJTkcpIHNldCB0byB0cnVlLgorCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NUaHJlYWRQcm94eS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpDQ1RocmVhZFByb3h5Ojp1cGRhdGVTY2hlZHVsZXJTdGF0ZU9uQ0NUaHJlYWQp OgorCiAyMDExLTA5LTI3ICBNaWhhaSBQYXJwYXJpdGEgIDxtaWhhaXBAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI5NjE0MS4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDVGhyZWFkUHJveHku Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NUaHJl YWRQcm94eS5jcHAKaW5kZXggYTFlNzFkYWRlYjRkMTg5YTdmZDY3ZmU4Y2U5M2YwZDI5ZjQ0NzBl MC4uMzYyN2NjMDNiMGYwZTVlMjA0ZGIzYmQ5NzFjOThjZmUzMmRjMjg4MCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NUaHJlYWRQcm94 eS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2Mv Q0NUaHJlYWRQcm94eS5jcHAKQEAgLTM5Nyw3ICszOTcsNyBAQCB2b2lkIENDVGhyZWFkUHJveHk6 OnVwZGF0ZVNjaGVkdWxlclN0YXRlT25DQ1RocmVhZChib29sIGNvbW1pdFJlcXVlc3RlZCwgYm9v bCByZQogICAgIC8vIEZJWE1FOiB1c2UgQ0NTY2hlZHVsZXIgdG8gZGVjaWRlIHdoZW4gdG8gbWFu YWdlIHRoZSBjb252ZXJzaW9uIG9mIHRoaXMKICAgICAvLyBjb21taXQgcmVxdWVzdCBpbnRvIGFu IGFjdHVhbCBjcmVhdGVCZWdpbkZyYW1lQW5kQ29tbWl0VGFza09uQ0NUaHJlYWQgY2FsbC4KICAg ICBtX3JlZHJhd1JlcXVlc3RlZE9uQ0NUaHJlYWQgfD0gcmVkcmF3UmVxdWVzdGVkOwotICAgIGlm ICghbV9iZWdpbkZyYW1lQW5kQ29tbWl0UGVuZGluZ09uQ0NUaHJlYWQpIHsKKyAgICBpZiAobV9j b21taXRSZXF1ZXN0ZWQgJiYgIW1fYmVnaW5GcmFtZUFuZENvbW1pdFBlbmRpbmdPbkNDVGhyZWFk KSB7CiAgICAgICAgIENDTWFpblRocmVhZDo6cG9zdFRhc2soY3JlYXRlQmVnaW5GcmFtZUFuZENv bW1pdFRhc2tPbkNDVGhyZWFkKCkpOwogICAgICAgICByZXR1cm47CiAgICAgfQo= 108955 2011-09-27 20:45:47 -0700 2011-09-27 21:02:29 -0700 Patch bug-68967-20110927204546.patch text/plain 1926 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogOTYxNzMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhNGM2NjlkZjlmMGI4MTU2 MTcyMTMxNzU0NTUzYjIwY2YzNDA1YzAxLi5lMGIyY2E0MjkwZWY5YWQwYTAyYjI2YjY4NzkzOWFk MzU3M2EzYTBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDktMjcgIEphbWVz IFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIE9u bHkgaW5pdGlhdGUgdGhlIGJlZ2luRnJhbWVBbmRDb21taXQgc2VxdWVuY2UgaWYgYSBjb21taXQg aGFzIGJlZW4gcmVxdWVzdGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD02ODk2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFdoZW4gdXBkYXRpbmcgdGhlIHNjaGVkdWxlciBzdGF0ZSwgd2Ugc2hvdWxkIG9u bHkgaW5pdGlhdGUgYSBuZXcgY29tbWl0IGZsb3cgaWYgYSBjb21taXQgaGFzIGJlZW4gcmVxdWVz dGVkIChhcworICAgICAgICBvcHBvc2VkIHRvIG9ubHkgYSByZWRyYXcpLgorCisgICAgICAgIENv dmVyZWQgYnkgdGhlIHVuaXQgdGVzdCBDQ0xheWVyVHJlZUhvc3RUZXN0U2V0TmVlZHNSZWRyYXcg d2l0aCBVU0UoVEhSRUFERURfQ09NUE9TSVRJTkcpIHNldCB0byB0cnVlLgorCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NUaHJlYWRQcm94eS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpDQ1RocmVhZFByb3h5Ojp1cGRhdGVTY2hlZHVsZXJTdGF0ZU9uQ0NUaHJlYWQp OgorCiAyMDExLTA5LTI3ICBNaWhhaSBQYXJwYXJpdGEgIDxtaWhhaXBAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI5NjE0MS4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDVGhyZWFkUHJveHku Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NUaHJl YWRQcm94eS5jcHAKaW5kZXggYTFlNzFkYWRlYjRkMTg5YTdmZDY3ZmU4Y2U5M2YwZDI5ZjQ0NzBl MC4uZWI1NmMyOGUwZTBiNDQ5MDk4ODcwNTBjMTNjYjNmNzk1MjQzNGIyNiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NUaHJlYWRQcm94 eS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2Mv Q0NUaHJlYWRQcm94eS5jcHAKQEAgLTM5Nyw3ICszOTcsNyBAQCB2b2lkIENDVGhyZWFkUHJveHk6 OnVwZGF0ZVNjaGVkdWxlclN0YXRlT25DQ1RocmVhZChib29sIGNvbW1pdFJlcXVlc3RlZCwgYm9v bCByZQogICAgIC8vIEZJWE1FOiB1c2UgQ0NTY2hlZHVsZXIgdG8gZGVjaWRlIHdoZW4gdG8gbWFu YWdlIHRoZSBjb252ZXJzaW9uIG9mIHRoaXMKICAgICAvLyBjb21taXQgcmVxdWVzdCBpbnRvIGFu IGFjdHVhbCBjcmVhdGVCZWdpbkZyYW1lQW5kQ29tbWl0VGFza09uQ0NUaHJlYWQgY2FsbC4KICAg ICBtX3JlZHJhd1JlcXVlc3RlZE9uQ0NUaHJlYWQgfD0gcmVkcmF3UmVxdWVzdGVkOwotICAgIGlm ICghbV9iZWdpbkZyYW1lQW5kQ29tbWl0UGVuZGluZ09uQ0NUaHJlYWQpIHsKKyAgICBpZiAoY29t bWl0UmVxdWVzdGVkICYmICFtX2JlZ2luRnJhbWVBbmRDb21taXRQZW5kaW5nT25DQ1RocmVhZCkg ewogICAgICAgICBDQ01haW5UaHJlYWQ6OnBvc3RUYXNrKGNyZWF0ZUJlZ2luRnJhbWVBbmRDb21t aXRUYXNrT25DQ1RocmVhZCgpKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0K