68964 2011-09-27 19:14:08 -0700 Defer call to CSSValue::isPrimitiveValue(), saves ~4% in CSSStyleSelector::applyProperty(). 2011-09-27 23:31:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 macpherson macpherson eric macpherson webkit.review.bot oldest_to_newest 474437 0 macpherson 2011-09-27 19:14:08 -0700 Defer call to CSSValue::isPrimitiveValue(), saves ~4% in CSSStyleSelector::applyProperty(). 474438 1 108949 macpherson 2011-09-27 19:17:14 -0700 Created attachment 108949 Patch 474502 2 108949 eric 2011-09-27 22:30:00 -0700 Comment on attachment 108949 Patch Sounds good to me. 474533 3 108949 webkit.review.bot 2011-09-27 23:31:45 -0700 Comment on attachment 108949 Patch Clearing flags on attachment: 108949 Committed r96192: <http://trac.webkit.org/changeset/96192> 474534 4 webkit.review.bot 2011-09-27 23:31:49 -0700 All reviewed patches have been landed. Closing bug. 108949 2011-09-27 19:17:14 -0700 2011-09-27 23:31:45 -0700 Patch bug-68964-20110928121712.patch text/plain 2758 macpherson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk2MTc5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDktMjcgIEx1a2UgTWFj cGhlcnNvbiAgIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBEZWZlciBjYWxs IHRvIENTU1ZhbHVlOjppc1ByaW1pdGl2ZVZhbHVlKCksIHNhdmVzIH40JSBpbiBDU1NTdHlsZVNl bGVjdG9yOjphcHBseVByb3BlcnR5KCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD02ODk2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAvIG5vIGZ1bmN0aW9uYWxpdHkgY2hhbmdlZC4K KworICAgICAgICBEb2luZyB2YWx1ZS0+aXNQcmltaXRpdmVWYWx1ZSgpIGlzIHJlbGF0dmllbHkg ZXhwZW5zaXZlLCBzbyBtb3ZpbmcgaXQgYWZ0ZXIgdGhlIGVhcmx5IHJldHVybnMgYnV0CisgICAg ICAgIGJlZm9yZSB0aGUgcmVzdWx0IGlzIHVzZWQgc2F2ZXMgYSBzaWduaWZpY2FudCBudW1iZXIg b2YgY3ljbGVzLiAoVGVzdGVkIHdpdGggU2hhcmsgcHJvZmlsZXIgaW4gU2FmYXJpKS4KKworICAg ICAgICAqIGNzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1N0 eWxlU2VsZWN0b3I6OmFwcGx5UHJvcGVydHkpOgorCiAyMDExLTA5LTI3ICBLZW50YXJvIEhhcmEg IDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBJbXBsZW1lbnQgYSBNZXNzYWdlRXZl bnQgY29uc3RydWN0b3IgZm9yIEpTQwpJbmRleDogU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxl U2VsZWN0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNl bGVjdG9yLmNwcAkocmV2aXNpb24gOTYxNzIpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5 bGVTZWxlY3Rvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIzNDgsMjYgKzIzNDgsMjAgQEAgYm9v bCBDU1NTdHlsZVNlbGVjdG9yOjp1c2VTVkdab29tUnVsZXMoKQogCiB2b2lkIENTU1N0eWxlU2Vs ZWN0b3I6OmFwcGx5UHJvcGVydHkoaW50IGlkLCBDU1NWYWx1ZSAqdmFsdWUpCiB7Ci0gICAgQ1NT UHJpbWl0aXZlVmFsdWUqIHByaW1pdGl2ZVZhbHVlID0gMDsKLSAgICBpZiAodmFsdWUtPmlzUHJp bWl0aXZlVmFsdWUoKSkKLSAgICAgICAgcHJpbWl0aXZlVmFsdWUgPSBzdGF0aWNfY2FzdDxDU1NQ cmltaXRpdmVWYWx1ZSo+KHZhbHVlKTsKLQotICAgIGZsb2F0IHpvb21GYWN0b3IgPSBtX3N0eWxl LT5lZmZlY3RpdmVab29tKCk7Ci0KICAgICBMZW5ndGggbDsKIAogICAgIHVuc2lnbmVkIHNob3J0 IHZhbHVlVHlwZSA9IHZhbHVlLT5jc3NWYWx1ZVR5cGUoKTsKIAogICAgIGJvb2wgaXNJbmhlcml0 ID0gbV9wYXJlbnROb2RlICYmIHZhbHVlVHlwZSA9PSBDU1NWYWx1ZTo6Q1NTX0lOSEVSSVQ7CiAg ICAgYm9vbCBpc0luaXRpYWwgPSB2YWx1ZVR5cGUgPT0gQ1NTVmFsdWU6OkNTU19JTklUSUFMIHx8 ICghbV9wYXJlbnROb2RlICYmIHZhbHVlVHlwZSA9PSBDU1NWYWx1ZTo6Q1NTX0lOSEVSSVQpOwot ICAgIAorCiAgICAgaWQgPSBDU1NQcm9wZXJ0eTo6cmVzb2x2ZURpcmVjdGlvbkF3YXJlUHJvcGVy dHkoaWQsIG1fc3R5bGUtPmRpcmVjdGlvbigpLCBtX3N0eWxlLT53cml0aW5nTW9kZSgpKTsKIAog ICAgIGlmIChtX2NoZWNrZXIuaXNNYXRjaGluZ1Zpc2l0ZWRQc2V1ZG9DbGFzcygpICYmICFpc1Zh bGlkVmlzaXRlZExpbmtQcm9wZXJ0eShpZCkpIHsKICAgICAgICAgLy8gTGltaXQgdGhlIHByb3Bl cnRpZXMgdGhhdCBjYW4gYmUgYXBwbGllZCB0byBvbmx5IHRoZSBvbmVzIGhvbm9yZWQgYnkgOnZp c2l0ZWQuCiAgICAgICAgIHJldHVybjsKICAgICB9Ci0gICAgCisKICAgICBDU1NQcm9wZXJ0eUlE IHByb3BlcnR5ID0gc3RhdGljX2Nhc3Q8Q1NTUHJvcGVydHlJRD4oaWQpOwogCiAgICAgLy8gY2hl Y2sgbG9va3VwIHRhYmxlIGZvciBpbXBsZW1lbnRhdGlvbnMgYW5kIHVzZSB3aGVuIGF2YWlsYWJs ZQpAQCAtMjM4MSw2ICsyMzc1LDEwIEBAIHZvaWQgQ1NTU3R5bGVTZWxlY3Rvcjo6YXBwbHlQcm9w ZXJ0eShpbnQKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAorICAgIENTU1ByaW1pdGl2ZVZhbHVl KiBwcmltaXRpdmVWYWx1ZSA9IHZhbHVlLT5pc1ByaW1pdGl2ZVZhbHVlKCkgPyBzdGF0aWNfY2Fz dDxDU1NQcmltaXRpdmVWYWx1ZSo+KHZhbHVlKSA6IDA7CisKKyAgICBmbG9hdCB6b29tRmFjdG9y ID0gbV9zdHlsZS0+ZWZmZWN0aXZlWm9vbSgpOworICAgIAogICAgIC8vIFdoYXQgZm9sbG93cyBp cyBhIGxpc3QgdGhhdCBtYXBzIHRoZSBDU1MgcHJvcGVydGllcyBpbnRvIHRoZWlyIGNvcnJlc3Bv bmRpbmcgZnJvbnQtZW5kCiAgICAgLy8gUmVuZGVyU3R5bGUgdmFsdWVzLiAgU2hvcnRoYW5kcyAo ZS5nLiBib3JkZXIsIGJhY2tncm91bmQpIG9jY3VyIGluIHRoaXMgbGlzdCBhcyB3ZWxsIGFuZAog ICAgIC8vIGFyZSBvbmx5IGhpdCB3aGVuIG1hcHBpbmcgImluaGVyaXQiIG9yICJpbml0aWFsIiBp bnRvIGZyb250LWVuZCB2YWx1ZXMuCg==