<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>68961</bug_id>
          
          <creation_ts>2011-09-27 17:08:59 -0700</creation_ts>
          <short_desc>Get JSVALUE32_64 DFG JIT building on OS X.</short_desc>
          <delta_ts>2011-09-27 18:08:40 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Gavin Barraclough">barraclough</reporter>
          <assigned_to name="Gavin Barraclough">barraclough</assigned_to>
          <cc>webkit.review.bot</cc>
    
    <cc>yuqiang.xian</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>474377</commentid>
    <comment_count>0</comment_count>
    <who name="Gavin Barraclough">barraclough</who>
    <bug_when>2011-09-27 17:08:59 -0700</bug_when>
    <thetext>* Merge bug #68763 (DFG JIT should not eagerly initialize integer tags in the register file).
* Forward-declare functions in DFGOperations.cpp
* UNUSED_PARAM for unused arguments
* NO_RETURN for unimplemented function that ASSERT_NOT_REACHED
* Fix argument types handled by OpInfo constructor.
* Use SYMBOL_STRING instead of STRINGIZE for asm symbols.
* Add files to Xcode project.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>474378</commentid>
    <comment_count>1</comment_count>
      <attachid>108937</attachid>
    <who name="Gavin Barraclough">barraclough</who>
    <bug_when>2011-09-27 17:10:19 -0700</bug_when>
    <thetext>Created attachment 108937
Fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>474379</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-09-27 17:11:56 -0700</bug_when>
    <thetext>Attachment 108937 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Source/JavaScriptCore/ChangeLog&apos;, u&apos;Source...&quot; exit_code: 1

Source/JavaScriptCore/ChangeLog:8:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:9:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:10:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:11:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:12:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:13:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:14:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 7 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>474406</commentid>
    <comment_count>3</comment_count>
      <attachid>108937</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2011-09-27 17:52:51 -0700</bug_when>
    <thetext>Comment on attachment 108937
Fix

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>474414</commentid>
    <comment_count>4</comment_count>
    <who name="Gavin Barraclough">barraclough</who>
    <bug_when>2011-09-27 18:08:40 -0700</bug_when>
    <thetext>Fixed in r96175</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>108937</attachid>
            <date>2011-09-27 17:10:19 -0700</date>
            <delta_ts>2011-09-27 17:52:50 -0700</delta_ts>
            <desc>Fix</desc>
            <filename>68961.patch</filename>
            <type>text/plain</type>
            <size>0</size>
            <attacher name="Gavin Barraclough">barraclough</attacher>
            
              <data encoding="base64"></data>
<flag name="review"
          id="106028"
          type_id="1"
          status="+"
          setter="ggaren"
    />
          </attachment>
      

    </bug>

</bugzilla>