68958 2011-09-27 16:39:29 -0700 Remove deprecated calls from CookieJarCFNet.cpp 2012-01-05 10:39:34 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 psolanki psolanki aroben jberlin psolanki oldest_to_newest 474350 0 psolanki 2011-09-27 16:39:29 -0700 CookieJarCFNet does soft-linking and calls CFHTTPCookieCopy* functions instead of CFHTTPCookieGet* functions. However, since the code references the Get version of the functions, we still get compile warnings. We can just switch over to the Copy variants, assuming the buildbot is happy. 474354 1 108931 psolanki 2011-09-27 16:44:18 -0700 Created attachment 108931 Patch 474356 2 psolanki 2011-09-27 16:44:53 -0700 Lets see what the windows EWS bot says for this patch. 530414 3 psolanki 2012-01-05 10:39:34 -0800 Committed r104179: <http://trac.webkit.org/changeset/104179> 108931 2011-09-27 16:44:18 -0700 2012-01-04 15:24:30 -0800 Patch bug-68958-20110927164417.patch text/plain 3724 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogOTYxNDkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiYzU4NTE1NDYxMDdhMGQ1 MzYyYmM1MDY1MjhhMzZiMGJiZWU3NmYzLi43NTk2ZjdiMDQ1YjNiYTFiZTk1NjUxMDhjMjc4ZjEy ZDQ3YTJiZDJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkgQEAKIDIwMTEtMDktMjcgIFByYXRp ayBTb2xhbmtpICA8cHNvbGFua2lAYXBwbGUuY29tPgogCisgICAgICAgIFJlbW92ZSBkZXByZWNh dGVkIGNhbGxzIGZyb20gQ29va2llSmFyQ0ZOZXQuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODk1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jZi9Db29raWVKYXJD Rk5ldC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjb29raWVEb21haW4pOgorICAgICAgICAoV2Vi Q29yZTo6Y29va2llRXhwaXJhdGlvblRpbWUpOgorICAgICAgICAoV2ViQ29yZTo6Y29va2llTmFt ZSk6CisgICAgICAgIChXZWJDb3JlOjpjb29raWVQYXRoKToKKyAgICAgICAgKFdlYkNvcmU6OmNv b2tpZVZhbHVlKToKKworMjAxMS0wOS0yNyAgUHJhdGlrIFNvbGFua2kgIDxwc29sYW5raUBhcHBs ZS5jb20+CisKICAgICAgICAgQ2FjaGVkUmVzb3VyY2VSZXF1ZXN0IHNob3VsZCBzdXBwb3J0IGRp ZFJlY2VpdmVEYXRhQXJyYXkKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTY4OTI4CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvY2YvQ29va2llSmFyQ0ZOZXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9jZi9Db29raWVKYXJDRk5ldC5jcHAKaW5kZXggNThmOTJhMGNiYzBlYjMyMmVjMTRkZGU5 Y2Y3ZDU4MmJkZTU4NjU0NS4uMDU5MjljMWY0NmIwNWI3ZWMyMjhjNWFmMGUxZjJiMWNkZWEwNjFm YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9Db29raWVK YXJDRk5ldC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9Db29r aWVKYXJDRk5ldC5jcHAKQEAgLTQ4LDU1ICs0OCwyOSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBz dGF0aWMgY29uc3QgQ0ZTdHJpbmdSZWYgc19zZXRDb29raWVLZXlDRiA9IENGU1RSKCJTZXQtQ29v a2llIik7CiBzdGF0aWMgY29uc3QgQ0ZTdHJpbmdSZWYgc19jb29raWVDRiA9IENGU1RSKCJDb29r aWUiKTsKIAotI2lmIFBMQVRGT1JNKFdJTikKLSNpZmRlZiBERUJVR19BTEwKLVNPRlRfTElOS19E RUJVR19MSUJSQVJZKENGTmV0d29yaykKLSNlbHNlCi1TT0ZUX0xJTktfTElCUkFSWShDRk5ldHdv cmspCi0jZW5kaWYKLSNlbHNlCi1TT0ZUX0xJTktfRlJBTUVXT1JLX0lOX0NPUkVTRVJWSUNFU19V TUJSRUxMQShDRk5ldHdvcmspCi0jZW5kaWYKLQotU09GVF9MSU5LX09QVElPTkFMKENGTmV0d29y aywgQ0ZIVFRQQ29va2llQ29weURvbWFpbiwgQ0ZTdHJpbmdSZWYsIF9fY2RlY2wsIChDRkhUVFBD b29raWVSZWYpKQotU09GVF9MSU5LX09QVElPTkFMKENGTmV0d29yaywgQ0ZIVFRQQ29va2llR2V0 RXhwaXJhdGlvblRpbWUsIENGQWJzb2x1dGVUaW1lLCBfX2NkZWNsLCAoQ0ZIVFRQQ29va2llUmVm KSkKLVNPRlRfTElOS19PUFRJT05BTChDRk5ldHdvcmssIENGSFRUUENvb2tpZUNvcHlOYW1lLCBD RlN0cmluZ1JlZiwgX19jZGVjbCwgKENGSFRUUENvb2tpZVJlZikpCi1TT0ZUX0xJTktfT1BUSU9O QUwoQ0ZOZXR3b3JrLCBDRkhUVFBDb29raWVDb3B5UGF0aCwgQ0ZTdHJpbmdSZWYsIF9fY2RlY2ws IChDRkhUVFBDb29raWVSZWYpKQotU09GVF9MSU5LX09QVElPTkFMKENGTmV0d29yaywgQ0ZIVFRQ Q29va2llQ29weVZhbHVlLCBDRlN0cmluZ1JlZiwgX19jZGVjbCwgKENGSFRUUENvb2tpZVJlZikp Ci0KIHN0YXRpYyBpbmxpbmUgUmV0YWluUHRyPENGU3RyaW5nUmVmPiBjb29raWVEb21haW4oQ0ZI VFRQQ29va2llUmVmIGNvb2tpZSkKIHsKLSAgICBpZiAoQ0ZIVFRQQ29va2llQ29weURvbWFpblB0 cigpKQotICAgICAgICByZXR1cm4gUmV0YWluUHRyPENGU3RyaW5nUmVmPihBZG9wdENGLCBDRkhU VFBDb29raWVDb3B5RG9tYWluUHRyKCkoY29va2llKSk7Ci0gICAgcmV0dXJuIENGSFRUUENvb2tp ZUdldERvbWFpbihjb29raWUpOworICAgIHJldHVybiBSZXRhaW5QdHI8Q0ZTdHJpbmdSZWY+KEFk b3B0Q0YsIENGSFRUUENvb2tpZUNvcHlEb21haW4oY29va2llKSk7CiB9CiAKIHN0YXRpYyBpbmxp bmUgQ0ZBYnNvbHV0ZVRpbWUgY29va2llRXhwaXJhdGlvblRpbWUoQ0ZIVFRQQ29va2llUmVmIGNv b2tpZSkKIHsKLSAgICBpZiAoQ0ZIVFRQQ29va2llR2V0RXhwaXJhdGlvblRpbWVQdHIoKSkKLSAg ICAgICAgcmV0dXJuIENGSFRUUENvb2tpZUdldEV4cGlyYXRpb25UaW1lUHRyKCkoY29va2llKTsK LSAgICByZXR1cm4gQ0ZEYXRlR2V0QWJzb2x1dGVUaW1lKENGSFRUUENvb2tpZUdldEV4cGlyYXRv bkRhdGUoY29va2llKSk7CisgICAgcmV0dXJuIENGSFRUUENvb2tpZUdldEV4cGlyYXRpb25UaW1l KGNvb2tpZSk7CiB9CiAKIHN0YXRpYyBpbmxpbmUgUmV0YWluUHRyPENGU3RyaW5nUmVmPiBjb29r aWVOYW1lKENGSFRUUENvb2tpZVJlZiBjb29raWUpCiB7Ci0gICAgaWYgKENGSFRUUENvb2tpZUNv cHlOYW1lUHRyKCkpCi0gICAgICAgIHJldHVybiBSZXRhaW5QdHI8Q0ZTdHJpbmdSZWY+KEFkb3B0 Q0YsIENGSFRUUENvb2tpZUNvcHlOYW1lUHRyKCkoY29va2llKSk7Ci0gICAgcmV0dXJuIENGSFRU UENvb2tpZUdldE5hbWUoY29va2llKTsKKyAgICByZXR1cm4gUmV0YWluUHRyPENGU3RyaW5nUmVm PihBZG9wdENGLCBDRkhUVFBDb29raWVDb3B5TmFtZShjb29raWUpKTsKIH0KIAogc3RhdGljIGlu bGluZSBSZXRhaW5QdHI8Q0ZTdHJpbmdSZWY+IGNvb2tpZVBhdGgoQ0ZIVFRQQ29va2llUmVmIGNv b2tpZSkKIHsKLSAgICBpZiAoQ0ZIVFRQQ29va2llQ29weVBhdGhQdHIoKSkKLSAgICAgICAgcmV0 dXJuIFJldGFpblB0cjxDRlN0cmluZ1JlZj4oQWRvcHRDRiwgQ0ZIVFRQQ29va2llQ29weVBhdGhQ dHIoKShjb29raWUpKTsKLSAgICByZXR1cm4gQ0ZIVFRQQ29va2llR2V0UGF0aChjb29raWUpOwor ICAgIHJldHVybiBSZXRhaW5QdHI8Q0ZTdHJpbmdSZWY+KEFkb3B0Q0YsIENGSFRUUENvb2tpZUNv cHlQYXRoKGNvb2tpZSkpOwogfQogCiBzdGF0aWMgaW5saW5lIFJldGFpblB0cjxDRlN0cmluZ1Jl Zj4gY29va2llVmFsdWUoQ0ZIVFRQQ29va2llUmVmIGNvb2tpZSkKIHsKLSAgICBpZiAoQ0ZIVFRQ Q29va2llQ29weVZhbHVlUHRyKCkpCi0gICAgICAgIHJldHVybiBSZXRhaW5QdHI8Q0ZTdHJpbmdS ZWY+KEFkb3B0Q0YsIENGSFRUUENvb2tpZUNvcHlWYWx1ZVB0cigpKGNvb2tpZSkpOwotICAgIHJl dHVybiBDRkhUVFBDb29raWVHZXRWYWx1ZShjb29raWUpOworICAgIHJldHVybiBSZXRhaW5QdHI8 Q0ZTdHJpbmdSZWY+KEFkb3B0Q0YsIENGSFRUUENvb2tpZUNvcHlWYWx1ZShjb29raWUpKTsKIH0K IAogc3RhdGljIFJldGFpblB0cjxDRkFycmF5UmVmPiBmaWx0ZXJDb29raWVzKENGQXJyYXlSZWYg dW5maWx0ZXJlZENvb2tpZXMpCg==