68953 2011-09-27 16:32:05 -0700 [chromium] Guard accelerated skia drawing logic with its own define to remove dependency on USE(THREADED_COMPOSITING) 2011-09-27 16:50:12 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr alokp enne kbr nduca vangelis oldest_to_newest 474341 0 jamesr 2011-09-27 16:32:05 -0700 [chromium] Guard accelerated skia drawing logic with its own define to remove dependency on USE(THREADED_COMPOSITING) 474342 1 108929 jamesr 2011-09-27 16:33:57 -0700 Created attachment 108929 Patch 474355 2 108929 kbr 2011-09-27 16:44:35 -0700 Comment on attachment 108929 Patch Looks fine. Do you want to add another GYP variable to Source/WebKit/chromium/features.gypi? 474358 3 jamesr 2011-09-27 16:47:58 -0700 I think we can do that when it's necessary - AFAIK so far only one person (Alok) has really worked on this, so it's pretty easy for him to just set it locally. 474362 4 108929 jamesr 2011-09-27 16:50:09 -0700 Comment on attachment 108929 Patch Clearing flags on attachment: 108929 Committed r96172: <http://trac.webkit.org/changeset/96172> 474363 5 jamesr 2011-09-27 16:50:12 -0700 All reviewed patches have been landed. Closing bug. 108929 2011-09-27 16:33:57 -0700 2011-09-27 16:50:09 -0700 Patch bug-68953-20110927163356.patch text/plain 4765 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogOTYxNDAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0MjA0MWQwOGFhY2RiMTIx NTM5YjU0MmYyYTIyNTc5NjRlMjE5Y2VhLi5iNGUxMjJhYmU0Mjc3OWJiMzc1ODIzODQzZmE5NjRh MzYwY2IyY2U2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDktMjcgIEphbWVz IFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIEd1 YXJkIGFjY2VsZXJhdGVkIHNraWEgZHJhd2luZyBsb2dpYyB3aXRoIGl0cyBvd24gZGVmaW5lIHRv IHJlbW92ZSBkZXBlbmRlbmN5IG9uIFVTRShUSFJFQURFRF9DT01QT1NJVElORykKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4OTUzCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGFjY2VsZXJhdGVkIGRy YXdpbmcgY29kZSBpcyBpbmNvbXBhdGlibGUgd2l0aCB0aHJlYWRlZCBjb21wb3NpdGluZy4gUmF0 aGVyIHRoYW4gdHlpbmcgdGhlIHR3byBiZWhhdmlvcnMKKyAgICAgICAgdG9nZXRoZXIgdmlhIFVT RShUSFJFQURFRF9DT01QT1NJVElORyksIHRoaXMgcGF0Y2ggZ3VhcmRzIHRoZSBhY2NlbGVyYXRl ZCBkcmF3aW5nIGNvZGUgd2l0aCBpdHMgb3duIFVTRSgpIGd1YXJkCisgICAgICAgIHNvIHRoZSBm ZWF0dXJlcyBjYW4gYWR2YW5jZSBpbmRlcGVuZGVudGx5LiBUb2RheSwgaXQncyBub3Qgc2FmZSB0 byBzZXQgYm90aCBvZiB0aGVzZSBmbGFncy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L2Nocm9taXVtL0NvbnRlbnRMYXllckNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNv bnRlbnRMYXllckNocm9taXVtOjpjcmVhdGVUZXh0dXJlVXBkYXRlcik6CisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJUZXh0dXJlVXBkYXRlckNhbnZhcy5jcHA6Cisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJUZXh0dXJlVXBkYXRlckNh bnZhcy5oOgorCiAyMDExLTA2LTI4ICBSb2JlcnQgSG9nYW4gIDxyb2JlcnRAd2Via2l0Lm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBIeWF0dC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0NvbnRlbnRMYXllckNocm9taXVtLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0NvbnRlbnRMYXll ckNocm9taXVtLmNwcAppbmRleCA4MWY3ZjE0ZGU2M2Y2MjkzMDA1MzhkMGI2OWYxN2JjZjA3ZTg5 NzI0Li45ZGU0ZGE5ZDZkNmQ0YjQzMDc2NmUxNzkyNzI4YTMwMzllYzcwOTAxIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Db250ZW50TGF5ZXJD aHJvbWl1bS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21p dW0vQ29udGVudExheWVyQ2hyb21pdW0uY3BwCkBAIC0xMjAsOCArMTIwLDcgQEAgYm9vbCBDb250 ZW50TGF5ZXJDaHJvbWl1bTo6ZHJhd3NDb250ZW50KCkgY29uc3QKIAogdm9pZCBDb250ZW50TGF5 ZXJDaHJvbWl1bTo6Y3JlYXRlVGV4dHVyZVVwZGF0ZXIoY29uc3QgQ0NMYXllclRyZWVIb3N0KiBo b3N0KQogewotI2lmICFVU0UoVEhSRUFERURfQ09NUE9TSVRJTkcpCi0jaWYgVVNFKFNLSUEpCisj aWYgVVNFKFNLSUEpICYmIFVTRShBQ0NFTEVSQVRFRF9EUkFXSU5HKQogICAgIC8vIE5vdGUgdGhh dCBob3N0LT5za2lhQ29udGV4dCgpIHdpbGwgY3Jhc2ggaWYgY2FsbGVkIHdoaWxlIGluIHRocmVh ZGVkCiAgICAgLy8gbW9kZS4gVGhpcyB0aHVzIGRlcGVuZHMgb24gQ0NMYXllclRyZWVIb3N0Ojpp bml0aWFsaXplIHR1cm5pbmcgb2ZmCiAgICAgLy8gYWNjZWxlcmF0ZVBhaW50aW5nIHRvIHByZXZl bnQgdGhpcyBmcm9tIGNyYXNoaW5nLgpAQCAtMTI5LDggKzEyOCw3IEBAIHZvaWQgQ29udGVudExh eWVyQ2hyb21pdW06OmNyZWF0ZVRleHR1cmVVcGRhdGVyKGNvbnN0IENDTGF5ZXJUcmVlSG9zdCog aG9zdCkKICAgICAgICAgbV90ZXh0dXJlVXBkYXRlciA9IExheWVyVGV4dHVyZVVwZGF0ZXJTa1Bp Y3R1cmU6OmNyZWF0ZShDb250ZW50TGF5ZXJQYWludGVyOjpjcmVhdGUobV9kZWxlZ2F0ZSkpOwog ICAgICAgICByZXR1cm47CiAgICAgfQotI2VuZGlmIC8vIFNLSUEKLSNlbmRpZiAvLyAhVEhSRUFE RURfQ09NUE9TSVRJTkcKKyNlbmRpZiAvLyBVU0UoU0tJQSkgJiYgVVNFKEFDQ0VMRVJBVEVEX0RS QVdJTkcpCiAKICAgICBtX3RleHR1cmVVcGRhdGVyID0gTGF5ZXJUZXh0dXJlVXBkYXRlckJpdG1h cDo6Y3JlYXRlKENvbnRlbnRMYXllclBhaW50ZXI6OmNyZWF0ZShtX2RlbGVnYXRlKSwgaG9zdC0+ bGF5ZXJSZW5kZXJlckNhcGFiaWxpdGllcygpLnVzaW5nTWFwU3ViKTsKIH0KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyVGV4dHVyZVVw ZGF0ZXJDYW52YXMuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21p dW0vTGF5ZXJUZXh0dXJlVXBkYXRlckNhbnZhcy5jcHAKaW5kZXggNmNlY2MyYWU2YzAyNjViMDhh NWRkZjFhYWUxZDE3YjFhNzJjY2FlYi4uZDE1MGI3YjExOGRkY2MyOTJiN2NlNmU4YzRkY2FlMzBl OWUwNmJkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hy b21pdW0vTGF5ZXJUZXh0dXJlVXBkYXRlckNhbnZhcy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJUZXh0dXJlVXBkYXRlckNhbnZhcy5jcHAK QEAgLTEwMSw4ICsxMDEsNyBAQCB2b2lkIExheWVyVGV4dHVyZVVwZGF0ZXJCaXRtYXA6OnVwZGF0 ZVRleHR1cmVSZWN0KEdyYXBoaWNzQ29udGV4dDNEKiBjb250ZXh0LCBNYQogICAgIG1fdGV4U3Vi SW1hZ2UudXBsb2FkKGxvY2tlci5waXhlbHMoKSwgY29udGVudFJlY3QoKSwgc291cmNlUmVjdCwg ZGVzdFJlY3QsIHRleHR1cmUtPmZvcm1hdCgpLCBjb250ZXh0KTsKIH0KIAotI2lmICFVU0UoVEhS RUFERURfQ09NUE9TSVRJTkcpCi0jaWYgVVNFKFNLSUEpCisjaWYgVVNFKFNLSUEpICYmIFVTRShB Q0NFTEVSQVRFRF9EUkFXSU5HKQogUGFzc1JlZlB0cjxMYXllclRleHR1cmVVcGRhdGVyU2tQaWN0 dXJlPiBMYXllclRleHR1cmVVcGRhdGVyU2tQaWN0dXJlOjpjcmVhdGUoUGFzc093blB0cjxMYXll clBhaW50ZXJDaHJvbWl1bT4gcGFpbnRlcikKIHsKICAgICByZXR1cm4gYWRvcHRSZWYobmV3IExh eWVyVGV4dHVyZVVwZGF0ZXJTa1BpY3R1cmUocGFpbnRlcikpOwpAQCAtMjU0LDggKzI1Myw3IEBA IGJvb2wgTGF5ZXJUZXh0dXJlVXBkYXRlclNrUGljdHVyZTo6Y3JlYXRlRnJhbWVCdWZmZXIoKQog ICAgIGNvbnRleHQoKS0+YmluZEZyYW1lYnVmZmVyKEdyYXBoaWNzQ29udGV4dDNEOjpGUkFNRUJV RkZFUiwgMCk7CiAgICAgcmV0dXJuIHRydWU7CiB9Ci0jZW5kaWYgLy8gU0tJQQotI2VuZGlmIC8v ICFUSFJFQURFRF9DT01QT1NJVElORworI2VuZGlmIC8vIFVTRShTS0lBKSAmJiBVU0UoQUNDRUxF UkFURURfRFJBV0lORykKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogI2VuZGlmIC8vIFVTRShB Q0NFTEVSQVRFRF9DT01QT1NJVElORykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyVGV4dHVyZVVwZGF0ZXJDYW52YXMuaCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyVGV4dHVyZVVwZGF0ZXJD YW52YXMuaAppbmRleCA0OWNiMjE2NDg4MTNmMDg1MGRjMWUyMTBlZDM2NjkxM2MwYWY4OTBlLi5k NWNlZWRmNmNlNGU1YjNhZGYyOTVlNjcyNzNjMDlmMjk0ZmI3Mzc2IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclRleHR1cmVVcGRhdGVy Q2FudmFzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0v TGF5ZXJUZXh0dXJlVXBkYXRlckNhbnZhcy5oCkBAIC03OSw3ICs3OSw3IEBAIHByaXZhdGU6CiAg ICAgTGF5ZXJUZXh0dXJlU3ViSW1hZ2UgbV90ZXhTdWJJbWFnZTsKIH07CiAKLSNpZiBVU0UoU0tJ QSkKKyNpZiBVU0UoU0tJQSkgJiYgVVNFKEFDQ0VMRVJBVEVEX0RSQVdJTkcpCiBjbGFzcyBMYXll clRleHR1cmVVcGRhdGVyU2tQaWN0dXJlIDogcHVibGljIExheWVyVGV4dHVyZVVwZGF0ZXJDYW52 YXMgewogcHVibGljOgogICAgIHN0YXRpYyBQYXNzUmVmUHRyPExheWVyVGV4dHVyZVVwZGF0ZXJT a1BpY3R1cmU+IGNyZWF0ZShQYXNzT3duUHRyPExheWVyUGFpbnRlckNocm9taXVtPik7CkBAIC0x MDUsNyArMTA1LDcgQEAgcHJpdmF0ZToKICAgICBQbGF0Zm9ybTNET2JqZWN0IG1fZGVwdGhTdGVu Y2lsQnVmZmVyOwogICAgIE93blB0cjxTa0NhbnZhcz4gbV9jYW52YXM7IC8vIEdQVSBhY2NlbGVy YXRlZCBjYW52YXMuCiB9OwotI2VuZGlmIC8vIFNLSUEKKyNlbmRpZiAvLyBVU0UoU0tJQSkgJiYg VVNFKEFDQ0VMRVJBVEVEX0RSQVdJTkcpCiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKICNlbmRp ZiAvLyBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCg==