68943 premultiplyAlpha 2011-09-27 15:13:23 -0700 Missing initialization of member in ImageFrameQt class 2011-09-28 00:21:49 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P4 Normal --- 0 savagobr webkit-unassigned webkit.review.bot oldest_to_newest 474278 0 savagobr 2011-09-27 15:13:23 -0700 While using Qt image decoder, the class member premultiplyAlpha is not being initialized or copied by assignment operator (thus at best depending on compiler/platform or simply random). This patch fixes this issue. ps: the same behavior is implemented in Skia port and grob branch. 474279 1 108910 savagobr 2011-09-27 15:14:48 -0700 Created attachment 108910 Initialize premultiplyAlpha and copy in operator 474374 2 108910 kenneth 2011-09-27 17:04:47 -0700 Comment on attachment 108910 Initialize premultiplyAlpha and copy in operator r=, misses ChangeLog! 474450 3 108952 savagobr 2011-09-27 20:07:24 -0700 Created attachment 108952 Patch 474451 4 108953 savagobr 2011-09-27 20:10:34 -0700 Created attachment 108953 Initialize premultiplyAlpha and copy in operator plus Changelog 474526 5 108953 noam 2011-09-27 23:26:13 -0700 Comment on attachment 108953 Initialize premultiplyAlpha and copy in operator plus Changelog It's already reviewed, you don't need to r? it again. 474562 6 108953 webkit.review.bot 2011-09-28 00:21:44 -0700 Comment on attachment 108953 Initialize premultiplyAlpha and copy in operator plus Changelog Clearing flags on attachment: 108953 Committed r96196: <http://trac.webkit.org/changeset/96196> 474563 7 webkit.review.bot 2011-09-28 00:21:49 -0700 All reviewed patches have been landed. Closing bug. 108910 2011-09-27 15:14:48 -0700 2011-09-27 20:07:10 -0700 Initialize premultiplyAlpha and copy in operator alpha_default.patch text/plain 1176 savagobr RnJvbSA0NTMyZTIzYTk2NDAyMjliNDI5MDQ1NzY1MWM0NDUwZTdkMWFhNDhhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGVuaWxzb24gQ2F2YWxjYW50aSA8YWRlbmlsc29uLnNpbHZh QG9wZW5ib3NzYS5vcmc+CkRhdGU6IE1vbiwgMjYgU2VwIDIwMTEgMTY6MjU6NTMgLTA0MDAKU3Vi amVjdDogW1BBVENIXSBTZXQgUXQgdG8gYWxzbyB1c2UgcHJlbXVsdGlwbHlBbHBoYT10cnVlIGJ5 IGRlZmF1bHQuCgpTaWduZWQtb2ZmLWJ5OiBBZGVuaWxzb24gQ2F2YWxjYW50aSA8YWRlbmlsc29u LnNpbHZhQG9wZW5ib3NzYS5vcmc+Ci0tLQogLi4uL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL3F0 L0ltYWdlRnJhbWVRdC5jcHAgICAgfCAgICAyICsrCiAxIGZpbGVzIGNoYW5nZWQsIDIgaW5zZXJ0 aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9pbWFnZS1kZWNvZGVycy9xdC9JbWFnZUZyYW1lUXQuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvcXQvSW1hZ2VGcmFtZVF0LmNwcAppbmRleCBhM2NmYmY2 Li4yZmU2YWNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNv ZGVycy9xdC9JbWFnZUZyYW1lUXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lt YWdlLWRlY29kZXJzL3F0L0ltYWdlRnJhbWVRdC5jcHAKQEAgLTQxLDYgKzQxLDcgQEAgSW1hZ2VG cmFtZTo6SW1hZ2VGcmFtZSgpCiAgICAgLCBtX3N0YXR1cyhGcmFtZUVtcHR5KQogICAgICwgbV9k dXJhdGlvbigwKQogICAgICwgbV9kaXNwb3NhbE1ldGhvZChEaXNwb3NlTm90U3BlY2lmaWVkKQor ICAgICwgbV9wcmVtdWx0aXBseUFscGhhKHRydWUpCiB7CiB9CiAKQEAgLTU0LDYgKzU1LDcgQEAg SW1hZ2VGcmFtZSYgSW1hZ2VGcmFtZTo6b3BlcmF0b3I9KGNvbnN0IEltYWdlRnJhbWUmIG90aGVy KQogICAgIHNldFN0YXR1cyhvdGhlci5zdGF0dXMoKSk7CiAgICAgc2V0RHVyYXRpb24ob3RoZXIu ZHVyYXRpb24oKSk7CiAgICAgc2V0RGlzcG9zYWxNZXRob2Qob3RoZXIuZGlzcG9zYWxNZXRob2Qo KSk7CisgICAgc2V0UHJlbXVsdGlwbHlBbHBoYShvdGhlci5wcmVtdWx0aXBseUFscGhhKCkpOwog ICAgIHJldHVybiAqdGhpczsKIH0KIAotLSAKMS43LjQuMQoK 108952 2011-09-27 20:07:24 -0700 2011-09-27 20:10:34 -0700 Patch bug-68943-20110927230719.patch text/plain 1650 savagobr U3VidmVyc2lvbiBSZXZpc2lvbjogOTU5NDgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxOWM1MTVhMDVmOGY3YzU2 OGViYTY1MDZmMTdkYTJmMzY0NTFhYWFlLi5iNDNhMWMyYmI4MTk1MTZiMDUyZWE3YmMyYWJlN2Fm NDc2YTUxYTUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDktMjcgIEFkZW5p bHNvbiBDYXZhbGNhbnRpICA8YWRlbmlsc29uLnNpbHZhQG9wZW5ib3NzYS5vcmc+CisKKyAgICAg ICAgTWlzc2luZyBpbml0aWFsaXphdGlvbiBvZiBtZW1iZXIgaW4gSW1hZ2VGcmFtZVF0IGNsYXNz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODk0Mwor CisgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cywgdGhpcyBmaXhlcyBpbnRlcm5hbCBpbXBsZW1lbnRhdGlvbiBkZXRh aWwuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9xdC9JbWFnZUZyYW1lUXQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VGcmFtZTo6SW1hZ2VGcmFtZSk6CisgICAgICAg IChXZWJDb3JlOjpJbWFnZUZyYW1lOjpvcGVyYXRvcj0pOgorCiAyMDExLTA5LTI2ICBBbmRyZWFz IEtsaW5nICA8a2xpbmdAd2Via2l0Lm9yZz4KIAogICAgICAgICBbUXRdIFVudXNlZCB2YXJpYWJs ZSBpbiBRTmV0d29ya1JlcGx5SGFuZGxlcjo6c2VuZE5ldHdvcmtSZXF1ZXN0LgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvcXQvSW1hZ2VGcmFtZVF0 LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL3F0L0ltYWdlRnJh bWVRdC5jcHAKaW5kZXggYTNjZmJmNmE3YzVhNWY1ZGUzOTgwYjNiYjFhY2JmZmFiYjQ3MDUyNi4u MmZlNmFjYzQ5ZjI1MjYxODg3YzMxNGViMTE4OGZhNWJkMTcwMWYzNyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvcXQvSW1hZ2VGcmFtZVF0LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9xdC9JbWFnZUZyYW1l UXQuY3BwCkBAIC00MSw2ICs0MSw3IEBAIEltYWdlRnJhbWU6OkltYWdlRnJhbWUoKQogICAgICwg bV9zdGF0dXMoRnJhbWVFbXB0eSkKICAgICAsIG1fZHVyYXRpb24oMCkKICAgICAsIG1fZGlzcG9z YWxNZXRob2QoRGlzcG9zZU5vdFNwZWNpZmllZCkKKyAgICAsIG1fcHJlbXVsdGlwbHlBbHBoYSh0 cnVlKQogewogfQogCkBAIC01NCw2ICs1NSw3IEBAIEltYWdlRnJhbWUmIEltYWdlRnJhbWU6Om9w ZXJhdG9yPShjb25zdCBJbWFnZUZyYW1lJiBvdGhlcikKICAgICBzZXRTdGF0dXMob3RoZXIuc3Rh dHVzKCkpOwogICAgIHNldER1cmF0aW9uKG90aGVyLmR1cmF0aW9uKCkpOwogICAgIHNldERpc3Bv c2FsTWV0aG9kKG90aGVyLmRpc3Bvc2FsTWV0aG9kKCkpOworICAgIHNldFByZW11bHRpcGx5QWxw aGEob3RoZXIucHJlbXVsdGlwbHlBbHBoYSgpKTsKICAgICByZXR1cm4gKnRoaXM7CiB9CiAK 108953 2011-09-27 20:10:34 -0700 2011-09-28 00:21:44 -0700 Initialize premultiplyAlpha and copy in operator plus Changelog alpha_default_changelog.patch text/plain 2008 savagobr RnJvbSAzZDRjMjkwMjcyNGM3ZGZhNDE2YjdhODM0N2RlODA5Yzg5NjQ3Mjg5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGVuaWxzb24gQ2F2YWxjYW50aSA8YWRlbmlsc29uLnNpbHZh QG9wZW5ib3NzYS5vcmc+CkRhdGU6IFR1ZSwgMjcgU2VwIDIwMTEgMjM6MDg6MjkgLTA0MDAKU3Vi amVjdDogW1BBVENIXSBGaXhpbmcgSW5pdGlhbGl6YXRpb24gb2YgaW50ZXJuYWwgbWVtYmVyIGlu IGltYWdlIGRlY29kZXIuCgpTaWduZWQtb2ZmLWJ5OiBBZGVuaWxzb24gQ2F2YWxjYW50aSA8YWRl bmlsc29uLnNpbHZhQG9wZW5ib3NzYS5vcmc+Ci0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n ICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDEzICsrKysrKysrKysrKysKIC4uLi9wbGF0 Zm9ybS9pbWFnZS1kZWNvZGVycy9xdC9JbWFnZUZyYW1lUXQuY3BwICAgIHwgICAgMiArKwogMiBm aWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpp bmRleCAxOWM1MTVhLi5iNDNhMWMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEt MDktMjcgIEFkZW5pbHNvbiBDYXZhbGNhbnRpICA8YWRlbmlsc29uLnNpbHZhQG9wZW5ib3NzYS5v cmc+CisKKyAgICAgICAgTWlzc2luZyBpbml0aWFsaXphdGlvbiBvZiBtZW1iZXIgaW4gSW1hZ2VG cmFtZVF0IGNsYXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02ODk0MworCisgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFu c2VuLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgdGhpcyBmaXhlcyBpbnRlcm5hbCBpbXBsZW1l bnRhdGlvbiBkZXRhaWwuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9xdC9J bWFnZUZyYW1lUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VGcmFtZTo6SW1hZ2VGcmFt ZSk6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZUZyYW1lOjpvcGVyYXRvcj0pOgorCiAyMDExLTA5 LTI2ICBBbmRyZWFzIEtsaW5nICA8a2xpbmdAd2Via2l0Lm9yZz4KIAogICAgICAgICBbUXRdIFVu dXNlZCB2YXJpYWJsZSBpbiBRTmV0d29ya1JlcGx5SGFuZGxlcjo6c2VuZE5ldHdvcmtSZXF1ZXN0 LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvcXQv SW1hZ2VGcmFtZVF0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJz L3F0L0ltYWdlRnJhbWVRdC5jcHAKaW5kZXggYTNjZmJmNi4uMmZlNmFjYyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvcXQvSW1hZ2VGcmFtZVF0LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9xdC9JbWFnZUZy YW1lUXQuY3BwCkBAIC00MSw2ICs0MSw3IEBAIEltYWdlRnJhbWU6OkltYWdlRnJhbWUoKQogICAg ICwgbV9zdGF0dXMoRnJhbWVFbXB0eSkKICAgICAsIG1fZHVyYXRpb24oMCkKICAgICAsIG1fZGlz cG9zYWxNZXRob2QoRGlzcG9zZU5vdFNwZWNpZmllZCkKKyAgICAsIG1fcHJlbXVsdGlwbHlBbHBo YSh0cnVlKQogewogfQogCkBAIC01NCw2ICs1NSw3IEBAIEltYWdlRnJhbWUmIEltYWdlRnJhbWU6 Om9wZXJhdG9yPShjb25zdCBJbWFnZUZyYW1lJiBvdGhlcikKICAgICBzZXRTdGF0dXMob3RoZXIu c3RhdHVzKCkpOwogICAgIHNldER1cmF0aW9uKG90aGVyLmR1cmF0aW9uKCkpOwogICAgIHNldERp c3Bvc2FsTWV0aG9kKG90aGVyLmRpc3Bvc2FsTWV0aG9kKCkpOworICAgIHNldFByZW11bHRpcGx5 QWxwaGEob3RoZXIucHJlbXVsdGlwbHlBbHBoYSgpKTsKICAgICByZXR1cm4gKnRoaXM7CiB9CiAK LS0gCjEuNy40LjEKCg==