68941 2011-09-27 15:08:49 -0700 Fix potential SVG performance regression (over-invalidation of caches) from 96052. 2011-09-28 01:05:59 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton webkit-bug-importer webkit.review.bot zimmermann oldest_to_newest 474272 0 thorton 2011-09-27 15:08:49 -0700 Because of https://bugs.webkit.org/show_bug.cgi?id=68457, I added code to drop objects from the SVGResources cache when the target changes. It turns out (validating Niko and Rob's concerns in the aforementioned bug) that there's no need to do this for any case (that I've come up with so far) except filters, as filters are the only resource which makes use of its targets style. So, we should only do the cache drop if we have a filter. Patch coming soon. 474273 1 webkit-bug-importer 2011-09-27 15:09:06 -0700 <rdar://problem/10196224> 474274 2 thorton 2011-09-27 15:09:21 -0700 s/Rob/Dirk/ 474286 3 108913 thorton 2011-09-27 15:26:23 -0700 Created attachment 108913 patch 474540 4 108913 zherczeg 2011-09-27 23:47:06 -0700 Comment on attachment 108913 patch LGTM 474585 5 108913 webkit.review.bot 2011-09-28 01:05:55 -0700 Comment on attachment 108913 patch Clearing flags on attachment: 108913 Committed r96203: <http://trac.webkit.org/changeset/96203> 474586 6 webkit.review.bot 2011-09-28 01:05:59 -0700 All reviewed patches have been landed. Closing bug. 108913 2011-09-27 15:26:23 -0700 2011-09-28 01:05:55 -0700 patch 68941.patch text/plain 1946 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwYTZhYWFkLi5lODBkZWNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjIg QEAKIDIwMTEtMDktMjcgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAK KyAgICAgICAgRml4IHBvdGVudGlhbCBTVkcgcGVyZm9ybWFuY2UgcmVncmVzc2lvbiAob3Zlci1p bnZhbGlkYXRpb24gb2YgY2FjaGVzKSBmcm9tIDk2MDUyCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODk0MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0v MTAxOTYyMjQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgT25seSBpbnZhbGlkYXRlIHRoZSBjYWNoZSBvZiBhIGZpbHRlciB3aGVuIHRhcmdldCBzdHls ZSBjaGFuZ2VzLCBhcyBvZiB0aGUgZGlmZmVyZW50IHR5cGVzIG9mIGNhY2hlZAorICAgICAgICBy ZXNvdXJjZXMsIG9ubHkgZmlsdGVycyBtYWtlIHVzZSBvZiB0aGUgc3R5bGUgb2YgdGhlIHRhcmdl dCBlbGVtZW50IGFuZCB0aHVzIG5lZWQgdG8gYmUgaW52YWxpZGF0ZWQKKyAgICAgICAgd2hlbiB0 aGUgdGFyZ2V0IHN0eWxlIGNoYW5nZXMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBwZXJmb3Jt YW5jZSBpbXByb3ZlbWVudC4KKworICAgICAgICAqIHJlbmRlcmluZy9zdmcvU1ZHUmVzb3VyY2Vz Q2FjaGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1ZHUmVzb3VyY2VzQ2FjaGU6OmNsaWVudFVw ZGF0ZWRGcm9tRWxlbWVudCk6CisKKzIwMTEtMDktMjcgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hv cnRvbkBhcHBsZS5jb20+CisKICAgICAgICAgUkVHUkVTU0lPTig2NTY2NSk6IFBhdHRlcm4gc2l6 ZSBiZWluZyBjbGFtcGVkIHRvIFNWRyBzaXplIGNhbiBwcmV2ZW50IHRyYW5zZm9ybWVkIGVsZW1l bnRzIGZyb20gYmVpbmcgZnVsbHkgY292ZXJlZCBieSB1c2VyU3BhY2VPblVzZSBwYXR0ZXJucwog ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njc3MDAKICAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEwMTI1MTAyPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL3N2Zy9TVkdSZXNvdXJjZXNDYWNoZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvc3ZnL1NWR1Jlc291cmNlc0NhY2hlLmNwcAppbmRleCBiYmQ0NDU0Li5iZWNiZDRl IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1NWR1Jlc291cmNlc0Nh Y2hlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1NWR1Jlc291cmNlc0Nh Y2hlLmNwcApAQCAtMTQ2LDEwICsxNDYsOCBAQCB2b2lkIFNWR1Jlc291cmNlc0NhY2hlOjpjbGll bnRVcGRhdGVkRnJvbUVsZW1lbnQoUmVuZGVyT2JqZWN0KiByZW5kZXJlciwgY29uc3QgUgogICAg IGNhY2hlLT5hZGRSZXNvdXJjZXNGcm9tUmVuZGVyT2JqZWN0KHJlbmRlcmVyLCBuZXdTdHlsZSk7 CiAKICAgICBTVkdSZXNvdXJjZXMqIHJlc291cmNlcyA9IFNWR1Jlc291cmNlc0NhY2hlOjpjYWNo ZWRSZXNvdXJjZXNGb3JSZW5kZXJPYmplY3QocmVuZGVyZXIpOwotICAgIGlmICghcmVzb3VyY2Vz KQotICAgICAgICByZXR1cm47Ci0KLSAgICByZXNvdXJjZXMtPnJlbW92ZUNsaWVudEZyb21DYWNo ZShyZW5kZXJlcik7CisgICAgaWYgKHJlc291cmNlcyAmJiByZXNvdXJjZXMtPmZpbHRlcigpKQor ICAgICAgICByZXNvdXJjZXMtPnJlbW92ZUNsaWVudEZyb21DYWNoZShyZW5kZXJlcik7CiB9CiAK IHZvaWQgU1ZHUmVzb3VyY2VzQ2FjaGU6OmNsaWVudERlc3Ryb3llZChSZW5kZXJPYmplY3QqIHJl bmRlcmVyKQo=