68931 2011-09-27 13:48:03 -0700 nrwt: newly generated results are put in cross-platform directory 2011-10-20 20:35:04 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 64491 1 rniwa rniwa abarth dpranke eric hyatt leandro ojan rakuco webkit.review.bot oldest_to_newest 474201 0 rniwa 2011-09-27 13:48:03 -0700 old-run-webkit-tests put newly generated results in right directory (e.g. platform/mac, platform/win. etc...) new-run-webkit-tests appears to put new results in wherever tests are, which is very annoying for pixel tests as contributors need to manually move them all to platform/X/ 488040 1 111882 rniwa 2011-10-20 17:48:26 -0700 Created attachment 111882 fixes the bug 488041 2 111882 abarth 2011-10-20 17:49:56 -0700 Comment on attachment 111882 fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=111882&action=review > Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:145 > + _render_tree_dump_pattern = re.compile(r"^layer at \(\d+,\d+\) size \d+x\d+\n") hum... 488048 3 rniwa 2011-10-20 17:57:50 -0700 (In reply to comment #2) > (From update of attachment 111882 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=111882&action=review > > > Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:145 > > + _render_tree_dump_pattern = re.compile(r"^layer at \(\d+,\d+\) size \d+x\d+\n") > > hum... Don't like it? 488049 4 abarth 2011-10-20 17:59:00 -0700 Looks like a hack, right? 488054 5 rniwa 2011-10-20 18:03:16 -0700 (In reply to comment #4) > Looks like a hack, right? Not really. I'm detecting whether the output looks like render tree dump or not. Since there is currently no way for us to know whether a test prints render tree dump or not, I don't think we can do better. orwt uses a similar trick in isTextOnlyTest. 488058 6 abarth 2011-10-20 18:08:19 -0700 Another approach might be to have DRT return a Content-Type header that says whether it is a text dump or a render tree dump. 488078 7 rniwa 2011-10-20 18:48:20 -0700 (In reply to comment #6) > Another approach might be to have DRT return a Content-Type header that says whether it is a text dump or a render tree dump. Yeah, that'll be cleaner and will be a nice follow up to do. This bug is about the regression that nrwt doesn't behave like orwt and this patch fixes exactly that. 488114 8 111882 webkit.review.bot 2011-10-20 20:34:59 -0700 Comment on attachment 111882 fixes the bug Clearing flags on attachment: 111882 Committed r98062: <http://trac.webkit.org/changeset/98062> 488115 9 webkit.review.bot 2011-10-20 20:35:04 -0700 All reviewed patches have been landed. Closing bug. 111882 2011-10-20 17:48:26 -0700 2011-10-20 20:34:59 -0700 fixes the bug bug-68931-20111020174825.patch text/plain 6764 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk4MDUxKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMjAgQEAKKzIwMTEtMTAtMjAgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgbnJ3dDogbmV3bHkgZ2VuZXJhdGVkIHJlc3VsdHMgYXJlIHB1dCBpbiBjcm9zcy1w bGF0Zm9ybSBkaXJlY3RvcnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTY4OTMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhlIGJ1ZyB3YXMgY2F1c2VkIGJ5IFNpbmdsZVRlc3RSdW5uZXIuX2FkZF9taXNz aW5nX2Jhc2VsaW5lcydzIGFsd2F5cyBjYWxsaW5nIF9zYXZlX2Jhc2VsaW5lX2RhdGEKKyAgICAg ICAgd2l0aCBnZW5lcmF0ZV9uZXdfYmFzZWxpbmUgc2V0IHRvIEZhbHNlLiBGaXhlZCB0aGUgYnVn IGJ5IGFsd2F5cyBwYXNzaW5nIFRydWUgd2hlbiAucG5nIGZpbGUgaXMgbWlzc2luZworICAgICAg ICAoYmVjYXVzZSBwbmcgaW1hZ2VzIGFyZSB0eXBpY2FsbHkgZGlmZmVyZW50IG9uIGVhY2ggcGxh dGZvcm0pLCBhbmQgcGFzc2luZyBUcnVlIHdoZW4gLnR4dCBmaWxlIGlzIG1pc3NpbmcKKyAgICAg ICAgYW5kIHRoZSBhY3R1YWwgcmVzdWx0J3MgZmlyc3QgbGluZSBtYXRjaGVzIHRoZSByZWd1bGFy IGV4cHJlc3Npb24gImxheWVyIGF0IFwoXGQrLFxkK1wpIHNpemUgXGQreFxkKyIuCisKKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9zaW5nbGVfdGVz dF9ydW5uZXIucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9y dC90ZXN0LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93 ZWJraXRfdGVzdHNfaW50ZWdyYXRpb250ZXN0LnB5OiBDaGFuZ2VkIHRoZSBleHBlY3RhdGlvbgor ICAgICAgICBhbmQgYWRkZWQgYSB0ZXN0IGNhc2UuCisKIDIwMTEtMTAtMjAgIE5pY28gV2ViZXIg IDx0aGFraXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bS9tYWNdIEFkZCBzdXBw b3J0IGZvciBidWlsZGluZyB3aXRoIG1ha2UKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHNfaW50ZWdyYXRpb250ZXN0LnB5Cj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVz dHNfaW50ZWdyYXRpb250ZXN0LnB5CShyZXZpc2lvbiA5ODAyNykKKysrIFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHNfaW50ZWdyYXRpb250ZXN0LnB5 CSh3b3JraW5nIGNvcHkpCkBAIC03NzQsMTUgKzc3NCwxNyBAQCBjbGFzcyBSZWJhc2VsaW5lVGVz dCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgIHJlcywgb3V0LCBlcnIsIF8gPSBsb2dnaW5n X3J1bihbJy0tbm8tc2hvdy1yZXN1bHRzJywKICAgICAgICAgICAgICAgICAgICAgICdmYWlsdXJl cy91bmV4cGVjdGVkL21pc3NpbmdfdGV4dC5odG1sJywKICAgICAgICAgICAgICAgICAgICAgICdm YWlsdXJlcy91bmV4cGVjdGVkL21pc3NpbmdfaW1hZ2UuaHRtbCcsCi0gICAgICAgICAgICAgICAg ICAgICAnZmFpbHVyZXMvdW5leHBlY3RlZC9taXNzaW5nX2F1ZGlvLmh0bWwnXSwKKyAgICAgICAg ICAgICAgICAgICAgICdmYWlsdXJlcy91bmV4cGVjdGVkL21pc3NpbmdfYXVkaW8uaHRtbCcsCisg ICAgICAgICAgICAgICAgICAgICAnZmFpbHVyZXMvdW5leHBlY3RlZC9taXNzaW5nX3JlbmRlcl90 cmVlX2R1bXAuaHRtbCddLAogICAgICAgICAgICAgICAgICAgICAgdGVzdHNfaW5jbHVkZWQ9VHJ1 ZSwgZmlsZXN5c3RlbT1mcywgbmV3X3Jlc3VsdHM9VHJ1ZSkKICAgICAgICAgZmlsZV9saXN0ID0g ZnMud3JpdHRlbl9maWxlcy5rZXlzKCkKICAgICAgICAgZmlsZV9saXN0LnJlbW92ZSgnL3RtcC9s YXlvdXQtdGVzdC1yZXN1bHRzL3Rlc3RzX3J1bjAudHh0JykKICAgICAgICAgc2VsZi5hc3NlcnRF cXVhbHMocmVzLCAwKQogICAgICAgICBzZWxmLmFzc2VydEZhbHNlKG91dC5lbXB0eSgpKQotICAg ICAgICBzZWxmLmFzc2VydEVxdWFsKGxlbihmaWxlX2xpc3QpLCA0KQorICAgICAgICBzZWxmLmFz c2VydEVxdWFsKGxlbihmaWxlX2xpc3QpLCA2KQogICAgICAgICBzZWxmLmFzc2VydEJhc2VsaW5l cyhmaWxlX2xpc3QsICIvZmFpbHVyZXMvdW5leHBlY3RlZC9taXNzaW5nX3RleHQiLCBbIi50eHQi XSwgZXJyKQotICAgICAgICBzZWxmLmFzc2VydEJhc2VsaW5lcyhmaWxlX2xpc3QsICIvZmFpbHVy ZXMvdW5leHBlY3RlZC9taXNzaW5nX2ltYWdlIiwgWyIucG5nIl0sIGVycikKKyAgICAgICAgc2Vs Zi5hc3NlcnRCYXNlbGluZXMoZmlsZV9saXN0LCAiL3BsYXRmb3JtL3Rlc3QtbWFjLWxlb3BhcmQv ZmFpbHVyZXMvdW5leHBlY3RlZC9taXNzaW5nX2ltYWdlIiwgWyIucG5nIl0sIGVycikKKyAgICAg ICAgc2VsZi5hc3NlcnRCYXNlbGluZXMoZmlsZV9saXN0LCAiL3BsYXRmb3JtL3Rlc3QtbWFjLWxl b3BhcmQvZmFpbHVyZXMvdW5leHBlY3RlZC9taXNzaW5nX3JlbmRlcl90cmVlX2R1bXAiLCBbIi50 eHQiXSwgZXJyKQogCiAgICAgZGVmIHRlc3RfbmV3X2Jhc2VsaW5lKHNlbGYpOgogICAgICAgICAj IFRlc3QgdGhhdCB3ZSB1cGRhdGUgdGhlIHBsYXRmb3JtIGV4cGVjdGF0aW9ucy4gSWYgdGhlIGV4 cGVjdGF0aW9uCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250 cm9sbGVycy9zaW5nbGVfdGVzdF9ydW5uZXIucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvc2luZ2xlX3Rlc3RfcnVubmVyLnB5 CShyZXZpc2lvbiA5ODAyNykKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L2NvbnRyb2xsZXJzL3NpbmdsZV90ZXN0X3J1bm5lci5weQkod29ya2luZyBjb3B5KQpAQCAtMjgs NiArMjgsNyBAQAogCiAKIGltcG9ydCBsb2dnaW5nCitpbXBvcnQgcmUKIGltcG9ydCB0aW1lCiAK IGZyb20gd2Via2l0cHkubGF5b3V0X3Rlc3RzLmxheW91dF9wYWNrYWdlIGltcG9ydCB0ZXN0X3Jl c3VsdF93cml0ZXIKQEAgLTE0MSwxNyArMTQyLDE2IEBAIGNsYXNzIFNpbmdsZVRlc3RSdW5uZXI6 CiAgICAgICAgIHNlbGYuX292ZXJ3cml0ZV9iYXNlbGluZXMoZHJpdmVyX291dHB1dCkKICAgICAg ICAgcmV0dXJuIFRlc3RSZXN1bHQoc2VsZi5fdGVzdF9uYW1lLCBmYWlsdXJlcywgZHJpdmVyX291 dHB1dC50ZXN0X3RpbWUsIGRyaXZlcl9vdXRwdXQuaGFzX3N0ZGVycigpKQogCisgICAgX3JlbmRl cl90cmVlX2R1bXBfcGF0dGVybiA9IHJlLmNvbXBpbGUociJebGF5ZXIgYXQgXChcZCssXGQrXCkg c2l6ZSBcZCt4XGQrXG4iKQorCiAgICAgZGVmIF9hZGRfbWlzc2luZ19iYXNlbGluZXMoc2VsZiwg dGVzdF9yZXN1bHQsIGRyaXZlcl9vdXRwdXQpOgorICAgICAgICBtaXNzaW5nSW1hZ2UgPSB0ZXN0 X3Jlc3VsdC5oYXNfZmFpbHVyZV9tYXRjaGluZ190eXBlcyh0ZXN0X2ZhaWx1cmVzLkZhaWx1cmVN aXNzaW5nSW1hZ2UsIHRlc3RfZmFpbHVyZXMuRmFpbHVyZU1pc3NpbmdJbWFnZUhhc2gpCiAgICAg ICAgIGlmIHRlc3RfcmVzdWx0Lmhhc19mYWlsdXJlX21hdGNoaW5nX3R5cGVzKHRlc3RfZmFpbHVy ZXMuRmFpbHVyZU1pc3NpbmdSZXN1bHQpOgotICAgICAgICAgICAgIyBGSVhNRTogV2Ugc2VlbSB0 byBiZSBwdXR0aW5nIG5ldyB0ZXh0IHJlc3VsdHMgaW4gbm9uLXBsYXRmb3JtCi0gICAgICAgICAg ICAjIHNwZWNpZmljIGRpcmVjdG9yaWVzIGV2ZW4gd2hlbiB0aGV5J3JlIHJlbmRlcnRyZWUgZHVt cHMuIE1heWJlCi0gICAgICAgICAgICAjIHdlIHNob3VsZCBoYXZlIGEgZGlmZmVyZW50IGtpbmQg b2YgZmFpbHVyZSBmb3IgcmVuZGVyIHRyZWUgZHVtcHMKLSAgICAgICAgICAgICMgdGhhbiBmb3Ig dGV4dCB0ZXN0cz8KLSAgICAgICAgICAgIHNlbGYuX3NhdmVfYmFzZWxpbmVfZGF0YShkcml2ZXJf b3V0cHV0LnRleHQsICIudHh0IiwgZ2VuZXJhdGVfbmV3X2Jhc2VsaW5lPUZhbHNlKQorICAgICAg ICAgICAgc2VsZi5fc2F2ZV9iYXNlbGluZV9kYXRhKGRyaXZlcl9vdXRwdXQudGV4dCwgIi50eHQi LCBTaW5nbGVUZXN0UnVubmVyLl9yZW5kZXJfdHJlZV9kdW1wX3BhdHRlcm4ubWF0Y2goZHJpdmVy X291dHB1dC50ZXh0KSkKICAgICAgICAgaWYgdGVzdF9yZXN1bHQuaGFzX2ZhaWx1cmVfbWF0Y2hp bmdfdHlwZXModGVzdF9mYWlsdXJlcy5GYWlsdXJlTWlzc2luZ0F1ZGlvKToKICAgICAgICAgICAg IHNlbGYuX3NhdmVfYmFzZWxpbmVfZGF0YShkcml2ZXJfb3V0cHV0LmF1ZGlvLCAiLndhdiIsIGdl bmVyYXRlX25ld19iYXNlbGluZT1GYWxzZSkKLSAgICAgICAgaWYgdGVzdF9yZXN1bHQuaGFzX2Zh aWx1cmVfbWF0Y2hpbmdfdHlwZXModGVzdF9mYWlsdXJlcy5GYWlsdXJlTWlzc2luZ0ltYWdlLCB0 ZXN0X2ZhaWx1cmVzLkZhaWx1cmVNaXNzaW5nSW1hZ2VIYXNoKToKLSAgICAgICAgICAgIHNlbGYu X3NhdmVfYmFzZWxpbmVfZGF0YShkcml2ZXJfb3V0cHV0LmltYWdlLCAiLnBuZyIsIGdlbmVyYXRl X25ld19iYXNlbGluZT1GYWxzZSkKKyAgICAgICAgaWYgbWlzc2luZ0ltYWdlOgorICAgICAgICAg ICAgc2VsZi5fc2F2ZV9iYXNlbGluZV9kYXRhKGRyaXZlcl9vdXRwdXQuaW1hZ2UsICIucG5nIiwg Z2VuZXJhdGVfbmV3X2Jhc2VsaW5lPVRydWUpCiAKICAgICBkZWYgX292ZXJ3cml0ZV9iYXNlbGlu ZXMoc2VsZiwgZHJpdmVyX291dHB1dCk6CiAgICAgICAgICMgQWx0aG91Z2ggYWxsIER1bXBSZW5k ZXJUcmVlIG91dHB1dCBzaG91bGQgYmUgdXRmLTgsCkBAIC0xODIsOCArMTgyLDcgQEAgY2xhc3Mg U2luZ2xlVGVzdFJ1bm5lcjoKICAgICAgICAgICAgIHJlbGF0aXZlX2RpciA9IGZzLmRpcm5hbWUo c2VsZi5fdGVzdF9uYW1lKQogICAgICAgICAgICAgYmFzZWxpbmVfcGF0aCA9IHBvcnQuYmFzZWxp bmVfcGF0aCgpCiAgICAgICAgICAgICBvdXRwdXRfZGlyID0gZnMuam9pbihiYXNlbGluZV9wYXRo LCByZWxhdGl2ZV9kaXIpCi0gICAgICAgICAgICBvdXRwdXRfZmlsZSA9IGZzLmJhc2VuYW1lKGZz LnNwbGl0ZXh0KHNlbGYuX3Rlc3RfbmFtZSlbMF0gKwotICAgICAgICAgICAgICAgICItZXhwZWN0 ZWQiICsgbW9kaWZpZXIpCisgICAgICAgICAgICBvdXRwdXRfZmlsZSA9IGZzLmJhc2VuYW1lKGZz LnNwbGl0ZXh0KHNlbGYuX3Rlc3RfbmFtZSlbMF0gKyAiLWV4cGVjdGVkIiArIG1vZGlmaWVyKQog ICAgICAgICAgICAgZnMubWF5YmVfbWFrZV9kaXJlY3Rvcnkob3V0cHV0X2RpcikKICAgICAgICAg ICAgIG91dHB1dF9wYXRoID0gZnMuam9pbihvdXRwdXRfZGlyLCBvdXRwdXRfZmlsZSkKICAgICAg ICAgZWxzZToKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9wb3J0L3Rlc3QucHkJKHJldmlzaW9uIDk4MDI3KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC90ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xMzksNiArMTM5 LDE0IEBAIGRlZiB1bml0X3Rlc3RfbGlzdCgpOgogICAgIHRlc3RzLmFkZCgnZmFpbHVyZXMvZXhw ZWN0ZWQvdGV4dC5odG1sJywgYWN0dWFsX3RleHQ9J3RleHRfZmFpbC1wbmcnKQogICAgIHRlc3Rz LmFkZCgnZmFpbHVyZXMvdW5leHBlY3RlZC9taXNzaW5nX3RleHQuaHRtbCcsIGV4cGVjdGVkX3Rl eHQ9Tm9uZSkKICAgICB0ZXN0cy5hZGQoJ2ZhaWx1cmVzL3VuZXhwZWN0ZWQvbWlzc2luZ19pbWFn ZS5odG1sJywgZXhwZWN0ZWRfaW1hZ2U9Tm9uZSkKKyAgICB0ZXN0cy5hZGQoJ2ZhaWx1cmVzL3Vu ZXhwZWN0ZWQvbWlzc2luZ19yZW5kZXJfdHJlZV9kdW1wLmh0bWwnLCBhY3R1YWxfdGV4dD0iIiJs YXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVyVmlldyBhdCAoMCwwKSBzaXplIDgw MHg2MDAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDM0CisgIFJlbmRlckJsb2NrIHtIVE1MfSBh dCAoMCwwKSBzaXplIDgwMHgzNAorICAgIFJlbmRlckJvZHkge0JPRFl9IGF0ICg4LDgpIHNpemUg Nzg0eDE4CisgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6ZSAxMzN4MTgKKyAg ICAgICAgdGV4dCBydW4gYXQgKDAsMCkgd2lkdGggMTMzOiAiVGhpcyBpcyBhbiBpbWFnZSB0ZXN0 ISIKKyIiIiwgZXhwZWN0ZWRfdGV4dD1Ob25lKQogICAgIHRlc3RzLmFkZCgnZmFpbHVyZXMvdW5l eHBlY3RlZC9jcmFzaC5odG1sJywgY3Jhc2g9VHJ1ZSkKICAgICB0ZXN0cy5hZGQoJ2ZhaWx1cmVz L3VuZXhwZWN0ZWQvY3Jhc2gtd2l0aC1zdGRlcnIuaHRtbCcsIGNyYXNoPVRydWUsCiAgICAgICAg ICAgICAgIGVycm9yPSJtb2NrLXN0ZC1lcnJvci1vdXRwdXQiKQo=