68925 2011-09-27 12:36:02 -0700 Add layout test for WaveShaperNode 2011-09-27 19:58:01 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 crogers crogers eric.carlson jer.noble kbr webkit.review.bot oldest_to_newest 474146 0 crogers 2011-09-27 12:36:02 -0700 Add layout test for WaveShaperNode 474148 1 108883 crogers 2011-09-27 12:38:19 -0700 Created attachment 108883 Patch 474150 2 crogers 2011-09-27 12:39:44 -0700 Please see the specification for WaveShaperNode for more background: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#WaveShaperNode-section 474427 3 108883 kbr 2011-09-27 18:40:14 -0700 Comment on attachment 108883 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108883&action=review This looks great to me modulo one nit. These layout tests for the Web Audio API are looking really nice so far. r=me > LayoutTests/webaudio/waveshaper.html:8 > +<script type="text/javascript" src="resources/buffer-loader.js"></script> I don't think this file is needed. 474446 4 108883 webkit.review.bot 2011-09-27 19:57:57 -0700 Comment on attachment 108883 Patch Clearing flags on attachment: 108883 Committed r96182: <http://trac.webkit.org/changeset/96182> 474447 5 webkit.review.bot 2011-09-27 19:58:01 -0700 All reviewed patches have been landed. Closing bug. 108883 2011-09-27 12:38:19 -0700 2011-09-27 19:57:57 -0700 Patch bug-68925-20110927123818.patch text/plain 5817 crogers U3VidmVyc2lvbiBSZXZpc2lvbjogOTU4MzcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBhOTUyOGNhZmI0NTc2ZjE2MTZlNmI1 OWRmY2QwY2RkMjg0NDdlNGI3Li45ZGQxZmMxYTQxZGRhMDQwZDJhY2M0OGY4OTFjNTMwNWEyZGE0 MTkyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDktMjcgIENocmlzIFJvZ2VycyAgPGNy b2dlcnNAZ29vZ2xlLmNvbT4KKworICAgICAgICBBZGQgbGF5b3V0IHRlc3QgZm9yIFdhdmVTaGFw ZXJOb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 ODkyNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog d2ViYXVkaW8vd2F2ZXNoYXBlci1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHdlYmF1 ZGlvL3dhdmVzaGFwZXIuaHRtbDogQWRkZWQuCisKIDIwMTEtMDktMjMgIElseWEgVGlraG9ub3Zz a3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIE5vcm1hbGl6 ZSB0ZXN0IG5hbWVzLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvd2ViYXVkaW8vd2F2ZXNoYXBl ci1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy93ZWJhdWRpby93YXZlc2hhcGVyLWV4cGVjdGVk LnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwLi5kODE1NDkzZjEwNjBjNzQ1ODA4ZDAyZTlmNzY5MmM1ZTg5MDcyNzgw Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvd2ViYXVkaW8vd2F2ZXNoYXBlci1leHBl Y3RlZC50eHQKQEAgLTAsMCArMSw5IEBACitUZXN0cyB0aGF0IFdhdmVTaGFwZXJOb2RlIGFwcGxp ZXMgcHJvcGVyIG5vbi1saW5lYXIgZGlzdG9ydGlvbi4KKworT24gc3VjY2VzcywgeW91IHdpbGwg c2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExF VEUiLgorCitQQVNTIFdhdmVTaGFwZXJOb2RlIHByb3Blcmx5IGFwcGxpZWQgbm9uLWxpbmVhciBk aXN0b3J0aW9uLgorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBM RVRFCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3dlYmF1ZGlvL3dhdmVzaGFwZXIuaHRtbCBi L0xheW91dFRlc3RzL3dlYmF1ZGlvL3dhdmVzaGFwZXIuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi42ZDEyYmE2 MjhkMDJlYzFmMWY0YzIxZjMwYzc4YzkwYmYzZWM2YTQ0Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvd2ViYXVkaW8vd2F2ZXNoYXBlci5odG1sCkBAIC0wLDAgKzEsMTQwIEBACis8IURP Q1RZUEUgaHRtbD4KKworPGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJl Zj0iLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiLz4KKzxzY3JpcHQgc3Jj PSIuLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0 IHR5cGU9InRleHQvamF2YXNjcmlwdCIgc3JjPSJyZXNvdXJjZXMvYXVkaW8tdGVzdGluZy5qcyI+ PC9zY3JpcHQ+Cis8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCIgc3JjPSJyZXNvdXJjZXMv YnVmZmVyLWxvYWRlci5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+CisKKzxib2R5PgorCis8ZGl2IGlk PSJkZXNjcmlwdGlvbiI+PC9kaXY+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKworPHNjcmlw dD4KK2Rlc2NyaXB0aW9uKCJUZXN0cyB0aGF0IFdhdmVTaGFwZXJOb2RlIGFwcGxpZXMgcHJvcGVy IG5vbi1saW5lYXIgZGlzdG9ydGlvbi4iKTsKKwordmFyIHNhbXBsZVJhdGUgPSA0NDEwMDsKK3Zh ciBsZW5ndGhJblNlY29uZHMgPSA0OwordmFyIG51bWJlck9mUmVuZGVyRnJhbWVzID0gc2FtcGxl UmF0ZSAqIGxlbmd0aEluU2Vjb25kczsKK3ZhciBudW1iZXJPZkN1cnZlRnJhbWVzID0gNjU1MzY7 Cit2YXIgaW5wdXRCdWZmZXI7Cit2YXIgd2F2ZVNoYXBpbmdDdXJ2ZTsKKwordmFyIGNvbnRleHQ7 CisKK2Z1bmN0aW9uIGdlbmVyYXRlSW5wdXRCdWZmZXIoKSB7CisgICAgLy8gQ3JlYXRlIG1vbm8g aW5wdXQgYnVmZmVyLgorICAgIHZhciBidWZmZXIgPSBjb250ZXh0LmNyZWF0ZUJ1ZmZlcigxLCBu dW1iZXJPZlJlbmRlckZyYW1lcywgY29udGV4dC5zYW1wbGVSYXRlKTsKKyAgICB2YXIgZGF0YSA9 IGJ1ZmZlci5nZXRDaGFubmVsRGF0YSgwKTsKKyAgICAKKyAgICAvLyBHZW5lcmF0ZSBhbiBpbnB1 dCB2ZWN0b3Igd2l0aCB2YWx1ZXMgZnJvbSAtMSAtPiArMSBvdmVyIGEgZHVyYXRpb24gb2YgbGVu Z3RoSW5TZWNvbmRzLgorICAgIC8vIFRoaXMgZXhlcmNpc2VzIHRoZSBmdWxsIG5vbWluYWwgaW5w dXQgcmFuZ2UgYW5kIHdpbGwgdG91Y2ggZXZlcnkgcG9pbnQgb2YgdGhlIHNoYXBpbmcgY3VydmUu CisgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBudW1iZXJPZlJlbmRlckZyYW1lczsgKytpKSB7Cisg ICAgICAgIHZhciB4ID0gaSAvIG51bWJlck9mUmVuZGVyRnJhbWVzOyAvLyAwIC0+IDEKKyAgICAg ICAgeCA9IDIgKiB4IC0gMTsgLy8gLTEgLT4gKzEKKyAgICAgICAgZGF0YVtpXSA9IHg7CisgICAg fQorCisgICAgcmV0dXJuIGJ1ZmZlcjsKK30KKworLy8gR2VuZXJhdGVzIGEgc3ltbWV0cmljIGN1 cnZlOiBNYXRoLmF0YW4oNSAqIHgpIC8gKDAuNSAqIE1hdGguUEkpCisvLyAod2l0aCB4ID09IDAg Y29ycmVzcG9uZGluZyB0byB0aGUgY2VudGVyIG9mIHRoZSBhcnJheSkKKy8vIFRoaXMgY3VydmUg aXMgYXJiaXRyYXJ5LCBidXQgd291bGQgYmUgdXNlZnVsIGluIHRoZSByZWFsLXdvcmxkLgorLy8g VG8gc29tZSBleHRlbnQsIHRoZSBhY3R1YWwgY3VydmUgd2UgY2hvb3NlIGlzIG5vdCBpbXBvcnRh bnQgaW4gdGhpcyB0ZXN0LAorLy8gc2luY2UgdGhlIGlucHV0IHZlY3RvciB3YWxrcyB0aHJvdWdo IGFsbCBwb3NzaWJsZSBjdXJ2ZSB2YWx1ZXMuCitmdW5jdGlvbiBnZW5lcmF0ZVdhdmVTaGFwaW5n Q3VydmUoKSB7CisgICAgdmFyIGN1cnZlID0gbmV3IEZsb2F0MzJBcnJheShudW1iZXJPZkN1cnZl RnJhbWVzKTsKKyAgICAKKyAgICB2YXIgbiA9IG51bWJlck9mQ3VydmVGcmFtZXM7CisgICAgdmFy IG4yID0gbiAvIDI7CisgICAgCisgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBuOyArK2kpIHsKKyAg ICAgICAgdmFyIHggPSAoaSAtIG4yKSAvIG4yOworICAgICAgICB2YXIgeSA9IE1hdGguYXRhbig1 ICogeCkgLyAoMC41ICogTWF0aC5QSSk7CisgICAgfQorCisgICAgcmV0dXJuIGN1cnZlOworfQor CitmdW5jdGlvbiBjaGVja1NoYXBlZEN1cnZlKGV2ZW50KSB7CisgICAgdmFyIGJ1ZmZlciA9IGV2 ZW50LnJlbmRlcmVkQnVmZmVyOworCisgICAgdmFyIGlucHV0RGF0YSA9IGlucHV0QnVmZmVyLmdl dENoYW5uZWxEYXRhKDApOworICAgIHZhciBvdXRwdXREYXRhID0gYnVmZmVyLmdldENoYW5uZWxE YXRhKDApOworCisgICAgdmFyIHN1Y2Nlc3MgPSB0cnVlOworICAgIAorICAgIC8vIEdvIHRocm91 Z2ggZXZlcnkgc2FtcGxlIGFuZCBtYWtlIHN1cmUgaXQgaGFzIGJlZW4gc2hhcGVkIGV4YWN0bHkg YWNjb3JkaW5nIHRvIHRoZSBzaGFwaW5nIGN1cnZlIHdlIGdhdmUgaXQuCisgICAgZm9yICh2YXIg aSA9IDA7IGkgPCBidWZmZXIubGVuZ3RoOyArK2kpIHsKKyAgICAgICAgdmFyIGlucHV0ID0gaW5w dXREYXRhW2ldOworICAgICAgICAKKyAgICAgICAgLy8gQ2FsY3VsYXRlIGFuIGluZGV4IGJhc2Vk IG9uIGlucHV0IC0xIC0+ICsxIHdpdGggMCBiZWluZyBhdCB0aGUgY2VudGVyIG9mIHRoZSBjdXJ2 ZSBkYXRhLgorICAgICAgICB2YXIgaW5kZXggPSBNYXRoLmZsb29yKG51bWJlck9mQ3VydmVGcmFt ZXMgKiAwLjUgKiAoaW5wdXQgKyAxKSk7CisKKyAgICAgICAgLy8gQ2xpcCBpbmRleCB0byB0aGUg aW5wdXQgcmFuZ2Ugb2YgdGhlIGN1cnZlLgorICAgICAgICAvLyBUaGlzIHRha2VzIGNhcmUgb2Yg aW5wdXQgb3V0c2lkZSBvZiBub21pbmFsIHJhbmdlIC0xIC0+ICsxCisgICAgICAgIGluZGV4ID0g aW5kZXggPCAwID8gMCA6IGluZGV4OworICAgICAgICBpbmRleCA9IGluZGV4ID4gbnVtYmVyT2ZD dXJ2ZUZyYW1lcyAtIDEgPyBudW1iZXJPZkN1cnZlRnJhbWVzIC0gMSA6IGluZGV4OworCisgICAg ICAgIHZhciBleHBlY3RlZE91dHB1dCA9IHdhdmVTaGFwaW5nQ3VydmVbaW5kZXhdOworICAgICAg ICAKKyAgICAgICAgdmFyIG91dHB1dCA9IG91dHB1dERhdGFbaV07CisgICAgICAgIAorICAgICAg ICBpZiAob3V0cHV0ICE9IGV4cGVjdGVkT3V0cHV0KSB7CisgICAgICAgICAgICBzdWNjZXNzID0g ZmFsc2U7CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAgfQorICAgIH0KKworICAgIGlmIChz dWNjZXNzKSB7CisgICAgICAgIHRlc3RQYXNzZWQoIldhdmVTaGFwZXJOb2RlIHByb3Blcmx5IGFw cGxpZWQgbm9uLWxpbmVhciBkaXN0b3J0aW9uLiIpOworICAgIH0gZWxzZSB7CisgICAgICAgIHRl c3RGYWlsZWQoIldhdmVTaGFwZXJOb2RlIGRpZCBub3QgcHJvcGVybHkgYXBwbHkgbm9uLWxpbmVh ciBkaXN0b3J0aW9uLiIpOworICAgIH0KKworICAgIGZpbmlzaEpTVGVzdCgpOworfQorCitmdW5j dGlvbiBydW5UZXN0KCkgeworICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsK KyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgICAgICBsYXlv dXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7CisgICAgfQorICAgIAorICAgIHdpbmRv dy5qc1Rlc3RJc0FzeW5jID0gdHJ1ZTsKKyAgICAgICAgCisgICAgLy8gQ3JlYXRlIG9mZmxpbmUg YXVkaW8gY29udGV4dC4KKyAgICBjb250ZXh0ID0gbmV3IHdlYmtpdEF1ZGlvQ29udGV4dCgxLCBu dW1iZXJPZlJlbmRlckZyYW1lcywgc2FtcGxlUmF0ZSk7CisgICAgCisgICAgLy8gc291cmNlIC0+ IHdhdmVzaGFwZXIgLT4gZGVzdGluYXRpb24KKyAgICB2YXIgc291cmNlID0gY29udGV4dC5jcmVh dGVCdWZmZXJTb3VyY2UoKTsKKyAgICB2YXIgd2F2ZXNoYXBlciA9IGNvbnRleHQuY3JlYXRlV2F2 ZVNoYXBlcigpOworICAgIHNvdXJjZS5jb25uZWN0KHdhdmVzaGFwZXIpOworICAgIHdhdmVzaGFw ZXIuY29ubmVjdChjb250ZXh0LmRlc3RpbmF0aW9uKTsKKworICAgIC8vIENyZWF0ZSBhbiBpbnB1 dCB0ZXN0IHZlY3Rvci4KKyAgICBpbnB1dEJ1ZmZlciA9IGdlbmVyYXRlSW5wdXRCdWZmZXIoKTsK KyAgICBzb3VyY2UuYnVmZmVyID0gaW5wdXRCdWZmZXI7CisgICAgCisgICAgLy8gV2UnbGwgYXBw bHkgbm9uLWxpbmVhciBkaXN0b3J0aW9uIGFjY29yZGluZyB0byB0aGlzIHNoYXBpbmcgY3VydmUu CisgICAgd2F2ZVNoYXBpbmdDdXJ2ZSA9IGdlbmVyYXRlV2F2ZVNoYXBpbmdDdXJ2ZSgpOworICAg IHdhdmVzaGFwZXIuY3VydmUgPSB3YXZlU2hhcGluZ0N1cnZlOworICAgIAorICAgIHNvdXJjZS5u b3RlT24oMCk7CisgICAgCisgICAgY29udGV4dC5vbmNvbXBsZXRlID0gY2hlY2tTaGFwZWRDdXJ2 ZTsKKyAgICBjb250ZXh0LnN0YXJ0UmVuZGVyaW5nKCk7Cit9CisKK3J1blRlc3QoKTsKK3N1Y2Nl c3NmdWxseVBhcnNlZCA9IHRydWU7CisKKzwvc2NyaXB0PgorCis8c2NyaXB0IHNyYz0iLi4vZmFz dC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRt bD4K