68923 2011-09-27 11:57:24 -0700 [Chromium] Fixed layout mode tests break subsequent tests 2011-09-27 13:23:16 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mihaip mihaip abarth fsamuel oldest_to_newest 474126 0 mihaip 2011-09-27 11:57:24 -0700 platform/chromium/fast/text/text-stroke-with-border.html has been flaky for quite a while: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fchromium%2Ffast%2Ftext%2Ftext-stroke-with-border.html&showExpectations=true However, it almost always passes when retried. Looking at the diffs, it's supposed to have a 800x600 layout, but instead it ends up with a 360x240 one, even though it does no resizing. Looking at a test log (http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6/builds/8553/steps/webkit_tests/logs/stdio), it looks like the worker that runs it also runs platform/chromium/fast/repaint/fixed-layout-360x240.html shortly before. You can also reproduce this locally with: run-webkit-tests --chromium --release --no-retry-failures platform/chromium/fast/repaint/fixed-layout-360x240.html platform/chromium/fast/text/text-stroke-with-border.html (both tests pass when run in insolation) The first test uses LayoutTestController capabilities that were added http://trac.webkit.org/changeset/94779 to switch to fixed layout. However, in between tests we never switch the ScrollView from out of fixed layout mode, so subsequent tests (until the next DRT process restart, which could be 1,000 tests later) end up in this inconsistent state. I'll look into resetting fixed layout mode. 474133 1 fsamuel 2011-09-27 12:03:49 -0700 Thanks for catching this. This should be a one-liner in Tools/DumpRenderTree/chromium/LayoutTestController.cpp. LayoutTestController::reset() that sets m_shell->webView()->enableFixedLayoutMode(false); Thanks again. 474135 2 108879 mihaip 2011-09-27 12:13:37 -0700 Created attachment 108879 Patch 474136 3 mihaip 2011-09-27 12:14:31 -0700 Wasn't sure about where to do this resetting (where you mentioned vs. WebViewHost::reset() vs. TestShell::resetTestController()). I ended up going with the latter, since it's where we also reset page scaling, which seems similar. 474185 4 mihaip 2011-09-27 13:23:16 -0700 Committed r96147: <http://trac.webkit.org/changeset/96147> 108879 2011-09-27 12:13:37 -0700 2011-09-27 12:29:14 -0700 Patch bug-68923-20110927121336.patch text/plain 1512 mihaip U3VidmVyc2lvbiBSZXZpc2lvbjogOTYxMzcKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4Mjc1YTE3ZTNiMTAwZjUwZGY0ZDc1MjQxZjJhMjc1Y2E1 MTkwMDEzLi5kMWI5OTAyZjgwNzFkZjk0ZmNjMjgwZWRlMGRhMDlkOWZjMTBjNjgyIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDktMjcgIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgW0Nocm9taXVtXSBGaXhlZCBsYXlvdXQgbW9kZSB0ZXN0cyBicmVhayBzdWJzZXF1 ZW50IHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02ODkyMworCisgICAgICAgIFJlc2V0IGZpeGVkIGxheW91dCBtb2RlIGJldHdlZW4gdGVzdHMs IHNvIHRoYXQgdGVzdHMgdGhhdCBydW4gYWZ0ZXIKKyAgICAgICAgcGxhdGZvcm0vY2hyb21pdW0v ZmFzdC9yZXBhaW50L2ZpeGVkLWxheW91dC0zNjB4MjQwLmh0bWwgc3RpbGwgaGF2ZSB0aGUKKyAg ICAgICAgcmVndWxhciA4MDB4NjAwIG5vbi1maXhlZCBsYXlvdXQuCisKKyAgICAgICAgKiBEdW1w UmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0U2hlbGwuY3BwOgorICAgICAgICAoVGVzdFNoZWxsOjpy ZXNldFRlc3RDb250cm9sbGVyKToKKwogMjAxMS0wOS0yNyAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3 ZWJraXQub3JnPgogCiAgICAgICAgIGdhcmRlbi1vLW1hdGljIHJlc3VsdHMgdmlldyBzaG91bGQg c29ydCB0ZXN0IGFuZCBidWlsZGVyIG5hbWVzCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVy VHJlZS9jaHJvbWl1bS9UZXN0U2hlbGwuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21p dW0vVGVzdFNoZWxsLmNwcAppbmRleCAzZTRjOTRjZThiMjVlMmM5Y2UzYzMwMDVlMmI3YzNkZjg4 NzU4ODMzLi43ZjNkODIxZDA0OTA4NjE2ZThkOTA0YzEzODFkZDNkYzU1ODJkNGQ4IDEwMDY0NAot LS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0U2hlbGwuY3BwCisrKyBiL1Rv b2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVsbC5jcHAKQEAgLTI2OSw2ICsyNjks OCBAQCB2b2lkIFRlc3RTaGVsbDo6cmVzZXRUZXN0Q29udHJvbGxlcigpCiAgICAgaWYgKG1fZHJ0 RGV2VG9vbHNDbGllbnQpCiAgICAgICAgIG1fZHJ0RGV2VG9vbHNDbGllbnQtPnJlc2V0KCk7CiAg ICAgd2ViVmlldygpLT5zY2FsZVBhZ2UoMSwgV2ViUG9pbnQoMCwgMCkpOworICAgIHdlYlZpZXco KS0+ZW5hYmxlRml4ZWRMYXlvdXRNb2RlKGZhbHNlKTsKKyAgICB3ZWJWaWV3KCktPnNldEZpeGVk TGF5b3V0U2l6ZShXZWJTaXplKDAsIDApKTsKICAgICB3ZWJWaWV3KCktPm1haW5GcmFtZSgpLT5j bGVhck9wZW5lcigpOwogICAgIFdlYlRlc3RpbmdTdXBwb3J0OjpyZXNldEludGVybmFsc09iamVj dCh3ZWJWaWV3KCktPm1haW5GcmFtZSgpKTsKIH0K