68906 2011-09-27 08:49:48 -0700 Make Chromium Win Release (Tests) a core builder 2011-09-28 00:01:41 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa abarth aroben eric ossy wsiegrist oldest_to_newest 473953 0 rniwa 2011-09-27 08:49:48 -0700 It appears that Chromium Windows Release (Tests) is stable enough to become a core builder: http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29?numbuilds=200 Comparison: Snow Leopard Intel: http://build.webkit.org/builders/SnowLeopard%20Intel%20Debug%20%28Tests%29?numbuilds=200 Qt: http://build.webkit.org/builders/Qt%20Linux%20Release?numbuilds=200 Chromium Linux: http://build.webkit.org/builders/Chromium%20Linux%20Release%20%28Tests%29?numbuilds=200 473963 1 108855 rniwa 2011-09-27 09:05:58 -0700 Created attachment 108855 Patch 474009 2 108855 abarth 2011-09-27 09:52:05 -0700 Comment on attachment 108855 Patch Ok. I'd prefer to delete the notion of a whether a builder is core though. 474177 3 rniwa 2011-09-27 13:12:38 -0700 Thanks for the review. I'll land this patch at night when the tree is more quiet. 474547 4 108855 rniwa 2011-09-28 00:01:37 -0700 Comment on attachment 108855 Patch Clearing flags on attachment: 108855 Committed r96194: <http://trac.webkit.org/changeset/96194> 474548 5 rniwa 2011-09-28 00:01:41 -0700 All reviewed patches have been landed. Closing bug. 108855 2011-09-27 09:05:58 -0700 2011-09-28 00:01:37 -0700 Patch bug-68906-20110927090557.patch text/plain 2536 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk2MTE1KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTEtMDktMjcgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgTWFrZSBDaHJvbWl1bSBXaW4gUmVsZWFzZSAoVGVzdHMpIGEgY29yZSBidWlsZGVy CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODkwNgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBDaHJv bWl1bSBXaW4gUmVsZWFzZSAoVGVzdHMpIHRvIHRoZSBsaXN0IG9mIGNvcmUgYnVpbGRlcnMuCisK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVpbGRib3QvYnVpbGRib3Qu cHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1aWxkYm90L2J1aWxk Ym90X3VuaXR0ZXN0LnB5OgorCiAyMDExLTA5LTI3ICBEYXZpZCBMZXZpbiAgPGxldmluQGNocm9t aXVtLm9yZz4KIAogICAgICAgICB3YXRjaGxpc3Q6IENoYW5nZSB3YXRjaGxpc3RwYXJzZXIucHkg dG8gYmUgY2xhc3MgYmFzZWQuCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9u ZXQvYnVpbGRib3QvYnVpbGRib3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb21tb24vbmV0L2J1aWxkYm90L2J1aWxkYm90LnB5CShyZXZpc2lvbiA5NjA3OCkKKysr IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWlsZGJvdC9idWlsZGJvdC5weQko d29ya2luZyBjb3B5KQpAQCAtMzA1LDcgKzMwNSw3IEBAIGNsYXNzIEJ1aWxkQm90KG9iamVjdCk6 CiAgICAgICAgICAgICAiR1RLLio2NC4qRGVidWciLCAgIyBEaXNhbGxvdyB0aGUgNjQtYml0IFJl bGVhc2UgYm90IHdoaWNoIGlzIGJyb2tlbi4KICAgICAgICAgICAgICJRdCIsCiAgICAgICAgICAg ICAiQ2hyb21pdW0uKihNYWN8TGludXh8V2luKS4qUmVsZWFzZSQiLAotICAgICAgICAgICAgIkNo cm9taXVtLiooTWFjfExpbnV4KS4qUmVsZWFzZS4qXChUZXN0cyIsCisgICAgICAgICAgICAiQ2hy b21pdW0uKihNYWN8TGludXh8V2luKS4qUmVsZWFzZS4qXChUZXN0cyIsCiAgICAgICAgIF0KIAog ICAgIGRlZiBfcGFyc2VfbGFzdF9idWlsZF9jZWxsKHNlbGYsIGJ1aWxkZXIsIGNlbGwpOgpJbmRl eDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1aWxkYm90L2J1aWxkYm90X3Vu aXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25l dC9idWlsZGJvdC9idWlsZGJvdF91bml0dGVzdC5weQkocmV2aXNpb24gOTYwNzgpCisrKyBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVpbGRib3QvYnVpbGRib3RfdW5pdHRlc3Qu cHkJKHdvcmtpbmcgY29weSkKQEAgLTI4OSw3ICsyODksNyBAQCBjbGFzcyBCdWlsZEJvdFRlc3Qo dW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICAgICAgIkdUSy4qNjQuKkRlYnVnIiwgICMgRGlz YWxsb3cgdGhlIDY0LWJpdCBSZWxlYXNlIGJvdCB3aGljaCBpcyBicm9rZW4uCiAgICAgICAgICAg ICAiUXQiLAogICAgICAgICAgICAgIkNocm9taXVtLiooTWFjfExpbnV4fFdpbikuKlJlbGVhc2Uk IiwKLSAgICAgICAgICAgICJDaHJvbWl1bS4qKE1hY3xMaW51eCkuKlJlbGVhc2UuKlwoVGVzdHMi LAorICAgICAgICAgICAgIkNocm9taXVtLiooTWFjfExpbnV4fFdpbikuKlJlbGVhc2UuKlwoVGVz dHMiLAogICAgICAgICBdCiAgICAgICAgIGV4cGVjdGVkX2J1aWxkZXJzID0gWwogICAgICAgICAg ICAgeyduYW1lJzogdSdMZW9wYXJkIEludGVsIFJlbGVhc2UgKEJ1aWxkKScsIH0sCkBAIC0zMTIs NiArMzEyLDcgQEAgY2xhc3MgQnVpbGRCb3RUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAg ICAgICAgIHsnbmFtZSc6IHUnUXQgV2luZG93cyAzMi1iaXQgUmVsZWFzZScsIH0sCiAgICAgICAg ICAgICB7J25hbWUnOiB1J1F0IFdpbmRvd3MgMzItYml0IERlYnVnJywgfSwKICAgICAgICAgICAg IHsnbmFtZSc6IHUnQ2hyb21pdW0gV2luIFJlbGVhc2UnLCB9LAorICAgICAgICAgICAgeyduYW1l JzogdSdDaHJvbWl1bSBXaW4gUmVsZWFzZSAoVGVzdHMpJywgfSwKICAgICAgICAgICAgIHsnbmFt ZSc6IHUnQ2hyb21pdW0gTWFjIFJlbGVhc2UnLCB9LAogICAgICAgICAgICAgeyduYW1lJzogdSdD aHJvbWl1bSBNYWMgUmVsZWFzZSAoVGVzdHMpJywgfSwKICAgICAgICAgICAgIHsnbmFtZSc6IHUn Q2hyb21pdW0gTGludXggUmVsZWFzZScsIH0sCg==