68905 2011-09-27 08:41:58 -0700 [chromium] Add a setVisibility method to WebGraphicsContext3D. 2011-10-20 16:22:24 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mmocny mmocny backer dglazkov fishd kbr webkit.review.bot oldest_to_newest 473948 0 mmocny 2011-09-27 08:41:58 -0700 [chromium][Not for review] Add a setVisibility method to WebGraphicsContext3D. 473950 1 108852 mmocny 2011-09-27 08:45:23 -0700 Created attachment 108852 Patch 484038 2 111025 mmocny 2011-10-14 10:07:30 -0700 Created attachment 111025 Patch 484039 3 webkit.review.bot 2011-10-14 10:11:01 -0700 Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. 484041 4 111025 webkit.review.bot 2011-10-14 10:12:32 -0700 Comment on attachment 111025 Patch Attachment 111025 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10066573 484059 5 mmocny 2011-10-14 10:36:21 -0700 Kenneth, it looked like you were a good reviewer for this patch, but if someone else is more appropriate, please let me know (and sorry to bother). This patch will give WebGraphicsContext3D implementations the opportunity to release some needless graphics resources. 484081 6 111025 kbr 2011-10-14 11:17:09 -0700 Comment on attachment 111025 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111025&action=review > Source/WebKit/chromium/public/WebGraphicsContext3D.h:144 > + virtual void setVisibility(bool visible) = 0; It seems clear that this is only useful for the compositor's context. What resources are released when called with argument "false"? Would it make more sense to just destroy the context and recreate it from scratch when visibility becomes true again? Without knowing more, it seems to me that any releasing of resources would be better done at the WebKit level. Also, you would need to either temporarily provide an empty body for this or land all of the Chromium side implementations first (and roll Source/WebKit/chromium/DEPS) in order to fix the pure virtual compilation problem on the EWS bots. 484100 7 backer 2011-10-14 11:28:12 -0700 I'm not sure that I understand the comment about being compositor specific. One could imagine other contexts (like Pepper3D or WebGL) wanting to release some resources if they aren't visible. E.g. AFAIK for WebGL, we double buffer; we could release one of those buffers in the GLES2Decoder if we had the appropriate signals plumbed (perhaps we'd only want to do that when the compositor context is not visible?). 484186 8 fishd 2011-10-14 12:37:57 -0700 (In reply to comment #3) > Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. I defer to Ken Russell for this change. I don't need to review it further. 484189 9 kbr 2011-10-14 12:39:39 -0700 (In reply to comment #7) > I'm not sure that I understand the comment about being compositor specific. One could imagine other contexts (like Pepper3D or WebGL) wanting to release some resources if they aren't visible. E.g. AFAIK for WebGL, we double buffer; we could release one of those buffers in the GLES2Decoder if we had the appropriate signals plumbed (perhaps we'd only want to do that when the compositor context is not visible?). The signaling in the current patch is compositor specific so the intent wasn't clear. The direction WebGL is going is to move the back buffer handling up to WebKit. See bug 53201. This means that any discarding of secondary buffers could be done in common code without plumbing anything through the WebGraphicsContext3D interface. The issue of secondary buffers doesn't really become relevant for WebGL until threaded compositing is in place though. I'd still like to see the Chromium side patch that uses this signal. 484213 10 mmocny 2011-10-14 12:56:53 -0700 (In reply to comment #9) > (In reply to comment #7) > > I'm not sure that I understand the comment about being compositor specific. One could imagine other contexts (like Pepper3D or WebGL) wanting to release some resources if they aren't visible. E.g. AFAIK for WebGL, we double buffer; we could release one of those buffers in the GLES2Decoder if we had the appropriate signals plumbed (perhaps we'd only want to do that when the compositor context is not visible?). > > The signaling in the current patch is compositor specific so the intent wasn't clear. > > The direction WebGL is going is to move the back buffer handling up to WebKit. See bug 53201. This means that any discarding of secondary buffers could be done in common code without plumbing anything through the WebGraphicsContext3D interface. The issue of secondary buffers doesn't really become relevant for WebGL until threaded compositing is in place though. > > I'd still like to see the Chromium side patch that uses this signal. The Chromium patch is: http://codereview.chromium.org/7890046 486271 11 111025 kbr 2011-10-18 13:22:46 -0700 Comment on attachment 111025 Patch OK, this seems fine at least as an interim solution. Source/WebKit/chromium/DEPS has since been rolled forward, so I think this will pass the commit queue now. r=me 486309 12 111025 webkit.review.bot 2011-10-18 14:27:35 -0700 Comment on attachment 111025 Patch Rejecting attachment 111025 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: pport/Source/WebKit/chromium/webkit/support/test_webkit_platform_support.o] Error 1 make: *** Waiting for unfinished jobs.... Failed to run "['Tools/Scripts/build-webkit', '--debug', '--chromium', '--update-chromium']" exit_code: 2 c/WebGraphicsContext3D.h:144: note: virtual void WebKit::WebGraphicsContext3D::setVisibility(bool) make: *** [out/Debug/obj.target/webkit_support/Source/WebKit/chromium/webkit/support/test_webkit_platform_support.o] Error 1 make: *** Waiting for unfinished jobs.... Full output: http://queues.webkit.org/results/10142031 486316 13 kbr 2011-10-18 14:36:38 -0700 Michal, you'll have to add the new virtual to src/webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc / .h downstream in Chromium, and once that's committed, roll forward chromium_rev in Source/WebKit/chromium/DEPS. 487739 14 111812 mmocny 2011-10-20 11:40:17 -0700 Created attachment 111812 Patch 487810 15 111812 kbr 2011-10-20 13:09:11 -0700 Comment on attachment 111812 Patch Looks good to me. 487976 16 111812 webkit.review.bot 2011-10-20 16:22:19 -0700 Comment on attachment 111812 Patch Clearing flags on attachment: 111812 Committed r98036: <http://trac.webkit.org/changeset/98036> 487977 17 webkit.review.bot 2011-10-20 16:22:24 -0700 All reviewed patches have been landed. Closing bug. 108852 2011-09-27 08:45:23 -0700 2011-10-14 10:07:24 -0700 Patch bug-68905-20110927114352.patch text/plain 3042 mmocny U3VidmVyc2lvbiBSZXZpc2lvbjogOTU5OTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg OGYzMjFjMGU2Zjk5ZTQzNTgxN2I1ZmJlMmQxNWYzMDY1M2ZhYzZhNS4uZWViN2E0ZTFlMDNjMmU2 M2ZhMGIzYTJiMWVkNjhiMjA2MDFlODUwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNyBAQAorMjAxMS0wOS0yNyAgTWljaGFsIE1vY255ICA8bW1vY255QGdvb2dsZS5j b20+CisKKyAgICAgICAgW2Nocm9taXVtXVtOb3QgZm9yIHJldmlld10gQWRkIGEgc2V0VmlzaWJp bGl0eSBtZXRob2QgdG8gV2ViR3JhcGhpY3NDb250ZXh0M0QuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODkwNQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcHVibGljL1dlYkdyYXBoaWNzQ29udGV4dDNE Lmg6CisgICAgICAgIChXZWJLaXQ6OldlYkdyYXBoaWNzQ29udGV4dDNEOjpzZXRWaXNpYmlsaXR5 KToKKyAgICAgICAgKiBzcmMvV2ViVmlld0ltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJW aWV3SW1wbDo6c2V0VmlzaWJpbGl0eVN0YXRlKToKKyAgICAgICAgKiB0ZXN0cy9Nb2NrV2ViR3Jh cGhpY3NDb250ZXh0M0QuaDoKKyAgICAgICAgKFdlYktpdDo6TW9ja1dlYkdyYXBoaWNzQ29udGV4 dDNEOjpzZXRWaXNpYmlsaXR5KToKKwogMjAxMS0wOS0yNiAgVy4gSmFtZXMgTWFjTGVhbiAgPHdq bWFjbGVhbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBSZXZpc2Ugem9vbSBh bmltYXRvciBiYWNrZW5kIHRvIHVzZSBmdWxsIHRyYW5zZm9ybSBpbnN0ZWFkIG9mIGp1c3Qgc2Nh bGUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJHcmFwaGlj c0NvbnRleHQzRC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViR3JhcGhpY3ND b250ZXh0M0QuaAppbmRleCAwNjJkMjNhMGJhOGVhNTFlYzU4MDBjNzg5MGNmZTk4MmI1MzQwZjEz Li4zODZmMDU2Mzc1ZmFhZjdlYjI0Zjc4ZjkzZGMxMDZkM2MxYWE3YmY2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJHcmFwaGljc0NvbnRleHQzRC5oCisrKyBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkdyYXBoaWNzQ29udGV4dDNELmgKQEAg LTE0MCw2ICsxNDAsMTAgQEAgcHVibGljOgogICAgIC8vIFJlc2l6ZXMgdGhlIHJlZ2lvbiBpbnRv IHdoaWNoIHRoaXMgV2ViR3JhcGhpY3NDb250ZXh0M0QgaXMgZHJhd2luZy4KICAgICB2aXJ0dWFs IHZvaWQgcmVzaGFwZShpbnQgd2lkdGgsIGludCBoZWlnaHQpID0gMDsKIAorICAgIC8vIENoYW5n ZXMgdGhlIHZpc2liaWxpdHkgb2YgdGhlIHJlZ2lvbgorICAgIC8vIFRPRE8obW1vY255KTogdmly dHVhbCB2b2lkIHNldFZpc2liaWxpdHkoYm9vbCB2aXNpYmxlKSA9IDA7CisgICAgdmlydHVhbCB2 b2lkIHNldFZpc2liaWxpdHkoYm9vbCB2aXNpYmxlKSB7IH0KKwogICAgIC8vIFF1ZXJ5IHdoZXRo ZXIgaXQgaXMgYnVpbHQgb24gdG9wIG9mIGNvbXBsaWFudCBHTEVTMiBpbXBsZW1lbnRhdGlvbi4K ICAgICB2aXJ0dWFsIGJvb2wgaXNHTEVTMkNvbXBsaWFudCgpID0gMDsKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCmluZGV4IGZjMDZjNjU5Y2JmZTQxMjQ1OWUy NzBjYzg1NTlmZDI5MWU2NTg1YTkuLjY1NjY0ZjJiMjQ1YjhiZmZlOGM3ZGM2ZjQyYTUzOGJkMjgw YjIyZmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBs LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKQEAg LTI3OTgsNiArMjc5OCw3IEBAIHZvaWQgV2ViVmlld0ltcGw6OnNldFZpc2liaWxpdHlTdGF0ZShX ZWJQYWdlVmlzaWJpbGl0eVN0YXRlIHZpc2liaWxpdHlTdGF0ZSwKICAgICAgICAgaWYgKCF2aXNp YmxlKQogICAgICAgICAgICAgbV9ub25Db21wb3NpdGVkQ29udGVudEhvc3QtPnByb3RlY3RWaXNp YmxlVGlsZVRleHR1cmVzKCk7CiAgICAgICAgIG1fbGF5ZXJUcmVlSG9zdC0+c2V0VmlzaWJsZSh2 aXNpYmxlKTsKKyAgICAgICAgZ3JhcGhpY3NDb250ZXh0M0QoKS0+c2V0VmlzaWJpbGl0eSh2aXNp YmxlKTsKICAgICB9CiAjZW5kaWYKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vdGVzdHMvTW9ja1dlYkdyYXBoaWNzQ29udGV4dDNELmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3Rlc3RzL01vY2tXZWJHcmFwaGljc0NvbnRleHQzRC5oCmluZGV4IDFlNGJkMDA4ZTNhODgx M2E4NGYwMDkxMjUyMTRhOTNhNjczYjEwMzUuLmYwNjE2ODU0ODczYjU0Mzg1ZWU5NTU2OWQxYzdm OTZkZTQ2YWU4YzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvTW9j a1dlYkdyYXBoaWNzQ29udGV4dDNELmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0 cy9Nb2NrV2ViR3JhcGhpY3NDb250ZXh0M0QuaApAQCAtNDMsNiArNDMsOCBAQCBwdWJsaWM6CiAK ICAgICB2aXJ0dWFsIHZvaWQgcmVzaGFwZShpbnQgd2lkdGgsIGludCBoZWlnaHQpIHsgfQogCisg ICAgdmlydHVhbCB2b2lkIHNldFZpc2liaWxpdHkoYm9vbCB2aXNpYmxlKSB7IH0KKwogICAgIHZp cnR1YWwgYm9vbCBpc0dMRVMyQ29tcGxpYW50KCkgeyByZXR1cm4gZmFsc2U7IH0KIAogICAgIHZp cnR1YWwgYm9vbCByZWFkQmFja0ZyYW1lYnVmZmVyKHVuc2lnbmVkIGNoYXIqIHBpeGVscywgc2l6 ZV90IGJ1ZmZlclNpemUsIFdlYkdMSWQgZnJhbWVidWZmZXIsIGludCB3aWR0aCwgaW50IGhlaWdo dCkgeyByZXR1cm4gZmFsc2U7IH0K 111025 2011-10-14 10:07:30 -0700 2011-10-20 11:40:11 -0700 Patch bug-68905-20111014130438.patch text/plain 3014 mmocny U3VidmVyc2lvbiBSZXZpc2lvbjogOTc0NzMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg ZDNkZDJlNzViMGE5YzM4NmE3N2ZlZDAxMjc4YjM1ODkxMGU1NzBiNi4uYjQ5ZTEwZTE2ZjhiMzAz NDY4ZmQzMDNjMmUyOTAzODg0ZWY4ZDYwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxOSBAQAorMjAxMS0xMC0xNCAgTWljaGFsIE1vY255ICA8bW1vY255QGdvb2dsZS5j b20+CisKKyAgICAgICAgW2Nocm9taXVtXSBBZGQgYSBzZXRWaXNpYmlsaXR5IG1ldGhvZCB0byBX ZWJHcmFwaGljc0NvbnRleHQzRC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTY4OTA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkZWQgaG9va3MgZm9yIG5vdGlmeWluZyBXZWJHcmFwaGljc0NvbnRleHQz RCBvZiBzdXJmYWNlIHZpc2liaWxpdHkgY2hhbmdlcy4KKyAgICAgICAgVXNlZnVsIGZvciByZWxl YXNpbmcgdmFyaW91cyBncmFwaGljcyByZXNvdXJjZS4KKworICAgICAgICAqIHB1YmxpYy9XZWJH cmFwaGljc0NvbnRleHQzRC5oOgorICAgICAgICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAg ICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjpzZXRWaXNpYmlsaXR5U3RhdGUpOgorICAgICAgICAq IHRlc3RzL01vY2tXZWJHcmFwaGljc0NvbnRleHQzRC5oOgorICAgICAgICAoV2ViS2l0OjpNb2Nr V2ViR3JhcGhpY3NDb250ZXh0M0Q6OnNldFZpc2liaWxpdHkpOgorCiAyMDExLTEwLTEzICBBcmtv IFNhaGEgIDxhcmtvQG1vdG9yb2xhLmNvbT4KIAogICAgICAgICBNaWNyb2RhdGE6IEJhc2ljIGlt cGxlbWVudGF0aW9uIG9mIGRvY3VtZW50LmdldEl0ZW1zKCkgbWV0aG9kLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViR3JhcGhpY3NDb250ZXh0M0QuaCBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkdyYXBoaWNzQ29udGV4dDNELmgKaW5kZXgg MDYyZDIzYTBiYThlYTUxZWM1ODAwYzc4OTBjZmU5ODJiNTM0MGYxMy4uOWQ3N2U4NDQzMzRjMzZj MTAyNDYxZDlkOWM3OGJlNDk5YzZhYTAwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9wdWJsaWMvV2ViR3JhcGhpY3NDb250ZXh0M0QuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJHcmFwaGljc0NvbnRleHQzRC5oCkBAIC0xNDAsNiArMTQwLDkgQEAg cHVibGljOgogICAgIC8vIFJlc2l6ZXMgdGhlIHJlZ2lvbiBpbnRvIHdoaWNoIHRoaXMgV2ViR3Jh cGhpY3NDb250ZXh0M0QgaXMgZHJhd2luZy4KICAgICB2aXJ0dWFsIHZvaWQgcmVzaGFwZShpbnQg d2lkdGgsIGludCBoZWlnaHQpID0gMDsKIAorICAgIC8vIENoYW5nZXMgdGhlIHZpc2liaWxpdHkg b2YgdGhlIHJlZ2lvbgorICAgIHZpcnR1YWwgdm9pZCBzZXRWaXNpYmlsaXR5KGJvb2wgdmlzaWJs ZSkgPSAwOworCiAgICAgLy8gUXVlcnkgd2hldGhlciBpdCBpcyBidWlsdCBvbiB0b3Agb2YgY29t cGxpYW50IEdMRVMyIGltcGxlbWVudGF0aW9uLgogICAgIHZpcnR1YWwgYm9vbCBpc0dMRVMyQ29t cGxpYW50KCkgPSAwOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJWaWV3SW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5j cHAKaW5kZXggNzIwMTkwN2YwOWM1MTk3ZmVkNzU5Mjk5N2FkYjQzZjg1ZGQxZTNkYi4uZTk5YmI5 YTExM2IyZmVhMGJhNTE4ZTAyY2JhOGE3MDc0YTcxMmY1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcApAQCAtMjc5OCw2ICsyNzk4LDcgQEAgdm9pZCBXZWJW aWV3SW1wbDo6c2V0VmlzaWJpbGl0eVN0YXRlKFdlYlBhZ2VWaXNpYmlsaXR5U3RhdGUgdmlzaWJp bGl0eVN0YXRlLAogICAgICAgICBpZiAoIXZpc2libGUpCiAgICAgICAgICAgICBtX25vbkNvbXBv c2l0ZWRDb250ZW50SG9zdC0+cHJvdGVjdFZpc2libGVUaWxlVGV4dHVyZXMoKTsKICAgICAgICAg bV9sYXllclRyZWVIb3N0LT5zZXRWaXNpYmxlKHZpc2libGUpOworICAgICAgICBncmFwaGljc0Nv bnRleHQzRCgpLT5zZXRWaXNpYmlsaXR5KHZpc2libGUpOwogICAgIH0KICNlbmRpZgogfQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9Nb2NrV2ViR3JhcGhpY3NDb250 ZXh0M0QuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvTW9ja1dlYkdyYXBoaWNzQ29u dGV4dDNELmgKaW5kZXggMWU0YmQwMDhlM2E4ODEzYTg0ZjAwOTEyNTIxNGE5M2E2NzNiMTAzNS4u ZjA2MTY4NTQ4NzNiNTQzODVlZTk1NTY5ZDFjN2Y5NmRlNDZhZThjNSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9Nb2NrV2ViR3JhcGhpY3NDb250ZXh0M0QuaAorKysg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL01vY2tXZWJHcmFwaGljc0NvbnRleHQzRC5o CkBAIC00Myw2ICs0Myw4IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgdm9pZCByZXNoYXBlKGlu dCB3aWR0aCwgaW50IGhlaWdodCkgeyB9CiAKKyAgICB2aXJ0dWFsIHZvaWQgc2V0VmlzaWJpbGl0 eShib29sIHZpc2libGUpIHsgfQorCiAgICAgdmlydHVhbCBib29sIGlzR0xFUzJDb21wbGlhbnQo KSB7IHJldHVybiBmYWxzZTsgfQogCiAgICAgdmlydHVhbCBib29sIHJlYWRCYWNrRnJhbWVidWZm ZXIodW5zaWduZWQgY2hhciogcGl4ZWxzLCBzaXplX3QgYnVmZmVyU2l6ZSwgV2ViR0xJZCBmcmFt ZWJ1ZmZlciwgaW50IHdpZHRoLCBpbnQgaGVpZ2h0KSB7IHJldHVybiBmYWxzZTsgfQo= 111812 2011-10-20 11:40:17 -0700 2011-10-20 16:22:19 -0700 Patch bug-68905-20111020144015.patch text/plain 3439 mmocny U3VidmVyc2lvbiBSZXZpc2lvbjogOTgwMDUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg ZTQ2NWFkNDZmN2ZmZGZkOWEyMzE3YTY1NTcxZmUyOGI4ZmU3NTk2NC4uZWQwZTdiYzAxNTYyMDg1 MjUyZDVmNWJkMjhiZTZiZmZhNjk2ZjM5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwyMCBAQAorMjAxMS0xMC0yMCAgTWljaGFsIE1vY255ICA8bW1vY255QGdvb2dsZS5j b20+CisKKyAgICAgICAgW2Nocm9taXVtXSBBZGQgYSBzZXRWaXNpYmlsaXR5IG1ldGhvZCB0byBX ZWJHcmFwaGljc0NvbnRleHQzRC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTY4OTA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkZWQgaG9va3MgZm9yIG5vdGlmeWluZyBXZWJHcmFwaGljc0NvbnRleHQz RCBvZiBzdXJmYWNlIHZpc2liaWxpdHkgY2hhbmdlcy4KKyAgICAgICAgVXNlZnVsIGZvciByZWxl YXNpbmcgdmFyaW91cyBncmFwaGljcyByZXNvdXJjZS4KKworICAgICAgICAqIERFUFM6CisgICAg ICAgICogcHVibGljL1dlYkdyYXBoaWNzQ29udGV4dDNELmg6CisgICAgICAgICogc3JjL1dlYlZp ZXdJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OnNldFZpc2liaWxpdHlT dGF0ZSk6CisgICAgICAgICogdGVzdHMvTW9ja1dlYkdyYXBoaWNzQ29udGV4dDNELmg6CisgICAg ICAgIChXZWJLaXQ6Ok1vY2tXZWJHcmFwaGljc0NvbnRleHQzRDo6c2V0VmlzaWJpbGl0eSk6CisK IDIwMTEtMTAtMjAgIEhhbyBaaGVuZyAgPHpoZW5naGFvQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBbQ2hyb21pdW1dIFJlZHVjZSBkZXBlbmRlbmNpZXMgb2YgSW1hZ2VEaWZmIHRvIGNvbXBpbGUg aXQgZm9yIEFuZHJvaWQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0RFUFMg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0RFUFMKaW5kZXggOWVjMGNjMDUxZDU5Nzk4Y2ExYzAz YWYyMWU3ZGI4NDMxNGQ5NGVmYS4uYjZkYmUxNWYyMTc5ZDU3OGI4ZDU1OTQxZDY5ZTMzNWIzZTEy ZDU4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9ERVBTCisrKyBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vREVQUwpAQCAtMzIsNyArMzIsNyBAQAogCiB2YXJzID0gewogICAn Y2hyb21pdW1fc3ZuJzogJ2h0dHA6Ly9zcmMuY2hyb21pdW0ub3JnL3N2bi90cnVuay9zcmMnLAot ICAnY2hyb21pdW1fcmV2JzogJzEwNTk3MCcKKyAgJ2Nocm9taXVtX3Jldic6ICcxMDYzNDInCiB9 CiAKIGRlcHMgPSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJHcmFwaGljc0NvbnRleHQzRC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2Vi R3JhcGhpY3NDb250ZXh0M0QuaAppbmRleCA3ZWQ4MGMzZTMyMmNkMGM3YTA5Mjk0ZTZhNDM4MGY1 YzViMWI2NDVhLi4zYTIzM2YzY2I3ZDMyMmNiODEyYzg4YjI1N2IwZDJmZWY4NDhhNWI4IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJHcmFwaGljc0NvbnRleHQz RC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkdyYXBoaWNzQ29udGV4 dDNELmgKQEAgLTE0MCw2ICsxNDAsOSBAQCBwdWJsaWM6CiAgICAgLy8gUmVzaXplcyB0aGUgcmVn aW9uIGludG8gd2hpY2ggdGhpcyBXZWJHcmFwaGljc0NvbnRleHQzRCBpcyBkcmF3aW5nLgogICAg IHZpcnR1YWwgdm9pZCByZXNoYXBlKGludCB3aWR0aCwgaW50IGhlaWdodCkgPSAwOwogCisgICAg Ly8gQ2hhbmdlcyB0aGUgdmlzaWJpbGl0eSBvZiB0aGUgcmVnaW9uCisgICAgdmlydHVhbCB2b2lk IHNldFZpc2liaWxpdHkoYm9vbCB2aXNpYmxlKSA9IDA7CisKICAgICAvLyBRdWVyeSB3aGV0aGVy IGl0IGlzIGJ1aWx0IG9uIHRvcCBvZiBjb21wbGlhbnQgR0xFUzIgaW1wbGVtZW50YXRpb24uCiAg ICAgdmlydHVhbCBib29sIGlzR0xFUzJDb21wbGlhbnQoKSA9IDA7CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAppbmRleCBmMzc0ZWRjYmI2YWE5MmQwYTdjYjMw ZWI0Zjk2MTZkOGU1MmMwNzZjLi4xNWM4ZTI0NWE2NDMzZTBiMzRiMzM2YjIzZGFjYTAwNThkY2Zk NzcwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5j cHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCkBAIC0y ODExLDYgKzI4MTEsNyBAQCB2b2lkIFdlYlZpZXdJbXBsOjpzZXRWaXNpYmlsaXR5U3RhdGUoV2Vi UGFnZVZpc2liaWxpdHlTdGF0ZSB2aXNpYmlsaXR5U3RhdGUsCiAgICAgICAgIGlmICghdmlzaWJs ZSkKICAgICAgICAgICAgIG1fbm9uQ29tcG9zaXRlZENvbnRlbnRIb3N0LT5wcm90ZWN0VmlzaWJs ZVRpbGVUZXh0dXJlcygpOwogICAgICAgICBtX2xheWVyVHJlZUhvc3QtPnNldFZpc2libGUodmlz aWJsZSk7CisgICAgICAgIGdyYXBoaWNzQ29udGV4dDNEKCktPnNldFZpc2liaWxpdHkodmlzaWJs ZSk7CiAgICAgfQogI2VuZGlmCiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3Rlc3RzL01vY2tXZWJHcmFwaGljc0NvbnRleHQzRC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS90ZXN0cy9Nb2NrV2ViR3JhcGhpY3NDb250ZXh0M0QuaAppbmRleCAxZTRiZDAwOGUzYTg4MTNh ODRmMDA5MTI1MjE0YTkzYTY3M2IxMDM1Li5mMDYxNjg1NDg3M2I1NDM4NWVlOTU1NjlkMWM3Zjk2 ZGU0NmFlOGM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL01vY2tX ZWJHcmFwaGljc0NvbnRleHQzRC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMv TW9ja1dlYkdyYXBoaWNzQ29udGV4dDNELmgKQEAgLTQzLDYgKzQzLDggQEAgcHVibGljOgogCiAg ICAgdmlydHVhbCB2b2lkIHJlc2hhcGUoaW50IHdpZHRoLCBpbnQgaGVpZ2h0KSB7IH0KIAorICAg IHZpcnR1YWwgdm9pZCBzZXRWaXNpYmlsaXR5KGJvb2wgdmlzaWJsZSkgeyB9CisKICAgICB2aXJ0 dWFsIGJvb2wgaXNHTEVTMkNvbXBsaWFudCgpIHsgcmV0dXJuIGZhbHNlOyB9CiAKICAgICB2aXJ0 dWFsIGJvb2wgcmVhZEJhY2tGcmFtZWJ1ZmZlcih1bnNpZ25lZCBjaGFyKiBwaXhlbHMsIHNpemVf dCBidWZmZXJTaXplLCBXZWJHTElkIGZyYW1lYnVmZmVyLCBpbnQgd2lkdGgsIGludCBoZWlnaHQp IHsgcmV0dXJuIGZhbHNlOyB9Cg==