68890 2011-09-27 05:04:14 -0700 [v8] Code calling the typed array optimization script is fragile, depends on typed array hierarchy. 2012-12-05 01:23:23 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 68237 75532 76040 104099 1 ulan ulan abarth kbr webkit.review.bot oldest_to_newest 473854 0 ulan 2011-09-27 05:04:14 -0700 See https://bugs.webkit.org/show_bug.cgi?id=68237#c2 . 474010 1 108860 ulan 2011-09-27 09:52:30 -0700 Created attachment 108860 Install the flag, which indicates whether or not the optimization script was executed, on the global object. 474065 2 108860 kbr 2011-09-27 10:47:32 -0700 Comment on attachment 108860 Install the flag, which indicates whether or not the optimization script was executed, on the global object. Looks good. Thanks for cleaning this up. r=me 474101 3 108860 webkit.review.bot 2011-09-27 11:18:06 -0700 Comment on attachment 108860 Install the flag, which indicates whether or not the optimization script was executed, on the global object. Clearing flags on attachment: 108860 Committed r96135: <http://trac.webkit.org/changeset/96135> 474102 4 webkit.review.bot 2011-09-27 11:18:10 -0700 All reviewed patches have been landed. Closing bug. 783349 5 108860 abarth 2012-12-04 21:06:42 -0800 Comment on attachment 108860 Install the flag, which indicates whether or not the optimization script was executed, on the global object. View in context: https://bugs.webkit.org/attachment.cgi?id=108860&action=review > Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp:36 > -const char fastSetFlagName[] = "webgl::FastSetFlag"; > +// The random suffix helps to avoid name collision. > +const char fastSetFlagName[] = "TypedArray::FastSet::8NkZVq"; There's no reason to use goofy names like this. The http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.h class helps us avoid naming collisions. 783508 6 ulan 2012-12-05 01:23:23 -0800 Thanks, Adam! I file a bug https://bugs.webkit.org/show_bug.cgi?id=104099 and will upload a fix. 108860 2011-09-27 09:52:30 -0700 2012-12-04 21:06:42 -0800 Install the flag, which indicates whether or not the optimization script was executed, on the global object. b68890 text/plain 2748 ulan SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDk2MTIx KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDkt MjcgIFVsYW4gRGVnZW5iYWV2ICA8dWxhbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW3Y4XSBD b2RlIGNhbGxpbmcgdGhlIHR5cGVkIGFycmF5IG9wdGltaXphdGlvbiBzY3JpcHQgaXMgZnJhZ2ls ZSwgZGVwZW5kcyBvbiB0eXBlZCBhcnJheSBoaWVyYXJjaHkuCisKKyAgICAgICAgSW5zdGFsbCB0 aGUgZmxhZywgd2hpY2ggaW5kaWNhdGVzIHdoZXRoZXIgb3Igbm90IHRoZSBvcHRpbWl6YXRpb24K KyAgICAgICAgc2NyaXB0IHdhcyBleGVjdXRlZCwgb24gdGhlIGdsb2JhbCBvYmplY3QuCisKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4ODkwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhBcnJheUJ1ZmZlclZpZXdDdXN0b20uY3BwOgorCiAy MDExLTA5LTIzICBUb3IgQXJuZSBWZXN0YsO4ICA8dG9yLmFybmUudmVzdGJvQG5va2lhLmNvbT4K IAogICAgICAgICBbUXRdIEZpeCBidWlsZCBhZ2FpbnN0IFF0NSBhZnRlciByZWZhY3RvciBvZiB3 aWRnZXRzIG91dCBvZiBRdEdVaQpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3Vz dG9tL1Y4QXJyYXlCdWZmZXJWaWV3Q3VzdG9tLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhBcnJheUJ1ZmZlclZpZXdDdXN0b20uY3BwCShyZXZp c2lvbiA5NjEyMCkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEFycmF5 QnVmZmVyVmlld0N1c3RvbS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMyLDI1ICszMiwyNCBAQAog CiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLWNvbnN0IGNoYXIgZmFzdFNldEZsYWdOYW1lW10gPSAi d2ViZ2w6OkZhc3RTZXRGbGFnIjsKKy8vIFRoZSByYW5kb20gc3VmZml4IGhlbHBzIHRvIGF2b2lk IG5hbWUgY29sbGlzaW9uLgorY29uc3QgY2hhciBmYXN0U2V0RmxhZ05hbWVbXSA9ICJUeXBlZEFy cmF5OjpGYXN0U2V0Ojo4TmtaVnEiOwogCiBib29sIGZhc3RTZXRJbnN0YWxsZWQodjg6OkhhbmRs ZTx2ODo6T2JqZWN0PiBhcnJheSkKIHsKLSAgICAvLyBVc2UgYSBoaWRkZW4gZmxhZyBpbiB0aGUg Y29tbW9uIHByb3RvdHlwZSAoQXJyYXlCdWZmZXJWaWV3KSBvZiBhbGwgdHlwZWQKLSAgICAvLyBh cnJheXMgYXMgYW4gaW5kaWNhdG9yIG9mIHdoZXRoZXIgdGhlIGZhc3QgJ3NldCcgaXMgaW5zdGFs bGVkIG9yIG5vdC4KLSAgICB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IHByb3RvdHlwZSA9IGFycmF5 LT5HZXRQcm90b3R5cGUoKS5Bczx2ODo6T2JqZWN0PigpOwotICAgIHY4OjpIYW5kbGU8djg6Ok9i amVjdD4gYXJyYXlCdWZmZXJWaWV3ID0gcHJvdG90eXBlLT5HZXRQcm90b3R5cGUoKS5Bczx2ODo6 T2JqZWN0PigpOworICAgIC8vIFVzZSBhIGhpZGRlbiBmbGFnIGluIHRoZSBnbG9iYWwgb2JqZWN0 IGFuIGluZGljYXRvciBvZiB3aGV0aGVyIHRoZSBmYXN0CisgICAgLy8gJ3NldCcgaXMgaW5zdGFs bGVkIG9yIG5vdC4KKyAgICB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IGdsb2JhbCA9IGFycmF5LT5D cmVhdGlvbkNvbnRleHQoKS0+R2xvYmFsKCk7CiAgICAgdjg6OkhhbmRsZTx2ODo6U3RyaW5nPiBr ZXkgPSB2ODo6U3RyaW5nOjpOZXcoZmFzdFNldEZsYWdOYW1lKTsKLSAgICB2ODo6SGFuZGxlPHY4 OjpWYWx1ZT4gZmFzdFNldEZsYWcgPSBhcnJheUJ1ZmZlclZpZXctPkdldEhpZGRlblZhbHVlKGtl eSk7CisgICAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IGZhc3RTZXRGbGFnID0gZ2xvYmFsLT5HZXRI aWRkZW5WYWx1ZShrZXkpOwogICAgIHJldHVybiAhZmFzdFNldEZsYWcuSXNFbXB0eSgpOwogfQog CiB2b2lkIGluc3RhbGxGYXN0U2V0KHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gYXJyYXkpCiB7Ci0g ICAgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBwcm90b3R5cGUgPSBhcnJheS0+R2V0UHJvdG90eXBl KCkuQXM8djg6Ok9iamVjdD4oKTsKLSAgICB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IGFycmF5QnVm ZmVyVmlldyA9IHByb3RvdHlwZS0+R2V0UHJvdG90eXBlKCkuQXM8djg6Ok9iamVjdD4oKTsKKyAg ICB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IGdsb2JhbCA9IGFycmF5LT5DcmVhdGlvbkNvbnRleHQo KS0+R2xvYmFsKCk7CiAgICAgdjg6OkhhbmRsZTx2ODo6U3RyaW5nPiBrZXkgPSB2ODo6U3RyaW5n OjpOZXcoZmFzdFNldEZsYWdOYW1lKTsKLSAgICBhcnJheUJ1ZmZlclZpZXctPlNldEhpZGRlblZh bHVlKGtleSwgdjg6OkJvb2xlYW46Ok5ldyh0cnVlKSk7CisgICAgZ2xvYmFsLT5TZXRIaWRkZW5W YWx1ZShrZXksIHY4OjpCb29sZWFuOjpOZXcodHJ1ZSkpOwogCiAgICAgU3RyaW5nIHNvdXJjZShy ZWludGVycHJldF9jYXN0PGNvbnN0IGNoYXIqPihWOEFycmF5QnVmZmVyVmlld0N1c3RvbVNjcmlw dF9qcyksCiAgICAgICAgICAgICAgICAgICBzaXplb2YoVjhBcnJheUJ1ZmZlclZpZXdDdXN0b21T Y3JpcHRfanMpKTsK