68876 2011-09-27 00:38:28 -0700 Input element created at later stage(may be after page load) should not be auto focused. 2012-03-30 12:38:08 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED INVALID P2 Normal --- 0 rakeshchaitan webkit-unassigned dglazkov ojan tkent webkit.review.bot oldest_to_newest 473749 0 108799 rakeshchaitan 2011-09-27 00:38:28 -0700 Created attachment 108799 Test case Steps to reproduce: 1. Run attached html file. 2. Click on the "click me" button. 3. The new input element should get created on button click. Expected: The new input element should not be focused. Current behavior: The new input element is being focused. Others: Firefox does not focus the newly created element. 473835 1 rakeshchaitan 2011-09-27 03:55:27 -0700 I think Document::setIgnoreAutofocus needs to be called from some place, may be just before firing 'onload' event as we are sure if there was any autofocus node, then it might have been focused and we don't want any future elements with autofocus to be focused. Please let me know your thoughts on this. Thanks. 474405 2 tkent 2011-09-27 17:52:36 -0700 I haven't seen requests to add other autofocus-canceling events. So, I don't think we need to do so. If other browsers cancels autofocus by other events, it's ok to follow them in WebKit. 474706 3 109016 rakeshchaitan 2011-09-28 06:22:55 -0700 Created attachment 109016 Proposed patch 474709 4 rakeshchaitan 2011-09-28 06:27:12 -0700 (In reply to comment #2) > I haven't seen requests to add other autofocus-canceling events. So, I don't think we need to do so. > > If other browsers cancels autofocus by other events, it's ok to follow them in WebKit. Yes, firefox does cancel the autofocus and it fulfills point 8 of http://www.whatwg.org/specs/web-apps/current-work/multipage/association-of-controls-and-forms.html#attr-fe-autofocus. 474710 5 rakeshchaitan 2011-09-28 06:30:35 -0700 (In reply to comment #3) > Created an attachment (id=109016) [details] > Proposed patch This patch fails two tests: 1. fast/forms/autofocus-opera-004.html 2. fast/forms/autofocus-opera-005.html which are expected with this change as autofocus is ignored after page load complete. 474721 6 109016 webkit.review.bot 2011-09-28 06:48:39 -0700 Comment on attachment 109016 Proposed patch Attachment 109016 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9878656 New failing tests: fast/forms/autofocus-opera-004.html fast/forms/autofocus-opera-005.html 476661 7 109016 tkent 2011-10-02 03:45:03 -0700 Comment on attachment 109016 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=109016&action=review r- because the patch wil break existing tests. We have to change the patch behavior or change the existing tests in this case. > Source/WebCore/dom/Document.cpp:2165 > + // Ignore any future Autofocus request from now > + setIgnoreAutofocus(); > + What are the behaviors of IE10, Firefox, and Opera on this? 476827 8 109447 rakeshchaitan 2011-10-03 00:20:36 -0700 Created attachment 109447 Updated patch 476829 9 rakeshchaitan 2011-10-03 00:25:25 -0700 (In reply to comment #7) > (From update of attachment 109016 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=109016&action=review > > r- because the patch wil break existing tests. > We have to change the patch behavior or change the existing tests in this case. > Changed the existing tests. > > Source/WebCore/dom/Document.cpp:2165 > > + // Ignore any future Autofocus request from now > > + setIgnoreAutofocus(); > > + > > What are the behaviors of IE10, Firefox, and Opera on this? Firefox and Opera does not auto focus elements which are added at later stages, could not test on IE10(don't have an windows 7 machine). 476872 10 tkent 2011-10-03 03:56:52 -0700 (In reply to comment #9) > (In reply to comment #7) > > (From update of attachment 109016 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=109016&action=review > > > > r- because the patch wil break existing tests. > > We have to change the patch behavior or change the existing tests in this case. > > > > Changed the existing tests. > > > > Source/WebCore/dom/Document.cpp:2165 > > > + // Ignore any future Autofocus request from now > > > + setIgnoreAutofocus(); > > > + > > > > What are the behaviors of IE10, Firefox, and Opera on this? > > Firefox and Opera does not auto focus elements which are added at later stages, > could not test on IE10(don't have an windows 7 machine). My investigation: Firefox 6 and 7 Mac: Failed with autofocus-opera-004, 005, and 006. Opera 11.51 Mac: Failed with autofocus-opera-008 IE10 on Windows 8: Failed with autofocus-opera-006 and 008. IMO, we should do nothing at this moment. Autofocusing on an element with autofocus attribute is what a web page author wants to do even after the page loading has been completed, and the standard allows it. 476934 11 rakeshchaitan 2011-10-03 06:08:22 -0700 (In reply to comment #10) > > My investigation: > Firefox 6 and 7 Mac: Failed with autofocus-opera-004, 005, and 006. > Opera 11.51 Mac: Failed with autofocus-opera-008 > IE10 on Windows 8: Failed with autofocus-opera-006 and 008. > > IMO, we should do nothing at this moment. Autofocusing on an element with autofocus attribute is what a web page author wants to do even after the page loading has been completed, and the standard allows it. True, but if focus is already set at some other node then I think it would be better to ignore the 'autofocus', that is what Opera or Firefox does if you run the attached test case (focus is on "Click me" button and not on the newly created input element). What I observed in Opera and firefox is when I click on button, autofocus is not honored, also better test I tried : function onLoad() { setTimeout(addInputElement, 2000); } and I start typing something in existing input element, the focus does not move to newly created element where as in webkit it moves to new element. 524170 12 109447 eric 2011-12-19 14:00:43 -0800 Comment on attachment 109447 Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=109447&action=review > LayoutTests/fast/forms/autofocus-add-autofocus-element-expected.txt:5 > +This input element should not have active state: > + > + > +PASS document.activeElement is document.getElementById("input") These lines seem incongruous. > LayoutTests/fast/forms/autofocus-opera-004-expected.txt:1 > -The form control should have a green background: > +The form control should have a red background: Red is normally an indication of failure in tests... 592402 13 ojan 2012-03-30 12:35:47 -0700 Relevant Gecko bug: https://bugzilla.mozilla.org/show_bug.cgi?id=662496. I don't see any reason to make autofocus conditional on page load. That's a totally arbitrary time. Might as well pick a fixed number of seconds from starting load. Item 8 of http://www.whatwg.org/specs/web-apps/current-work/multipage/association-of-controls-and-forms.html#attr-fe-autofocus says nothing about page load. It says that if the *user* indicated in some way that they want focus elsewhere the UA can ignore this attribute if they want to. I'm going to close this bug. A new bug for ignoring autofocus if the user has started typing in an input might be worth considering. But I think we should only do that if this is a problem web pages are hitting in practice, which seems unlikely to me. 592407 14 ojan 2012-03-30 12:38:08 -0700 In fact, the other bug is already filed: https://bugs.webkit.org/show_bug.cgi?id=31032 108799 2011-09-27 00:38:28 -0700 2011-09-27 00:38:28 -0700 Test case autofocus-js-created-element.html text/html 651 rakeshchaitan PGh0bWw+CjxoZWFkPgo8c2NyaXB0IGxhbmd1YWdlPSJKYXZhU2NyaXB0IiB0eXBlPSJ0ZXh0L2ph dmFzY3JpcHQiPgpmdW5jdGlvbiBhZGRJbnB1dEVsZW1lbnQoKQp7CiAgICB2YXIgcGFyYSA9IGRv Y3VtZW50LmNyZWF0ZUVsZW1lbnQoIlAiKTsKICAgIHZhciB0ZXh0ID0gZG9jdW1lbnQuY3JlYXRl VGV4dE5vZGUoIlRoaXMgaW5wdXQgZWxlbWVudCBzaG91bGQgbm90IGhhdmUgYWN0aXZlIHN0YXRl OiIpOwogICAgcGFyYS5hcHBlbmRDaGlsZCh0ZXh0KTsKICAgIGRvY3VtZW50LmJvZHkuYXBwZW5k Q2hpbGQocGFyYSk7CgogICAgdmFyIHYgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJpbnB1dCIp OwogICAgdi50eXBlID0gInBhc3N3b3JkIjsKICAgIHYuaWQgPSAibmV3SW5wdXQiOwogICAgdi5z ZXRBdHRyaWJ1dGUoImF1dG9mb2N1cyIsICJhdXRvZm9jdXMiKTsKICAgIGRvY3VtZW50LmJvZHku YXBwZW5kQ2hpbGQodik7Cn0KPC9zY3JpcHQ+CjwvaGVhZD4KPGJvZHk+CjxpbnB1dCBpZD0iaW5w dXQxIiB0eXBlPSJ0ZXh0IiBhdXRvZm9jdXMgLz4KPGJyLz4KPGlucHV0IGlkPSJidXR0b24iIHR5 cGU9ImJ1dHRvbiIgdmFsdWU9ImNsaWNrIG1lIiBvbmNsaWNrPSJhZGRJbnB1dEVsZW1lbnQoKSI+ Cjxici8+IAo8L2JvZHk+CjwvaHRtbD4K 109016 2011-09-28 06:22:55 -0700 2011-10-03 00:20:12 -0700 Proposed patch bug-68876-20110928185013.patch text/plain 3781 rakeshchaitan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk2MjE3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDktMjggIFJha2VzaCBL TiAgPHJha2VzaC5rbkBtb3Rvcm9sYS5jb20+CisKKyAgICAgICAgSW5wdXQgZWxlbWVudCBjcmVh dGVkIGF0IGxhdGVyIHN0YWdlKG1heSBiZSBhZnRlciBwYWdlIGxvYWQpIHNob3VsZCBub3QgYmUg YXV0byBmb2N1c2VkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9Njg4NzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUZXN0OiBmYXN0L2Zvcm1zL2F1dG9mb2N1cy1hZGQtYXV0b2ZvY3VzLWVsZW1lbnQuaHRt bAorCisgICAgICAgIElnbm9yaW5nIEF1dG9mb2N1cyBhZnRlciBwYWdlIGxvYWQuCisKKyAgICAg ICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OmltcGxp Y2l0Q2xvc2UpOgorCiAyMDExLTA5LTI4ICBWc2V2b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJlZmFjdG9yIHNlYXJjaGluZyBpbiBp bnNwZWN0b3IsIGFkZCB0ZXN0IChmaXhlZCBub24gcmVnZXggc2VhcmNoKS4KSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv ZG9tL0RvY3VtZW50LmNwcAkocmV2aXNpb24gOTYwOTYpCisrKyBTb3VyY2UvV2ViQ29yZS9kb20v RG9jdW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMTYwLDYgKzIxNjAsOSBAQCB2b2lkIERv Y3VtZW50OjppbXBsaWNpdENsb3NlKCkKICAgICBpZiAoIWRvbG9hZCkKICAgICAgICAgcmV0dXJu OwogCisgICAgLy8gSWdub3JlIGFueSBmdXR1cmUgQXV0b2ZvY3VzIHJlcXVlc3QgZnJvbSBub3cK KyAgICBzZXRJZ25vcmVBdXRvZm9jdXMoKTsKKwogICAgIG1fcHJvY2Vzc2luZ0xvYWRFdmVudCA9 IHRydWU7CiAKICAgICBTY3JpcHRhYmxlRG9jdW1lbnRQYXJzZXIqIHBhcnNlciA9IHNjcmlwdGFi bGVEb2N1bWVudFBhcnNlcigpOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gOTYyMTcpCisrKyBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wOS0y OCAgUmFrZXNoIEtOICA8cmFrZXNoLmtuQG1vdG9yb2xhLmNvbT4KKworICAgICAgICBJbnB1dCBl bGVtZW50IGNyZWF0ZWQgYXQgbGF0ZXIgc3RhZ2UobWF5IGJlIGFmdGVyIHBhZ2UgbG9hZCkgc2hv dWxkIG5vdCBiZSBhdXRvIGZvY3VzZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD02ODg3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIElnbm9yaW5nIEF1dG9mb2N1cyBhZnRlciBwYWdlIGxvYWQuCisKKyAg ICAgICAgKiBmYXN0L2Zvcm1zL2F1dG9mb2N1cy1hZGQtYXV0b2ZvY3VzLWVsZW1lbnQtZXhwZWN0 ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Zvcm1zL2F1dG9mb2N1cy1hZGQtYXV0b2Zv Y3VzLWVsZW1lbnQuaHRtbDogQWRkZWQuCisKIDIwMTEtMDktMjggIENzYWJhIE9zenRyb2dvbsOh YyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBbUXRdIFVucmV2aWV3ZWQgZ2FyZGVuaW5n LCB1cGRhdGUgZXhwZWN0ZWQgZmlsZSBhZnRlciByOTU3NDUuCkluZGV4OiBMYXlvdXRUZXN0cy9m YXN0L2Zvcm1zL2F1dG9mb2N1cy1hZGQtYXV0b2ZvY3VzLWVsZW1lbnQtZXhwZWN0ZWQudHh0Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvYXV0b2ZvY3VzLWFkZC1hdXRvZm9j dXMtZWxlbWVudC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0 L2Zvcm1zL2F1dG9mb2N1cy1hZGQtYXV0b2ZvY3VzLWVsZW1lbnQtZXhwZWN0ZWQudHh0CShyZXZp c2lvbiAwKQpAQCAtMCwwICsxLDkgQEAKKyAKK1RoaXMgaW5wdXQgZWxlbWVudCBzaG91bGQgbm90 IGhhdmUgYWN0aXZlIHN0YXRlOiAKKworCitQQVNTIGRvY3VtZW50LmFjdGl2ZUVsZW1lbnQgaXMg ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImlucHV0IikKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2Vk IGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1z L2F1dG9mb2N1cy1hZGQtYXV0b2ZvY3VzLWVsZW1lbnQuaHRtbAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9mYXN0L2Zvcm1zL2F1dG9mb2N1cy1hZGQtYXV0b2ZvY3VzLWVsZW1lbnQuaHRtbAko cmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvYXV0b2ZvY3VzLWFkZC1hdXRv Zm9jdXMtZWxlbWVudC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDQwIEBACis8aHRtbD4K KzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9z Y3JpcHQ+Cis8c2NyaXB0IGxhbmd1YWdlPSJKYXZhU2NyaXB0IiB0eXBlPSJ0ZXh0L2phdmFzY3Jp cHQiPgord2luZG93LmpzVGVzdElzQXN5bmMgPSB0cnVlOworCitmdW5jdGlvbiBwYWdlTG9hZCgp Cit7CisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImlucHV0IikuZm9jdXMoKTsKKyAgICBz ZXRUaW1lb3V0KGFkZElucHV0RWxlbWVudCwgMTAwKTsKK30KKworZnVuY3Rpb24gYWRkSW5wdXRF bGVtZW50KCkKK3sKKyAgICB2YXIgdiA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImlucHV0Iik7 CisgICAgdi50eXBlID0gInBhc3N3b3JkIjsKKyAgICB2LmlkID0gIm5ld0lucHV0IjsKKyAgICB2 LnNldEF0dHJpYnV0ZSgiYXV0b2ZvY3VzIiwgImF1dG9mb2N1cyIpOworICAgIGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCJwYXJhIikuYXBwZW5kQ2hpbGQodik7CisgICAgc2V0VGltZW91dChjaGVj aywgMCk7Cit9CisKK2Z1bmN0aW9uIGNoZWNrKCkKK3sKKyAgICBzaG91bGRCZSgnZG9jdW1lbnQu YWN0aXZlRWxlbWVudCcsICdkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiaW5wdXQiKScpOworICAg IGZpbmlzaEpTVGVzdCgpOworfQorc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKKzwvc2NyaXB0 PgorPC9oZWFkPgorPGJvZHkgb25sb2FkPSJwYWdlTG9hZCgpIj4KKzxpbnB1dCBpZD0iaW5wdXQi IHR5cGU9InRleHQiLz4KKzxici8+Cis8cCBpZD0icGFyYSI+VGhpcyBpbnB1dCBlbGVtZW50IHNo b3VsZCBub3QgaGF2ZSBhY3RpdmUgc3RhdGU6Cis8cHJlIGlkPSJjb25zb2xlIj4KKworPC9wcmU+ Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+ Cis8L2JvZHk+Cis8L2h0bWw+Cg== 109447 2011-10-03 00:20:36 -0700 2011-12-19 14:00:42 -0800 Updated patch bug-68876-20111003124736.patch text/plain 6479 rakeshchaitan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk2NDg0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMTAtMDMgIFJha2VzaCBL TiAgPHJha2VzaC5rbkBtb3Rvcm9sYS5jb20+CisKKyAgICAgICAgSW5wdXQgZWxlbWVudCBjcmVh dGVkIGF0IGxhdGVyIHN0YWdlKG1heSBiZSBhZnRlciBwYWdlIGxvYWQpIHNob3VsZCBub3QgYmUg YXV0byBmb2N1c2VkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9Njg4NzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUZXN0OiBmYXN0L2Zvcm1zL2F1dG9mb2N1cy1hZGQtYXV0b2ZvY3VzLWVsZW1lbnQuaHRt bAorCisgICAgICAgIElnbm9yaW5nIEF1dG9mb2N1cyBhZnRlciBwYWdlIGxvYWQuCisKKyAgICAg ICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OmltcGxp Y2l0Q2xvc2UpOgorCiAyMDExLTEwLTAyICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9y Zz4KIAogICAgICAgICBtZXRob2QvZW5jdHlwZS9mb3JtTWV0aG9kL2Zvcm1FbmN0eXBlIHByb3Bl cnRpZXMgc2hvdWxkIGJlIGxpbWl0ZWQgdG8ga25vd24gdmFsdWVzLgpJbmRleDogU291cmNlL1dl YkNvcmUvZG9tL0RvY3VtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20v RG9jdW1lbnQuY3BwCShyZXZpc2lvbiA5NjA5NikKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1 bWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIxNjAsNiArMjE2MCw5IEBAIHZvaWQgRG9jdW1l bnQ6OmltcGxpY2l0Q2xvc2UoKQogICAgIGlmICghZG9sb2FkKQogICAgICAgICByZXR1cm47CiAK KyAgICAvLyBJZ25vcmUgYW55IGZ1dHVyZSBBdXRvZm9jdXMgcmVxdWVzdCBmcm9tIG5vdworICAg IHNldElnbm9yZUF1dG9mb2N1cygpOworCiAgICAgbV9wcm9jZXNzaW5nTG9hZEV2ZW50ID0gdHJ1 ZTsKIAogICAgIFNjcmlwdGFibGVEb2N1bWVudFBhcnNlciogcGFyc2VyID0gc2NyaXB0YWJsZURv Y3VtZW50UGFyc2VyKCk7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA5NjQ4NCkKKysrIExheW91dFRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDExLTEwLTAzICBS YWtlc2ggS04gIDxyYWtlc2gua25AbW90b3JvbGEuY29tPgorCisgICAgICAgIElucHV0IGVsZW1l bnQgY3JlYXRlZCBhdCBsYXRlciBzdGFnZShtYXkgYmUgYWZ0ZXIgcGFnZSBsb2FkKSBzaG91bGQg bm90IGJlIGF1dG8gZm9jdXNlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTY4ODc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL2F1dG9mb2N1cy1hZGQtYXV0b2ZvY3VzLWVsZW1lbnQt ZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Zvcm1zL2F1dG9mb2N1cy1hZGQt YXV0b2ZvY3VzLWVsZW1lbnQuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9mb3Jtcy9hdXRv Zm9jdXMtb3BlcmEtMDA0LWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2Zvcm1zL2F1dG9m b2N1cy1vcGVyYS0wMDQuaHRtbDoKKyAgICAgICAgKiBmYXN0L2Zvcm1zL2F1dG9mb2N1cy1vcGVy YS0wMDUtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3QvZm9ybXMvYXV0b2ZvY3VzLW9wZXJh LTAwNS5odG1sOgorCisgICAgICAgIElnbm9yaW5nIEF1dG9mb2N1cyBhZnRlciBwYWdlIGxvYWQu CisKIDIwMTEtMTAtMDIgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIG1ldGhvZC9lbmN0eXBlL2Zvcm1NZXRob2QvZm9ybUVuY3R5cGUgcHJvcGVydGllcyBzaG91 bGQgYmUgbGltaXRlZCB0byBrbm93biB2YWx1ZXMuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zv cm1zL2F1dG9mb2N1cy1hZGQtYXV0b2ZvY3VzLWVsZW1lbnQtZXhwZWN0ZWQudHh0Cj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvYXV0b2ZvY3VzLWFkZC1hdXRvZm9jdXMtZWxl bWVudC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1z L2F1dG9mb2N1cy1hZGQtYXV0b2ZvY3VzLWVsZW1lbnQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAw KQpAQCAtMCwwICsxLDkgQEAKKyAKK1RoaXMgaW5wdXQgZWxlbWVudCBzaG91bGQgbm90IGhhdmUg YWN0aXZlIHN0YXRlOiAKKworCitQQVNTIGRvY3VtZW50LmFjdGl2ZUVsZW1lbnQgaXMgZG9jdW1l bnQuZ2V0RWxlbWVudEJ5SWQoImlucHV0IikKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRy dWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2F1dG9m b2N1cy1hZGQtYXV0b2ZvY3VzLWVsZW1lbnQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9mYXN0L2Zvcm1zL2F1dG9mb2N1cy1hZGQtYXV0b2ZvY3VzLWVsZW1lbnQuaHRtbAkocmV2aXNp b24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvYXV0b2ZvY3VzLWFkZC1hdXRvZm9jdXMt ZWxlbWVudC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDQwIEBACis8aHRtbD4KKzxoZWFk PgorPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+ Cis8c2NyaXB0IGxhbmd1YWdlPSJKYXZhU2NyaXB0IiB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgor d2luZG93LmpzVGVzdElzQXN5bmMgPSB0cnVlOworCitmdW5jdGlvbiBwYWdlTG9hZCgpCit7Cisg ICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImlucHV0IikuZm9jdXMoKTsKKyAgICBzZXRUaW1l b3V0KGFkZElucHV0RWxlbWVudCwgMTAwKTsKK30KKworZnVuY3Rpb24gYWRkSW5wdXRFbGVtZW50 KCkKK3sKKyAgICB2YXIgdiA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImlucHV0Iik7CisgICAg di50eXBlID0gInBhc3N3b3JkIjsKKyAgICB2LmlkID0gIm5ld0lucHV0IjsKKyAgICB2LnNldEF0 dHJpYnV0ZSgiYXV0b2ZvY3VzIiwgImF1dG9mb2N1cyIpOworICAgIGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCJwYXJhIikuYXBwZW5kQ2hpbGQodik7CisgICAgc2V0VGltZW91dChjaGVjaywgMCk7 Cit9CisKK2Z1bmN0aW9uIGNoZWNrKCkKK3sKKyAgICBzaG91bGRCZSgnZG9jdW1lbnQuYWN0aXZl RWxlbWVudCcsICdkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiaW5wdXQiKScpOworICAgIGZpbmlz aEpTVGVzdCgpOworfQorc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKKzwvc2NyaXB0PgorPC9o ZWFkPgorPGJvZHkgb25sb2FkPSJwYWdlTG9hZCgpIj4KKzxpbnB1dCBpZD0iaW5wdXQiIHR5cGU9 InRleHQiLz4KKzxici8+Cis8cCBpZD0icGFyYSI+VGhpcyBpbnB1dCBlbGVtZW50IHNob3VsZCBu b3QgaGF2ZSBhY3RpdmUgc3RhdGU6Cis8cHJlIGlkPSJjb25zb2xlIj4KKworPC9wcmU+Cis8c2Ny aXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2Jv ZHk+Cis8L2h0bWw+CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2F1dG9mb2N1cy1vcGVy YS0wMDQtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZm9ybXMv YXV0b2ZvY3VzLW9wZXJhLTAwNC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDk2MDk2KQorKysgTGF5 b3V0VGVzdHMvZmFzdC9mb3Jtcy9hdXRvZm9jdXMtb3BlcmEtMDA0LWV4cGVjdGVkLnR4dAkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDMgQEAKLVRoZSBmb3JtIGNvbnRyb2wgc2hvdWxkIGhhdmUg YSBncmVlbiBiYWNrZ3JvdW5kOiAKK1RoZSBmb3JtIGNvbnRyb2wgc2hvdWxkIGhhdmUgYSByZWQg YmFja2dyb3VuZDogCiAKIFNVQ0NFU1MKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZm9ybXMvYXV0 b2ZvY3VzLW9wZXJhLTAwNC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZm9y bXMvYXV0b2ZvY3VzLW9wZXJhLTAwNC5odG1sCShyZXZpc2lvbiA5NjA5NikKKysrIExheW91dFRl c3RzL2Zhc3QvZm9ybXMvYXV0b2ZvY3VzLW9wZXJhLTAwNC5odG1sCSh3b3JraW5nIGNvcHkpCkBA IC0yNSw3ICsyNSw3IEBACiAgICAgfQogICAgIAogICAgIGZ1bmN0aW9uIGNoZWNrKCkgewotICAg ICAgICBpZiAoZG9jdW1lbnQuYWN0aXZlRWxlbWVudCA9PSBkb2N1bWVudC5nZXRFbGVtZW50c0J5 VGFnTmFtZSgiaW5wdXQiKVswXSkKKyAgICAgICAgaWYgKGRvY3VtZW50LmFjdGl2ZUVsZW1lbnQg IT0gZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoImlucHV0IilbMF0pCiAgICAgICAgICAg ICBsb2coIlNVQ0NFU1MiKTsKICAgICAgICAgZWxzZQogICAgICAgICAgICAgbG9nKCJGQUlMVVJF Iik7CkBAIC0zNyw4ICszNyw4IEBACiA8L3NjcmlwdD4KIDwvaGVhZD4KIDxib2R5IG9ubG9hZD0i dGVzdCgpIj4KLTxwPlRoZSBmb3JtIGNvbnRyb2wgc2hvdWxkIGhhdmUgYSBncmVlbiBiYWNrZ3Jv dW5kOiA8aW5wdXQvPjwvcD4KKzxwPlRoZSBmb3JtIGNvbnRyb2wgc2hvdWxkIGhhdmUgYSByZWQg YmFja2dyb3VuZDogPGlucHV0Lz48L3A+CiA8aHIvPgogPG9sIGlkPSJjb25zb2xlIj48L29sPgog PC9ib2R5PgotPC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKKzwvaHRtbD4KSW5k ZXg6IExheW91dFRlc3RzL2Zhc3QvZm9ybXMvYXV0b2ZvY3VzLW9wZXJhLTAwNS1leHBlY3RlZC50 eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9hdXRvZm9jdXMtb3BlcmEt MDA1LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gOTYwOTYpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Zv cm1zL2F1dG9mb2N1cy1vcGVyYS0wMDUtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMyBAQAotVGhlIGZvcm0gY29udHJvbCBzaG91bGQgaGF2ZSBhIGdyZWVuIGJhY2tncm91 bmQ6IAorVGhlIGZvcm0gY29udHJvbCBzaG91bGQgaGF2ZSBhIHJlZCBiYWNrZ3JvdW5kOiAKIAog U1VDQ0VTUwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9hdXRvZm9jdXMtb3BlcmEtMDA1 Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9hdXRvZm9jdXMtb3Bl cmEtMDA1Lmh0bWwJKHJldmlzaW9uIDk2MDk2KQorKysgTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9h dXRvZm9jdXMtb3BlcmEtMDA1Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTI2LDcgKzI2LDcgQEAK ICAgICB9CiAgICAgCiAgICAgZnVuY3Rpb24gY2hlY2soKSB7Ci0gICAgICAgIGlmIChkb2N1bWVu dC5hY3RpdmVFbGVtZW50ID09IGRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCJpbnB1dCIp WzBdKQorICAgICAgICBpZiAoZG9jdW1lbnQuYWN0aXZlRWxlbWVudCAhPSBkb2N1bWVudC5nZXRF bGVtZW50c0J5VGFnTmFtZSgiaW5wdXQiKVswXSkKICAgICAgICAgICAgIGxvZygiU1VDQ0VTUyIp OwogICAgICAgICBlbHNlCiAgICAgICAgICAgICBsb2coIkZBSUxVUkUiKTsKQEAgLTM3LDggKzM3 LDggQEAKIDwvc2NyaXB0PgogPC9oZWFkPgogPGJvZHkgb25sb2FkPSJ0ZXN0KCkiPgotPHA+VGhl IGZvcm0gY29udHJvbCBzaG91bGQgaGF2ZSBhIGdyZWVuIGJhY2tncm91bmQ6IDxpbnB1dC8+PC9w PgorPHA+VGhlIGZvcm0gY29udHJvbCBzaG91bGQgaGF2ZSBhIHJlZCBiYWNrZ3JvdW5kOiA8aW5w dXQvPjwvcD4KIDxoci8+CiA8b2wgaWQ9ImNvbnNvbGUiPjwvb2w+CiA8L2JvZHk+Ci08L2h0bWw+ ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQorPC9odG1sPgo=