68868 2011-09-26 22:28:32 -0700 Slightly improve performance of CSSStyleApplyProperty handler lookup. 2011-09-27 16:24:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 macpherson macpherson eric koivisto macpherson webkit.review.bot oldest_to_newest 473676 0 macpherson 2011-09-26 22:28:32 -0700 Slightly improve performance of CSSStyleApplyProperty handler lookup. 473677 1 108787 macpherson 2011-09-26 22:31:01 -0700 Created attachment 108787 Patch 473678 2 macpherson 2011-09-26 22:32:47 -0700 Shaves a few percent off the time spent in applyProperty() (measured using Shark profiler), and as a nice side effect makes it easier to see where time is spent when profiling. 473735 3 108787 eric 2011-09-27 00:24:52 -0700 Comment on attachment 108787 Patch Yay for avoiding double lookups! Can you please explain what test you used to show that this was faster? 474287 4 macpherson 2011-09-27 15:28:35 -0700 Not a test as such, I was using the profiler (shark) and digging in the disassembled output to see where time was going and could see that the cost of the lookup was contributing more than necessary. 474332 5 108787 webkit.review.bot 2011-09-27 16:24:00 -0700 Comment on attachment 108787 Patch Clearing flags on attachment: 108787 Committed r96168: <http://trac.webkit.org/changeset/96168> 474333 6 webkit.review.bot 2011-09-27 16:24:04 -0700 All reviewed patches have been landed. Closing bug. 108787 2011-09-26 22:31:01 -0700 2011-09-27 16:24:00 -0700 Patch bug-68868-20110927153059.patch text/plain 3654 macpherson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk2MDY5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDktMjYgIEx1a2UgTWFj cGhlcnNvbiAgIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBTbGlnaHRseSBp bXByb3ZlIHBlcmZvcm1hbmNlIG9mIENTU1N0eWxlQXBwbHlQcm9wZXJ0eSBoYW5kbGVyIGxvb2t1 cC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4ODY4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzIGFzIG5vIGZ1bmN0aW9uYWxpdHkgY2hhbmdlZC4KKworICAgICAgICAqIGNzcy9DU1NT dHlsZUFwcGx5UHJvcGVydHkuaDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1N0eWxlQXBwbHlQcm9w ZXJ0eTo6cHJvcGVydHlIYW5kbGVyKToKKyAgICAgICAgTWFrZSBwcm9wZXJ0eUhhbmRsZXIoKSBw dWJsaWMgYW5kIHJlbW92ZSByZWRpcmVjdGluZyBmdW5jdGlvbnMuCisgICAgICAgICogY3NzL0NT U1N0eWxlU2VsZWN0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTU3R5bGVTZWxlY3Rvcjo6 YXBwbHlQcm9wZXJ0eSk6CisgICAgICAgIFBlcmZvcm0gcHJvcGVydHkgaGFuZGxlciBsb29rdXAg b25jZSBhbmQgcmV1c2UgdGhlIHJlc3VsdC4KKwogMjAxMS0wOS0wOSAgU2ltb24gRnJhc2VyICA8 c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBUcmFuc2x1Y2VudCBzY3JvbGxiYXJz IG9uIGNvbXBvc2l0ZWQgbGF5ZXJzIHJlbmRlciBpbmNvcnJlY3RseQpJbmRleDogU291cmNlL1dl YkNvcmUvY3NzL0NTU1N0eWxlQXBwbHlQcm9wZXJ0eS5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NTdHlsZUFwcGx5UHJvcGVydHkuaAkocmV2aXNpb24gOTYwNjgpCisrKyBT b3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVBcHBseVByb3BlcnR5LmgJKHdvcmtpbmcgY29weSkK QEAgLTQ5LDI5ICs0OSwxMSBAQCBjbGFzcyBDU1NTdHlsZUFwcGx5UHJvcGVydHkgewogcHVibGlj OgogICAgIHN0YXRpYyBjb25zdCBDU1NTdHlsZUFwcGx5UHJvcGVydHkmIHNoYXJlZENTU1N0eWxl QXBwbHlQcm9wZXJ0eSgpOwogCi0gICAgdm9pZCBhcHBseUluaGVyaXRWYWx1ZShDU1NQcm9wZXJ0 eUlEIHByb3BlcnR5LCBDU1NTdHlsZVNlbGVjdG9yKiBzZWxlY3RvcikgY29uc3QKLSAgICB7Ci0g ICAgICAgIEFTU0VSVChpbXBsZW1lbnRzKHByb3BlcnR5KSk7Ci0gICAgICAgIHByb3BlcnR5SGFu ZGxlcihwcm9wZXJ0eSktPmFwcGx5SW5oZXJpdFZhbHVlKHNlbGVjdG9yKTsKLSAgICB9Ci0KLSAg ICB2b2lkIGFwcGx5SW5pdGlhbFZhbHVlKENTU1Byb3BlcnR5SUQgcHJvcGVydHksIENTU1N0eWxl U2VsZWN0b3IqIHNlbGVjdG9yKSBjb25zdAotICAgIHsKLSAgICAgICAgQVNTRVJUKGltcGxlbWVu dHMocHJvcGVydHkpKTsKLSAgICAgICAgcHJvcGVydHlIYW5kbGVyKHByb3BlcnR5KS0+YXBwbHlJ bml0aWFsVmFsdWUoc2VsZWN0b3IpOwotICAgIH0KLQotICAgIHZvaWQgYXBwbHlWYWx1ZShDU1NQ cm9wZXJ0eUlEIHByb3BlcnR5LCBDU1NTdHlsZVNlbGVjdG9yKiBzZWxlY3RvciwgQ1NTVmFsdWUq IHZhbHVlKSBjb25zdAotICAgIHsKLSAgICAgICAgQVNTRVJUKGltcGxlbWVudHMocHJvcGVydHkp KTsKLSAgICAgICAgcHJvcGVydHlIYW5kbGVyKHByb3BlcnR5KS0+YXBwbHlWYWx1ZShzZWxlY3Rv ciwgdmFsdWUpOwotICAgIH0KLQotICAgIGJvb2wgaW1wbGVtZW50cyhDU1NQcm9wZXJ0eUlEIHBy b3BlcnR5KSBjb25zdAorICAgIEFwcGx5UHJvcGVydHlCYXNlKiBwcm9wZXJ0eUhhbmRsZXIoQ1NT UHJvcGVydHlJRCBwcm9wZXJ0eSkgY29uc3QKICAgICB7Ci0gICAgICAgIHJldHVybiBwcm9wZXJ0 eUhhbmRsZXIocHJvcGVydHkpOworICAgICAgICBBU1NFUlQodmFsaWQocHJvcGVydHkpKTsKKyAg ICAgICAgcmV0dXJuIG1fcHJvcGVydHlNYXBbaW5kZXgocHJvcGVydHkpXTsKICAgICB9Ci0KIHBy aXZhdGU6CiAgICAgQ1NTU3R5bGVBcHBseVByb3BlcnR5KCk7CiAgICAgc3RhdGljIGludCBpbmRl eChDU1NQcm9wZXJ0eUlEIHByb3BlcnR5KQpAQCAtMTAwLDEyICs4Miw2IEBAIHByaXZhdGU6CiAg ICAgICAgIG1fcHJvcGVydHlNYXBbaW5kZXgobmV3UHJvcGVydHkpXSA9IG1fcHJvcGVydHlNYXBb aW5kZXgoZXF1aXZhbGVudFByb3BlcnR5KV07CiAgICAgfQogCi0gICAgQXBwbHlQcm9wZXJ0eUJh c2UqIHByb3BlcnR5SGFuZGxlcihDU1NQcm9wZXJ0eUlEIHByb3BlcnR5KSBjb25zdAotICAgIHsK LSAgICAgICAgQVNTRVJUKHZhbGlkKHByb3BlcnR5KSk7Ci0gICAgICAgIHJldHVybiBtX3Byb3Bl cnR5TWFwW2luZGV4KHByb3BlcnR5KV07Ci0gICAgfQotCiAgICAgQXBwbHlQcm9wZXJ0eUJhc2Uq IG1fcHJvcGVydHlNYXBbbnVtQ1NTUHJvcGVydGllc107CiB9OwogCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCShyZXZpc2lvbiA5NjA2OCkKKysrIFNvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjM3MSwx MyArMjM3MSwxMyBAQCB2b2lkIENTU1N0eWxlU2VsZWN0b3I6OmFwcGx5UHJvcGVydHkoaW50CiAg ICAgQ1NTUHJvcGVydHlJRCBwcm9wZXJ0eSA9IHN0YXRpY19jYXN0PENTU1Byb3BlcnR5SUQ+KGlk KTsKIAogICAgIC8vIGNoZWNrIGxvb2t1cCB0YWJsZSBmb3IgaW1wbGVtZW50YXRpb25zIGFuZCB1 c2Ugd2hlbiBhdmFpbGFibGUKLSAgICBpZiAobV9hcHBseVByb3BlcnR5LmltcGxlbWVudHMocHJv cGVydHkpKSB7CisgICAgaWYgKEFwcGx5UHJvcGVydHlCYXNlKiBoYW5kbGVyID0gbV9hcHBseVBy b3BlcnR5LnByb3BlcnR5SGFuZGxlcihwcm9wZXJ0eSkpIHsKICAgICAgICAgaWYgKGlzSW5oZXJp dCkKLSAgICAgICAgICAgIG1fYXBwbHlQcm9wZXJ0eS5hcHBseUluaGVyaXRWYWx1ZShwcm9wZXJ0 eSwgdGhpcyk7CisgICAgICAgICAgICBoYW5kbGVyLT5hcHBseUluaGVyaXRWYWx1ZSh0aGlzKTsK ICAgICAgICAgZWxzZSBpZiAoaXNJbml0aWFsKQotICAgICAgICAgICAgbV9hcHBseVByb3BlcnR5 LmFwcGx5SW5pdGlhbFZhbHVlKHByb3BlcnR5LCB0aGlzKTsKKyAgICAgICAgICAgIGhhbmRsZXIt PmFwcGx5SW5pdGlhbFZhbHVlKHRoaXMpOwogICAgICAgICBlbHNlCi0gICAgICAgICAgICBtX2Fw cGx5UHJvcGVydHkuYXBwbHlWYWx1ZShwcm9wZXJ0eSwgdGhpcywgdmFsdWUpOworICAgICAgICAg ICAgaGFuZGxlci0+YXBwbHlWYWx1ZSh0aGlzLCB2YWx1ZSk7CiAgICAgICAgIHJldHVybjsKICAg ICB9CiAK