68859 2011-09-26 18:18:32 -0700 ASSERT(!m_styleSheets->length()) can be easily hit when playing with document.open 2023-08-28 14:03:49 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All NEW P2 Minor --- 64284 1 jchaffraix jchaffraix abarth ap cdumez eric koivisto mitz opendarwin simon.fraser zhenghao oldest_to_newest 473604 0 jchaffraix 2011-09-26 18:18:32 -0700 Kind of a follow up of bug 60935, the ASSERT that was not removed is actually hit on bug 64284. Instead of fixing both issues from the previous bug at the same time, I thought it would be better to provide remove the ASSERT first as it may be controversial. Patch on his way. 473620 1 108774 jchaffraix 2011-09-26 18:38:30 -0700 Created attachment 108774 Proposed removal. 473656 2 108774 ap 2011-09-26 20:14:32 -0700 Comment on attachment 108774 Proposed removal. View in context: https://bugs.webkit.org/attachment.cgi?id=108774&action=review Hmm, but isn't this assertion catching a bug here? Stylesheets should have a matching compatibility mode AFAICT. > LayoutTests/fast/parser/append-style-followed-by-close.html:7 > + layoutTestController.waitUntilDone(); No need for waitUntilDone() - onload is called before DRT automatically dumps results. 473662 3 108774 darin 2011-09-26 20:32:46 -0700 Comment on attachment 108774 Proposed removal. View in context: https://bugs.webkit.org/attachment.cgi?id=108774&action=review > Source/WebCore/dom/Document.cpp:-682 > - ASSERT(!m_styleSheets->length()); What was the rationale of the original assertion? I assume it’s asserting because if there are style sheets they might have to be processed again to handle the compatibility mode properly. So if we are removing the assertion it seems we might have to add code that does something to cause the style sheets to be processed again. It’s fairly common to assert something like this to emphasize that there is no work to be done. Work that otherwise we might need to have code to accomplish. Or maybe the assertion was completely spurious with no value. We should find out. 473965 4 108774 jchaffraix 2011-09-27 09:07:19 -0700 Comment on attachment 108774 Proposed removal. View in context: https://bugs.webkit.org/attachment.cgi?id=108774&action=review >> LayoutTests/fast/parser/append-style-followed-by-close.html:7 >> + layoutTestController.waitUntilDone(); > > No need for waitUntilDone() - onload is called before DRT automatically dumps results. I would have agreed with you before writing the test. If you don't put waitUntilDone, you don't dump the alert() on Chromium. As the test is not slow, there seems to be some race-condition (seen only under NRWT not under plain DRT) but I did not investigate it. >> Source/WebCore/dom/Document.cpp:-682 >> - ASSERT(!m_styleSheets->length()); > > What was the rationale of the original assertion? I assume it’s asserting because if there are style sheets they might have to be processed again to handle the compatibility mode properly. So if we are removing the assertion it seems we might have to add code that does something to cause the style sheets to be processed again. > > It’s fairly common to assert something like this to emphasize that there is no work to be done. Work that otherwise we might need to have code to accomplish. > > Or maybe the assertion was completely spurious with no value. > > We should find out. The ASSERT was added in bug 44788 - implement HTML5-compliant doctype switching - as a way to catch what any already processed stylesheet. The goal was to underline what you said (that we did not have to reprocess some of the stylesheets). The default Document's parser will not hit the ASSERT: per HTML5's parsing algorithm, it would have changed the tree builder's state if it sees any <style> element. However any series of document.open, document.addChild, document.close would trigger it. I bet there are other examples if you start mixing up some parsing + document.addChild from JS. Under those assumptions, it seemed fine to remove it. Another way would be to loosen it to skip the check for a JS-created parser (likely with a comment saying that we would need to have a reparsing phase in this case). 477750 5 108774 jchaffraix 2011-10-04 11:01:31 -0700 Comment on attachment 108774 Proposed removal. Clearing the review flag while I find another way to handle the ASSERT. 479284 6 jchaffraix 2011-10-06 10:54:46 -0700 Renaming the bug as the consensus is that the ASSERT should be kept and my assumptions were wrong. 479495 7 110024 jchaffraix 2011-10-06 14:35:46 -0700 Created attachment 110024 Tweaked the ASSERT to not trigger in this case as it is too fragile. Added a comment about the fix. 495815 8 110024 jchaffraix 2011-11-03 15:14:16 -0700 Comment on attachment 110024 Tweaked the ASSERT to not trigger in this case as it is too fragile. Added a comment about the fix. Looking again at the patch, I thought it was blocking some testing for the associated crasher but it's possible to work around the ASSERT by enabling the test only in Release. Under this light, the patch is not not a good change as we lose coverage for a potentially bad situation. I will just progress with the other bug and use this one for the ASSERT failure. 563905 9 mitz 2012-02-23 21:25:46 -0800 I disabled a test that was failing this assertion in<http://trac.webkit.org/r108725>. 564433 10 jchaffraix 2012-02-24 10:20:05 -0800 *** Bug 51793 has been marked as a duplicate of this bug. *** 564435 11 jchaffraix 2012-02-24 10:23:20 -0800 *** Bug 75135 has been marked as a duplicate of this bug. *** 652172 12 zhenghao 2012-06-19 00:55:55 -0700 *** Bug 89441 has been marked as a duplicate of this bug. *** 652390 13 110024 eric 2012-06-19 06:51:28 -0700 Comment on attachment 110024 Tweaked the ASSERT to not trigger in this case as it is too fragile. Added a comment about the fix. View in context: https://bugs.webkit.org/attachment.cgi?id=110024&action=review > Source/WebCore/dom/Document.cpp:684 > + // in ways that are unknown to the parser (like manually inserting stylesheets). FIXME: To solve this issue This reminded me of this comment: http://trac.webkit.org/browser/trunk/Source/WebCore/css/StyleResolver.cpp#L410 Marking the document's style-resolver as needing recalc will cause it to reparse sheets I think. I suspect clearPageUserSheet, etc. have that effect already (but I have not confirmed). 108774 2011-09-26 18:38:30 -0700 2011-10-06 14:35:42 -0700 Proposed removal. bug-68859-20110926183829.patch text/plain 3734 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogOTYwMTQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAzZjZiNTQ5NmIyMDI4N2NjZjljMmQw Y2EzOTM1NmE3ZTJkNzMxZTlmLi45Y2MwMjYwMWMxMzYyYWYyM2QzMTRkYzUxYmU3YTRjMGVmMmRh Y2EwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDktMjYgIEp1bGllbiBDaGFmZnJhaXgg IDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVtb3ZlIGFub3RoZXIgYm9ndXMg QVNTRVJUIGluIERvY3VtZW50OjpzZXRDb21wYXRpYmlsaXR5TW9kZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njg4NTkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvcGFyc2VyL2FwcGVuZC1zdHls ZS1mb2xsb3dlZC1ieS1jbG9zZS5odG1sOiBBZGRlZC4KKwogMjAxMS0wOS0yNiAgS2VuamkgSW1h c2FraSAgPGltYXNha2lAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gVXBkYXRl IHRoZSB0ZXN0IGV4cGVjdGFpb24gZmlsZSBmb3IgbWVkaWEgcmVsYXRlZCB0ZXN0cy4KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvcGFyc2VyL2FwcGVuZC1zdHlsZS1mb2xsb3dlZC1ieS1j bG9zZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L3BhcnNlci9hcHBlbmQtc3R5bGUt Zm9sbG93ZWQtYnktY2xvc2UtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmM3YWQxMjFhZjkwOWMz MzE4NDM5ZWU3Mjg5MjQ0MmI0YzcyNmM1ODgKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L3BhcnNlci9hcHBlbmQtc3R5bGUtZm9sbG93ZWQtYnktY2xvc2UtZXhwZWN0ZWQudHh0 CkBAIC0wLDAgKzEsMyBAQAorQUxFUlQ6IEJ1ZyA2ODg1OTogUmVtb3ZlIGFub3RoZXIgYm9ndXMg QVNTRVJUIGluIERvY3VtZW50OjpzZXRDb21wYXRpYmlsaXR5TW9kZQorVGhlIHRlc3QgaGFzIFBB U1NFRCBhcyBpdCBkaWQgbm90IEFTU0VSVC4KKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9wYXJzZXIvYXBwZW5kLXN0eWxlLWZvbGxvd2VkLWJ5LWNsb3NlLmh0bWwgYi9MYXlvdXRUZXN0 cy9mYXN0L3BhcnNlci9hcHBlbmQtc3R5bGUtZm9sbG93ZWQtYnktY2xvc2UuaHRtbApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwLi43MGM2OGI5YTMzZTE4ZmUyZjM3YzBmY2JjNTZiYWZlNjhiNzhhOWVlCi0tLSAvZGV2L251 bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9wYXJzZXIvYXBwZW5kLXN0eWxlLWZvbGxvd2VkLWJ5 LWNsb3NlLmh0bWwKQEAgLTAsMCArMSwyMCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxi b2R5IG9ubG9hZD0iZ28oKSI+PC9ib2R5PgorPHNjcmlwdD4KKyAgICBpZiAod2luZG93LmxheW91 dFRlc3RDb250cm9sbGVyKSB7CisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1Rl eHQoKTsKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworICAg IH0KKworICAgIGZ1bmN0aW9uIGdvKCkgeworICAgICAgICBkb2N1bWVudC5vcGVuKCk7CisgICAg ICAgIHZhciBzdHlsZUVsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJzdHlsZSIpOwor ICAgICAgICBkb2N1bWVudC5hcHBlbmRDaGlsZChzdHlsZUVsZW1lbnQpOworICAgICAgICBkb2N1 bWVudC5jbG9zZSgpOworICAgICAgICBhbGVydCgiQnVnIDY4ODU5OiBSZW1vdmUgYW5vdGhlciBi b2d1cyBBU1NFUlQgaW4gRG9jdW1lbnQ6OnNldENvbXBhdGliaWxpdHlNb2RlXG5UaGUgdGVzdCBo YXMgUEFTU0VEIGFzIGl0IGRpZCBub3QgQVNTRVJULiIpOworICAgICAgICBpZiAod2luZG93Lmxh eW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90 aWZ5RG9uZSgpOworICAgIH0KKzwvc2NyaXB0PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGI5ZDk1 YzFiYjU3YTAzZDEzZDU3NDdkYjk2M2YxMDUxZjc1MTE3OGQuLmM4N2M2ODEyMGU4NmVjNTYyODdi MzUwNjRkNTA0ZjQwNDFiYmJjMGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMS0w OS0yNiAgSnVsaWVuIENoYWZmcmFpeCAgPGpjaGFmZnJhaXhAd2Via2l0Lm9yZz4KKworICAgICAg ICBSZW1vdmUgYW5vdGhlciBib2d1cyBBU1NFUlQgaW4gRG9jdW1lbnQ6OnNldENvbXBhdGliaWxp dHlNb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 ODg1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRl c3Q6IGZhc3QvcGFyc2VyL2FwcGVuZC1zdHlsZS1mb2xsb3dlZC1ieS1jbG9zZS5odG1sCisKKyAg ICAgICAgSW4gcjg2NjQ5LCBwYXJ0IG9mIHRoZSBBU1NFUlQgaW4gc2V0Q29tcGF0aWJpbGl0eU1v ZGUgd2FzIHJlbW92ZWQuCisgICAgICAgIEhvd2V2ZXIgdGhlIHJlbWFpbmluZyBwYXJ0IGNhbiBh bHNvIGJlIHJlYWNoZWQ6IGlmIHNvbWUgc3R5bGUKKyAgICAgICAgZWxlbWVudHMgYXJlIHByb2dy YW1tYXRpY2FsbHkgYWRkZWQgdG8gYSB0cmVlIGJ1aWxkZXIgaW4gdGhlIGluaXRpYWwKKyAgICAg ICAgc3RhdGUsIHRoYXQgdGhlbiBnZXRzIHRoZSBFT0YgdG9rZW4uCisKKyAgICAgICAgKiBkb20v RG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnNldENvbXBhdGliaWxp dHlNb2RlKToKKwogMjAxMS0wOS0yNiAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CiAK ICAgICAgICAgW0dUS10gRG8gbm90IGlnbm9yZSAnUmVwbGFjZWFibGUnIGF0dHJpYnV0ZXMgaW4g dGhlIERPTSBiaW5kaW5ncwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50 LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKaW5kZXggYWVjMjJiMDI0NjZj YTBjNWNjM2Q0MzIxNDdkNjJiNTQ0MzZjMjFmMC4uZjM5NjM5OGJjMTFkNTYzM2YyZDZkNzI5OTEx N2QxZDkyMDJhMTI5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCkBAIC02NzksNyArNjc5LDcg QEAgdm9pZCBEb2N1bWVudDo6c2V0Q29tcGF0aWJpbGl0eU1vZGUoQ29tcGF0aWJpbGl0eU1vZGUg bW9kZSkKIHsKICAgICBpZiAobV9jb21wYXRpYmlsaXR5TW9kZUxvY2tlZCB8fCBtb2RlID09IG1f Y29tcGF0aWJpbGl0eU1vZGUpCiAgICAgICAgIHJldHVybjsKLSAgICBBU1NFUlQoIW1fc3R5bGVT aGVldHMtPmxlbmd0aCgpKTsKKwogICAgIGJvb2wgd2FzSW5RdWlya3NNb2RlID0gaW5RdWlya3NN b2RlKCk7CiAgICAgbV9jb21wYXRpYmlsaXR5TW9kZSA9IG1vZGU7CiAgICAgaWYgKGluUXVpcmtz TW9kZSgpICE9IHdhc0luUXVpcmtzTW9kZSkgewo= 110024 2011-10-06 14:35:46 -0700 2012-06-19 06:51:28 -0700 Tweaked the ASSERT to not trigger in this case as it is too fragile. Added a comment about the fix. bug-68859-20111006143545.patch text/plain 4840 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogOTY4NTIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwNmE2ZGU1MTA4NjdmM2JiYTRjMzYz ZThhNWI0N2M2NDFmZjBkYTE3Li4yODZjNzZlOGY3ZWEyNjY2YzJkYjhkYjE1MGM2MDE5MmU2YTM3 Mjg5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTAtMDYgIEp1bGllbiBDaGFmZnJhaXgg IDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+CisKKyAgICAgICAgQVNTRVJUKCFtX3N0eWxlU2hlZXRz LT5sZW5ndGgoKSkgY2FuIGJlIGVhc2lseSBoaXQgd2hlbiBwbGF5aW5nIHdpdGggZG9jdW1lbnQu b3BlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njg4 NTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZh c3QvcGFyc2VyL2FwcGVuZC1zdHlsZS1mb2xsb3dlZC1ieS1jbG9zZS1leHBlY3RlZC50eHQ6IEFk ZGVkLgorICAgICAgICAqIGZhc3QvcGFyc2VyL2FwcGVuZC1zdHlsZS1mb2xsb3dlZC1ieS1jbG9z ZS5odG1sOiBBZGRlZC4KKwogMjAxMS0xMC0wNiAgRGlyayBTY2h1bHplICA8a3JpdEB3ZWJraXQu b3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQ6IDNyZCBjaHVuayBvZiBuZXcgU1ZHIGJhc2VsaW5l IGZvciBsaW9uLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9wYXJzZXIvYXBwZW5kLXN0 eWxlLWZvbGxvd2VkLWJ5LWNsb3NlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvcGFy c2VyL2FwcGVuZC1zdHlsZS1mb2xsb3dlZC1ieS1jbG9zZS1leHBlY3RlZC50eHQKbmV3IGZpbGUg bW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MC4uMDM0NTNhNjNkYWMwOTc0NmMzODlkMzZiODFhMGY4ZDVjOThmZDUxZQotLS0gL2Rldi9udWxs CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvcGFyc2VyL2FwcGVuZC1zdHlsZS1mb2xsb3dlZC1ieS1j bG9zZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwzIEBACitBTEVSVDogQnVnIDY4ODU5OiBBU1NF UlQoIW1fc3R5bGVTaGVldHMtPmxlbmd0aCgpKSBjYW4gYmUgZWFzaWx5IGhpdCB3aGVuIHBsYXlp bmcgd2l0aCBkb2N1bWVudC5vcGVuCitUaGUgdGVzdCBoYXMgUEFTU0VEIGFzIGl0IGRpZCBub3Qg QVNTRVJULgorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3BhcnNlci9hcHBlbmQtc3R5 bGUtZm9sbG93ZWQtYnktY2xvc2UuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvcGFyc2VyL2FwcGVu ZC1zdHlsZS1mb2xsb3dlZC1ieS1jbG9zZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjdhMDBmMDkxMzE2MDE4 NGU1NTA0YTkyMGUyYzE0YmU4ZTExNTk0MDAKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L3BhcnNlci9hcHBlbmQtc3R5bGUtZm9sbG93ZWQtYnktY2xvc2UuaHRtbApAQCAtMCww ICsxLDIwIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGJvZHkgb25sb2FkPSJnbygpIj48 L2JvZHk+Cis8c2NyaXB0PgorICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsK KyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgICAgICBsYXlv dXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7CisgICAgfQorCisgICAgZnVuY3Rpb24g Z28oKSB7CisgICAgICAgIGRvY3VtZW50Lm9wZW4oKTsKKyAgICAgICAgdmFyIHN0eWxlRWxlbWVu dCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInN0eWxlIik7CisgICAgICAgIGRvY3VtZW50LmFw cGVuZENoaWxkKHN0eWxlRWxlbWVudCk7CisgICAgICAgIGRvY3VtZW50LmNsb3NlKCk7CisgICAg ICAgIGFsZXJ0KCJCdWcgNjg4NTk6IEFTU0VSVCghbV9zdHlsZVNoZWV0cy0+bGVuZ3RoKCkpIGNh biBiZSBlYXNpbHkgaGl0IHdoZW4gcGxheWluZyB3aXRoIGRvY3VtZW50Lm9wZW5cblRoZSB0ZXN0 IGhhcyBQQVNTRUQgYXMgaXQgZGlkIG5vdCBBU1NFUlQuIik7CisgICAgICAgIGlmICh3aW5kb3cu bGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5u b3RpZnlEb25lKCk7CisgICAgfQorPC9zY3JpcHQ+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTEw NTViYTIxOTdiMzAwYjRiNDdjOWJlMTViNDA3OTkwZTU4Mzg5MS4uOWRkMTUzZDIxZjEwYmY3NjEz N2ZkM2ViNjE4NWQ4ZWIyMTAxNDc2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEx LTEwLTA2ICBKdWxpZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgorCisgICAg ICAgIEFTU0VSVCghbV9zdHlsZVNoZWV0cy0+bGVuZ3RoKCkpIGNhbiBiZSBlYXNpbHkgaGl0IHdo ZW4gcGxheWluZyB3aXRoIGRvY3VtZW50Lm9wZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTY4ODU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGVzdDogZmFzdC9wYXJzZXIvYXBwZW5kLXN0eWxlLWZvbGxv d2VkLWJ5LWNsb3NlLmh0bWwKKworICAgICAgICBUaGUgZ2lzdCBvZiB0aGUgaXNzdWUgaXMgdGhh dCBKUyBjYW4gZWFzaWx5IG11dGF0ZSB0aGUgZG9jdW1lbnQgaW4gd2F5cworICAgICAgICB0aGF0 IGFyZSB1bmtub3duIHRvIHRoZSBwYXJzZXIgKG5vdGUgdGhhdCB0aGUgQVNTRVJUIHdhcyB0d2Vh a2VkIGluIHI4NjY0OQorICAgICAgICBkdWUgdG8gdGhlIHZlcnkgc2FtZSByZWFzb24pLgorCisg ICAgICAgIFRoaXMgY2hhbmdlIGRpc2FibGVzIHRoZSBBU1NFUlQgZm9yIGEgSlMtY3JlYXRlZCBw YXJzZXIuIFRoaXMgbWFrZXMgc2Vuc2UgYXMKKyAgICAgICAgaXQgaXMgYW4gaW1wb3J0YW50IEFT U0VSVCBmb3IgdGhlIG5vcm1hbCBwYXJzZXIsIG5vdCBzbyBtdWNoIGZvciBhIEpTIGNvbnRyb2xs ZWQKKyAgICAgICAgb25lLiBUaGlzIGRvZXMgbm90IHNvbHZlIHRoZSB1bmRlcmx5aW5nIHByb2Js ZW0gLSB3aGljaCB3b3VsZCBpbnZvbHZlCisgICAgICAgIHJlcGFyc2luZyB0aGUgc3R5bGUgc2hl ZXRzIGluIHRoZSBuZXcgY29tcGF0aWJpbGl0eSBtb2RlLiBUaGlzIGlzIG5vbi10cml2aWFsCisg ICAgICAgIGFuZCBwYWdlcyByZWx5aW5nIG9uIHN1Y2ggcmVwYXJzaW5nIGFyZSBsaWtlbHkgcmFy ZSBhbmQgd3JvbmcgaW4gb3RoZXIgd2F5cy4KKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6c2V0Q29tcGF0aWJpbGl0eU1vZGUpOiBJbXBs ZW1lbnRlZCB0aGUgcHJldmlvdXMgY2hhbmdlCisgICAgICAgIGFuZCBhZGRlZCBhIGNvbW1lbnQg ZXhwbGFpbmluZyB0aGUgcmF0aW9uYWxlIGJlaGluZCBpdC4KKwogMjAxMS0xMC0wNiAgR2F2aW4g UGV0ZXJzICA8Z2F2aW5wQGNocm9taXVtLm9yZz4KIAogICAgICAgICBjb25kaXRpb25hbGl6ZSBt X2NhY2hlZFNjcmlwdCBzdGFja3MgdG8ganVzdCBDaHJvbWl1bSBwb3J0CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3Vt ZW50LmNwcAppbmRleCA3ZTRkZTFmOGJjOTMzMGM2MjhhZjM1ZmU0ZDM4Y2Y4ZDg2MmE3YmFlLi5i Y2IyMmJiOWQ2ZTU5OTgzMWY2NmI3Y2UyYmU3N2ZiMTgyYmY0NmYzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1 bWVudC5jcHAKQEAgLTY3OSw3ICs2NzksMTIgQEAgdm9pZCBEb2N1bWVudDo6c2V0Q29tcGF0aWJp bGl0eU1vZGUoQ29tcGF0aWJpbGl0eU1vZGUgbW9kZSkKIHsKICAgICBpZiAobV9jb21wYXRpYmls aXR5TW9kZUxvY2tlZCB8fCBtb2RlID09IG1fY29tcGF0aWJpbGl0eU1vZGUpCiAgICAgICAgIHJl dHVybjsKLSAgICBBU1NFUlQoIW1fc3R5bGVTaGVldHMtPmxlbmd0aCgpKTsKKworICAgIC8vIFdl IGRpc2FibGUgdGhpcyBBU1NFUlQgZm9yIGEgSlMgY3JlYXRlZCBwYXJzZXIgKGZvciBleGFtcGxl IGRvY3VtZW50Lm9wZW4pIGFzIEpTIGNhbiBtdXRhdGUgdGhlIGRvY3VtZW50CisgICAgLy8gaW4g d2F5cyB0aGF0IGFyZSB1bmtub3duIHRvIHRoZSBwYXJzZXIgKGxpa2UgbWFudWFsbHkgaW5zZXJ0 aW5nIHN0eWxlc2hlZXRzKS4gRklYTUU6IFRvIHNvbHZlIHRoaXMgaXNzdWUKKyAgICAvLyB3ZSB3 b3VsZCBuZWVkIHRvIHJlcGFyc2UgdGhlIHN0eWxlc2hlZXRzIGluIHRoZSBuZXcgY29tcGF0aWJp bGl0eSBtb2RlIGJ1dCBpdCBpcyBub24tdHJpdmlhbCBhbmQgcGFnZXMKKyAgICAvLyByZWx5aW5n IG9uIHRoaXMgYmVoYXZpb3Igc2hvdWxkIGJlIHJhcmUuCisgICAgQVNTRVJUKCFtX3N0eWxlU2hl ZXRzLT5sZW5ndGgoKSB8fCAoc2NyaXB0YWJsZURvY3VtZW50UGFyc2VyKCkgJiYgc2NyaXB0YWJs ZURvY3VtZW50UGFyc2VyKCktPndhc0NyZWF0ZWRCeVNjcmlwdCgpKSk7CiAgICAgYm9vbCB3YXNJ blF1aXJrc01vZGUgPSBpblF1aXJrc01vZGUoKTsKICAgICBtX2NvbXBhdGliaWxpdHlNb2RlID0g bW9kZTsKICAgICBpZiAoaW5RdWlya3NNb2RlKCkgIT0gd2FzSW5RdWlya3NNb2RlKSB7Cg==