68848 2011-09-26 16:17:09 -0700 [Qt][WK2] Mark FINAL properties which can't be overridden by a subclass. 2011-09-27 00:54:21 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 menard menard benjamin cmarcelo hausmann kling noam vestbo webkit.review.bot oldest_to_newest 473506 0 menard 2011-09-26 16:17:09 -0700 [Qt][WK2] Mark FINAL properties which can't be overridden by a subclass. 473511 1 108751 menard 2011-09-26 16:20:01 -0700 Created attachment 108751 Patch 473747 2 108751 kling 2011-09-27 00:36:40 -0700 Comment on attachment 108751 Patch Sure. 473766 3 108751 webkit.review.bot 2011-09-27 00:54:17 -0700 Comment on attachment 108751 Patch Clearing flags on attachment: 108751 Committed r96079: <http://trac.webkit.org/changeset/96079> 473767 4 webkit.review.bot 2011-09-27 00:54:21 -0700 All reviewed patches have been landed. Closing bug. 108751 2011-09-26 16:20:01 -0700 2011-09-27 00:54:16 -0700 Patch bug-68848-20110926201948.patch text/plain 4102 menard SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk2MDI4KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDktMjYgIEFsZXhpcyBN ZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgW1F0XVtXSzJd IE1hcmsgRklOQUwgcHJvcGVydGllcyB3aGljaCBjYW4ndCBiZSBvdmVycmlkZGVuIGJ5IGEgc3Vi Y2xhc3MuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 ODg0OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo ZSBwcmVzZW5jZSBvZiB0aGUgRklOQUwgYXR0cmlidXRlIGluZGljYXRlcyB0aGF0IHRoZSBwcm9w ZXJ0eSB3aWxsIG5vdCBiZSAKKyAgICAgICAgb3ZlcnJpZGRlbiBieSBhIGRlcml2ZWQgY2xhc3Mu IFRoaXMgY2FuIGJlIHVzZWQgZm9yIHBlcmZvcm1hbmNlIG9wdGltaXphdGlvbnMKKyAgICAgICAg YnkgUU1MLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xZGVza3RvcHdlYnZpZXcuaDoK KyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3F0b3VjaHdlYnBhZ2UuaDoKKyAgICAgICAgKiBV SVByb2Nlc3MvQVBJL3F0L3F0b3VjaHdlYnZpZXcuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L3F0L3F3ZWJuYXZpZ2F0aW9uY29udHJvbGxlci5oOgorCiAyMDExLTA5LTI2ICBBbGV4ZXkgUHJv c2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHI5NTc0Nyk6 IEFjdGl2YXRpbmcgdGhlIHdlYiBpbnNwZWN0b3IgY2F1c2VzIHRoZSB3ZWIgcHJvY2VzcyB0byBi ZSBraWxsZWQKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcWRlc2t0b3B3 ZWJ2aWV3LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9x ZGVza3RvcHdlYnZpZXcuaAkocmV2aXNpb24gOTU2MTUpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL3F0L3FkZXNrdG9wd2Vidmlldy5oCSh3b3JraW5nIGNvcHkpCkBAIC01Miw3ICs1 Miw3IEBAIGNsYXNzIFFXRUJLSVRfRVhQT1JUIFFEZXNrdG9wV2ViVmlldyA6IHAKICAgICBRX1BS T1BFUlRZKFFTdHJpbmcgdGl0bGUgUkVBRCB0aXRsZSBOT1RJRlkgdGl0bGVDaGFuZ2VkKQogICAg IFFfUFJPUEVSVFkoUVVybCB1cmwgUkVBRCB1cmwgTk9USUZZIHVybENoYW5nZWQpCiAgICAgUV9Q Uk9QRVJUWShpbnQgbG9hZFByb2dyZXNzIFJFQUQgbG9hZFByb2dyZXNzIE5PVElGWSBsb2FkUHJv Z3Jlc3NDaGFuZ2VkKQotICAgIFFfUFJPUEVSVFkoUVdlYk5hdmlnYXRpb25Db250cm9sbGVyKiBu YXZpZ2F0aW9uIFJFQUQgbmF2aWdhdGlvbkNvbnRyb2xsZXIgQ09OU1RBTlQpCisgICAgUV9QUk9Q RVJUWShRV2ViTmF2aWdhdGlvbkNvbnRyb2xsZXIqIG5hdmlnYXRpb24gUkVBRCBuYXZpZ2F0aW9u Q29udHJvbGxlciBDT05TVEFOVCBGSU5BTCkKICAgICBRX0VOVU1TKE5hdmlnYXRpb25Qb2xpY3kp CiAgICAgUV9FTlVNUyhFcnJvclR5cGUpCiBwdWJsaWM6CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL3F0L3F0b3VjaHdlYnBhZ2UuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F0b3VjaHdlYnBhZ2UuaAkocmV2aXNpb24gOTU2MTUpCisr KyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F0b3VjaHdlYnBhZ2UuaAkod29ya2lu ZyBjb3B5KQpAQCAtNDAsNyArNDAsNyBAQCBjbGFzcyBRV0VCS0lUX0VYUE9SVCBRVG91Y2hXZWJQ YWdlIDogcHViCiAgICAgUV9QUk9QRVJUWShRU3RyaW5nIHRpdGxlIFJFQUQgdGl0bGUgTk9USUZZ IHRpdGxlQ2hhbmdlZCkKICAgICBRX1BST1BFUlRZKFFVcmwgdXJsIFJFQUQgdXJsIE5PVElGWSB1 cmxDaGFuZ2VkKQogICAgIFFfUFJPUEVSVFkoaW50IGxvYWRQcm9ncmVzcyBSRUFEIGxvYWRQcm9n cmVzcyBOT1RJRlkgbG9hZFByb2dyZXNzQ2hhbmdlZCkKLSAgICBRX1BST1BFUlRZKFFXZWJOYXZp Z2F0aW9uQ29udHJvbGxlciogbmF2aWdhdGlvbiBSRUFEIG5hdmlnYXRpb25Db250cm9sbGVyIENP TlNUQU5UKQorICAgIFFfUFJPUEVSVFkoUVdlYk5hdmlnYXRpb25Db250cm9sbGVyKiBuYXZpZ2F0 aW9uIFJFQUQgbmF2aWdhdGlvbkNvbnRyb2xsZXIgQ09OU1RBTlQgRklOQUwpCiAgICAgUV9FTlVN UyhFcnJvclR5cGUpCiBwdWJsaWM6CiAgICAgZW51bSBFcnJvclR5cGUgewpJbmRleDogU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xdG91Y2h3ZWJ2aWV3LmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xdG91Y2h3ZWJ2aWV3LmgJKHJldmlzaW9u IDk1NjE1KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xdG91Y2h3ZWJ2aWV3 LmgJKHdvcmtpbmcgY29weSkKQEAgLTM1LDcgKzM1LDcgQEAgY2xhc3MgVG91Y2hWaWV3SW50ZXJm YWNlOwogY2xhc3MgUVdFQktJVF9FWFBPUlQgUVRvdWNoV2ViVmlldyA6IHB1YmxpYyBRU0dJdGVt CiB7CiAgICAgUV9PQkpFQ1QKLSAgICBRX1BST1BFUlRZKFFUb3VjaFdlYlBhZ2UqIHBhZ2UgUkVB RCBwYWdlIENPTlNUQU5UKQorICAgIFFfUFJPUEVSVFkoUVRvdWNoV2ViUGFnZSogcGFnZSBSRUFE IHBhZ2UgQ09OU1RBTlQgRklOQUwpCiAKIHB1YmxpYzoKICAgICBRVG91Y2hXZWJWaWV3KFFTR0l0 ZW0qIHBhcmVudCA9IDApOwpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9x d2VibmF2aWdhdGlvbmNvbnRyb2xsZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL3F0L3F3ZWJuYXZpZ2F0aW9uY29udHJvbGxlci5oCShyZXZpc2lvbiA5NTYx NSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdlYm5hdmlnYXRpb25jb250 cm9sbGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTM1LDEwICszNSwxMCBAQCBjbGFzcyBRV2ViTmF2 aWdhdGlvbkNvbnRyb2xsZXJQcml2YXRlOwogCiBjbGFzcyBRV0VCS0lUX0VYUE9SVCBRV2ViTmF2 aWdhdGlvbkNvbnRyb2xsZXIgOiBwdWJsaWMgUU9iamVjdCB7CiAgICAgUV9PQkpFQ1QKLSAgICBR X1BST1BFUlRZKFFBY3Rpb24qIGJhY2tBY3Rpb24gUkVBRCBiYWNrQWN0aW9uIENPTlNUQU5UKQot ICAgIFFfUFJPUEVSVFkoUUFjdGlvbiogZm9yd2FyZEFjdGlvbiBSRUFEIGZvcndhcmRBY3Rpb24g Q09OU1RBTlQpCi0gICAgUV9QUk9QRVJUWShRQWN0aW9uKiBzdG9wQWN0aW9uIFJFQUQgc3RvcEFj dGlvbiBDT05TVEFOVCkKLSAgICBRX1BST1BFUlRZKFFBY3Rpb24qIHJlbG9hZEFjdGlvbiBSRUFE IHJlbG9hZEFjdGlvbiBDT05TVEFOVCkKKyAgICBRX1BST1BFUlRZKFFBY3Rpb24qIGJhY2tBY3Rp b24gUkVBRCBiYWNrQWN0aW9uIENPTlNUQU5UIEZJTkFMKQorICAgIFFfUFJPUEVSVFkoUUFjdGlv biogZm9yd2FyZEFjdGlvbiBSRUFEIGZvcndhcmRBY3Rpb24gQ09OU1RBTlQgRklOQUwpCisgICAg UV9QUk9QRVJUWShRQWN0aW9uKiBzdG9wQWN0aW9uIFJFQUQgc3RvcEFjdGlvbiBDT05TVEFOVCBG SU5BTCkKKyAgICBRX1BST1BFUlRZKFFBY3Rpb24qIHJlbG9hZEFjdGlvbiBSRUFEIHJlbG9hZEFj dGlvbiBDT05TVEFOVCBGSU5BTCkKIHB1YmxpYzoKICAgICBRV2ViTmF2aWdhdGlvbkNvbnRyb2xs ZXIoUXRXZWJQYWdlUHJveHkqKTsKICAgICB+UVdlYk5hdmlnYXRpb25Db250cm9sbGVyKCk7Cg==