68841 2011-09-26 15:29:51 -0700 garden-o-matic should not say "Just now" when it doesn't actually know when an event happened. 2011-10-02 10:19:00 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66960 1 dglazkov dglazkov abarth webkit.review.bot oldest_to_newest 473451 0 dglazkov 2011-09-26 15:29:51 -0700 garden-o-matic should not say "Just now" when it doesn't actually know when an event happened. 473453 1 108733 dglazkov 2011-09-26 15:31:01 -0700 Created attachment 108733 Patch 473592 2 108733 webkit.review.bot 2011-09-26 17:57:37 -0700 Comment on attachment 108733 Patch Rejecting attachment 108733 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: c2996de174d922d6b506c8fb68458303b6422244 r96054 = 8ee031caadb0321203e774bc8560b9100ca4f84b Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9883060 473616 3 108733 dglazkov 2011-09-26 18:29:40 -0700 Comment on attachment 108733 Patch Oh come on. It's good patch yes? Good patch! 473619 4 108733 webkit.review.bot 2011-09-26 18:36:16 -0700 Comment on attachment 108733 Patch Rejecting attachment 108733 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ns_unittests.js.rej patching file Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js Hunk #1 FAILED at 111. 1 out of 1 hunk FAILED -- saving rejects to file Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js.rej patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/9880108 476679 5 abarth 2011-10-02 10:19:00 -0700 I think dglazkov already landed this patch. 108733 2011-09-26 15:31:01 -0700 2011-09-26 18:36:16 -0700 Patch bug-68841-20110926153100.patch text/plain 6140 dglazkov U3VidmVyc2lvbiBSZXZpc2lvbjogOTYwMDIKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9z Y3JpcHRzL3VpLmpzIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1j b25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvdWkuanMKaW5kZXggOTJkNDNh MTkxZjg3YjM5Y2UxMDVjZjBjM2ViZDRhODVlZmQxNmU3NC4uZDY2Y2VmNzQxZGMxMjBlZmQwZmQ3 ZjFjYmZjMmRkMDI2YzczNDBhMiAxMDA2NDQKLS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv YnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMv dWkuanMKKysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25m aWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvdWkuanMKQEAgLTExNCw3ICsxMTQs NiBAQCBzZXRJbnRlcnZhbChmdW5jdGlvbigpIHsKIHVpLlJlbGF0aXZlVGltZSA9IGJhc2UuZXh0 ZW5kcygndGltZScsIHsKICAgICBpbml0OiBmdW5jdGlvbigpCiAgICAgewotICAgICAgICB0aGlz LnNldERhdGUobmV3IERhdGUoKSk7CiAgICAgICAgIHRoaXMuY2xhc3NOYW1lID0gJ3JlbGF0aXZl JzsKICAgICB9LAogICAgIGRhdGU6IGZ1bmN0aW9uKCkKQEAgLTEyMywxMiArMTIyLDEyIEBAIHVp LlJlbGF0aXZlVGltZSA9IGJhc2UuZXh0ZW5kcygndGltZScsIHsKICAgICB9LAogICAgIHVwZGF0 ZTogZnVuY3Rpb24oKQogICAgIHsKLSAgICAgICAgdGhpcy50ZXh0Q29udGVudCA9IGJhc2UucmVs YXRpdml6ZVRpbWUodGhpcy5fZGF0ZSk7CisgICAgICAgIHRoaXMudGV4dENvbnRlbnQgPSB0aGlz Ll9kYXRlID8gYmFzZS5yZWxhdGl2aXplVGltZSh0aGlzLl9kYXRlKSA6ICcnOwogICAgIH0sCiAg ICAgc2V0RGF0ZTogZnVuY3Rpb24oZGF0ZSkKICAgICB7CiAgICAgICAgIHRoaXMuX2RhdGUgPSBk YXRlOwotICAgICAgICB0aGlzLnRleHRDb250ZW50ID0gYmFzZS5yZWxhdGl2aXplVGltZShkYXRl KTsKKyAgICAgICAgdGhpcy51cGRhdGUoKTsKICAgICB9CiB9KTsKIApkaWZmIC0tZ2l0IGEvVG9v bHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwv VGVzdEZhaWx1cmVzL3NjcmlwdHMvdWkvbm90aWZpY2F0aW9uc191bml0dGVzdHMuanMgYi9Ub29s cy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9U ZXN0RmFpbHVyZXMvc2NyaXB0cy91aS9ub3RpZmljYXRpb25zX3VuaXR0ZXN0cy5qcwppbmRleCBm NTI5Yjk2MmYyZDQyYzgzNjRjMWFiZDQxMGRjMjc0OTc2ZDMyY2ViLi5kNjc3MTE1Yjc4YTk2Njg2 NWFmNzhiNjdhNDIwNmI2MWVmM2NiZWM2IDEwMDY0NAotLS0gYS9Ub29scy9CdWlsZFNsYXZlU3Vw cG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2Ny aXB0cy91aS9ub3RpZmljYXRpb25zX3VuaXR0ZXN0cy5qcworKysgYi9Ub29scy9CdWlsZFNsYXZl U3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMv c2NyaXB0cy91aS9ub3RpZmljYXRpb25zX3VuaXR0ZXN0cy5qcwpAQCAtMTAzLDcgKzEwMyw3IEBA IHRlc3QoJ0ZhaWxpbmdUZXN0c1N1bW1hcnknLCAxMiwgZnVuY3Rpb24oKSB7CiAgICAgZXF1YWwo dGVzdEZhaWx1cmVzLnRhZ05hbWUsICdMSScpOwogICAgIGVxdWFsKHRlc3RGYWlsdXJlcy5pbm5l ckhUTUwsCiAgICAgICAgICc8ZGl2IGNsYXNzPSJob3ciPicgKwotICAgICAgICAgICAgJzx0aW1l IGNsYXNzPSJyZWxhdGl2ZSI+SnVzdCBub3c8L3RpbWU+JyArCisgICAgICAgICAgICAnPHRpbWUg Y2xhc3M9InJlbGF0aXZlIj48L3RpbWU+JyArCiAgICAgICAgICAgICAnPHRhYmxlIGNsYXNzPSJm YWlsdXJlcyI+JyArCiAgICAgICAgICAgICAgICAgJzx0aGVhZD48dHI+PHRkPnR5cGU8L3RkPjx0 ZD5yZWxlYXNlPC90ZD48dGQ+ZGVidWc8L3RkPjwvdHI+PC90aGVhZD4nICsKICAgICAgICAgICAg ICAgICAnPHRib2R5Pjx0ciBjbGFzcz0iQlVJTERJTkciIHN0eWxlPSJkaXNwbGF5OiBub25lOyAi Pjx0ZD5CVUlMRElORzwvdGQ+PHRkPjwvdGQ+PHRkPjwvdGQ+PC90cj48L3Rib2R5PicgKwpAQCAt MTI0LDcgKzEyNCw3IEBAIHRlc3QoJ0ZhaWxpbmdUZXN0c1N1bW1hcnknLCAxMiwgZnVuY3Rpb24o KSB7CiAgICAgZXF1YWwodGVzdEZhaWx1cmVzLmluZGV4KCksIDApOwogICAgIGVxdWFsKHRlc3RG YWlsdXJlcy5pbm5lckhUTUwsCiAgICAgICAgICc8ZGl2IGNsYXNzPSJob3ciPicgKwotICAgICAg ICAgICAgJzx0aW1lIGNsYXNzPSJyZWxhdGl2ZSI+SnVzdCBub3c8L3RpbWU+JyArCisgICAgICAg ICAgICAnPHRpbWUgY2xhc3M9InJlbGF0aXZlIj48L3RpbWU+JyArCiAgICAgICAgICAgICAnPHRh YmxlIGNsYXNzPSJmYWlsdXJlcyI+JyArCiAgICAgICAgICAgICAgICAgJzx0aGVhZD48dHI+PHRk PnR5cGU8L3RkPjx0ZD5yZWxlYXNlPC90ZD48dGQ+ZGVidWc8L3RkPjwvdHI+PC90aGVhZD4nICsK ICAgICAgICAgICAgICAgICAnPHRib2R5Pjx0ciBjbGFzcz0iQlVJTERJTkciIHN0eWxlPSJkaXNw bGF5OiBub25lOyAiPjx0ZD5CVUlMRElORzwvdGQ+PHRkPjwvdGQ+PHRkPjwvdGQ+PC90cj48L3Ri b2R5PicgKwpAQCAtMTQ4LDcgKzE0OCw3IEBAIHRlc3QoJ0ZhaWxpbmdUZXN0c1N1bW1hcnknLCAx MiwgZnVuY3Rpb24oKSB7CiAgICAgdGVzdEZhaWx1cmVzLmFkZEZhaWx1cmVBbmFseXNpcyh7dGVz dE5hbWU6ICd0ZXN0J30pOwogICAgIGVxdWFsKHRlc3RGYWlsdXJlcy5pbm5lckhUTUwsCiAgICAg ICAgICc8ZGl2IGNsYXNzPSJob3ciPicgKwotICAgICAgICAgICAgJzx0aW1lIGNsYXNzPSJyZWxh dGl2ZSI+SnVzdCBub3c8L3RpbWU+JyArCisgICAgICAgICAgICAnPHRpbWUgY2xhc3M9InJlbGF0 aXZlIj48L3RpbWU+JyArCiAgICAgICAgICAgICAnPHRhYmxlIGNsYXNzPSJmYWlsdXJlcyI+JyAr CiAgICAgICAgICAgICAgICAgJzx0aGVhZD48dHI+PHRkPnR5cGU8L3RkPjx0ZD5yZWxlYXNlPC90 ZD48dGQ+ZGVidWc8L3RkPjwvdHI+PC90aGVhZD4nICsKICAgICAgICAgICAgICAgICAnPHRib2R5 Pjx0ciBjbGFzcz0iQlVJTERJTkciIHN0eWxlPSJkaXNwbGF5OiBub25lOyAiPjx0ZD5CVUlMRElO RzwvdGQ+PHRkPjwvdGQ+PHRkPjwvdGQ+PC90cj48L3Rib2R5PicgKwpAQCAtMzA5LDcgKzMwOSw3 IEBAIHRlc3QoJ0ZhaWxpbmdUZXN0c1N1bW1hcnkgKGdyb3VwaW5nKScsIDEsIGZ1bmN0aW9uKCkg ewogICAgIHRlc3RGYWlsdXJlcy5hZGRGYWlsdXJlQW5hbHlzaXMoe3Rlc3ROYW1lOiAncGF0aC9h bm90aGVyL3Rlc3QuaHRtbCcsIHJlc3VsdE5vZGVzQnlCdWlsZGVyOiB7fX0pOwogICAgIGVxdWFs KHRlc3RGYWlsdXJlcy5pbm5lckhUTUwsCiAgICAgICAgICc8ZGl2IGNsYXNzPSJob3ciPicgKwot ICAgICAgICAgICAgJzx0aW1lIGNsYXNzPSJyZWxhdGl2ZSI+SnVzdCBub3c8L3RpbWU+JyArCisg ICAgICAgICAgICAnPHRpbWUgY2xhc3M9InJlbGF0aXZlIj48L3RpbWU+JyArCiAgICAgICAgICAg ICAnPHRhYmxlIGNsYXNzPSJmYWlsdXJlcyI+JyArCiAgICAgICAgICAgICAgICAgJzx0aGVhZD48 dHI+PHRkPnR5cGU8L3RkPjx0ZD5yZWxlYXNlPC90ZD48dGQ+ZGVidWc8L3RkPjwvdHI+PC90aGVh ZD4nICsKICAgICAgICAgICAgICAgICAnPHRib2R5Pjx0ciBjbGFzcz0iQlVJTERJTkciIHN0eWxl PSJkaXNwbGF5OiBub25lOyAiPjx0ZD5CVUlMRElORzwvdGQ+PHRkPjwvdGQ+PHRkPjwvdGQ+PC90 cj48L3Rib2R5PicgKwpAQCAtMzM3LDcgKzMzNyw3IEBAIHRlc3QoJ0J1aWxkZXJzRmFpbGluZycs IDEsIGZ1bmN0aW9uKCkgewogICAgIGJ1aWxkZXJGYWlsaW5nLnNldEZhaWxpbmdCdWlsZGVycyhb J1dlYktpdCBMaW51eCcsICdXZWJraXQgVmlzdGEnXSk7CiAgICAgZXF1YWwoYnVpbGRlckZhaWxp bmcuaW5uZXJIVE1MLAogICAgICAgICAnPGRpdiBjbGFzcz0iaG93Ij4nICsKLSAgICAgICAgICAg ICc8dGltZSBjbGFzcz0icmVsYXRpdmUiPkp1c3Qgbm93PC90aW1lPicgKworICAgICAgICAgICAg Jzx0aW1lIGNsYXNzPSJyZWxhdGl2ZSI+PC90aW1lPicgKwogICAgICAgICAnPC9kaXY+JyArCiAg ICAgICAgICc8ZGl2IGNsYXNzPSJ3aGF0Ij4nICsKICAgICAgICAgICAgICc8ZGl2IGNsYXNzPSJw cm9ibGVtIj5CdWlsZCBGYWlsZWQ6JyArCmRpZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3Vw cG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2Ny aXB0cy91aV91bml0dGVzdHMuanMgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJr aXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy91aV91bml0dGVz dHMuanMKaW5kZXggZTM1OWIwY2U4NmVkNDk4YTM0YjJlY2IyOWJhMzY1ZmIyZWQ1OTlhMC4uMjFj N2Q5ZTI0ZTRiMWMyM2Y2ZWRmYzdkMjk1YmZmNzFiZDBkNDUyOCAxMDA2NDQKLS0tIGEvVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVz dEZhaWx1cmVzL3NjcmlwdHMvdWlfdW5pdHRlc3RzLmpzCisrKyBiL1Rvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9z Y3JpcHRzL3VpX3VuaXR0ZXN0cy5qcwpAQCAtMTExLDcgKzExMSw3IEBAIHRlc3QoInRpbWUiLCA2 LCBmdW5jdGlvbigpIHsKICAgICAgICAgJ3NldERhdGUnLAogICAgICAgICAndXBkYXRlJywKICAg ICBdKTsKLSAgICBlcXVhbCh0aW1lLm91dGVySFRNTCwgJzx0aW1lIGNsYXNzPSJyZWxhdGl2ZSI+ SnVzdCBub3c8L3RpbWU+Jyk7CisgICAgZXF1YWwodGltZS5vdXRlckhUTUwsICc8dGltZSBjbGFz cz0icmVsYXRpdmUiPjwvdGltZT4nKTsKICAgICB2YXIgdGVuTWludXRlc0FnbyA9IG5ldyBEYXRl KCk7CiAgICAgdGVuTWludXRlc0Fnby5zZXRNaW51dGVzKHRlbk1pbnV0ZXNBZ28uZ2V0TWludXRl cygpIC0gMTApOwogICAgIHRpbWUuc2V0RGF0ZSh0ZW5NaW51dGVzQWdvKTsKZGlmZiAtLWdpdCBh L1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmMmNlNWY3YjcxNWY5NzNl ZDJlNzk2ZWFiNTM4ZGRlNzg4MmU1ZDcxLi5iNzc4MmQ1OGE5MjE4OTM5ZWIzMTZhZDUxZWEyNTg1 ODgzZmVmMjc0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDktMjYgIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6 a292QGNocm9taXVtLm9yZz4KKworICAgICAgICBnYXJkZW4tby1tYXRpYyBzaG91bGQgbm90IHNh eSAiSnVzdCBub3ciIHdoZW4gaXQgZG9lc24ndCBhY3R1YWxseSBrbm93IHdoZW4gYW4gZXZlbnQg aGFwcGVuZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02ODg0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwv VGVzdEZhaWx1cmVzL3NjcmlwdHMvdWkuanM6IENoYW5nZWQgdWkuUmVsYXRpdmVUaW1lIHRvIG5v dCBpbml0aWFsaXplIHdpdGggY3VycmVudCB0aW1lLgorICAgICAgICAqIEJ1aWxkU2xhdmVTdXBw b3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3Jp cHRzL3VpL25vdGlmaWNhdGlvbnNfdW5pdHRlc3RzLmpzOiBBZGp1c3RlZCB1bml0IHRlc3RzLgor ICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1Ymxp Y19odG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRzL3VpX3VuaXR0ZXN0cy5qczogRGl0dG8uCisKIDIw MTEtMDktMjYgIE5heWFuIEt1bWFyIEsgIDxuYXlhbmtrQG1vdG9yb2xhLmNvbT4KIAogICAgICAg ICBHZXQgaG92ZXInZWQgZWxlbWVudCBVUkwgZnJvbSBIaXRUZXN0Lgo=