6884 2006-01-27 17:43:35 -0800 GC after destroying the very last frame to avoid node leak false positives 2006-01-27 21:24:44 -0800 1 1 1 Unclassified WebKit Frames 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 mjs mjs oldest_to_newest 30364 0 mjs 2006-01-27 17:43:35 -0800 The NodeImpl leak counter can give false positives sometimes if the GC after destroying the last ScriptInterpreter doesn't collect everything due to stack references. Thus, in debug mode, it would be good to do a GC from Page's destructor after destroying the last frame, so we're at a point on the stack where there wont be JS object references. 30365 1 6033 mjs 2006-01-27 17:45:19 -0800 Created attachment 6033 GC after destroying the very last Frame, from higher up on the stack 30367 2 6033 ggaren 2006-01-27 17:58:25 -0800 Comment on attachment 6033 GC after destroying the very last Frame, from higher up on the stack r=me I'm a little worried that we'll be finessing the garbage collector to avoid false leak reports in a lot more places. RenderObject comes to mind. 6033 2006-01-27 17:45:19 -0800 2006-01-27 17:58:25 -0800 GC after destroying the very last Frame, from higher up on the stack avoid-false-positives.patch.txt text/plain 1739 mjs SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEyNDIy KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDYtMDEt MjcgIE1hY2llaiBTdGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAtIEdDIGFmdGVyIGRlc3Ryb3lpbmcgdGhl IHZlcnkgbGFzdCBmcmFtZSB0byBhdm9pZCBub2RlIGxlYWsgZmFsc2UgcG9zaXRpdmVzCisgICAg ICAgIGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njg4NAor CisgICAgICAgICogRm9yd2FyZGluZ0hlYWRlcnMvSlNMb2NrLmg6IGFkZGVkCisgICAgICAgICog cGFnZS9QYWdlLmNwcDoKKyAgICAgICAgKFBhZ2U6On5QYWdlKTogSW4gZGVidWcgbW9kZSwgd2hl biBkZXN0cm95aW5nIHRoZSBsYXN0IHBhZ2UsCisgICAgICAgIDAgb3V0IG1fbWFpbkZyYW1lIHRv IGRlc3Ryb3kgdGhlIHZlcnkgbGFzdCBmcmFtZSBhbmQgdGhlbiBnYXJiYWdlIGNvbGxlY3QsCisg ICAgICAgIHNvIGEgR0MgaGFwcGVucyBhdCBhIHRpbWUgd2hlbiB0aGUgc3RhY2sgd29uJ3QgaGF2 ZSByZWZlcmVuY2VzIGludG8gdGhlIEpTCisgICAgICAgIGhlYXAgZm9yIHRoZSBjb25zZXJ2YXRp dmUgR0MgdG8gY2F0Y2guCisKIDIwMDYtMDEtMjcgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkZWxlLgpJbmRleDogRm9yd2FyZGluZ0hlYWRl cnMva2pzL0pTTG9jay5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEZvcndhcmRpbmdIZWFkZXJzL2tqcy9KU0xv Y2suaAkocmV2aXNpb24gMCkKKysrIEZvcndhcmRpbmdIZWFkZXJzL2tqcy9KU0xvY2suaAkocmV2 aXNpb24gMCkKQEAgLTAsMCArMSBAQAorI2ltcG9ydCA8SmF2YVNjcmlwdENvcmUvSlNMb2NrLmg+ CkluZGV4OiBwYWdlL1BhZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHBhZ2UvUGFnZS5jcHAJKHJldmlz aW9uIDEyNDA3KQorKysgcGFnZS9QYWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjEsNiArMjEs MTAgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJQYWdlLmgiCiAjaW5jbHVkZSAi RnJhbWUuaCIKKyNpbmNsdWRlIDxranMvY29sbGVjdG9yLmg+CisjaW5jbHVkZSA8a2pzL0pTTG9j ay5oPgorCit1c2luZyBuYW1lc3BhY2UgS0pTOwogCiBzdGF0aWMgaW50IHBhZ2VDb3VudDsKIApA QCAtMzMsNiArMzcsMTIgQEAgUGFnZTo6UGFnZShQYXNzUmVmUHRyPEZyYW1lPiBtYWluRnJhbWUp IAogUGFnZTo6flBhZ2UoKSAKIHsgCiAgICAgbV9tYWluRnJhbWUtPmRldGFjaEZyb21WaWV3KCk7 IAotICAgIGlmICghLS1wYWdlQ291bnQpCisgICAgaWYgKCEtLXBhZ2VDb3VudCkgewogICAgICAg ICBGcmFtZTo6ZW5kQWxsTGlmZVN1cHBvcnQoKTsKKyNpZm5kZWYgTkRFQlVHCisgICAgICAgIG1f bWFpbkZyYW1lID0gMDsKKyAgICAgICAgSlNMb2NrIGxvY2s7CisgICAgICAgIENvbGxlY3Rvcjo6 Y29sbGVjdCgpOworI2VuZGlmCisgICAgfQogfQo=