68838 2011-09-26 15:06:29 -0700 [chromium] Work around null render surface crash in updateCompositorResources 2011-09-26 16:03:34 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enne enne enne jamesr oldest_to_newest 473417 0 enne 2011-09-26 15:06:29 -0700 [chromium] Work around null render surface crash in updateCompositorResources 473421 1 108728 enne 2011-09-26 15:09:33 -0700 Created attachment 108728 Patch 473430 2 enne 2011-09-26 15:15:44 -0700 I plan to land this on the 874 branch. Bugzilla's not really equipped to make that obvious. An alternate approach would have been to clear m_updateList in setRootLayer, since this is the place where render surfaces are cleared. Or, since m_updateList is in use in paintLayers, mark some flag that it needed to be cleared, since it's in use in that function. However, I wanted something simple on the branch so it only had to be fixed once, so I just added a conditional check. 473435 3 108728 jamesr 2011-09-26 15:19:47 -0700 Comment on attachment 108728 Patch R=me for branch (not trunk) 473497 4 enne 2011-09-26 16:03:34 -0700 Committed manually on the 874 branch in: http://trac.webkit.org/changeset/96022. See also: http://code.google.com/p/chromium/issues/detail?id=96719 108728 2011-09-26 15:09:33 -0700 2011-09-26 15:19:47 -0700 Patch bug-68838-20110926150932.patch text/plain 1449 enne SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk2MDAwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDktMjYgIEFkcmllbm5l IFdhbGtlciAgPGVubmVAZ29vZ2xlLmNvbT4KKworICAgICAgICBbY2hyb21pdW1dIFdvcmsgYXJv dW5kIG51bGwgcmVuZGVyIHN1cmZhY2UgY3Jhc2ggaW4gdXBkYXRlQ29tcG9zaXRvclJlc291cmNl cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njg4MzgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpDQ0xheWVyVHJlZUhvc3Q6OnVwZGF0ZUNvbXBvc2l0b3JSZXNvdXJjZXMpOgorCiAy MDExLTA5LTIxICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgW2Nocm9taXVtXSBTaGFyZWRHcmFwaGljc0NvbnRleHQzRCdzIGNvbnRleHQgc2hvdWxkIG5v dCBiZSBkZXN0cm95ZWQgZHVyaW5nIGF0ZXhpdApJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0LmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJl ZUhvc3QuY3BwCShyZXZpc2lvbiA5NTk5MCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTM4OCw2ICszODgsOCBAQCB2b2lkIENDTGF5ZXJUcmVlSG9zdDo6dXBkYXRlQ29tcG9zaXRvclJl CiAgICAgICAgIExheWVyQ2hyb21pdW0qIHJlbmRlclN1cmZhY2VMYXllciA9IHJlbmRlclN1cmZh Y2VMYXllckxpc3Rbc3VyZmFjZUluZGV4XS5nZXQoKTsKICAgICAgICAgUmVuZGVyU3VyZmFjZUNo cm9taXVtKiByZW5kZXJTdXJmYWNlID0gcmVuZGVyU3VyZmFjZUxheWVyLT5yZW5kZXJTdXJmYWNl KCk7CiAgICAgICAgIEFTU0VSVChyZW5kZXJTdXJmYWNlKTsKKyAgICAgICAgaWYgKCFyZW5kZXJT dXJmYWNlKQorICAgICAgICAgICAgY29udGludWU7CiAKICAgICAgICAgaWYgKCFyZW5kZXJTdXJm YWNlLT5sYXllckxpc3QoKS5zaXplKCkgfHwgIXJlbmRlclN1cmZhY2UtPmRyYXdPcGFjaXR5KCkp CiAgICAgICAgICAgICBjb250aW51ZTsK