68837 2011-09-26 14:46:59 -0700 [GTK] Do not ignore 'Replaceable' attributes in the DOM bindings 2011-09-26 21:21:19 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 xan.lopez webkit-unassigned sam xan.lopez oldest_to_newest 473406 0 xan.lopez 2011-09-26 14:46:59 -0700 We are ignoring all attributes with this tag, but we shouldn't. Worst case they should be readable, which is what this patch does. In the future we should probably actually allow them to be replaced, with some kind of custom code. 473424 1 108729 xan.lopez 2011-09-26 15:10:52 -0700 Created attachment 108729 replaceable.diff 473427 2 108729 mrobinson 2011-09-26 15:13:31 -0700 Comment on attachment 108729 replaceable.diff Looks good. Better open abug for the the FIXME. 473447 3 108729 xan.lopez 2011-09-26 15:27:32 -0700 Comment on attachment 108729 replaceable.diff Clearing flags on attachment: 108729 Committed r96009: <http://trac.webkit.org/changeset/96009> 473448 4 xan.lopez 2011-09-26 15:27:38 -0700 All reviewed patches have been landed. Closing bug. 473670 5 sam 2011-09-26 21:21:19 -0700 Replaceable (as far as I can remember) is really is only there to support the fact that the DOMWindow is also the global object, so it probably doesn't makes sense outside of JavaScript. 108729 2011-09-26 15:10:52 -0700 2011-09-26 15:27:32 -0700 replaceable.diff replaceable.diff text/plain 3614 xan.lopez RnJvbSBiYjMxNzA5NDQwMjE1MWEyZjY4NDIyNDljOTg3NDY0MzZkNWQ4MDg2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhsb3BlekBpZ2FsaWEuY29tPgpEYXRlOiBU dWUsIDI3IFNlcCAyMDExIDAwOjA4OjE1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gMjAxMS0wOS0y NiAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CgogICAgICAgIFtHVEtdIERvIG5vdCBp Z25vcmUgJ1JlcGxhY2VhYmxlJyBhdHRyaWJ1dGVzIGluIHRoZSBET00gYmluZGluZ3MKICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njg4MzcKCiAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9D b2RlR2VuZXJhdG9yR09iamVjdC5wbTogYWRkIGdldHRlcnMgKGJ1dCBub3QKICAgICAgICBzZXR0 ZXJzKSBmb3IgJ1JlcGxhY2VhYmxlJyBhdHRyaWJ1dGVzLiBQdW50IGZvciB0aGUgZnV0dXJlCiAg ICAgICAgYWN0dWFsbHkgbWFraW5nIHRoZW0gc2V0dGFibGUsIHNpbmNlIGl0IHNlZW1zIG5vbiB0 cml2aWFsLgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAg ICAgICAgIHwgICAxMSArKysrKysrKysrKwogLi4uL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVy YXRvckdPYmplY3QucG0gICAgICAgfCAgIDE3ICsrKysrKysrKysrLS0tLS0tCiAyIGZpbGVzIGNo YW5nZWQsIDIyIGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDQ0 MmRhYjkuLjg1Y2I3YzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMS0wOS0yNiAg WGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gRG8gbm90IGln bm9yZSAnUmVwbGFjZWFibGUnIGF0dHJpYnV0ZXMgaW4gdGhlIERPTSBiaW5kaW5ncworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njg4MzcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJpbmRpbmdzL3Njcmlw dHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG06IGFkZCBnZXR0ZXJzIChidXQgbm90CisgICAgICAg IHNldHRlcnMpIGZvciAnUmVwbGFjZWFibGUnIGF0dHJpYnV0ZXMuIFB1bnQgZm9yIHRoZSBmdXR1 cmUKKyAgICAgICAgYWN0dWFsbHkgbWFraW5nIHRoZW0gc2V0dGFibGUsIHNpbmNlIGl0IHNlZW1z IG5vbiB0cml2aWFsLgorCiAyMDExLTA5LTI2ICBXLiBKYW1lcyBNYWNMZWFuICA8d2ptYWNsZWFu QGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIFJldmlzZSB6b29tIGFuaW1hdG9y IGJhY2tlbmQgdG8gdXNlIGZ1bGwgdHJhbnNmb3JtIGluc3RlYWQgb2YganVzdCBzY2FsZS4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdP YmplY3QucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JH T2JqZWN0LnBtCmluZGV4IDBhZjBiY2YuLjc0M2M5MDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG0KKysrIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbQpAQCAtMTU1 LDExICsxNTUsMTAgQEAgc3ViIFNraXBBdHRyaWJ1dGUgewogICAgIG15ICRhdHRyaWJ1dGUgPSBz aGlmdDsKICAgICAKICAgICBpZiAoJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJp YnV0ZXMtPnsiQ3VzdG9tR2V0dGVyIn0gfHwKLSAgICAgICAgJGF0dHJpYnV0ZS0+c2lnbmF0dXJl LT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiQ3VzdG9tU2V0dGVyIn0gfHwKLSAgICAgICAgJGF0dHJp YnV0ZS0+c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiUmVwbGFjZWFibGUifSkgewor ICAgICAgICAkYXR0cmlidXRlLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDdXN0 b21TZXR0ZXIifSkgewogICAgICAgICByZXR1cm4gMTsKICAgICB9Ci0gICAgCisKICAgICBteSAk cHJvcFR5cGUgPSAkYXR0cmlidXRlLT5zaWduYXR1cmUtPnR5cGU7CiAgICAgaWYgKCRwcm9wVHlw ZSA9fiAvQ29uc3RydWN0b3IkLykgewogICAgICAgICByZXR1cm4gMTsKQEAgLTMwNyw3ICszMDYs MTAgQEAgc3ViIEdldFdyaXRlYWJsZVByb3BlcnRpZXMgewogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgJGd0eXBlIGVxICJ1aW50NjQiIHx8ICRndHlwZSBlcSAidWxvbmciIHx8ICRn dHlwZSBlcSAibG9uZyIgfHwgCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAkZ3R5 cGUgZXEgInVpbnQiIHx8ICRndHlwZSBlcSAidXNob3J0IiB8fCAkZ3R5cGUgZXEgInVjaGFyIiB8 fAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJGd0eXBlIGVxICJjaGFyIiB8fCAk Z3R5cGUgZXEgInN0cmluZyIpOwotICAgICAgICBpZiAoJHdyaXRlYWJsZSAmJiAkaGFzR3R5cGVT aWduYXR1cmUpIHsKKyAgICAgICAgIyBGSVhNRTogV2UgYXJlIG5vdCBnZW5lcmF0aW5nIHNldHRl cnMgZm9yICdSZXBsYWNlYWJsZScKKyAgICAgICAgIyBhdHRyaWJ1dGVzIG5vdywgYnV0IHdlIHNo b3VsZCBzb21laG93LgorICAgICAgICBteSAkcmVwbGFjZWFibGUgPSAkcHJvcGVydHktPnNpZ25h dHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IlJlcGxhY2VhYmxlIn07CisgICAgICAgIGlmICgk d3JpdGVhYmxlICYmICRoYXNHdHlwZVNpZ25hdHVyZSAmJiAhJHJlcGxhY2VhYmxlKSB7CiAgICAg ICAgICAgICBwdXNoKEByZXN1bHQsICRwcm9wZXJ0eSk7CiAgICAgICAgIH0KICAgICB9CkBAIC0x MDM5LDggKzEwNDEsMTEgQEAgc3ViIEdlbmVyYXRlRnVuY3Rpb25zIHsKICAgICAgICAgJGZ1bmN0 aW9uLT5zaWduYXR1cmUoJGF0dHJpYnV0ZS0+c2lnbmF0dXJlKTsKICAgICAgICAgJGZ1bmN0aW9u LT5yYWlzZXNFeGNlcHRpb25zKCRhdHRyaWJ1dGUtPmdldHRlckV4Y2VwdGlvbnMpOwogICAgICAg ICAkb2JqZWN0LT5HZW5lcmF0ZUZ1bmN0aW9uKCRpbnRlcmZhY2VOYW1lLCAkZnVuY3Rpb24sICJn ZXRfIik7Ci0gICAgICAgIAotICAgICAgICBpZiAoJGF0dHJpYnV0ZS0+dHlwZSA9fiAvXnJlYWRv bmx5LykgeworCisgICAgICAgICMgRklYTUU6IFdlIGFyZSBub3QgZ2VuZXJhdGluZyBzZXR0ZXJz IGZvciAnUmVwbGFjZWFibGUnCisgICAgICAgICMgYXR0cmlidXRlcyBub3csIGJ1dCB3ZSBzaG91 bGQgc29tZWhvdy4KKyAgICAgICAgaWYgKCRhdHRyaWJ1dGUtPnR5cGUgPX4gL15yZWFkb25seS8g fHwKKyAgICAgICAgICAgICRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVz LT57IlJlcGxhY2VhYmxlIn0pIHsKICAgICAgICAgICAgIG5leHQgVE9QOwogICAgICAgICB9CiAg ICAgICAgIAotLSAKMS43LjYuR0lUCgo=