68819 2011-09-26 11:42:50 -0700 REGRESSION (r95926) Assert firing in svg/clip-path/clip-path-on-svg.svg 2011-09-26 13:07:23 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED LayoutTestFailure, Regression P1 Normal --- 1 mihaip mitz sam oldest_to_newest 473248 0 mihaip 2011-09-26 11:42:50 -0700 After this http://trac.webkit.org/changeset/95926/ the test crashes with: ASSERTION FAILED: !m_layoutRoot->container() || !m_layoutRoot->container()->needsLayout() Thread 0 Crashed: Dispatch queue: com.apple.main-thread 0 WebCore::FrameView::scheduleRelayoutOfSubtree(WebCore::RenderObject*) + 1045 (FrameView.cpp:1960) 1 WebCore::RenderObject::scheduleRelayout() + 127 (RenderObject.cpp:2312) 2 WebCore::RenderObject::markContainingBlocksForLayout(bool, WebCore::RenderObject*) + 945 (RenderObject.cpp:657) 3 WebCore::RenderObject::setNeedsLayout(bool, bool) + 170 (RenderObject.h:954) 4 WebCore::RenderSVGResourceContainer::markAllClientsForInvalidation(WebCore::RenderSVGResourceContainer::InvalidationMode) + 243 (RenderSVGResourceContainer.cpp:111) 5 WebCore::RenderSVGResourceClipper::removeAllClientsFromCache(bool) + 155 (RenderSVGResourceClipper.cpp:80) 6 WebCore::SVGResources::resourceDestroyed(WebCore::RenderSVGResourceContainer*) + 1332 (SVGResources.cpp:397) 7 WebCore::SVGResourcesCache::resourceDestroyed(WebCore::RenderSVGResourceContainer*) + 170 (SVGResourcesCache.cpp:169) 8 WebCore::RenderSVGResourceContainer::willBeDestroyed() + 21 (RenderSVGResourceContainer.cpp:62) 9 WebCore::RenderObject::destroy() + 34 (RenderObject.cpp:2206) 10 WebCore::Node::detach() + 71 (Node.cpp:1390) 11 WebCore::ContainerNode::detach() + 86 (ContainerNode.cpp:777) 12 WebCore::Element::detach() + 65 (Element.cpp:998) 13 WebCore::ContainerNode::detach() + 48 (ContainerNode.cpp:773) 14 WebCore::Element::detach() + 65 (Element.cpp:998) 15 WebCore::ContainerNode::detach() + 48 (ContainerNode.cpp:773) 16 WebCore::Element::detach() + 65 (Element.cpp:998) 17 WebCore::ContainerNode::detach() + 48 (ContainerNode.cpp:773) 18 WebCore::Document::detach() + 438 (Document.cpp:1867) 19 WebCore::Frame::setView(WTF::PassRefPtr<WebCore::FrameView>) + 221 (Frame.cpp:273) 20 WebFrameLoaderClient::transitionToCommittedForNewPage() + 812 (WebFrameLoaderClient.mm:1256) 21 WebCore::FrameLoader::transitionToCommitted(WTF::PassRefPtr<WebCore::CachedPage>) + 1255 (FrameLoader.cpp:1930) 22 WebCore::FrameLoader::commitProvisionalLoad() + 957 (FrameLoader.cpp:1781) 23 WebCore::DocumentLoader::commitIfReady() + 73 (DocumentLoader.cpp:276) 24 WebCore::DocumentLoader::commitLoad(char const*, int) + 58 (DocumentLoader.cpp:296) 25 WebCore::DocumentLoader::receivedData(char const*, int) + 78 (DocumentLoader.cpp:330) 26 WebCore::MainResourceLoader::addData(char const*, int, bool) + 66 (MainResourceLoader.cpp:169) 27 WebCore::ResourceLoader::didReceiveData(char const*, int, long long, bool) + 260 (ResourceLoader.cpp:285) 28 WebCore::MainResourceLoader::didReceiveData(char const*, int, long long, bool) + 686 (MainResourceLoader.cpp:458) 29 WebCore::ResourceLoader::didReceiveData(WebCore::ResourceHandle*, char const*, int, int) + 128 (ResourceLoader.cpp:436) 30 -[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:] + 282 (ResourceHandleMac.mm:833) 31 _NSURLConnectionDidReceiveData + 137 32 URLConnectionClient::_clientDidReceiveData(__CFData const*, URLConnectionClient::ClientConnectionEventQueue*) + 236 33 URLConnectionClient::ClientConnectionEventQueue::processAllEventsAndConsumePayload(XConnectionEventInfo<XClientEvent, Full crash log at http://build.webkit.org/results/SnowLeopard%20Intel%20Debug%20(Tests)/r95928%20(2310)/svg/clip-path/clip-path-on-svg-crash-log.txt 473265 1 mitz 2011-09-26 11:56:27 -0700 Note that AFAICT the assertion comes from teardown of the previous test, clip-path-objectBoundingBox.svg. 473274 2 108703 mitz 2011-09-26 12:03:05 -0700 Created attachment 108703 Revert to using view() in RenderObject::scheduleRelayout() 473320 3 108703 hyatt 2011-09-26 13:00:15 -0700 Comment on attachment 108703 Revert to using view() in RenderObject::scheduleRelayout() r=me 473327 4 mitz 2011-09-26 13:07:23 -0700 Fixed in <http://trac.webkit.org/r95985>. 108703 2011-09-26 12:03:05 -0700 2011-09-26 13:00:15 -0700 Revert to using view() in RenderObject::scheduleRelayout() bug-68819-20110926120306.patch text/plain 1590 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk1OTY3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDktMjYgIERhbiBCZXJu c3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyOTU5MjYpIEFz c2VydCBmaXJpbmcgaW4gc3ZnL2NsaXAtcGF0aC9jbGlwLXBhdGgtb24tc3ZnLnN2ZworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njg4MTkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5k ZXJPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyT2JqZWN0OjpzY2hlZHVsZVJl bGF5b3V0KTogUmV2ZXJ0IHRvIHVzaW5nIHZpZXcoKSBpbnN0ZWFkIG9mIHRoZSBSZW5kZXJWaWV3 KioKKyAgICAgICAgcGFyYW1ldGVyIG9mIGlzUm9vdGVkLCBzaW5jZSBvbmx5IHRoZSBmb3JtZXIg cmV0dXJucyAwIHdoZW4gdGhlIGRvY3VtZW50IGlzIGRldGFjaGVkLgorCiAyMDExLTA5LTIzICBT aW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJlcGFpbnQg dGVzdHMgZG9uJ3Qgd29yayBpbiBXZWJLaXQyCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyT2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyT2JqZWN0LmNwcAkocmV2aXNpb24gOTU5NjMpCisrKyBTb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjMwOCwxMCArMjMw OCwxMSBAQCB2b2lkIFJlbmRlck9iamVjdDo6c2NoZWR1bGVSZWxheW91dCgpCiAgICAgICAgIGlm ICh2aWV3KQogICAgICAgICAgICAgdmlldy0+c2NoZWR1bGVSZWxheW91dCgpOwogICAgIH0gZWxz ZSB7Ci0gICAgICAgIFJlbmRlclZpZXcqIHJlbmRlclZpZXc7Ci0gICAgICAgIGlmIChpc1Jvb3Rl ZCgmcmVuZGVyVmlldykpIHsKLSAgICAgICAgICAgIGlmIChGcmFtZVZpZXcqIGZyYW1lVmlldyA9 IHJlbmRlclZpZXctPmZyYW1lVmlldygpKQotICAgICAgICAgICAgICAgIGZyYW1lVmlldy0+c2No ZWR1bGVSZWxheW91dE9mU3VidHJlZSh0aGlzKTsKKyAgICAgICAgaWYgKGlzUm9vdGVkKCkpIHsK KyAgICAgICAgICAgIGlmIChSZW5kZXJWaWV3KiByZW5kZXJWaWV3ID0gdmlldygpKSB7CisgICAg ICAgICAgICAgICAgaWYgKEZyYW1lVmlldyogZnJhbWVWaWV3ID0gcmVuZGVyVmlldy0+ZnJhbWVW aWV3KCkpCisgICAgICAgICAgICAgICAgICAgIGZyYW1lVmlldy0+c2NoZWR1bGVSZWxheW91dE9m U3VidHJlZSh0aGlzKTsKKyAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgIH0KIH0K