68815 2011-09-26 10:49:36 -0700 fast/dom/scroll-element-to-rect.html fails on WK1 Mac port 2011-10-03 11:42:21 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa simon.fraser andersca dglazkov sam simon.fraser varunjain oldest_to_newest 473201 0 rniwa 2011-09-26 10:49:36 -0700 The following tests added by http://trac.webkit.org/changeset/95890 are failing on Mac WK1 port: fast/dom/scroll-element-to-rect.html fast/dom/scroll-element-to-rect-centered.html 475081 1 simon.fraser 2011-09-28 16:49:03 -0700 I think this is broken in WK1 because Element::boundsInWindowSpace() returns rect in flipped coordinates in WK1. "in window space" is not something that should be used in WebCore code much. 475082 2 simon.fraser 2011-09-28 16:50:42 -0700 Actually FrameView::scrollElementToRect() should not be using 'boundsInWindowSpace'. I think getRect() would work just fine. 475102 3 109099 simon.fraser 2011-09-28 17:14:20 -0700 Created attachment 109099 Patch 475125 4 simon.fraser 2011-09-28 17:44:39 -0700 http://trac.webkit.org/changeset/96278 477111 5 varunjain 2011-10-03 11:42:21 -0700 (In reply to comment #4) > http://trac.webkit.org/changeset/96278 Thanks Simon! for fixing this Apologies for the delay as I could not get hold of a machine to repro the failure in time :( 109099 2011-09-28 17:14:20 -0700 2011-09-28 17:16:23 -0700 Patch bug-68815-20110928171418.patch text/plain 4792 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogOTYyMzUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwYTViMjY2OGIwNmRiNjU1MzVjYTNh OTVkMzRkMWNkOTU1YTFkMWZjLi5mOTliNGQ5OTY5MWQzODM4M2RhNDdkOGNlYjlmZGIzNDc1Nzlj NTY0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDktMjggIFNpbW9uIEZyYXNlciAgPHNp bW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgZmFzdC9kb20vc2Nyb2xsLWVsZW1lbnQt dG8tcmVjdC5odG1sIGZhaWxzIG9uIFdLMSBNYWMgcG9ydAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njg4MTUKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIEZpeCB0aGVzZSB0ZXN0cyB0byBub3Qg dGhyb3cgZXJyb3JzIHdoZW4gd2luZG93LmludGVybmFscyBpcyBub3QgYXZhaWxhYmxlLgorCisg ICAgICAgICogZmFzdC9kb20vc2Nyb2xsLWVsZW1lbnQtdG8tcmVjdC1jZW50ZXJlZC5odG1sOgor ICAgICAgICAqIGZhc3QvZG9tL3Njcm9sbC1lbGVtZW50LXRvLXJlY3QuaHRtbDoKKwogMjAxMS0w OS0yOCAgS2F1c3R1YmggQXRyYXdhbGthciAgPGthdXN0dWJoQG1vdG9yb2xhLmNvbT4KIAogICAg ICAgICBbR3RrXSBJbXBsZW1lbnQgdGV4dElucHV0Q29udHJvbGxlci5kb0NvbW1hbmQKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL3Njcm9sbC1lbGVtZW50LXRvLXJlY3QtY2VudGVy ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL3Njcm9sbC1lbGVtZW50LXRvLXJlY3QtY2Vu dGVyZWQuaHRtbAppbmRleCA1YzVkZjgyYWRmN2UxYWJiNWU0NzczYTgwZjFlNTI4ZmJlODhhZGI4 Li42MTQ2NGVmN2U4MTgwMDFmNzFlNzAxYjZiZWIyYTM5YjM3YmRjNWMzIDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9mYXN0L2RvbS9zY3JvbGwtZWxlbWVudC10by1yZWN0LWNlbnRlcmVkLmh0bWwK KysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2Nyb2xsLWVsZW1lbnQtdG8tcmVjdC1jZW50ZXJl ZC5odG1sCkBAIC05LDEwICs5LDEwIEBACiAgICAgPC9ib2R5PgogICAgIDxzY3JpcHQgc3JjPSIu Li9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgogICAgIDxzY3JpcHQ+Ci0g ICAgICBpZiAod2luZG93LmludGVybmFscykgewotICAgICAgICB2YXIgYm94ID0gZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoJ3RleHRib3gnKTsKKyAgICAgIHZhciBib3ggPSBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgndGV4dGJveCcpOworICAgICAgaWYgKHdpbmRvdy5pbnRlcm5hbHMpCiAgICAg ICAgIHdpbmRvdy5pbnRlcm5hbHMuc2Nyb2xsRWxlbWVudFRvUmVjdChib3gsIDUwLCAzMCwgMjAw LCAyNTApOwotICAgICAgfQorCiAgICAgICB2YXIgcmVjdCA9IGJveC5nZXRCb3VuZGluZ0NsaWVu dFJlY3QoKTsKICAgICAgIHZhciBjb21wdXRlZExlZnQgPSA1MCArIE1hdGguZmxvb3IoKDIwMCAt IHJlY3Qud2lkdGgpIC8gMik7CiAgICAgICB2YXIgY29tcHV0ZWRUb3AgPSAzMCArIE1hdGguZmxv b3IoKDI1MCAtIHJlY3QuaGVpZ2h0KSAvIDIpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9kb20vc2Nyb2xsLWVsZW1lbnQtdG8tcmVjdC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20v c2Nyb2xsLWVsZW1lbnQtdG8tcmVjdC5odG1sCmluZGV4IDc3NjIzYmFlNjg1ODI2Njg2MWZkOTFm MjAxZjRiYzMxY2YyZDVjMWQuLmE3ZTA1ZTViZjUzMDY4Y2ZhMTllMDZiMGJlZTA0MmFjNTM4YzQ0 YTIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL3Njcm9sbC1lbGVtZW50LXRvLXJl Y3QuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zY3JvbGwtZWxlbWVudC10by1yZWN0 Lmh0bWwKQEAgLTgsMTAgKzgsMTAgQEAKICAgICA8L2JvZHk+CiAgICAgPHNjcmlwdCBzcmM9Ii4u L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+CiAgICAgPHNjcmlwdD4KLSAg ICAgIGlmICh3aW5kb3cuaW50ZXJuYWxzKSB7Ci0gICAgICAgIHZhciBib3ggPSBkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgndGV4dGJveCcpOworCSAgdmFyIGJveCA9IGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCd0ZXh0Ym94Jyk7CisgICAgICBpZiAod2luZG93LmludGVybmFscykKICAgICAgICAg d2luZG93LmludGVybmFscy5zY3JvbGxFbGVtZW50VG9SZWN0KGJveCwgMCwgMCwgMzAwLCAzMDAp OwotICAgICAgfQorCiAgICAgICB2YXIgcmVjdCA9IGJveC5nZXRCb3VuZGluZ0NsaWVudFJlY3Qo KTsKICAgICAgIHZhciBjb21wdXRlZExlZnQgPSBNYXRoLmZsb29yKCgzMDAgLSByZWN0LndpZHRo KSAvIDIpOwogICAgICAgdmFyIGNvbXB1dGVkVG9wID0gTWF0aC5mbG9vcigoMzAwIC0gcmVjdC5o ZWlnaHQpIC8gMik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGRlM2IxOTI3ZWUxMDZhNTBhYWQ0YTE0ZjBmZTcx MDM1NzVlYjc1ZS4uODRkMGM3YTJhNTQxNWYwYWRhMWU5OWI4NmQyOGYzMzExODFmZmVhYyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDExLTA5LTI4ICBTaW1vbiBGcmFzZXIgIDxzaW1v bi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIGZhc3QvZG9tL3Njcm9sbC1lbGVtZW50LXRv LXJlY3QuaHRtbCBmYWlscyBvbiBXSzEgTWFjIHBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4ODE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBGcmFtZVZpZXc6OnNjcm9sbEVsZW1lbnRU b1JlY3QoKSB3YXMgaW5jb3JyZWN0bHkgdXNpbmcgRWxlbWVudDo6Ym91bmRzSW5XaW5kb3dTcGFj ZSgpLAorICAgICAgICB3aGljaCBpcyB3aW5kb3ctcmVsYXRpdmUgKG5vdCB3ZWIgdmlldy1yZWxh dGl2ZSksIGFuZCBoYXMgZmxpcHBlZCBjb29yZGluYXRlcworICAgICAgICBpbiBXZWJLaXQxLgor ICAgICAgICAKKyAgICAgICAgQ2hhbmdlIHRvIHVzZSBOb2RlOjpnZXRSZWN0KCkgd2hpY2ggaXMg d2hhdCB0aGUgYXV0aG9yIGludGVuZGVkLgorCisgICAgICAgICogZG9tL0VsZW1lbnQuaDoKKyAg ICAgICAgKiBwYWdlL0ZyYW1lVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6 OnNjcm9sbEVsZW1lbnRUb1JlY3QpOgorCiAyMDExLTA5LTI4ICBGYWR5IFNhbXVlbCAgPGZzYW11 ZWxAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gU2VwZXJhdGUgR1RLIHNwZWNp ZmljIEd5cCBydWxlcyBmcm9tIFgxMSBHeXAgcnVsZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2RvbS9FbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCmluZGV4IGQy YTg3NmZjYzc0MWM3N2Q3MGE0MmZiMTQ2ODUxYTYzYTY5ODk3YmIuLjMyZDNlZDYyNDVkZmY4OGI3 OWY0ZDdjMWI1ODBjNjI3MDZiNmExMjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9F bGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaApAQCAtMTY2LDYgKzE2 Niw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGludCBzY3JvbGxXaWR0aCgpOwogICAgIHZpcnR1 YWwgaW50IHNjcm9sbEhlaWdodCgpOwogCisgICAgLy8gTm90ZSB0aGF0IHRoZSAnd2luZG93IHNw YWNlJyBoYXMgYSBmbGlwcGVkIGNvb3JkaW5hdGUgc3lzdGVtIG9uIHNvbWUgcGxhdGZvcm1zLgog ICAgIExheW91dFJlY3QgYm91bmRzSW5XaW5kb3dTcGFjZSgpOwogCiAgICAgUGFzc1JlZlB0cjxD bGllbnRSZWN0TGlzdD4gZ2V0Q2xpZW50UmVjdHMoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BhZ2UvRnJhbWVWaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNw cAppbmRleCA2YzdjNjU4ZGFhZjgxZmI3Y2E1ZTdhYjA0OTZjOWVmZjZjYmQ4MTA4Li5kMTIzMzE4 MWEyYWY1N2IzNThmMWQyNjE3YzRlOGEyM2UxMzQ5ODczIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZp ZXcuY3BwCkBAIC0xNjM4LDcgKzE2MzgsNyBAQCB2b2lkIEZyYW1lVmlldzo6c2Nyb2xsRWxlbWVu dFRvUmVjdChFbGVtZW50KiBlbGVtZW50LCBjb25zdCBJbnRSZWN0JiByZWN0KQogewogICAgIG1f ZnJhbWUtPmRvY3VtZW50KCktPnVwZGF0ZUxheW91dElnbm9yZVBlbmRpbmdTdHlsZXNoZWV0cygp OwogCi0gICAgTGF5b3V0UmVjdCBib3VuZHMgPSBlbGVtZW50LT5ib3VuZHNJbldpbmRvd1NwYWNl KCk7CisgICAgTGF5b3V0UmVjdCBib3VuZHMgPSBlbGVtZW50LT5nZXRSZWN0KCk7CiAgICAgaW50 IGNlbnRlcmluZ09mZnNldFggPSAocmVjdC53aWR0aCgpIC0gYm91bmRzLndpZHRoKCkpIC8gMjsK ICAgICBpbnQgY2VudGVyaW5nT2Zmc2V0WSA9IChyZWN0LmhlaWdodCgpIC0gYm91bmRzLmhlaWdo dCgpKSAvIDI7CiAgICAgc2Nyb2xsQnkoSW50U2l6ZShib3VuZHMueCgpIC0gY2VudGVyaW5nT2Zm c2V0WCAtIHJlY3QueCgpLCBib3VuZHMueSgpIC0gY2VudGVyaW5nT2Zmc2V0WSAtIHJlY3QueSgp KSk7Cg==