68809 2011-09-26 09:40:27 -0700 IconDatabase::syncThreadMainLoop can assert if wakeSyncThread is called before thread starts executing 2011-09-26 10:35:25 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Regression P2 Normal --- 1 mrowe mrowe aroben dino mitz simon.fraser oldest_to_newest 473148 0 mrowe 2011-09-26 09:40:27 -0700 As in summary. This is a regression from r95929 / bug 68783. 473151 1 108679 mrowe 2011-09-26 09:42:43 -0700 Created attachment 108679 Untested patch This is an untested patch that I believe will address the issue. I’m putting it up as it may be a few hours before I’m able to test the patch, and it may be useful for anyone being troubled by the assertion. 473161 2 108683 mrowe 2011-09-26 10:03:22 -0700 Created attachment 108683 Patch v1 Dan says that this addressed the issue for him, so I’m putting it up for review. 473187 3 mrowe 2011-09-26 10:35:25 -0700 Fixed in r95961. 108679 2011-09-26 09:42:43 -0700 2011-09-26 10:03:22 -0700 Untested patch bug-68809-v0.patch text/plain 874 mrowe ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9pY29uL0ljb25EYXRhYmFzZS5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvaWNvbi9JY29uRGF0YWJhc2UuY3BwCmluZGV4IDVlZTZm OTAuLmU4NjMwNTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9pY29uL0ljb25E YXRhYmFzZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2ljb24vSWNvbkRhdGFiYXNl LmNwcApAQCAtMTM1Nyw2ICsxMzU3LDEwIEBAIHZvaWQqIEljb25EYXRhYmFzZTo6c3luY1RocmVh ZE1haW5Mb29wKCkKICAgICBib29sIHNob3VsZFJlZW5hYmxlU3VkZGVuVGVybWluYXRpb24gPSBt X2Rpc2FibGVkU3VkZGVuVGVybWluYXRpb25Gb3JTeW5jVGhyZWFkOwogICAgIG1fZGlzYWJsZWRT dWRkZW5UZXJtaW5hdGlvbkZvclN5bmNUaHJlYWQgPSBmYWxzZTsKIAorICAgIC8vIFdlJ2xsIGVp dGhlciBkbyBhbnkgcGVuZGluZyB3b3JrIG9uIG91ciBmaXJzdCBwYXNzIHRocm91Z2ggdGhlIGxv b3AsIG9yIHdlJ2xsIHRlcm1pbmF0ZQorICAgIC8vIHdpdGhvdXQgZG9pbmcgYW55IHdvcmsuIEVp dGhlciB3YXkgd2UncmUgZGVhbGluZyB3aXRoIGFueSBjdXJyZW50bHktcGVuZGluZyB3b3JrLgor ICAgIG1fc3luY1RocmVhZEhhc1dvcmtUb0RvID0gZmFsc2U7CisKICAgICAvLyBJdCdzIHBvc3Np YmxlIHRocmVhZCB0ZXJtaW5hdGlvbiBpcyByZXF1ZXN0ZWQgYmVmb3JlIHRoZSBtYWluIGxvb3Ag ZXZlbiBzdGFydHMgLSBpbiB0aGF0IGNhc2UsIGp1c3Qgc2tpcCBzdHJhaWdodCB0byBjbGVhbnVw CiAgICAgd2hpbGUgKCFtX3RocmVhZFRlcm1pbmF0aW9uUmVxdWVzdGVkKSB7CiAgICAgICAgIG1f c3luY0xvY2sudW5sb2NrKCk7Cg== 108683 2011-09-26 10:03:22 -0700 2011-09-26 10:04:17 -0700 Patch v1 0001-http-webkit.org-b-68809-IconDatabase-syncThreadMainL.patch text/plain 3199 mrowe RnJvbSBiNjQxNzNlOGE5NTZhNzk1OGJmNmYwMWM0OTZhM2NmOTRmMGQ3OGFiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJrIFJvd2UgPG1yb3dlQGFwcGxlLmNvbT4KRGF0ZTogTW9u LCAyNiBTZXAgMjAxMSAxMDowMTo1NSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIDxodHRwOi8vd2Vi a2l0Lm9yZy9iLzY4ODA5PiBJY29uRGF0YWJhc2U6OnN5bmNUaHJlYWRNYWluTG9vcAogY2FuIGFz c2VydCBpZiB3YWtlU3luY1RocmVhZCBpcyBjYWxsZWQgYmVmb3JlIHRocmVhZCBzdGFydHMKIGV4 ZWN1dGluZwoKSWYgd2FrZVN5bmNUaHJlYWQgaXMgY2FsbGVkIGJlZm9yZSBzeW5jVGhyZWFkTWFp bkxvb3Agc3RhcnRzIGV4ZWN1dGluZyB0aGVuIG1fc3luY1RocmVhZEhhc1dvcmtUb0RvIHdvdWxk IGJlIHNldAp3aGlsZSBleGVjdXRpbmcgdGhlIGJvZHkgb2YgdGhlIHN5bmMgdGhyZWFkIGxvb3As IGNhdXNpbmcgdXMgdG8gc2tpcCBibG9ja2luZyBvbiB0aGUgY29uZGl0aW9uIHZhcmlhYmxlLiBU aGlzIHdvdWxkCmxlYWQgdG8gdXMgaGl0dGluZyB0aGUgYXNzZXJ0aW9uIGZhaWx1cmUgZHVlIHRv IG1fZGlzYWJsZWRTdWRkZW5UZXJtaW5hdGlvbkZvclN5bmNUaHJlYWQgYmVpbmcgZmFsc2UsIHVu bGVzcyB0aGUgbWFpbgp0aHJlYWQgaGFwcGVuZWQgdG8gY2FsbCB3YWtlU3luY1RocmVhZCBhIHNl Y29uZCB0aW1lIHdoaWxlIHRoZSBmaXJzdCBsb29wIGl0ZXJhdGlvbiB3YXMgZXhlY3V0aW5nLgoK UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgoqIGxvYWRlci9pY29uL0ljb25EYXRhYmFzZS5j cHA6CihXZWJDb3JlOjpJY29uRGF0YWJhc2U6OnN5bmNUaHJlYWRNYWluTG9vcCk6IENsZWFyIG1f c3luY1RocmVhZEhhc1dvcmtUb0RvIHRvIGluZGljYXRlIHRoYXQgd2UncmUgYWJvdXQgdG8gcGVy Zm9ybQphbGwgcGVuZGluZyB3b3JrLgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAg ICAgICAgICAgICAgICAgfCAgIDE1ICsrKysrKysrKysrKysrKwogU291cmNlL1dlYkNvcmUvbG9h ZGVyL2ljb24vSWNvbkRhdGFiYXNlLmNwcCB8ICAgIDQgKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAx OSBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhNzczODUyLi5m YTEyODdjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDktMjYgIE1hcmsgUm93 ZSAgPG1yb3dlQGFwcGxlLmNvbT4KKworICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi82ODgw OT4gSWNvbkRhdGFiYXNlOjpzeW5jVGhyZWFkTWFpbkxvb3AgY2FuIGFzc2VydCBpZiB3YWtlU3lu Y1RocmVhZCBpcyBjYWxsZWQgYmVmb3JlIHRocmVhZCBzdGFydHMgZXhlY3V0aW5nCisKKyAgICAg ICAgSWYgd2FrZVN5bmNUaHJlYWQgaXMgY2FsbGVkIGJlZm9yZSBzeW5jVGhyZWFkTWFpbkxvb3Ag c3RhcnRzIGV4ZWN1dGluZyB0aGVuIG1fc3luY1RocmVhZEhhc1dvcmtUb0RvIHdvdWxkIGJlIHNl dAorICAgICAgICB3aGlsZSBleGVjdXRpbmcgdGhlIGJvZHkgb2YgdGhlIHN5bmMgdGhyZWFkIGxv b3AsIGNhdXNpbmcgdXMgdG8gc2tpcCBibG9ja2luZyBvbiB0aGUgY29uZGl0aW9uIHZhcmlhYmxl LiBUaGlzIHdvdWxkCisgICAgICAgIGxlYWQgdG8gdXMgaGl0dGluZyB0aGUgYXNzZXJ0aW9uIGZh aWx1cmUgZHVlIHRvIG1fZGlzYWJsZWRTdWRkZW5UZXJtaW5hdGlvbkZvclN5bmNUaHJlYWQgYmVp bmcgZmFsc2UsIHVubGVzcyB0aGUgbWFpbgorICAgICAgICB0aHJlYWQgaGFwcGVuZWQgdG8gY2Fs bCB3YWtlU3luY1RocmVhZCBhIHNlY29uZCB0aW1lIHdoaWxlIHRoZSBmaXJzdCBsb29wIGl0ZXJh dGlvbiB3YXMgZXhlY3V0aW5nLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogbG9hZGVyL2ljb24vSWNvbkRhdGFiYXNlLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6Okljb25EYXRhYmFzZTo6c3luY1RocmVhZE1haW5Mb29wKTogQ2xlYXIgbV9zeW5jVGhy ZWFkSGFzV29ya1RvRG8gdG8gaW5kaWNhdGUgdGhhdCB3ZSdyZSBhYm91dCB0byBwZXJmb3JtCisg ICAgICAgIGFsbCBwZW5kaW5nIHdvcmsuCisKIDIwMTEtMDktMjUgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBGaW5pc2ggcmVtb3ZpbmcgUExBVEZPUk0oQlJFV01Q KSBieSByZW1vdmluZyBhc3NvY2lhdGVkIGNvZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2xvYWRlci9pY29uL0ljb25EYXRhYmFzZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvaWNv bi9JY29uRGF0YWJhc2UuY3BwCmluZGV4IDVlZTZmOTAuLmU4NjMwNTUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9pY29uL0ljb25EYXRhYmFzZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvbG9hZGVyL2ljb24vSWNvbkRhdGFiYXNlLmNwcApAQCAtMTM1Nyw2ICsxMzU3LDEwIEBA IHZvaWQqIEljb25EYXRhYmFzZTo6c3luY1RocmVhZE1haW5Mb29wKCkKICAgICBib29sIHNob3Vs ZFJlZW5hYmxlU3VkZGVuVGVybWluYXRpb24gPSBtX2Rpc2FibGVkU3VkZGVuVGVybWluYXRpb25G b3JTeW5jVGhyZWFkOwogICAgIG1fZGlzYWJsZWRTdWRkZW5UZXJtaW5hdGlvbkZvclN5bmNUaHJl YWQgPSBmYWxzZTsKIAorICAgIC8vIFdlJ2xsIGVpdGhlciBkbyBhbnkgcGVuZGluZyB3b3JrIG9u IG91ciBmaXJzdCBwYXNzIHRocm91Z2ggdGhlIGxvb3AsIG9yIHdlJ2xsIHRlcm1pbmF0ZQorICAg IC8vIHdpdGhvdXQgZG9pbmcgYW55IHdvcmsuIEVpdGhlciB3YXkgd2UncmUgZGVhbGluZyB3aXRo IGFueSBjdXJyZW50bHktcGVuZGluZyB3b3JrLgorICAgIG1fc3luY1RocmVhZEhhc1dvcmtUb0Rv ID0gZmFsc2U7CisKICAgICAvLyBJdCdzIHBvc3NpYmxlIHRocmVhZCB0ZXJtaW5hdGlvbiBpcyBy ZXF1ZXN0ZWQgYmVmb3JlIHRoZSBtYWluIGxvb3AgZXZlbiBzdGFydHMgLSBpbiB0aGF0IGNhc2Us IGp1c3Qgc2tpcCBzdHJhaWdodCB0byBjbGVhbnVwCiAgICAgd2hpbGUgKCFtX3RocmVhZFRlcm1p bmF0aW9uUmVxdWVzdGVkKSB7CiAgICAgICAgIG1fc3luY0xvY2sudW5sb2NrKCk7Ci0tIAoxLjcu Ny5yYzEKCg==