68807 2011-09-26 09:08:09 -0700 [skia] need rebaseline after the next skia roll -- improvements to xfermodes on gpu 2011-09-26 15:20:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 reed reed jamesr kbr senorblanco webkit.review.bot oldest_to_newest 473130 0 reed 2011-09-26 09:08:09 -0700 [skia] need rebaseline after the next skia roll -- improvedments to xfermodes on gpu 473131 1 108674 reed 2011-09-26 09:08:49 -0700 Created attachment 108674 Patch 473140 2 108674 jamesr 2011-09-26 09:30:43 -0700 Comment on attachment 108674 Patch They only need a rebaseline on linux? What about mac or windows? If they only need a rebaseline in GPU mode, you can add the 'GPU' modifier. 473158 3 108682 reed 2011-09-26 09:58:37 -0700 Created attachment 108682 Patch 473159 4 reed 2011-09-26 09:59:06 -0700 updated expectations to specify GPU 473354 5 jamesr 2011-09-26 13:53:28 -0700 This says GPU but I still have no idea why this would be linux-specific. Mind explaining that? 473365 6 108682 senorblanco 2011-09-26 14:02:47 -0700 Comment on attachment 108682 Patch Looks good. r=me 473367 7 senorblanco 2011-09-26 14:03:57 -0700 Sorry, didn't see James's comments until I r+'ed it. Well, I leave it up to your discretion. If you break it, you bought it. :) 473377 8 reed 2011-09-26 14:16:16 -0700 I ran DRT locally on windows and linux, and only saw the problem on linux. I can be more conservative next time, and just say GPU. 473385 9 jamesr 2011-09-26 14:25:38 -0700 (In reply to comment #8) > I ran DRT locally on windows and linux, and only saw the problem on linux. I can be more conservative next time, and just say GPU. OK, that's fine. There's no way for me to know that you had done that unless you let me know somehow, or say so in the ChangeLog. 473389 10 reed 2011-09-26 14:32:52 -0700 I wouldn't have know which ones to rebaseline, if I hadn't run locally. That said, it is odd that I didn't see any failures when I ran on Windows. Who knows, I may have just screwed up and missed them (gulp). 473407 11 jamesr 2011-09-26 14:50:31 -0700 ¯\(°_o)/¯ let's see what the bots says, then. 473436 12 108682 webkit.review.bot 2011-09-26 15:20:11 -0700 Comment on attachment 108682 Patch Clearing flags on attachment: 108682 Committed r96006: <http://trac.webkit.org/changeset/96006> 473437 13 webkit.review.bot 2011-09-26 15:20:16 -0700 All reviewed patches have been landed. Closing bug. 108674 2011-09-26 09:08:49 -0700 2011-09-26 09:58:32 -0700 Patch bug-68807-20110926120848.patch text/plain 1469 reed SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDk1OTU1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDktMjYgIE1pa2UgUmVlZCAgPHJlZWRA Z29vZ2xlLmNvbT4KKworICAgICAgICBbc2tpYV0gbmVlZCByZWJhc2VsaW5lIGFmdGVyIHRoZSBu ZXh0IHNraWEgcm9sbCAtLSBpbXByb3ZlbWVudHMgdG8geGZlcm1vZGVzIG9uIGdwdQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njg4MDcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9t aXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dDoKKwogMjAxMS0wOS0yNiAgWnNvbHQgRmVow6lyICA8 ZmVoZXJ6c0BpbmYudS1zemVnZWQuaHU+CiAKICAgICAgICAgVW5yZXZpZXdlZCBRdCBnYXJkZW5p bmcuCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9u cy50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9l eHBlY3RhdGlvbnMudHh0CShyZXZpc2lvbiA5NTkzNykKKysrIExheW91dFRlc3RzL3BsYXRmb3Jt L2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMjI3Myw2 ICsyMjczLDExIEBAIEJVR1dLNDY5NTEgOiBmYXN0L3VybC9zZWdtZW50cy5odG1sID0gVEUKIC8v IHJlYmFzZWxpbmUgYWZ0ZXIgc2tpYSByZXYuIDIyOTUgbGFuZHMKIEJVR19SRUVEIExJTlVYIFdJ TiBTTk9XTEVPUEFSRCA6IHN2Zy9XM0MtU1ZHLTEuMS9wc2VydmVycy1ncmFkLTE0LWIuc3ZnID0g SU1BR0UKIAorLy8gcmViYXNlbGluZSBhZnRlciBza2lhIHJldi4gMjMzMCBsYW5kcworQlVHX1JF RUQgTElOVVggOiBmYXN0L2NhbnZhcy9jYW52YXMtY29tcG9zaXRlLXRyYW5zZm9ybWNsaXAuaHRt bCA9IElNQUdFCitCVUdfUkVFRCBMSU5VWCA6IGZhc3QvY2FudmFzL2NhbnZhcy1jb21wb3NpdGUu aHRtbCA9IElNQUdFCitCVUdfUkVFRCBMSU5VWCA6IGZhc3QvY2FudmFzL2NhbnZhcy10cmFuc2Zv cm1zLWR1cmluZy1wYXRoLmh0bWwgPSBJTUFHRQorCiAvLyBVbmV4cGVjdGVkIHRpbWVvdXQgaW4g dGhlc2UgdGVzdHMuCiBCVUdfSENMQU0gOiBodHRwL3Rlc3RzL2Nzcy9ib3JkZXItaW1hZ2UtbG9h ZGluZy5odG1sID0gUEFTUyBUSU1FT1VUIFRFWFQKIEJVR19IQ0xBTSA6IGh0dHAvdGVzdHMvY3Nz L2Nzcy1pbWFnZS1sb2FkaW5nLmh0bWwgPSBQQVNTIFRJTUVPVVQgVEVYVAo= 108682 2011-09-26 09:58:37 -0700 2011-09-26 15:20:11 -0700 Patch bug-68807-20110926125835.patch text/plain 1481 reed SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDk1OTU1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDktMjYgIE1pa2UgUmVlZCAgPHJlZWRA Z29vZ2xlLmNvbT4KKworICAgICAgICBbc2tpYV0gbmVlZCByZWJhc2VsaW5lIGFmdGVyIHRoZSBu ZXh0IHNraWEgcm9sbCAtLSBpbXByb3ZlbWVudHMgdG8geGZlcm1vZGVzIG9uIGdwdQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njg4MDcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9t aXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dDoKKwogMjAxMS0wOS0yNiAgWnNvbHQgRmVow6lyICA8 ZmVoZXJ6c0BpbmYudS1zemVnZWQuaHU+CiAKICAgICAgICAgVW5yZXZpZXdlZCBRdCBnYXJkZW5p bmcuCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9u cy50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9l eHBlY3RhdGlvbnMudHh0CShyZXZpc2lvbiA5NTkzNykKKysrIExheW91dFRlc3RzL3BsYXRmb3Jt L2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMjI3Myw2 ICsyMjczLDExIEBAIEJVR1dLNDY5NTEgOiBmYXN0L3VybC9zZWdtZW50cy5odG1sID0gVEUKIC8v IHJlYmFzZWxpbmUgYWZ0ZXIgc2tpYSByZXYuIDIyOTUgbGFuZHMKIEJVR19SRUVEIExJTlVYIFdJ TiBTTk9XTEVPUEFSRCA6IHN2Zy9XM0MtU1ZHLTEuMS9wc2VydmVycy1ncmFkLTE0LWIuc3ZnID0g SU1BR0UKIAorLy8gcmViYXNlbGluZSBhZnRlciBza2lhIHJldi4gMjMzMCBsYW5kcworQlVHX1JF RUQgTElOVVggR1BVIDogZmFzdC9jYW52YXMvY2FudmFzLWNvbXBvc2l0ZS10cmFuc2Zvcm1jbGlw Lmh0bWwgPSBJTUFHRQorQlVHX1JFRUQgTElOVVggR1BVIDogZmFzdC9jYW52YXMvY2FudmFzLWNv bXBvc2l0ZS5odG1sID0gSU1BR0UKK0JVR19SRUVEIExJTlVYIEdQVSA6IGZhc3QvY2FudmFzL2Nh bnZhcy10cmFuc2Zvcm1zLWR1cmluZy1wYXRoLmh0bWwgPSBJTUFHRQorCiAvLyBVbmV4cGVjdGVk IHRpbWVvdXQgaW4gdGhlc2UgdGVzdHMuCiBCVUdfSENMQU0gOiBodHRwL3Rlc3RzL2Nzcy9ib3Jk ZXItaW1hZ2UtbG9hZGluZy5odG1sID0gUEFTUyBUSU1FT1VUIFRFWFQKIEJVR19IQ0xBTSA6IGh0 dHAvdGVzdHMvY3NzL2Nzcy1pbWFnZS1sb2FkaW5nLmh0bWwgPSBQQVNTIFRJTUVPVVQgVEVYVAo=