<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>68786</bug_id>
          
          <creation_ts>2011-09-25 19:49:50 -0700</creation_ts>
          <short_desc>DFG support for op_resolve_global is not enabled</short_desc>
          <delta_ts>2011-09-25 20:35:51 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Filip Pizlo">fpizlo</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>fpizlo</cc>
    
    <cc>oliver</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>472951</commentid>
    <comment_count>0</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2011-09-25 19:49:50 -0700</bug_when>
    <thetext>Support for the op_resolve_global opcode was added to the DFG, but code that uses it is still not DFG compiled because op_resolve_global was not added to DFGCapabilities.h.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>472952</commentid>
    <comment_count>1</comment_count>
      <attachid>108622</attachid>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2011-09-25 19:56:49 -0700</bug_when>
    <thetext>Created attachment 108622
the patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>472953</commentid>
    <comment_count>2</comment_count>
      <attachid>108623</attachid>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2011-09-25 20:00:41 -0700</bug_when>
    <thetext>Created attachment 108623
the patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>472955</commentid>
    <comment_count>3</comment_count>
      <attachid>108623</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2011-09-25 20:09:20 -0700</bug_when>
    <thetext>Comment on attachment 108623
the patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>472962</commentid>
    <comment_count>4</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2011-09-25 20:35:51 -0700</bug_when>
    <thetext>Landed in r95932.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>108622</attachid>
            <date>2011-09-25 19:56:49 -0700</date>
            <delta_ts>2011-09-25 20:00:41 -0700</delta_ts>
            <desc>the patch</desc>
            <filename>globalvarprofile_patch_1.diff</filename>
            <type>text/plain</type>
            <size>3740</size>
            <attacher name="Filip Pizlo">fpizlo</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTUxNzMpCisrKyBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAK
KzIwMTEtMDktMTQgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBW
YWx1ZSBwcm9maWxlcyBjb2xsZWN0IG5vIGluZm9ybWF0aW9uIGZvciBnbG9iYWwgdmFyaWFibGVz
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODE0Mwor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAg
MTclIHNwZWVkLXVwIG9uIHN0cmluZy1mYXN0YS4gIE5ldXRyYWwgZWxzZXdoZXJlLgorCisgICAg
ICAgICogZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpCeXRl
Q29kZVBhcnNlcjo6Z2V0U3Ryb25nUHJlZGljdGlvbik6CisgICAgICAgIChKU0M6OkRGRzo6Qnl0
ZUNvZGVQYXJzZXI6OnN0cm9uZ2x5UHJlZGljdCk6CisgICAgICAgIChKU0M6OkRGRzo6Qnl0ZUNv
ZGVQYXJzZXI6OnBhcnNlQmxvY2spOgorICAgICAgICAqIGppdC9KSVRQcm9wZXJ0eUFjY2Vzcy5j
cHA6CisgICAgICAgIChKU0M6OkpJVDo6ZW1pdF9vcF9nZXRfZ2xvYmFsX3Zhcik6CisKIDIwMTEt
MDktMTQgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBERkcgZG9l
cyBub3Qgc3BlY3VsYXRlIGFnZ3Jlc3NpdmVseSBlbm91Z2ggb24gY29tcGFyaXNvbnMKSW5kZXg6
IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwCj09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwCShy
ZXZpc2lvbiA5NTE3MykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQ
YXJzZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NzQsMjEgKzQ3NCwyOSBAQCBwcml2YXRlOgog
ICAgICAgICB9IHdoaWxlICghbV9yZXVzYWJsZU5vZGVTdGFjay5pc0VtcHR5KCkpOwogICAgIH0K
ICAgICAKLSAgICB2b2lkIHN0cm9uZ2x5UHJlZGljdChOb2RlSW5kZXggbm9kZUluZGV4LCB1bnNp
Z25lZCBieXRlY29kZUluZGV4KQorICAgIFByZWRpY3RlZFR5cGUgZ2V0U3Ryb25nUHJlZGljdGlv
bihOb2RlSW5kZXggbm9kZUluZGV4LCB1bnNpZ25lZCBieXRlY29kZUluZGV4KQogICAgIHsKKyAg
ICAgICAgVU5VU0VEX1BBUkFNKG5vZGVJbmRleCk7CisgICAgICAgIFVOVVNFRF9QQVJBTShieXRl
Y29kZUluZGV4KTsKKyAgICAgICAgCiAjaWYgRU5BQkxFKERZTkFNSUNfT1BUSU1JWkFUSU9OKQog
ICAgICAgICBWYWx1ZVByb2ZpbGUqIHByb2ZpbGUgPSBtX3Byb2ZpbGVkQmxvY2stPnZhbHVlUHJv
ZmlsZUZvckJ5dGVjb2RlT2Zmc2V0KGJ5dGVjb2RlSW5kZXgpOwogICAgICAgICBBU1NFUlQocHJv
ZmlsZSk7Ci0gICAgICAgIG1fZ3JhcGhbbm9kZUluZGV4XS5wcmVkaWN0KHByb2ZpbGUtPmNvbXB1
dGVVcGRhdGVkUHJlZGljdGlvbigpICYgflByZWRpY3Rpb25UYWdNYXNrLCBTdHJvbmdQcmVkaWN0
aW9uKTsKKyAgICAgICAgUHJlZGljdGVkVHlwZSBwcmVkaWN0aW9uID0gcHJvZmlsZS0+Y29tcHV0
ZVVwZGF0ZWRQcmVkaWN0aW9uKCk7CiAjaWYgRU5BQkxFKERGR19ERUJVR19WRVJCT1NFKQotICAg
ICAgICBwcmludGYoIkR5bmFtaWMgWyV1LCAldV0gcHJlZGljdGlvbjogJXNcbiIsIG5vZGVJbmRl
eCwgYnl0ZWNvZGVJbmRleCwgcHJlZGljdGlvblRvU3RyaW5nKG1fZ3JhcGhbbm9kZUluZGV4XS5n
ZXRQcmVkaWN0aW9uKCkpKTsKKyAgICAgICAgcHJpbnRmKCJEeW5hbWljIFsldSwgJXVdIHByZWRp
Y3Rpb246ICVzXG4iLCBub2RlSW5kZXgsIGJ5dGVjb2RlSW5kZXgsIHByZWRpY3Rpb25Ub1N0cmlu
ZyhwcmVkaWN0aW9uKSk7CiAjZW5kaWYKKyAgICAgICAgcmV0dXJuIHByZWRpY3Rpb247CiAjZWxz
ZQotICAgICAgICBVTlVTRURfUEFSQU0obm9kZUluZGV4KTsKLSAgICAgICAgVU5VU0VEX1BBUkFN
KGJ5dGVjb2RlSW5kZXgpOworICAgICAgICByZXR1cm4gUHJlZGljdE5vbmU7CiAjZW5kaWYKICAg
ICB9CiAgICAgCisgICAgdm9pZCBzdHJvbmdseVByZWRpY3QoTm9kZUluZGV4IG5vZGVJbmRleCwg
dW5zaWduZWQgYnl0ZWNvZGVJbmRleCkKKyAgICB7CisgICAgICAgIG1fZ3JhcGhbbm9kZUluZGV4
XS5wcmVkaWN0KGdldFN0cm9uZ1ByZWRpY3Rpb24obm9kZUluZGV4LCBieXRlY29kZUluZGV4KSAm
IH5QcmVkaWN0aW9uVGFnTWFzaywgU3Ryb25nUHJlZGljdGlvbik7CisgICAgfQorICAgIAogICAg
IHZvaWQgc3Ryb25nbHlQcmVkaWN0KE5vZGVJbmRleCBub2RlSW5kZXgpCiAgICAgewogICAgICAg
ICBzdHJvbmdseVByZWRpY3Qobm9kZUluZGV4LCBtX2N1cnJlbnRJbmRleCk7CkBAIC05ODgsNiAr
OTk2LDcgQEAgYm9vbCBCeXRlQ29kZVBhcnNlcjo6cGFyc2VCbG9jayh1bnNpZ25lZAogICAgICAg
ICBjYXNlIG9wX2dldF9nbG9iYWxfdmFyOiB7CiAgICAgICAgICAgICBOb2RlSW5kZXggZ2V0R2xv
YmFsVmFyID0gYWRkVG9HcmFwaChHZXRHbG9iYWxWYXIsIE9wSW5mbyhjdXJyZW50SW5zdHJ1Y3Rp
b25bMl0udS5vcGVyYW5kKSk7CiAgICAgICAgICAgICBzZXQoY3VycmVudEluc3RydWN0aW9uWzFd
LnUub3BlcmFuZCwgZ2V0R2xvYmFsVmFyKTsKKyAgICAgICAgICAgIG1fZ3JhcGgucHJlZGljdEds
b2JhbFZhcihjdXJyZW50SW5zdHJ1Y3Rpb25bMl0udS5vcGVyYW5kLCBnZXRTdHJvbmdQcmVkaWN0
aW9uKGdldEdsb2JhbFZhciwgbV9jdXJyZW50SW5kZXgpICYgflByZWRpY3Rpb25UYWdNYXNrLCBT
dHJvbmdQcmVkaWN0aW9uKTsKICAgICAgICAgICAgIE5FWFRfT1BDT0RFKG9wX2dldF9nbG9iYWxf
dmFyKTsKICAgICAgICAgfQogCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFBy
b3BlcnR5QWNjZXNzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0
L0pJVFByb3BlcnR5QWNjZXNzLmNwcAkocmV2aXNpb24gOTUxNzMpCisrKyBTb3VyY2UvSmF2YVNj
cmlwdENvcmUvaml0L0pJVFByb3BlcnR5QWNjZXNzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTAw
NCw2ICsxMDA0LDcgQEAgdm9pZCBKSVQ6OmVtaXRfb3BfZ2V0X2dsb2JhbF92YXIoSW5zdHJ1Ywog
ICAgIEpTVmFyaWFibGVPYmplY3QqIGdsb2JhbE9iamVjdCA9IG1fY29kZUJsb2NrLT5nbG9iYWxP
YmplY3QoKTsKICAgICBsb2FkUHRyKCZnbG9iYWxPYmplY3QtPm1fcmVnaXN0ZXJzLCByZWdUMCk7
CiAgICAgbG9hZFB0cihBZGRyZXNzKHJlZ1QwLCBjdXJyZW50SW5zdHJ1Y3Rpb25bMl0udS5vcGVy
YW5kICogc2l6ZW9mKFJlZ2lzdGVyKSksIHJlZ1QwKTsKKyAgICBlbWl0VmFsdWVQcm9maWxpbmdT
aXRlKEZpcnN0UHJvZmlsaW5nU2l0ZSk7CiAgICAgZW1pdFB1dFZpcnR1YWxSZWdpc3RlcihjdXJy
ZW50SW5zdHJ1Y3Rpb25bMV0udS5vcGVyYW5kKTsKIH0KIAo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>108623</attachid>
            <date>2011-09-25 20:00:41 -0700</date>
            <delta_ts>2011-09-25 20:09:20 -0700</delta_ts>
            <desc>the patch</desc>
            <filename>resolveglobal_patch_1.diff</filename>
            <type>text/plain</type>
            <size>1113</size>
            <attacher name="Filip Pizlo">fpizlo</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTU5MzApCisrKyBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAK
KzIwMTEtMDktMjUgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBE
Rkcgc3VwcG9ydCBmb3Igb3BfcmVzb2x2ZV9nbG9iYWwgaXMgbm90IGVuYWJsZWQKKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4Nzg2CisKKyAgICAgICAg
UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkZmcvREZHQ2FwYWJpbGl0
aWVzLmg6CisgICAgICAgIChKU0M6OkRGRzo6Y2FuQ29tcGlsZU9wY29kZSk6CisKIDIwMTEtMDkt
MjUgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBERkcgc3RhdGlj
IHByZWRpY3Rpb24gY29kZSBpcyBubyBsb25nZXIgbmVlZGVkIGFuZCBzaG91bGQgYmUgcmVtb3Zl
ZApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdDYXBhYmlsaXRpZXMuaAo9PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0NhcGFiaWxpdGllcy5oCShy
ZXZpc2lvbiA5NTkzMCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ2FwYWJpbGl0
aWVzLmgJKHdvcmtpbmcgY29weSkKQEAgLTExOCw2ICsxMTgsNyBAQCBpbmxpbmUgYm9vbCBjYW5D
b21waWxlT3Bjb2RlKE9wY29kZUlEIG9wCiAgICAgY2FzZSBvcF9jYWxsX3B1dF9yZXN1bHQ6CiAg
ICAgY2FzZSBvcF9yZXNvbHZlOgogICAgIGNhc2Ugb3BfcmVzb2x2ZV9iYXNlOgorICAgIGNhc2Ug
b3BfcmVzb2x2ZV9nbG9iYWw6CiAgICAgY2FzZSBvcF9zdHJjYXQ6CiAgICAgY2FzZSBvcF90b19w
cmltaXRpdmU6CiAgICAgY2FzZSBvcF90aHJvdzoK
</data>
<flag name="review"
          id="105635"
          type_id="1"
          status="+"
          setter="ggaren"
    />
          </attachment>
      

    </bug>

</bugzilla>