<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>68785</bug_id>
          
          <creation_ts>2011-09-25 19:44:36 -0700</creation_ts>
          <short_desc>DFG JIT does not count speculation successes correctly</short_desc>
          <delta_ts>2011-09-25 21:05:00 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Filip Pizlo">fpizlo</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>fpizlo</cc>
    
    <cc>oliver</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>472949</commentid>
    <comment_count>0</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2011-09-25 19:44:36 -0700</bug_when>
    <thetext>Speculation successes are counted in the code block entry code, which is skipped in the case of function code.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>472950</commentid>
    <comment_count>1</comment_count>
      <attachid>108621</attachid>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2011-09-25 19:46:08 -0700</bug_when>
    <thetext>Created attachment 108621
the patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>472954</commentid>
    <comment_count>2</comment_count>
      <attachid>108621</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2011-09-25 20:08:40 -0700</bug_when>
    <thetext>Comment on attachment 108621
the patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>472963</commentid>
    <comment_count>3</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2011-09-25 21:05:00 -0700</bug_when>
    <thetext>Landed in r95933.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>108621</attachid>
            <date>2011-09-25 19:46:08 -0700</date>
            <delta_ts>2011-09-25 20:08:40 -0700</delta_ts>
            <desc>the patch</desc>
            <filename>goodspeccount_patch_1.diff</filename>
            <type>text/plain</type>
            <size>2729</size>
            <attacher name="Filip Pizlo">fpizlo</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTU5MzApCisrKyBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAK
KzIwMTEtMDktMjUgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBE
RkcgSklUIGRvZXMgbm90IGNvdW50IHNwZWN1bGF0aW9uIHN1Y2Nlc3NlcyBjb3JyZWN0bHkKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4Nzg1CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkZmcvREZHSklU
Q29tcGlsZXIuY3BwOgorICAgICAgICAoSlNDOjpERkc6OkpJVENvbXBpbGVyOjpjb21waWxlRW50
cnkpOgorICAgICAgICAoSlNDOjpERkc6OkpJVENvbXBpbGVyOjpjb21waWxlQm9keSk6CisgICAg
ICAgICogZGZnL0RGR09wZXJhdGlvbnMuY3BwOgorCiAyMDExLTA5LTI1ICBGaWxpcCBQaXpsbyAg
PGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgREZHIHN0YXRpYyBwcmVkaWN0aW9uIGNvZGUg
aXMgbm8gbG9uZ2VyIG5lZWRlZCBhbmQgc2hvdWxkIGJlIHJlbW92ZWQKSW5kZXg6IFNvdXJjZS9K
YXZhU2NyaXB0Q29yZS9kZmcvREZHSklUQ29tcGlsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj
ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSklUQ29tcGlsZXIuY3BwCShyZXZpc2lvbiA5NTkzMCkK
KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSklUQ29tcGlsZXIuY3BwCSh3b3JraW5n
IGNvcHkpCkBAIC01MjYsOCArNTI2LDYgQEAgdm9pZCBKSVRDb21waWxlcjo6Y29tcGlsZUVudHJ5
KCkKICAgICAvLyBib3RoIG5vcm1hbCByZXR1cm4gY29kZSBhbmQgd2hlbiBqdW1waW5nIHRvIGFu
IGV4Y2VwdGlvbiBoYW5kbGVyKS4KICAgICBwcmVzZXJ2ZVJldHVybkFkZHJlc3NBZnRlckNhbGwo
R1BSSW5mbzo6cmVnVDIpOwogICAgIGVtaXRQdXRUb0NhbGxGcmFtZUhlYWRlcihHUFJJbmZvOjpy
ZWdUMiwgUmVnaXN0ZXJGaWxlOjpSZXR1cm5QQyk7Ci0gICAgCi0gICAgYWRkUHRyKEltbTMyKDEp
LCBBYnNvbHV0ZUFkZHJlc3MoY29kZUJsb2NrKCktPmFkZHJlc3NPZlNwZWN1bGF0aXZlU3VjY2Vz
c0NvdW50ZXIoKSkpOwogfQogCiB2b2lkIEpJVENvbXBpbGVyOjpjb21waWxlQm9keSgpCkBAIC01
MzksNiArNTM3LDggQEAgdm9pZCBKSVRDb21waWxlcjo6Y29tcGlsZUJvZHkoKQogICAgIC8vIEhh
bmR5IGRlYnVnIHRvb2whCiAgICAgYnJlYWtwb2ludCgpOwogI2VuZGlmCisgICAgCisgICAgYWRk
UHRyKEltbTMyKDEpLCBBYnNvbHV0ZUFkZHJlc3MoY29kZUJsb2NrKCktPmFkZHJlc3NPZlNwZWN1
bGF0aXZlU3VjY2Vzc0NvdW50ZXIoKSkpOwogCiAgICAgTGFiZWwgc3BlY3VsYXRpdmVQYXRoQmVn
aW4gPSBsYWJlbCgpOwogICAgIFNwZWN1bGF0aXZlSklUIHNwZWN1bGF0aXZlKCp0aGlzKTsKSW5k
ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT3BlcmF0aW9ucy5jcHAKPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVyYXRpb25zLmNwcAkocmV2aXNp
b24gOTU5MzApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMuY3Bw
CSh3b3JraW5nIGNvcHkpCkBAIC04MTUsNyArODE1LDggQEAgUmVnaXN0ZXJTaXplZEJvb2xlYW4g
ZGZnQ29udmVydEpTVmFsdWVUbwogdm9pZCBkZWJ1Z09wZXJhdGlvblByaW50U3BlY3VsYXRpb25G
YWlsdXJlKEV4ZWNTdGF0ZSosIHZvaWQqIGRlYnVnSW5mb1JhdykKIHsKICAgICBTcGVjdWxhdGlv
bkZhaWx1cmVEZWJ1Z0luZm8qIGRlYnVnSW5mbyA9IHN0YXRpY19jYXN0PFNwZWN1bGF0aW9uRmFp
bHVyZURlYnVnSW5mbyo+KGRlYnVnSW5mb1Jhdyk7Ci0gICAgcHJpbnRmKCJTcGVjdWxhdGlvbiBm
YWlsdXJlIGluICVwIGF0IDB4JXghXG4iLCBkZWJ1Z0luZm8tPmNvZGVCbG9jaywgZGVidWdJbmZv
LT5kZWJ1Z09mZnNldCk7CisgICAgQ29kZUJsb2NrKiBjb2RlQmxvY2sgPSBkZWJ1Z0luZm8tPmNv
ZGVCbG9jazsKKyAgICBwcmludGYoIlNwZWN1bGF0aW9uIGZhaWx1cmUgaW4gJXAgYXQgMHgleCB3
aXRoIGV4ZWN1dGVDb3VudGVyID0gJWQsIHJlb3B0aW1pemF0aW9uUmV0cnlDb3VudGVyID0gJXUs
IG9wdGltaXphdGlvbkRlbGF5Q291bnRlciA9ICV1LCBzdWNjZXNzL2ZhaWwgJXUvJXVcbiIsIGNv
ZGVCbG9jaywgZGVidWdJbmZvLT5kZWJ1Z09mZnNldCwgY29kZUJsb2NrLT5hbHRlcm5hdGl2ZSgp
LT5leGVjdXRlQ291bnRlcigpLCBjb2RlQmxvY2stPmFsdGVybmF0aXZlKCktPnJlb3B0aW1pemF0
aW9uUmV0cnlDb3VudGVyKCksIGNvZGVCbG9jay0+YWx0ZXJuYXRpdmUoKS0+b3B0aW1pemF0aW9u
RGVsYXlDb3VudGVyKCksIGNvZGVCbG9jay0+c3BlY3VsYXRpdmVTdWNjZXNzQ291bnRlcigpLCBj
b2RlQmxvY2stPnNwZWN1bGF0aXZlRmFpbENvdW50ZXIoKSk7CiB9CiAjZW5kaWYKIAo=
</data>
<flag name="review"
          id="105632"
          type_id="1"
          status="+"
          setter="ggaren"
    />
          </attachment>
      

    </bug>

</bugzilla>