68781 2011-09-25 15:44:37 -0700 DFG tracking of the value in cachedResultRegister does not handle op_mov correctly 2011-09-25 16:40:17 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo webkit-unassigned fpizlo oliver oldest_to_newest 472913 0 fpizlo 2011-09-25 15:44:37 -0700 The old JIT implementation of op_mov does not handle the cachedResultRegister the same way as other operations. The DFG's tracking does not take this into account. 472915 1 108613 fpizlo 2011-09-25 16:11:04 -0700 Created attachment 108613 the patch 472923 2 fpizlo 2011-09-25 16:40:17 -0700 Landed in r95925. 108613 2011-09-25 16:11:04 -0700 2011-09-25 16:30:28 -0700 the patch fixopmov_patch_1.diff text/plain 3810 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTU5MjQpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAK KzIwMTEtMDktMjUgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBE RkcgdHJhY2tpbmcgb2YgdGhlIHZhbHVlIGluIGNhY2hlZFJlc3VsdFJlZ2lzdGVyIGRvZXMgbm90 IGhhbmRsZQorICAgICAgICBvcF9tb3YgY29ycmVjdGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODc4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgVGhpcyB0YWtlcyB0aGUgc2ltcGxlc3Qg YXBwcm9hY2g6IGl0IG1ha2VzIHRoZSBvbGQgSklUIGR1bWJlciByYXRoZXIKKyAgICAgICAgdGhh biBtYWtpbmcgdGhlIERGRyBKSVQgc21hcnRlci4gVGhpcyBpcyBwZXJmb3JtYW5jZS1uZXV0cmFs LgorCisgICAgICAgICogaml0L0pJVC5oOgorICAgICAgICAoSlNDOjpKSVQ6OmNhbkJlT3B0aW1p emVkKToKKyAgICAgICAgKiBqaXQvSklUT3Bjb2Rlcy5jcHA6CisgICAgICAgIChKU0M6OkpJVDo6 ZW1pdF9vcF9tb3YpOgorCiAyMDExLTA5LTI1ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmVtb3ZlIFBMQVRGT1JNKEhBSUtVKSBhbmQgYXNzb2NpYXRlZCBjb2Rl CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVC5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklULmgJKHJldmlzaW9uIDk1OTI0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL2ppdC9KSVQuaAkod29ya2luZyBjb3B5KQpAQCAtMTAzNCw4ICsxMDM0 LDEwIEBAIG5hbWVzcGFjZSBKU0MgewogI2VuZGlmCiAKICNpZiBFTkFCTEUoREZHX0pJVCkKKyAg ICAgICAgYm9vbCBjYW5CZU9wdGltaXplZCgpIHsgcmV0dXJuIG1fY2FuQmVPcHRpbWl6ZWQ7IH0K ICAgICAgICAgYm9vbCBzaG91bGRFbWl0UHJvZmlsaW5nKCkgeyByZXR1cm4gbV9jYW5CZU9wdGlt aXplZDsgfQogI2Vsc2UKKyAgICAgICAgYm9vbCBjYW5CZU9wdGltaXplZCgpIHsgcmV0dXJuIGZh bHNlOyB9CiAgICAgICAgIC8vIEVuYWJsZXMgdXNlIG9mIHZhbHVlIHByb2ZpbGVyIHdpdGggdGll cmVkIGNvbXBpbGF0aW9uIHR1cm5lZCBvZmYsCiAgICAgICAgIC8vIGluIHdoaWNoIGNhc2UgYWxs IGNvZGUgZ2V0cyBwcm9maWxlZC4KICAgICAgICAgYm9vbCBzaG91bGRFbWl0UHJvZmlsaW5nKCkg eyByZXR1cm4gdHJ1ZTsgfQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGNv ZGVzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wY29k ZXMuY3BwCShyZXZpc2lvbiA5NTkyNCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklU T3Bjb2Rlcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMwMywxOSArMzAzLDI2IEBAIHZvaWQgSklU OjplbWl0X29wX21vdihJbnN0cnVjdGlvbiogY3VycmUKICAgICBpbnQgZHN0ID0gY3VycmVudElu c3RydWN0aW9uWzFdLnUub3BlcmFuZDsKICAgICBpbnQgc3JjID0gY3VycmVudEluc3RydWN0aW9u WzJdLnUub3BlcmFuZDsKIAotICAgIGlmIChtX2NvZGVCbG9jay0+aXNDb25zdGFudFJlZ2lzdGVy SW5kZXgoc3JjKSkgewotICAgICAgICBzdG9yZVB0cihJbW1QdHIoSlNWYWx1ZTo6ZW5jb2RlKGdl dENvbnN0YW50T3BlcmFuZChzcmMpKSksIEFkZHJlc3MoY2FsbEZyYW1lUmVnaXN0ZXIsIGRzdCAq IHNpemVvZihSZWdpc3RlcikpKTsKLSAgICAgICAgaWYgKGRzdCA9PSBtX2xhc3RSZXN1bHRCeXRl Y29kZVJlZ2lzdGVyKQotICAgICAgICAgICAga2lsbExhc3RSZXN1bHRSZWdpc3RlcigpOwotICAg IH0gZWxzZSBpZiAoKHNyYyA9PSBtX2xhc3RSZXN1bHRCeXRlY29kZVJlZ2lzdGVyKSB8fCAoZHN0 ID09IG1fbGFzdFJlc3VsdEJ5dGVjb2RlUmVnaXN0ZXIpKSB7Ci0gICAgICAgIC8vIElmIGVpdGhl ciB0aGUgc3JjIG9yIGRzdCBpcyB0aGUgY2FjaGVkIHJlZ2lzdGVyIGdvIHRob3VnaAotICAgICAg ICAvLyBnZXQvcHV0IHJlZ2lzdGVycyB0byBtYWtlIHN1cmUgd2UgdHJhY2sgdGhpcyBjb3JyZWN0 bHkuCisgICAgaWYgKGNhbkJlT3B0aW1pemVkKCkpIHsKKyAgICAgICAgLy8gVXNlIHNpbXBsZXIg YXBwcm9hY2gsIHNpbmNlIHRoZSBERkcgdGhpbmtzIHRoYXQgdGhlIGxhc3QgcmVzdWx0IHJlZ2lz dGVyCisgICAgICAgIC8vIGlzIGFsd2F5cyBzZXQgdG8gdGhlIGRlc3RpbmF0aW9uIG9uIGV2ZXJ5 IG9wZXJhdGlvbi4KICAgICAgICAgZW1pdEdldFZpcnR1YWxSZWdpc3RlcihzcmMsIHJlZ1QwKTsK ICAgICAgICAgZW1pdFB1dFZpcnR1YWxSZWdpc3Rlcihkc3QpOwogICAgIH0gZWxzZSB7Ci0gICAg ICAgIC8vIFBlcmZvcm0gdGhlIGNvcHkgdmlhIHJlZ1QxOyBkbyBub3QgZGlzdHVyYiBhbnkgbWFw cGluZyBpbiByZWdUMC4KLSAgICAgICAgbG9hZFB0cihBZGRyZXNzKGNhbGxGcmFtZVJlZ2lzdGVy LCBzcmMgKiBzaXplb2YoUmVnaXN0ZXIpKSwgcmVnVDEpOwotICAgICAgICBzdG9yZVB0cihyZWdU MSwgQWRkcmVzcyhjYWxsRnJhbWVSZWdpc3RlciwgZHN0ICogc2l6ZW9mKFJlZ2lzdGVyKSkpOwor ICAgICAgICBpZiAobV9jb2RlQmxvY2stPmlzQ29uc3RhbnRSZWdpc3RlckluZGV4KHNyYykpIHsK KyAgICAgICAgICAgIHN0b3JlUHRyKEltbVB0cihKU1ZhbHVlOjplbmNvZGUoZ2V0Q29uc3RhbnRP cGVyYW5kKHNyYykpKSwgQWRkcmVzcyhjYWxsRnJhbWVSZWdpc3RlciwgZHN0ICogc2l6ZW9mKFJl Z2lzdGVyKSkpOworICAgICAgICAgICAgaWYgKGRzdCA9PSBtX2xhc3RSZXN1bHRCeXRlY29kZVJl Z2lzdGVyKQorICAgICAgICAgICAgICAgIGtpbGxMYXN0UmVzdWx0UmVnaXN0ZXIoKTsKKyAgICAg ICAgfSBlbHNlIGlmICgoc3JjID09IG1fbGFzdFJlc3VsdEJ5dGVjb2RlUmVnaXN0ZXIpIHx8IChk c3QgPT0gbV9sYXN0UmVzdWx0Qnl0ZWNvZGVSZWdpc3RlcikpIHsKKyAgICAgICAgICAgIC8vIElm IGVpdGhlciB0aGUgc3JjIG9yIGRzdCBpcyB0aGUgY2FjaGVkIHJlZ2lzdGVyIGdvIHRob3VnaAor ICAgICAgICAgICAgLy8gZ2V0L3B1dCByZWdpc3RlcnMgdG8gbWFrZSBzdXJlIHdlIHRyYWNrIHRo aXMgY29ycmVjdGx5LgorICAgICAgICAgICAgZW1pdEdldFZpcnR1YWxSZWdpc3RlcihzcmMsIHJl Z1QwKTsKKyAgICAgICAgICAgIGVtaXRQdXRWaXJ0dWFsUmVnaXN0ZXIoZHN0KTsKKyAgICAgICAg fSBlbHNlIHsKKyAgICAgICAgICAgIC8vIFBlcmZvcm0gdGhlIGNvcHkgdmlhIHJlZ1QxOyBkbyBu b3QgZGlzdHVyYiBhbnkgbWFwcGluZyBpbiByZWdUMC4KKyAgICAgICAgICAgIGxvYWRQdHIoQWRk cmVzcyhjYWxsRnJhbWVSZWdpc3Rlciwgc3JjICogc2l6ZW9mKFJlZ2lzdGVyKSksIHJlZ1QxKTsK KyAgICAgICAgICAgIHN0b3JlUHRyKHJlZ1QxLCBBZGRyZXNzKGNhbGxGcmFtZVJlZ2lzdGVyLCBk c3QgKiBzaXplb2YoUmVnaXN0ZXIpKSk7CisgICAgICAgIH0KICAgICB9CiB9CiAK