68738 2011-09-23 15:17:19 -0700 Add a mechanism to test for the compositing tree mutated during painting 2011-09-27 14:46:40 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr cmarrin enne jamesr simon.fraser vangelis webkit.review.bot oldest_to_newest 472541 0 jamesr 2011-09-23 15:17:19 -0700 We've had a lot of bugs in the past with compositing turning off or the GraphicsLayer tree being mutated during painting. See https://bugs.webkit.org/show_bug.cgi?id=54707, http://trac.webkit.org/changeset/45715/trunk/WebCore/rendering/RenderLayer.cpp and others. We should add ASSERT()s to catch this case and some test cases to hit the areas where we've seen this happen in the past. 472559 1 108549 jamesr 2011-09-23 15:41:47 -0700 Created attachment 108549 some assertions, no test case yet 472566 2 jamesr 2011-09-23 15:46:01 -0700 I'm working on reduce a manual test case down to something automated that will make this ASSERT() hit without the fix in https://bugs.webkit.org/show_bug.cgi?id=68727. 472682 3 108572 jamesr 2011-09-23 18:25:58 -0700 Created attachment 108572 Patch 472683 4 jamesr 2011-09-23 18:26:33 -0700 Many bothans died to bring you this test case that reliably fails in DRT prior to http://trac.webkit.org/changeset/95863. The timing is unbelievably sensitive. 472691 5 108572 abarth 2011-09-23 19:30:31 -0700 Comment on attachment 108572 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108572&action=review > Source/WebCore/platform/graphics/GraphicsLayer.cpp:65 > +static bool s_inPaintContents = false; I would have used a counter, but that's because I'm paranoid about re-entrancy from working on the parser. :) 474252 6 108572 webkit.review.bot 2011-09-27 14:46:35 -0700 Comment on attachment 108572 Patch Clearing flags on attachment: 108572 Committed r96160: <http://trac.webkit.org/changeset/96160> 474253 7 webkit.review.bot 2011-09-27 14:46:40 -0700 All reviewed patches have been landed. Closing bug. 108549 2011-09-23 15:41:47 -0700 2011-09-23 18:25:55 -0700 some assertions, no test case yet bug-68738-20110923154146.patch text/plain 2253 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogOTU4NjIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkNDZkMmJjMDQ1YmNjNjFj MGNmYTJkZDBlZjYzMGY3N2M0N2IwNTU3Li45MGYzMDE5N2E3NzgyYTNmYWM1OGY3NTdmYjA0YzE0 MjFkYzcxNjg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDktMjMgIEphbWVz IFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KKworICAgICAgICBBZGQgYSBtZWNoYW5p c20gdG8gdGVzdCBmb3IgdGhlIGNvbXBvc2l0aW5nIHRyZWUgbXV0YXRlZCBkdXJpbmcgcGFpbnRp bmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4NzM4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzLiAoT09QUyEpCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xh eWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXI6OkdyYXBoaWNzTGF5ZXIp OgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NMYXllcjo6fkdyYXBoaWNzTGF5ZXIpOgorICAg ICAgICAoV2ViQ29yZTo6R3JhcGhpY3NMYXllcjo6cGFpbnRHcmFwaGljc0xheWVyQ29udGVudHMp OgorCiAyMDExLTA5LTIzICBGYWR5IFNhbXVlbCAgPGZzYW11ZWxAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJlZmFjdG9yIHBhaW50T3ZlcmhhbmdBcmVhcyB0byBhbGxvdyBub24tTWFjIENocm9t aXVtIHBsYXRmb3JtcyB0byByZXVzZSBjb2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXIuY3BwCmluZGV4IDk4MDllMTZjODU5OGQ2ZTBkNTM3 NjQzNzQ4YWU2NDRhYTY4ZjUyYTIuLjYwODA5ZDVmNGE0OTljNmFlOTlhZjAyNDIyNWMzYzllNTQ4 NWQ5YWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBo aWNzTGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBo aWNzTGF5ZXIuY3BwCkBAIC02MSw2ICs2MSwxMCBAQCB2b2lkIEtleWZyYW1lVmFsdWVMaXN0Ojpp bnNlcnQoY29uc3QgQW5pbWF0aW9uVmFsdWUqIHZhbHVlKQogICAgIG1fdmFsdWVzLmFwcGVuZCh2 YWx1ZSk7CiB9CiAKKyNpZm5kZWYgTkRFQlVHCitzdGF0aWMgYm9vbCBzX2luUGFpbnRDb250ZW50 cyA9IGZhbHNlOworI2VuZGlmCisKIEdyYXBoaWNzTGF5ZXI6OkdyYXBoaWNzTGF5ZXIoR3JhcGhp Y3NMYXllckNsaWVudCogY2xpZW50KQogICAgIDogbV9jbGllbnQoY2xpZW50KQogICAgICwgbV9h bmNob3JQb2ludCgwLjVmLCAwLjVmLCAwKQpAQCAtODQsMTAgKzg4LDEyIEBAIEdyYXBoaWNzTGF5 ZXI6OkdyYXBoaWNzTGF5ZXIoR3JhcGhpY3NMYXllckNsaWVudCogY2xpZW50KQogICAgICwgbV9y ZXBsaWNhdGVkTGF5ZXIoMCkKICAgICAsIG1fcmVwYWludENvdW50KDApCiB7CisgICAgQVNTRVJU KCFzX2luUGFpbnRDb250ZW50cyk7CiB9CiAKIEdyYXBoaWNzTGF5ZXI6On5HcmFwaGljc0xheWVy KCkKIHsKKyAgICBBU1NFUlQoIXNfaW5QYWludENvbnRlbnRzKTsKICAgICByZW1vdmVBbGxDaGls ZHJlbigpOwogICAgIHJlbW92ZUZyb21QYXJlbnQoKTsKIH0KQEAgLTI2OCw4ICsyNzQsMTQgQEAg dm9pZCBHcmFwaGljc0xheWVyOjpjbGVhckJhY2tncm91bmRDb2xvcigpCiAKIHZvaWQgR3JhcGhp Y3NMYXllcjo6cGFpbnRHcmFwaGljc0xheWVyQ29udGVudHMoR3JhcGhpY3NDb250ZXh0JiBjb250 ZXh0LCBjb25zdCBJbnRSZWN0JiBjbGlwKQogeworI2lmbmRlZiBOREVCVUcKKyAgICBzX2luUGFp bnRDb250ZW50cyA9IHRydWU7CisjZW5kaWYKICAgICBpZiAobV9jbGllbnQpCiAgICAgICAgIG1f Y2xpZW50LT5wYWludENvbnRlbnRzKHRoaXMsIGNvbnRleHQsIG1fcGFpbnRpbmdQaGFzZSwgY2xp cCk7CisjaWZuZGVmIE5ERUJVRworICAgIHNfaW5QYWludENvbnRlbnRzID0gZmFsc2U7CisjZW5k aWYKIH0KIAogU3RyaW5nIEdyYXBoaWNzTGF5ZXI6OmFuaW1hdGlvbk5hbWVGb3JUcmFuc2l0aW9u KEFuaW1hdGVkUHJvcGVydHlJRCBwcm9wZXJ0eSkK 108572 2011-09-23 18:25:58 -0700 2011-09-27 14:46:35 -0700 Patch bug-68738-20110923182557.patch text/plain 4867 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogOTU4NjMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA1YTMwZDk4NzhmYjY2NmE5MTE4NWQw NTZmMGY3NmE3ODM5MjkyNmVkLi5kN2QxN2VkYzYzODAzYjZjMzRkOTZlOGI5MzY2YTk2YjhlZDU5 YWRiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDktMjMgIEphbWVzIFJvYmluc29uICA8 amFtZXNyQGNocm9taXVtLm9yZz4KKworICAgICAgICBBZGQgYSBtZWNoYW5pc20gdG8gdGVzdCBm b3IgdGhlIGNvbXBvc2l0aW5nIHRyZWUgbXV0YXRlZCBkdXJpbmcgcGFpbnRpbmcKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4NzM4CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkcyBhIHRlc3QgdGhhdCBj YXVzZWQgY29tcG9zaXRpbmcgdG8gYmUgZGlzYWJsZWQgZHVyaW5nIHBhaW50aW5nIGJlZm9yZSBy OTU4NjMgZHVlIHRvIGEgdmlkZW8gbG9hZCBmYWlsaW5nLgorCisgICAgICAgICogY29tcG9zaXRp bmcvdmlkZW8vdmlkZW8td2l0aC1pbnZhbGlkLXNvdXJjZS1leHBlY3RlZC50eHQ6IEFkZGVkLgor ICAgICAgICAqIGNvbXBvc2l0aW5nL3ZpZGVvL3ZpZGVvLXdpdGgtaW52YWxpZC1zb3VyY2UuaHRt bDogQWRkZWQuCisKIDIwMTEtMDktMjMgIEFiaGlzaGVrIEFyeWEgIDxpbmZlcm5vQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLiBDaHJvbWl1bSByZWJhc2VsaW5lcyBmb3Igcjk1 ODU3LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvdmlkZW8vdmlkZW8td2l0 aC1pbnZhbGlkLXNvdXJjZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy92 aWRlby92aWRlby13aXRoLWludmFsaWQtc291cmNlLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43 ZWYyMmU5YTQzMWFkMDI3MjcxM2I3MWZkYzg3OTQwMTZjOGVmMTJmCi0tLSAvZGV2L251bGwKKysr IGIvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvdmlkZW8vdmlkZW8td2l0aC1pbnZhbGlkLXNvdXJj ZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSBAQAorUEFTUwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvY29tcG9zaXRpbmcvdmlkZW8vdmlkZW8td2l0aC1pbnZhbGlkLXNvdXJjZS5odG1sIGIvTGF5 b3V0VGVzdHMvY29tcG9zaXRpbmcvdmlkZW8vdmlkZW8td2l0aC1pbnZhbGlkLXNvdXJjZS5odG1s Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLjA2Mjc4YjEzNmNhMzFiZjc1YzVlZDBlNWU0ZTk1OGU3MzE1NTNjYWEKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy92aWRlby92aWRlby13aXRo LWludmFsaWQtc291cmNlLmh0bWwKQEAgLTAsMCArMSwyNSBAQAorPCFET0NUWVBFIGh0bWw+DQor PHNjcmlwdD4NCitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7DQorICAgIGxheW91 dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsNCisgICAgbGF5b3V0VGVzdENvbnRyb2xs ZXIuZHVtcEFzVGV4dCgpOw0KK30NCisNCitmdW5jdGlvbiB0ZXN0KCkgew0KKyAgICB2YXIgdiA9 IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInZpZGVvIik7DQorICAgIGRvY3VtZW50LmJvZHkuYXBw ZW5kQ2hpbGQodik7DQorICAgIHZhciBzcmMgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJzb3Vy Y2UiKTsNCisgICAgc3JjLnNyYyA9ICJub3RhcmVhbHNvdXJjZSI7DQorICAgIHYuYXBwZW5kQ2hp bGQoc3JjKTsNCisgICAgc3JjLmFkZEV2ZW50TGlzdGVuZXIoImVycm9yIiwgZnVuY3Rpb24oKSB7 DQorICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsNCisgICAgICAgICAg ICBsYXlvdXRUZXN0Q29udHJvbGxlci5kaXNwbGF5KCk7DQorICAgICAgICAgICAgLy8gSWYgd2Ug ZGlkbid0IGNyYXNoIGhlcmUsIHlheSEgIFRlc3QgaXMgYSBzdWNjZXNzDQorICAgICAgICAgICAg ZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZSgiUEFTUyIp KTsNCisgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7DQorICAg ICAgICB9DQorICAgIH0sIGZhbHNlKTsNCit9DQorPC9zY3JpcHQ+DQorPGJvZHkgb25sb2FkPSJ0 ZXN0KCkiPg0KKzwvYm9keT4NCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDE4YmQ1ZTZlYjMzNDg5NjI3ZTQ0ZGY4 MDkwMDQyYTZjMmE1NjhkZC4uNTZhZWU0MWE4OGMyZGM5ZDE2YWU0NmRkNTM1MDdmZjAxNDFiMmEw NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDExLTA5LTIzICBKYW1lcyBSb2JpbnNv biAgPGphbWVzckBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgQWRkIGEgbWVjaGFuaXNtIHRvIHRl c3QgZm9yIHRoZSBjb21wb3NpdGluZyB0cmVlIG11dGF0ZWQgZHVyaW5nIHBhaW50aW5nCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODczOAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNldHMgYSBzdGF0aWMg Ym9vbCBkdXJpbmcgR3JhcGhpY3NMYXllcjo6cGFpbnRHcmFwaGljc0xheWVyQ29udGVudHMgYW5k IEFTU0VSVCgpcyB0aGF0IHdlIG5ldmVyIGNyZWF0ZSBvcgorICAgICAgICBkZXN0cm95IGEgR3Jh cGhpY3NMYXllciBpbnNpZGUgdGhpcyBmdW5jdGlvbi4gUGFpbnRpbmcgc2hvdWxkIG5ldmVyIG11 dGF0ZSB0aGUgR3JhcGhpY3NMYXllciB0cmVlLgorCisgICAgICAgIFRlc3Q6IGNvbXBvc2l0aW5n L3ZpZGVvL3ZpZGVvLXdpdGgtaW52YWxpZC1zb3VyY2UuaHRtbAorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvR3JhcGhpY3NMYXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGlj c0xheWVyOjpHcmFwaGljc0xheWVyKToKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXI6 On5HcmFwaGljc0xheWVyKToKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXI6OnBhaW50 R3JhcGhpY3NMYXllckNvbnRlbnRzKToKKworMjAxMS0wOS0yMyAgSmFtZXMgUm9iaW5zb24gIDxq YW1lc3JAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIEF2b2lkIHVwZGF0aW5nIGNvbXBvc2l0aW5n IHN0YXRlIGR1cmluZyBwYWludAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Njg3MjcKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvR3JhcGhpY3NMYXllci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9HcmFwaGljc0xheWVyLmNwcAppbmRleCA5ODA5ZTE2Yzg1OThkNmUwZDUzNzY0Mzc0OGFl NjQ0YWE2OGY1MmEyLi42MDgwOWQ1ZjRhNDk5YzZhZTk5YWYwMjQyMjVjM2M5ZTU0ODVkOWFiIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVy LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVy LmNwcApAQCAtNjEsNiArNjEsMTAgQEAgdm9pZCBLZXlmcmFtZVZhbHVlTGlzdDo6aW5zZXJ0KGNv bnN0IEFuaW1hdGlvblZhbHVlKiB2YWx1ZSkKICAgICBtX3ZhbHVlcy5hcHBlbmQodmFsdWUpOwog fQogCisjaWZuZGVmIE5ERUJVRworc3RhdGljIGJvb2wgc19pblBhaW50Q29udGVudHMgPSBmYWxz ZTsKKyNlbmRpZgorCiBHcmFwaGljc0xheWVyOjpHcmFwaGljc0xheWVyKEdyYXBoaWNzTGF5ZXJD bGllbnQqIGNsaWVudCkKICAgICA6IG1fY2xpZW50KGNsaWVudCkKICAgICAsIG1fYW5jaG9yUG9p bnQoMC41ZiwgMC41ZiwgMCkKQEAgLTg0LDEwICs4OCwxMiBAQCBHcmFwaGljc0xheWVyOjpHcmFw aGljc0xheWVyKEdyYXBoaWNzTGF5ZXJDbGllbnQqIGNsaWVudCkKICAgICAsIG1fcmVwbGljYXRl ZExheWVyKDApCiAgICAgLCBtX3JlcGFpbnRDb3VudCgwKQogeworICAgIEFTU0VSVCghc19pblBh aW50Q29udGVudHMpOwogfQogCiBHcmFwaGljc0xheWVyOjp+R3JhcGhpY3NMYXllcigpCiB7Cisg ICAgQVNTRVJUKCFzX2luUGFpbnRDb250ZW50cyk7CiAgICAgcmVtb3ZlQWxsQ2hpbGRyZW4oKTsK ICAgICByZW1vdmVGcm9tUGFyZW50KCk7CiB9CkBAIC0yNjgsOCArMjc0LDE0IEBAIHZvaWQgR3Jh cGhpY3NMYXllcjo6Y2xlYXJCYWNrZ3JvdW5kQ29sb3IoKQogCiB2b2lkIEdyYXBoaWNzTGF5ZXI6 OnBhaW50R3JhcGhpY3NMYXllckNvbnRlbnRzKEdyYXBoaWNzQ29udGV4dCYgY29udGV4dCwgY29u c3QgSW50UmVjdCYgY2xpcCkKIHsKKyNpZm5kZWYgTkRFQlVHCisgICAgc19pblBhaW50Q29udGVu dHMgPSB0cnVlOworI2VuZGlmCiAgICAgaWYgKG1fY2xpZW50KQogICAgICAgICBtX2NsaWVudC0+ cGFpbnRDb250ZW50cyh0aGlzLCBjb250ZXh0LCBtX3BhaW50aW5nUGhhc2UsIGNsaXApOworI2lm bmRlZiBOREVCVUcKKyAgICBzX2luUGFpbnRDb250ZW50cyA9IGZhbHNlOworI2VuZGlmCiB9CiAK IFN0cmluZyBHcmFwaGljc0xheWVyOjphbmltYXRpb25OYW1lRm9yVHJhbnNpdGlvbihBbmltYXRl ZFByb3BlcnR5SUQgcHJvcGVydHkpCg==