68727 2011-09-23 13:56:47 -0700 Avoid updating compositing state during paint 2011-09-23 15:19:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr cmarrin simon.fraser oldest_to_newest 472483 0 jamesr 2011-09-23 13:56:47 -0700 Avoid updating compositing state during paint 472489 1 108533 jamesr 2011-09-23 14:03:42 -0700 Created attachment 108533 Patch 472494 2 108533 simon.fraser 2011-09-23 14:07:05 -0700 Comment on attachment 108533 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108533&action=review Would be great to have a test case. > Source/WebCore/ChangeLog:10 > + fix this exact issue. Based off the ChangeLog entries, I think that this was just a typo. One space after period. > Source/WebCore/rendering/RenderLayerCompositor.cpp:259 > - case CompositingUpdateOnPaitingOrHitTest: > + case CompositingUpdateOnHitTest: I'm not sure we even have to update compositing on hit testing, since that doesn't have anything to do with compositing. 472521 3 jamesr 2011-09-23 14:51:05 -0700 Committed r95863: <http://trac.webkit.org/changeset/95863> 472545 4 jamesr 2011-09-23 15:19:16 -0700 (In reply to comment #2) > (From update of attachment 108533 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=108533&action=review > > Would be great to have a test case. Filed https://bugs.webkit.org/show_bug.cgi?id=68738 > > Source/WebCore/rendering/RenderLayerCompositor.cpp:259 > > - case CompositingUpdateOnPaitingOrHitTest: > > + case CompositingUpdateOnHitTest: > > I'm not sure we even have to update compositing on hit testing, since that doesn't have anything to do with compositing. Filed https://bugs.webkit.org/show_bug.cgi?id=68738 472546 5 jamesr 2011-09-23 15:19:32 -0700 (In reply to comment #4) > > > Source/WebCore/rendering/RenderLayerCompositor.cpp:259 > > > - case CompositingUpdateOnPaitingOrHitTest: > > > + case CompositingUpdateOnHitTest: > > > > I'm not sure we even have to update compositing on hit testing, since that doesn't have anything to do with compositing. > > Filed https://bugs.webkit.org/show_bug.cgi?id=68738 Sorry I meant https://bugs.webkit.org/show_bug.cgi?id=68739 108533 2011-09-23 14:03:42 -0700 2011-09-23 14:07:05 -0700 Patch bug-68727-20110923140341.patch text/plain 3688 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogOTU4NDcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5MDc3MTQwZTU5ODkyYzRk YzkyOTM2ZGFjZDZiNzg3NWZiY2I1MGUxLi5hOGQ4OGYzM2Y2YWYwNjJiZjIzZTNiNDU2OTI3OWJi OWNmNGJhNTBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDktMjMgIEphbWVz IFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KKworICAgICAgICBBdm9pZCB1cGRhdGlu ZyBjb21wb3NpdGluZyBzdGF0ZSBkdXJpbmcgcGFpbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4NzI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ugc2hvdWxkbid0IHVwZGF0ZSBvdXIgY29tcG9zaXRp bmcgc3RhdGUgaW4gdGhlIG1pZGRsZSBvZiBhIHBhaW50LiBUaGUgY2FsbCB0bworICAgICAgICB1 cGRhdGVDb21wb3NpdGluZ0FuZExheWVyTGlzdHNJZk5lZWRlZCgpIHdhcyBhZGRlZCB0byBSZW5k ZXJMYXllcjo6cGFpbnRMYXllciBpbiByNDU3MTUsIHdoaWNoIHdhcyBpbnRlbmRlZCB0bworICAg ICAgICBmaXggdGhpcyBleGFjdCBpc3N1ZS4gIEJhc2VkIG9mZiB0aGUgQ2hhbmdlTG9nIGVudHJp ZXMsIEkgdGhpbmsgdGhhdCB0aGlzIHdhcyBqdXN0IGEgdHlwby4KKworICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJMYXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6cGFp bnRMYXllcik6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6dXBkYXRlQ29tcG9zaXRp bmdBbmRMYXllckxpc3RzSWZOZWVkZWQpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXll ckNvbXBvc2l0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJDb21wb3NpdG9y Ojp1cGRhdGVDb21wb3NpdGluZ0xheWVycyk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxh eWVyQ29tcG9zaXRvci5oOgorCiAyMDExLTA5LTIzICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNh bmNoZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBSZW1vdmUgZXh0cmEgc3BhY2UgYXQg dGhlIGJlZ2lubmluZyBvZiB0aGUgbGFzdCBsaW5lLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJMYXllci5jcHAKaW5kZXggZGJkMjQ4MzVjYTg1ZDA3MTg1ZGEyZDZkMGU2ZGI4M2U3MDM3 YjM4Mi4uNzQ1MzU1OGUwN2I4ODc5Y2I3NjBlYzY4ZWU1Mzk4MmQ4MjRlMDZmNyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCkBAIC0yNzIyLDcgKzI3MjIsNyBAQCB2 b2lkIFJlbmRlckxheWVyOjpwYWludExheWVyKFJlbmRlckxheWVyKiByb290TGF5ZXIsIEdyYXBo aWNzQ29udGV4dCogcCwKICAgICBMYXlvdXRQb2ludCBwYWludE9mZnNldCA9IHRvUG9pbnQobGF5 ZXJCb3VuZHMubG9jYXRpb24oKSAtIHJlbmRlckJveExvY2F0aW9uKCkpOwogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAKICAgICAvLyBFbnN1cmUgb3VyIGxpc3RzIGFyZSB1cC10by1kYXRl LgotICAgIHVwZGF0ZUNvbXBvc2l0aW5nQW5kTGF5ZXJMaXN0c0lmTmVlZGVkKCk7CisgICAgdXBk YXRlTGF5ZXJMaXN0c0lmTmVlZGVkKCk7CiAKICAgICBib29sIGZvcmNlQmxhY2tUZXh0ID0gcGFp bnRCZWhhdmlvciAmIFBhaW50QmVoYXZpb3JGb3JjZUJsYWNrVGV4dDsKICAgICBib29sIHNlbGVj dGlvbk9ubHkgID0gcGFpbnRCZWhhdmlvciAmIFBhaW50QmVoYXZpb3JTZWxlY3Rpb25Pbmx5OwpA QCAtNDAxNiw3ICs0MDE2LDcgQEAgdm9pZCBSZW5kZXJMYXllcjo6dXBkYXRlQ29tcG9zaXRpbmdB bmRMYXllckxpc3RzSWZOZWVkZWQoKQogI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykK ICAgICBpZiAoY29tcG9zaXRvcigpLT5pbkNvbXBvc2l0aW5nTW9kZSgpKSB7CiAgICAgICAgIGlm ICgoaXNTdGFja2luZ0NvbnRleHQoKSAmJiBtX3pPcmRlckxpc3RzRGlydHkpIHx8IG1fbm9ybWFs Rmxvd0xpc3REaXJ0eSkKLSAgICAgICAgICAgIGNvbXBvc2l0b3IoKS0+dXBkYXRlQ29tcG9zaXRp bmdMYXllcnMoQ29tcG9zaXRpbmdVcGRhdGVPblBhaXRpbmdPckhpdFRlc3QsIHRoaXMpOworICAg ICAgICAgICAgY29tcG9zaXRvcigpLT51cGRhdGVDb21wb3NpdGluZ0xheWVycyhDb21wb3NpdGlu Z1VwZGF0ZU9uSGl0VGVzdCwgdGhpcyk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAjZW5kaWYK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0 b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5j cHAKaW5kZXggYWUwOGVjNjJjZTYzYzQ2YjQ4M2YyNTNkMzAwNzg3NDVlZjQ4NjE5Ni4uMzI1MmI1 N2E4NmFkYjIzYmZlODBiNjcyOTU1Njc2MjdhNmIyYzA2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKQEAgLTI1Niw3ICsyNTYs NyBAQCB2b2lkIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6dXBkYXRlQ29tcG9zaXRpbmdMYXllcnMo Q29tcG9zaXRpbmdVcGRhdGVUeXBlIHVwZGF0ZQogCiAgICAgc3dpdGNoICh1cGRhdGVUeXBlKSB7 CiAgICAgY2FzZSBDb21wb3NpdGluZ1VwZGF0ZUFmdGVyTGF5b3V0T3JTdHlsZUNoYW5nZToKLSAg ICBjYXNlIENvbXBvc2l0aW5nVXBkYXRlT25QYWl0aW5nT3JIaXRUZXN0OgorICAgIGNhc2UgQ29t cG9zaXRpbmdVcGRhdGVPbkhpdFRlc3Q6CiAgICAgICAgIGNoZWNrRm9ySGllcmFyY2h5VXBkYXRl ID0gdHJ1ZTsKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBDb21wb3NpdGluZ1VwZGF0ZU9uU2Ny b2xsOgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29t cG9zaXRvci5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRv ci5oCmluZGV4IDcyMTA4ZmU3Mjg3Yzc3NzUzY2QwMmI2MmQ4YWE2ZjE0ZjQxZWU2YTIuLmZlMDE4 OGRhZGFkYmZjMTE4ZDJjZTRkZjk5YmIyYjk0MzIzYWFmMzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmgKQEAgLTQzLDcgKzQzLDcgQEAg Y2xhc3MgUmVuZGVyVmlkZW87CiAKIGVudW0gQ29tcG9zaXRpbmdVcGRhdGVUeXBlIHsKICAgICBD b21wb3NpdGluZ1VwZGF0ZUFmdGVyTGF5b3V0T3JTdHlsZUNoYW5nZSwKLSAgICBDb21wb3NpdGlu Z1VwZGF0ZU9uUGFpdGluZ09ySGl0VGVzdCwKKyAgICBDb21wb3NpdGluZ1VwZGF0ZU9uSGl0VGVz dCwKICAgICBDb21wb3NpdGluZ1VwZGF0ZU9uU2Nyb2xsCiB9OwogCg==