68722 2011-09-23 13:17:04 -0700 Implicit conversion double to float in ShadowBlur::adjustBlurRadius 2011-09-27 13:33:51 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 68667 1 jchaffraix jchaffraix darin harrison simon.fraser webkit.review.bot oldest_to_newest 472449 0 jchaffraix 2011-09-23 13:17:04 -0700 This is making the Intel Mac Debug bot bad. Let's make add an explicit conversion to calm the bots. 472455 1 108524 jchaffraix 2011-09-23 13:20:45 -0700 Created attachment 108524 Proposed build fix: add 2 variables with the proper cast. 472462 2 108524 simon.fraser 2011-09-23 13:29:59 -0700 Comment on attachment 108524 Proposed build fix: add 2 variables with the proper cast. I think m_blurRadius.scale(1 / static_cast<float>(transform.xScale()), 1 / static_cast<float>(transform.yScale())); would be better. 472473 3 108528 jchaffraix 2011-09-23 13:42:29 -0700 Created attachment 108528 fix 2.... 472563 4 darin 2011-09-23 15:43:41 -0700 Rather than a cast we could use narrowPrecisionToFloat next time. 472570 5 simon.fraser 2011-09-23 15:48:33 -0700 We're not consistent about using narrowPrecisionToFloat(). It seems to have little value. narrowPrecisionToCGFloat, on the other hand, has obvious value. 472590 6 108528 webkit.review.bot 2011-09-23 16:11:00 -0700 Comment on attachment 108528 fix 2.... Clearing flags on attachment: 108528 Committed r95879: <http://trac.webkit.org/changeset/95879> 472591 7 webkit.review.bot 2011-09-23 16:11:05 -0700 All reviewed patches have been landed. Closing bug. 472708 8 darin 2011-09-23 20:33:01 -0700 (In reply to comment #5) > We're not consistent about using narrowPrecisionToFloat(). It seems to have little value. It has value in that you can easily see at the call site that it's not some other kind of static_cast, say from int to float. > narrowPrecisionToCGFloat, on the other hand, has obvious value. What value over calling static_cast<CGFloat>? The two situations seem entirely analogous to me. 472710 9 simon.fraser 2011-09-23 20:38:39 -0700 (In reply to comment #8) > (In reply to comment #5) > > We're not consistent about using narrowPrecisionToFloat(). It seems to have little value. > > It has value in that you can easily see at the call site that it's not some other kind of static_cast, say from int to float. Then we should use it more consistently! > > narrowPrecisionToCGFloat, on the other hand, has obvious value. > > What value over calling static_cast<CGFloat>? The two situations seem entirely analogous to me. Now that I think about it, you're right. I was thinking that it eliminated some float/double confusion. 474191 10 harrison 2011-09-27 13:33:51 -0700 rdar://10184811 108524 2011-09-23 13:20:45 -0700 2011-09-23 13:42:26 -0700 Proposed build fix: add 2 variables with the proper cast. bug-68722-20110923132044.patch text/plain 1552 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogOTU4NDYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5MDc3MTQwZTU5ODkyYzRk YzkyOTM2ZGFjZDZiNzg3NWZiY2I1MGUxLi45ZjQzOWM3MTM5MGZlMmI1YTMyNTA0YTU3NGM1MThl MWFjYWI4ODJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDktMjMgIEp1bGll biBDaGFmZnJhaXggIDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+CisKKyAgICAgICAgSW1wbGljaXQg Y29udmVyc2lvbiBkb3VibGUgdG8gZmxvYXQgaW4gU2hhZG93Qmx1cjo6YWRqdXN0Qmx1clJhZGl1 cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njg3MjIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL1NoYWRvd0JsdXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2hhZG93Qmx1 cjo6YWRqdXN0Qmx1clJhZGl1cyk6IEFkZGVkIDIgdmFyaWFibGVzIHRvIG1ha2UgdGhlCisgICAg ICAgIGNvbnZlcnNpb25zIGV4cGxpY2l0LgorCiAyMDExLTA5LTIzICBNYXJpbyBTYW5jaGV6IFBy YWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBSZW1vdmUgZXh0cmEg c3BhY2UgYXQgdGhlIGJlZ2lubmluZyBvZiB0aGUgbGFzdCBsaW5lLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvU2hhZG93Qmx1ci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9TaGFkb3dCbHVyLmNwcAppbmRleCA4NGQwNGZjNDgxOTdj ZTI4Y2ZmOWU1NzFiOTgyZGU4MGRmYzRmNTU0Li5hYjgxMzIyZDQ0ZjExNzU4ODE0NDYxZGI1ZGRi OTE3ZGJhMDFkOTg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9TaGFkb3dCbHVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9T aGFkb3dCbHVyLmNwcApAQCAtMzU2LDcgKzM1Niw5IEBAIHZvaWQgU2hhZG93Qmx1cjo6YWRqdXN0 Qmx1clJhZGl1cyhHcmFwaGljc0NvbnRleHQqIGNvbnRleHQpCiAgICAgICAgIHJldHVybjsKIAog ICAgIEFmZmluZVRyYW5zZm9ybSB0cmFuc2Zvcm0gPSBjb250ZXh0LT5nZXRDVE0oKTsKLSAgICBt X2JsdXJSYWRpdXMuc2NhbGUoMSAvIHRyYW5zZm9ybS54U2NhbGUoKSwgMSAvIHRyYW5zZm9ybS55 U2NhbGUoKSk7CisgICAgY29uc3QgZmxvYXQgeFNjYWxlID0gc3RhdGljX2Nhc3Q8ZmxvYXQ+KHRy YW5zZm9ybS54U2NhbGUoKSk7CisgICAgY29uc3QgZmxvYXQgeVNjYWxlID0gc3RhdGljX2Nhc3Q8 ZmxvYXQ+KHRyYW5zZm9ybS55U2NhbGUoKSk7CisgICAgbV9ibHVyUmFkaXVzLnNjYWxlKDEgLyB4 U2NhbGUsIDEgLyB5U2NhbGUpOwogfQogCiBJbnRTaXplIFNoYWRvd0JsdXI6OmJsdXJyZWRFZGdl U2l6ZSgpIGNvbnN0Cg== 108528 2011-09-23 13:42:29 -0700 2011-09-23 16:11:00 -0700 fix 2.... bug-68722-20110923134228.patch text/plain 1462 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogOTU4NDYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5MDc3MTQwZTU5ODkyYzRk YzkyOTM2ZGFjZDZiNzg3NWZiY2I1MGUxLi41M2RmYzM0ZDZjMjIyYzRmNTE2NDA0MTFmMmM2YjI2 ZTcwODViZjBlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDktMjMgIEp1bGll biBDaGFmZnJhaXggIDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+CisKKyAgICAgICAgSW1wbGljaXQg Y29udmVyc2lvbiBkb3VibGUgdG8gZmxvYXQgaW4gU2hhZG93Qmx1cjo6YWRqdXN0Qmx1clJhZGl1 cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njg3MjIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL1NoYWRvd0JsdXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2hhZG93Qmx1 cjo6YWRqdXN0Qmx1clJhZGl1cyk6IEFkZGVkIDIgZXhwbGljaXQKKyAgICAgICAgY29udmVyc2lv bnMuCisKIDIwMTEtMDktMjMgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFtHVEtdIFJlbW92ZSBleHRyYSBzcGFjZSBhdCB0aGUgYmVnaW5uaW5n IG9mIHRoZSBsYXN0IGxpbmUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9TaGFkb3dCbHVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L1NoYWRvd0JsdXIuY3BwCmluZGV4IDg0ZDA0ZmM0ODE5N2NlMjhjZmY5ZTU3MWI5ODJkZTgwZGZj NGY1NTQuLjcyZmRmZmI0ZWIyNmRjZmRhYWJlMmE0OWExY2E2OGQ5ODVlM2JhMTcgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1NoYWRvd0JsdXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1NoYWRvd0JsdXIuY3BwCkBAIC0zNTYs NyArMzU2LDcgQEAgdm9pZCBTaGFkb3dCbHVyOjphZGp1c3RCbHVyUmFkaXVzKEdyYXBoaWNzQ29u dGV4dCogY29udGV4dCkKICAgICAgICAgcmV0dXJuOwogCiAgICAgQWZmaW5lVHJhbnNmb3JtIHRy YW5zZm9ybSA9IGNvbnRleHQtPmdldENUTSgpOwotICAgIG1fYmx1clJhZGl1cy5zY2FsZSgxIC8g dHJhbnNmb3JtLnhTY2FsZSgpLCAxIC8gdHJhbnNmb3JtLnlTY2FsZSgpKTsKKyAgICBtX2JsdXJS YWRpdXMuc2NhbGUoMSAvIHN0YXRpY19jYXN0PGZsb2F0Pih0cmFuc2Zvcm0ueFNjYWxlKCkpLCAx IC8gc3RhdGljX2Nhc3Q8ZmxvYXQ+KHRyYW5zZm9ybS55U2NhbGUoKSkpOwogfQogCiBJbnRTaXpl IFNoYWRvd0JsdXI6OmJsdXJyZWRFZGdlU2l6ZSgpIGNvbnN0Cg==