68716 2011-09-23 12:39:56 -0700 Add a bunch of unhandled node types to the propagator 2011-09-23 12:50:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver oldest_to_newest 472411 0 oliver 2011-09-23 12:39:56 -0700 Add a bunch of unhandled node types to the propagator 472412 1 108510 oliver 2011-09-23 12:41:50 -0700 Created attachment 108510 Patch 472413 2 108510 darin 2011-09-23 12:43:28 -0700 Comment on attachment 108510 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108510&action=review > Source/JavaScriptCore/dfg/DFGPropagator.cpp:-610 > - ASSERT_NOT_REACHED(); Might still be nice to have an ASSERT_NOT_REACHED when the node type is not a legal enum value. Sometimes we do that by using return instead of break, and then asserting outside the switch statement. 472416 3 108510 barraclough 2011-09-23 12:46:09 -0700 Comment on attachment 108510 Patch r+ with or without ValueToDouble doing anything. 472417 4 oliver 2011-09-23 12:47:38 -0700 Committed r95851: <http://trac.webkit.org/changeset/95851> 472420 5 108510 fpizlo 2011-09-23 12:50:37 -0700 Comment on attachment 108510 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108510&action=review > Source/JavaScriptCore/dfg/DFGPropagator.cpp:404 > + changed |= mergePrediction(makePrediction(PredictNumber, StrongPrediction)); This should be PredictDouble. PredictNumber means that it could be either double or int32. ValueToDouble only returns doubles. But also, this is dead code: ValueToDouble should never come up at this stage of compilation, since it is only introduced during post-propagation fixup just following this fixpoint. We could put ASSERT_NOT_REACHED here. 108510 2011-09-23 12:41:50 -0700 2011-09-23 12:50:37 -0700 Patch bug-68716-20110923124149.patch text/plain 2339 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogOTU4NDYKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDAx ZDc0Njc2YWZiMDI0N2RkODgwMGM3ZTkwOGQzMTc5NmY4NTFhYTkuLmIyYmQxY2Y2MGIyZTAzMThh YWExNzkwNTZmNTFlMmVkODNmZTVhNGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSw1 ICsxLDIwIEBACiAyMDExLTA5LTIzICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAK KyAgICAgICAgQWRkIGEgYnVuY2ggb2YgdW5oYW5kbGVkIG5vZGUgdHlwZXMgdG8gdGhlIHByb3Bh Z2F0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4 NzE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVt b3ZlIHRoZSBBU1NFUlRfTk9UX1JFQUNIRUQoKSBkZWZhdWx0IGZvciBkZWJ1ZyBidWlsZHMgaW4g dGhlCisgICAgICAgIHByZWRpY3Rpb24gcHJvcGFnYXRvciwgdGhpcyB3YXkgdW5oYW5kbGVkIG5v ZGVzIHdpbGwganVzdCBjYXVzZQorICAgICAgICBjb21waWxlIHRpbWUgZmFpbHVyZXMgcmF0aGVy IHRoYW4gZmFpbGluZyBhdCBzb21lIHBvaW50IGluIHRoZQorICAgICAgICBmdXR1cmUuCisKKyAg ICAgICAgKiBkZmcvREZHUHJvcGFnYXRvci5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6UHJvcGFn YXRvcjo6cHJvcGFnYXRlTm9kZVByZWRpY3Rpb25zKToKKworMjAxMS0wOS0yMyAgT2xpdmVyIEh1 bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgorCiAgICAgICAgIE5vZGUgcHJvcGFnYXRpb24gZG9lc24n dCBoYW5kbGUgUHV0U2NvcGVkVmFyCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD02ODcxMwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR1Byb3BhZ2F0b3IuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdQcm9w YWdhdG9yLmNwcAppbmRleCBmNTAzOGY4MzdlZDNmN2RiYTMwYmYwOWZiNzJkZmEwMDE2ZGJlZmUz Li5kNTU1MDUxNTNmZWYwMzIzMjY5YjAyNTM3YjdiYjQwNWI0NmY1Yzg4IDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1Byb3BhZ2F0b3IuY3BwCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHUHJvcGFnYXRvci5jcHAKQEAgLTM5OSw3ICszOTksMTIgQEAg cHJpdmF0ZToKICAgICAgICAgICAgIAogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KLSAg ICAgICAgICAgIAorCisgICAgICAgIGNhc2UgVmFsdWVUb0RvdWJsZTogeworICAgICAgICAgICAg Y2hhbmdlZCB8PSBtZXJnZVByZWRpY3Rpb24obWFrZVByZWRpY3Rpb24oUHJlZGljdE51bWJlciwg U3Ryb25nUHJlZGljdGlvbikpOworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIH0KKyAgICAg ICAgCiAgICAgICAgIGNhc2UgVmFsdWVBZGQ6IHsKICAgICAgICAgICAgIFByZWRpY3RlZFR5cGUg bGVmdCA9IG1fcHJlZGljdGlvbnNbbm9kZS5jaGlsZDEoKV07CiAgICAgICAgICAgICBQcmVkaWN0 ZWRUeXBlIHJpZ2h0ID0gbV9wcmVkaWN0aW9uc1tub2RlLmNoaWxkMigpXTsKQEAgLTU4OCw2ICs1 OTMsNyBAQCBwcml2YXRlOgogICAgICAgICAvLyBUaGVzZSBnZXQgaWdub3JlZCBiZWNhdXNlIHRo ZXkgZG9uJ3QgcmV0dXJuIGFueXRoaW5nLgogICAgICAgICBjYXNlIERGRzo6SnVtcDoKICAgICAg ICAgY2FzZSBCcmFuY2g6CisgICAgICAgIGNhc2UgQnJlYWtwb2ludDoKICAgICAgICAgY2FzZSBS ZXR1cm46CiAgICAgICAgIGNhc2UgQ2hlY2tIYXNJbnN0YW5jZToKICAgICAgICAgY2FzZSBQaGk6 CkBAIC01OTksNiArNjA1LDcgQEAgcHJpdmF0ZToKICAgICAgICAgY2FzZSBSZXNvbHZlOgogICAg ICAgICBjYXNlIFJlc29sdmVCYXNlOgogICAgICAgICBjYXNlIFJlc29sdmVCYXNlU3RyaWN0UHV0 OgorICAgICAgICBjYXNlIFJlc29sdmVHbG9iYWw6CiAgICAgICAgIGNhc2UgUHV0U2NvcGVkVmFy OgogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICAKQEAgLTYwNiw5ICs2MTMsNyBAQCBw cml2YXRlOgogICAgICAgICBjYXNlIFBoYW50b206CiAgICAgICAgICAgICBicmVhazsKIAotICAg ICAgICBkZWZhdWx0OgotICAgICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Ci0gICAgICAg ICAgICBicmVhazsKKwogI2Vsc2UKICAgICAgICAgZGVmYXVsdDoKICAgICAgICAgICAgIGJyZWFr Owo=