68707 2011-09-23 11:00:55 -0700 [GTK] Fix coding style issues in ResourceRequestSoup.cpp 2011-09-23 11:25:24 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) All Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 mario webkit-unassigned oldest_to_newest 472341 0 mario 2011-09-23 11:00:55 -0700 The following problems in this file should be addressed: check-webkit-style WebCore/platform/network/soup/ResourceRequestSoup.cpp Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:31: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:99: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 2 in 1 files 472348 1 108496 mario 2011-09-23 11:12:32 -0700 Created attachment 108496 The Patch Patch for fixing this issue 472349 2 108496 xan.lopez 2011-09-23 11:15:56 -0700 Comment on attachment 108496 The Patch Best. Patch. Ever. 472359 3 mario 2011-09-23 11:25:24 -0700 Fixed on r95837 http://trac.webkit.org/changeset/95837 108496 2011-09-23 11:12:32 -0700 2011-09-23 11:15:56 -0700 The Patch 0001-2011-09-23-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 2712 mario RnJvbSA5ODQ5ZDc1MDRhMmZmOGY0MWI1NmQxMjc5OTFlZjQxODQ5MjRiMzYyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBGcmksIDIzIFNlcCAyMDExIDIwOjA5OjE0ICswMjAwClN1YmplY3Q6IFtQQVRD SF0gMjAxMS0wOS0yMyAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+ CgogICAgICAgIFtHVEtdIEZpeCBjb2Rpbmcgc3R5bGUgaXNzdWVzIGluIFJlc291cmNlUmVxdWVz dFNvdXAuY3BwCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTY4NzA3CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBUaGlz IHBhdGNoIGZpeGVzIHNvbWUgaXNzdWVzIGFzIHJlcG9ydGVkIGJ5IGNoZWNrLXdlYmtpdC1zdHls ZS4KCiAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VSZXF1ZXN0U291cC5j cHA6CiAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdDo6dXBkYXRlRnJvbVNvdXBNZXNz YWdlKToKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAg ICAgICB8ICAgMTIgKysrKysrKysrKysrCiAuLi4vcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291 cmNlUmVxdWVzdFNvdXAuY3BwICB8ICAgIDUgKystLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTQgaW5z ZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjYwNGE3NC4uZjA2N2I0 MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTA5LTIzICBNYXJpbyBTYW5jaGV6 IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBGaXggY29kaW5n IHN0eWxlIGlzc3VlcyBpbiBSZXNvdXJjZVJlcXVlc3RTb3VwLmNwcAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njg3MDcKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIGZpeGVzIHNvbWUgaXNz dWVzIGFzIHJlcG9ydGVkIGJ5IGNoZWNrLXdlYmtpdC1zdHlsZS4KKworICAgICAgICAqIHBsYXRm b3JtL25ldHdvcmsvc291cC9SZXNvdXJjZVJlcXVlc3RTb3VwLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlJlc291cmNlUmVxdWVzdDo6dXBkYXRlRnJvbVNvdXBNZXNzYWdlKToKKwogMjAxMS0wOS0x NSAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGdvb2dsZS5jb20+CiAKICAgICAgICAgV2ViIElu c3BlY3RvcjogcmVuYW1lIENvbnNvbGUuY2xlYXJDb25zb2xlTWVzc2FnZXMgdG8gQ29uc29sZS5j bGVhck1lc3NhZ2VzLCBicnVzaCB1cCBjb25zb2xlIGRvbWFpbiBkb2MuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VSZXF1ZXN0U291cC5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VSZXF1ZXN0 U291cC5jcHAKaW5kZXggYTY4NDc5MC4uY2NmZjY1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlUmVxdWVzdFNvdXAuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZVJlcXVlc3RTb3VwLmNw cApAQCAtMjYsOSArMjYsOSBAQAogI2luY2x1ZGUgIk1JTUVUeXBlUmVnaXN0cnkuaCIKICNpbmNs dWRlICJQbGF0Zm9ybVN0cmluZy5oIgogI2luY2x1ZGUgIlNvdXBVUklVdGlscy5oIgotI2luY2x1 ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4KIAogI2luY2x1ZGUgPGxpYnNvdXAvc291cC5oPgorI2lu Y2x1ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4KIAogdXNpbmcgbmFtZXNwYWNlIHN0ZDsKIApAQCAt OTQsOSArOTQsOCBAQCB2b2lkIFJlc291cmNlUmVxdWVzdDo6dXBkYXRlRnJvbVNvdXBNZXNzYWdl KFNvdXBNZXNzYWdlKiBzb3VwTWVzc2FnZSkKICAgICBjb25zdCBjaGFyKiBoZWFkZXJOYW1lOwog ICAgIGNvbnN0IGNoYXIqIGhlYWRlclZhbHVlOwogICAgIHNvdXBfbWVzc2FnZV9oZWFkZXJzX2l0 ZXJfaW5pdCgmaGVhZGVyc0l0ZXIsIHNvdXBNZXNzYWdlLT5yZXF1ZXN0X2hlYWRlcnMpOwotICAg IHdoaWxlIChzb3VwX21lc3NhZ2VfaGVhZGVyc19pdGVyX25leHQoJmhlYWRlcnNJdGVyLCAmaGVh ZGVyTmFtZSwgJmhlYWRlclZhbHVlKSkgeworICAgIHdoaWxlIChzb3VwX21lc3NhZ2VfaGVhZGVy c19pdGVyX25leHQoJmhlYWRlcnNJdGVyLCAmaGVhZGVyTmFtZSwgJmhlYWRlclZhbHVlKSkKICAg ICAgICAgbV9odHRwSGVhZGVyRmllbGRzLnNldChTdHJpbmc6OmZyb21VVEY4KGhlYWRlck5hbWUp LCBTdHJpbmc6OmZyb21VVEY4KGhlYWRlclZhbHVlKSk7Ci0gICAgfQogCiAgICAgaWYgKHNvdXBN ZXNzYWdlLT5yZXF1ZXN0X2JvZHktPmRhdGEpCiAgICAgICAgIG1faHR0cEJvZHkgPSBGb3JtRGF0 YTo6Y3JlYXRlKHNvdXBNZXNzYWdlLT5yZXF1ZXN0X2JvZHktPmRhdGEsIHNvdXBNZXNzYWdlLT5y ZXF1ZXN0X2JvZHktPmxlbmd0aCk7Ci0tIAoxLjcuNgoK