68699 2011-09-23 08:21:20 -0700 [EFL] Add virtual method to notify user when wrapping focus 2011-09-26 12:57:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 lucas.de.marchi lucas.de.marchi kenneth leandro lucas.de.marchi rakuco tonikitoo oldest_to_newest 472251 0 lucas.de.marchi 2011-09-23 08:21:20 -0700 [EFL] Add virtual method to notify user when wrapping focus 472287 1 108484 lucas.de.marchi 2011-09-23 09:49:14 -0700 Created attachment 108484 Patch 472290 2 rakuco 2011-09-23 09:53:16 -0700 Informal r+. 472458 3 lucas.de.marchi 2011-09-23 13:24:50 -0700 CC'ing reviewers. 472487 4 108484 tonikitoo 2011-09-23 14:01:40 -0700 Comment on attachment 108484 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108484&action=review Does it need API review? > Source/WebKit/efl/ewk/ewk_view.h:117 > + EWK_FOCUS_DIRECTION_BACKWARD, > + EWK_FOCUS_DIRECTION_UP, > + EWK_FOCUS_DIRECTION_DOWN, > + EWK_FOCUS_DIRECTION_LEFT, > + EWK_FOCUS_DIRECTION_RIGHT, Is it for TAB navigation. Do you need the arrow ones? 472547 5 lucas.de.marchi 2011-09-23 15:22:09 -0700 (In reply to comment #4) > (From update of attachment 108484 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=108484&action=review > > Does it need API review? > > > Source/WebKit/efl/ewk/ewk_view.h:117 > > + EWK_FOCUS_DIRECTION_BACKWARD, > > + EWK_FOCUS_DIRECTION_UP, > > + EWK_FOCUS_DIRECTION_DOWN, > > + EWK_FOCUS_DIRECTION_LEFT, > > + EWK_FOCUS_DIRECTION_RIGHT, > > Is it for TAB navigation. Do you need the arrow ones? I thought we could actually wrap when going through a certain direction, but FocusController::advanceFocusDirectionally() doesn't call this function. Is it on purpose or just a missing functionality? 472656 6 tonikitoo 2011-09-23 17:41:15 -0700 (In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 108484 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=108484&action=review > > > > Does it need API review? > > > > > Source/WebKit/efl/ewk/ewk_view.h:117 > > > + EWK_FOCUS_DIRECTION_BACKWARD, > > > + EWK_FOCUS_DIRECTION_UP, > > > + EWK_FOCUS_DIRECTION_DOWN, > > > + EWK_FOCUS_DIRECTION_LEFT, > > > + EWK_FOCUS_DIRECTION_RIGHT, > > > > Is it for TAB navigation. Do you need the arrow ones? > > I thought we could actually wrap when going through a certain direction, but FocusController::advanceFocusDirectionally() doesn't call this function. Is it on purpose or just a missing functionality? wrapping in direction navigation would not really make users happy :). 473282 7 108706 lucas.de.marchi 2011-09-26 12:16:20 -0700 Created attachment 108706 Patch 473284 8 lucas.de.marchi 2011-09-26 12:19:03 -0700 (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > (From update of attachment 108484 [details] [details] [details]) > > > View in context: https://bugs.webkit.org/attachment.cgi?id=108484&action=review > > > > > > Does it need API review? > > > > > > > Source/WebKit/efl/ewk/ewk_view.h:117 > > > > + EWK_FOCUS_DIRECTION_BACKWARD, > > > > + EWK_FOCUS_DIRECTION_UP, > > > > + EWK_FOCUS_DIRECTION_DOWN, > > > > + EWK_FOCUS_DIRECTION_LEFT, > > > > + EWK_FOCUS_DIRECTION_RIGHT, > > > > > > Is it for TAB navigation. Do you need the arrow ones? > > > > I thought we could actually wrap when going through a certain direction, but FocusController::advanceFocusDirectionally() doesn't call this function. Is it on purpose or just a missing functionality? > > wrapping in direction navigation would not really make users happy :). Ok, I uploaded a new patch then. 473317 9 108706 lucas.de.marchi 2011-09-26 12:57:34 -0700 Comment on attachment 108706 Patch Clearing flags on attachment: 108706 Committed r95983: <http://trac.webkit.org/changeset/95983> 473318 10 lucas.de.marchi 2011-09-26 12:57:42 -0700 All reviewed patches have been landed. Closing bug. 108484 2011-09-23 09:49:14 -0700 2011-09-26 12:16:13 -0700 Patch bug-68699-20110923135032.patch text/plain 6123 lucas.de.marchi U3VidmVyc2lvbiBSZXZpc2lvbjogOTU3OTYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCBlYmJlYWYxZjk3 YzcyYjRkY2E5Nzg3MjBlOTQ0MzU3OWNhMDZkZDlmLi5jYmJiYjY1N2E1MjQyZGZkOWI1ZjcwMGI2 M2U3YjRkZTI3NTUzZGEwIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEt MDktMjMgIEx1Y2FzIERlIE1hcmNoaSAgPGx1Y2FzLmRlbWFyY2hpQHByb2Z1c2lvbi5tb2JpPgor CisgICAgICAgIFtFRkxdIEFkZCB2aXJ0dWFsIG1ldGhvZCB0byBub3RpZnkgdXNlciB3aGVuIHdy YXBwaW5nIGZvY3VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02ODY5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEFkZCBhIHZpcnR1YWwgbWV0aG9kIHRvIGV3a192aWV3LCBzbyB0aGUgQ2hyb21lIGdldHMg bm90aWZpZWQgaWYgd2UKKyAgICAgICAgZmluaXNoZWQgZm9jdXNpbmcgYWxsIHRoZSBpdGVtcyBh bmQgd291bGQgc3RhcnQgb3Zlci4gVGhpcyB3YXkgdGhlCisgICAgICAgIGJyb3dzZXIgY2FuIGRl Y2lkZSB0byBoYW5kbGUgdGhlIHN1YnNlcXVlbnQgZm9jdXMgY2hhbmdlcyBhbW9uZyBpdHMKKyAg ICAgICAgd2lkZ2V0cy4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEVm bC5jcHA6IGNhbGwgZXdrX3ZpZXcncyB2aXJ0dWFsIG1ldGhvZCB0bworICAgICAgICBnaXZlIGl0 IGEgY2hhbmNlIHRvIGdyYWIgZm9jdXMKKyAgICAgICAgKFdlYkNvcmU6OkNocm9tZUNsaWVudEVm bDo6Y2FuVGFrZUZvY3VzKToKKyAgICAgICAgKiBld2svZXdrX3ByaXZhdGUuaDoKKyAgICAgICAg KiBld2svZXdrX3ZpZXcuY3BwOiBhZGQgdmlydHVhbCBtZXRob2QKKyAgICAgICAgKGV3a192aWV3 X2ZvY3VzX2Nhbl9jeWNsZSk6CisgICAgICAgICogZXdrL2V3a192aWV3Lmg6IGFkZCBmb2N1cyBk aXJlY3Rpb24gZW51bSBhbmQgdmlydHVhbCBtZXRob2QKKwogMjAxMS0wOS0yMSAgTHVjYXMgRGUg TWFyY2hpICA8bHVjYXMuZGVtYXJjaGlAcHJvZnVzaW9uLm1vYmk+CiAKICAgICAgICAgW0VGTF0g UmV2ZXJ0IHBvaW50ZXIgb3BlcmF0b3IgY29kaW5nIHN0eWxlIGluIGV3awpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50RWZsLmNwcCBiL1Nv dXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEVmbC5jcHAKaW5kZXgg MjQzNTk1NjhkOGFhZTYzZjMzMGYwNjZlNzllZjYwOTk1NDUzMzFjMi4uZjI1N2JhNDBlNDM1YWMy ZWU4YmExMDBmY2Q1MDk3MWFmZmMwODRkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwv V2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50RWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Vm bC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRFZmwuY3BwCkBAIC0yMzYsMTEgKzIzNiwxMyBA QCB2b2lkIENocm9tZUNsaWVudEVmbDo6Y2xvc2VXaW5kb3dTb29uKCkKICAgICBld2tfdmlld193 aW5kb3dfY2xvc2UobV92aWV3KTsKIH0KIAotYm9vbCBDaHJvbWVDbGllbnRFZmw6OmNhblRha2VG b2N1cyhGb2N1c0RpcmVjdGlvbikKK2Jvb2wgQ2hyb21lQ2xpZW50RWZsOjpjYW5UYWtlRm9jdXMo Rm9jdXNEaXJlY3Rpb24gY29yZURpcmVjdGlvbikKIHsKKyAgICBFd2tfRm9jdXNfRGlyZWN0aW9u IGRpcmVjdGlvbiA9IHN0YXRpY19jYXN0PEV3a19Gb2N1c19EaXJlY3Rpb24+KGNvcmVEaXJlY3Rp b24pOworCiAgICAgLy8gVGhpcyBpcyBjYWxsZWQgd2hlbiBjeWNsaW5nIHRocm91Z2ggbGlua3Mv Zm9jdXNhYmxlIG9iamVjdHMgYW5kIHdlCiAgICAgLy8gcmVhY2ggdGhlIGxhc3QgZm9jdXNhYmxl IG9iamVjdC4KLSAgICByZXR1cm4gZmFsc2U7CisgICAgcmV0dXJuICFld2tfdmlld19mb2N1c19j YW5fY3ljbGUobV92aWV3LCBkaXJlY3Rpb24pOwogfQogCiB2b2lkIENocm9tZUNsaWVudEVmbDo6 dGFrZUZvY3VzKEZvY3VzRGlyZWN0aW9uKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwv ZXdrL2V3a19wcml2YXRlLmggYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ByaXZhdGUuaApp bmRleCA5YzgzYTkzM2YwYjk2NjhjMDE0YjZkYjQ2ZDMxYTgwNTAwNDU5MTUwLi5lMTliMjQ4YjM2 NGIyZmZlMzFiMDlmMTJmYTdiYmZhNmQ2MjY3NzczIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2VmbC9ld2svZXdrX3ByaXZhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3By aXZhdGUuaApAQCAtMTM5LDYgKzEzOSw4IEBAIHZvaWQqIGV3a192aWV3X3Byb3RvY29sX2hhbmRs ZXJfcmVzb3VyY2VfZ2V0KEV2YXNfT2JqZWN0KiBvLCBzaXplX3QqIGJ5dGVzUmVhZCwKIHZvaWQg ZXdrX3ZpZXdfZWRpdG9yX2NsaWVudF9jb250ZW50c19jaGFuZ2VkKEV2YXNfT2JqZWN0KiBvKTsK IHZvaWQgZXdrX3ZpZXdfZWRpdG9yX2NsaWVudF9zZWxlY3Rpb25fY2hhbmdlZChFdmFzX09iamVj dCogbyk7CiAKK2Jvb2wgZXdrX3ZpZXdfZm9jdXNfY2FuX2N5Y2xlKEV2YXNfT2JqZWN0ICpvLCBF d2tfRm9jdXNfRGlyZWN0aW9uIGRpcmVjdGlvbik7CisKICNpZiBFTkFCTEUoTkVUU0NBUEVfUExV R0lOX0FQSSkKIHZvaWQgZXdrX3ZpZXdfanNfd2luZG93X29iamVjdF9jbGVhcihFdmFzX09iamVj dCogbywgRXZhc19PYmplY3QqIGZyYW1lKTsKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9lZmwvZXdrL2V3a192aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmll dy5jcHAKaW5kZXggNDgyNGNiY2EyYTA1NTkxZGQ1ZGE2YjIxODJiMTZiNDM1MTk2MWRmMi4uOWMx ZjQxZDc0ZmIwNGMwYzY1MzQ2ZjZhMzgwM2RjODNkZmU3YjEwZSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2sv ZXdrX3ZpZXcuY3BwCkBAIC0zMTA3LDYgKzMxMDcsMTggQEAgdm9pZCBld2tfdmlld19hZGRfY29u c29sZV9tZXNzYWdlKEV2YXNfT2JqZWN0KiBvLCBjb25zdCBjaGFyKiBtZXNzYWdlLCB1bnNpZ25l ZAogICAgIHNkLT5hcGktPmFkZF9jb25zb2xlX21lc3NhZ2Uoc2QsIG1lc3NhZ2UsIGxpbmVOdW1i ZXIsIHNvdXJjZUlEKTsKIH0KIAorYm9vbCBld2tfdmlld19mb2N1c19jYW5fY3ljbGUoRXZhc19P YmplY3QqIG8sIEV3a19Gb2N1c19EaXJlY3Rpb24gZGlyZWN0aW9uKQoreworICAgIERCRygibz0l cCBkaXJlY3Rpb249JWQiLCBvLCBkaXJlY3Rpb24pOworICAgIEVXS19WSUVXX1NEX0dFVF9PUl9S RVRVUk4obywgc2QsIGZhbHNlKTsKKyAgICBFSU5BX1NBRkVUWV9PTl9OVUxMX1JFVFVSTl9WQUwo c2QtPmFwaSwgZmFsc2UpOworCisgICAgaWYgKCFzZC0+YXBpLT5mb2N1c19jYW5fY3ljbGUpCisg ICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIHJldHVybiBzZC0+YXBpLT5mb2N1c19jYW5fY3lj bGUoc2QsIGRpcmVjdGlvbik7Cit9CisKIHZvaWQgZXdrX3ZpZXdfcnVuX2phdmFzY3JpcHRfYWxl cnQoRXZhc19PYmplY3QqIG8sIEV2YXNfT2JqZWN0KiBmcmFtZSwgY29uc3QgY2hhciogbWVzc2Fn ZSkKIHsKICAgICBEQkcoIm89JXAgZnJhbWU9JXAgbWVzc2FnZT0lcyIsIG8sIGZyYW1lLCBtZXNz YWdlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5oIGIvU291 cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmgKaW5kZXggZWRhYzk1MmY4YjIxMzc4NWVkOTVj NmI3ZjZmMzVjMDg4ZmI3ZjM4NC4uOTRhZDNmNzVmZGJiZGUyZGExZjhhMjVlYWE0ZGU4OTNkZmFj NzlhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmgKKysrIGIv U291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmgKQEAgLTEwNCw2ICsxMDQsMjAgQEAgdHlw ZWRlZiB2b2lkKiAoKkV3a19WaWV3X1Jlc291cmNlX0hhbmRsZXJfQ2IpKGNvbnN0IGNoYXIgKiwg c2l6ZV90ICosIGNoYXIgKiosIHYKIAogLy8vIENyZWF0ZXMgYSB0eXBlIG5hbWUgZm9yIEBhIF9F d2tfVmlld19TbWFydF9DbGFzcy4KIHR5cGVkZWYgc3RydWN0IF9Fd2tfVmlld19TbWFydF9DbGFz cyBFd2tfVmlld19TbWFydF9DbGFzczsKKworLy8gRGVmaW5lcyB0aGUgZGlyZWN0aW9uIG9mIGZv Y3VzIGNoYW5nZS4gS2VlcCBpbiBzeW5jIHdpdGgKKy8vIFdlYkNvcmU6OkZvY3VzRGlyZWN0aW9u LgorZW51bSBfRXdrX0ZvY3VzX0RpcmVjdGlvbiB7CisgICAgRVdLX0ZPQ1VTX0RJUkVDVElPTl9O T05FID0gMCwKKyAgICBFV0tfRk9DVVNfRElSRUNUSU9OX0ZPUldBUkQsCisgICAgRVdLX0ZPQ1VT X0RJUkVDVElPTl9CQUNLV0FSRCwKKyAgICBFV0tfRk9DVVNfRElSRUNUSU9OX1VQLAorICAgIEVX S19GT0NVU19ESVJFQ1RJT05fRE9XTiwKKyAgICBFV0tfRk9DVVNfRElSRUNUSU9OX0xFRlQsCisg ICAgRVdLX0ZPQ1VTX0RJUkVDVElPTl9SSUdIVCwKK307Cit0eXBlZGVmIGVudW0gX0V3a19Gb2N1 c19EaXJlY3Rpb24gRXdrX0ZvY3VzX0RpcmVjdGlvbjsKKwogLy8vIEV3ayB2aWV3J3MgY2xhc3Ms IHRvIGJlIG92ZXJyaWRkZW4gYnkgc3ViLWNsYXNzZXMuCiBzdHJ1Y3QgX0V3a19WaWV3X1NtYXJ0 X0NsYXNzIHsKICAgICBFdmFzX1NtYXJ0X0NsYXNzIHNjOyAvKio8IEFsbCBidXQgJ2RhdGEnIGlz IGZyZWUgdG8gYmUgY2hhbmdlZC4gKi8KQEAgLTE0OSwxMyArMTYzLDE0IEBAIHN0cnVjdCBfRXdr X1ZpZXdfU21hcnRfQ2xhc3MgewogICAgIEVpbmFfQm9vbCAoKnJ1bl9vcGVuX3BhbmVsKShFd2tf Vmlld19TbWFydF9EYXRhICpzZCwgRXZhc19PYmplY3QgKmZyYW1lLCBFaW5hX0Jvb2wgYWxsb3dz X211bHRpcGxlX2ZpbGVzLCBjb25zdCBjaGFyICphY2NlcHRfdHlwZXMsIEVpbmFfTGlzdCAqKnNl bGVjdGVkX2ZpbGVuYW1lcyk7CiAKICAgICBFaW5hX0Jvb2wgKCpuYXZpZ2F0aW9uX3BvbGljeV9k ZWNpc2lvbikoRXdrX1ZpZXdfU21hcnRfRGF0YSAqc2QsIEV3a19GcmFtZV9SZXNvdXJjZV9SZXF1 ZXN0ICpyZXF1ZXN0KTsKKyAgICBFaW5hX0Jvb2wgKCpmb2N1c19jYW5fY3ljbGUpKEV3a19WaWV3 X1NtYXJ0X0RhdGEgKnNkLCBFd2tfRm9jdXNfRGlyZWN0aW9uIGRpcmVjdGlvbik7CiB9OwogCiAv KioKICAqIFRoZSB2ZXJzaW9uIHlvdSBoYXZlIHRvIHB1dCBpbnRvIHRoZSB2ZXJzaW9uIGZpZWxk CiAgKiBpbiB0aGUgQGEgRXdrX1ZpZXdfU21hcnRfQ2xhc3Mgc3RydWN0dXJlLgogICovCi0jZGVm aW5lIEVXS19WSUVXX1NNQVJUX0NMQVNTX1ZFUlNJT04gMVVMCisjZGVmaW5lIEVXS19WSUVXX1NN QVJUX0NMQVNTX1ZFUlNJT04gMlVMCiAKIC8qKgogICogSW5pdGlhbGl6ZXMgYSB3aG9sZSBAYSBF d2tfVmlld19TbWFydF9DbGFzcyBzdHJ1Y3R1cmUuCkBAIC0xNjcsNyArMTgyLDcgQEAgc3RydWN0 IF9Fd2tfVmlld19TbWFydF9DbGFzcyB7CiAgKiBAc2VlIEVXS19WSUVXX1NNQVJUX0NMQVNTX0lO SVRfVkVSU0lPTgogICogQHNlZSBFV0tfVklFV19TTUFSVF9DTEFTU19JTklUX05BTUVfVkVSU0lP TgogICovCi0jZGVmaW5lIEVXS19WSUVXX1NNQVJUX0NMQVNTX0lOSVQoc21hcnRfY2xhc3NfaW5p dCkge3NtYXJ0X2NsYXNzX2luaXQsIEVXS19WSUVXX1NNQVJUX0NMQVNTX1ZFUlNJT04sIDAsIDAs IDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAs IDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDB9CisjZGVmaW5lIEVXS19WSUVXX1NNQVJU X0NMQVNTX0lOSVQoc21hcnRfY2xhc3NfaW5pdCkge3NtYXJ0X2NsYXNzX2luaXQsIEVXS19WSUVX X1NNQVJUX0NMQVNTX1ZFUlNJT04sIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAs IDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAs IDAsIDB9CiAKIC8qKgogICogSW5pdGlhbGl6ZXMgdG8gemVybyBhIHdob2xlIEBhIEV3a19WaWV3 X1NtYXJ0X0NsYXNzIHN0cnVjdHVyZS4K 108706 2011-09-26 12:16:20 -0700 2011-09-26 12:57:34 -0700 Patch bug-68699-20110926161741.patch text/plain 6047 lucas.de.marchi U3VidmVyc2lvbiBSZXZpc2lvbjogOTU5NjIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCA2NDdiMGMwYTc4 YmQ0NTJkY2ZkNzRmNzRmZGE4YTRkOGUyZDk2ZDViLi40NDUxMGQ0MWI0MjVkNzgzOThkZjg0M2Q1 MzkyMWI1MDk0NmVmZDIyIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEt MDktMjMgIEx1Y2FzIERlIE1hcmNoaSAgPGx1Y2FzLmRlbWFyY2hpQHByb2Z1c2lvbi5tb2JpPgor CisgICAgICAgIFtFRkxdIEFkZCB2aXJ0dWFsIG1ldGhvZCB0byBub3RpZnkgdXNlciB3aGVuIHdy YXBwaW5nIGZvY3VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02ODY5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEFkZCBhIHZpcnR1YWwgbWV0aG9kIHRvIGV3a192aWV3LCBzbyB0aGUgQ2hyb21lIGdldHMg bm90aWZpZWQgaWYgd2UKKyAgICAgICAgZmluaXNoZWQgZm9jdXNpbmcgYWxsIHRoZSBpdGVtcyBh bmQgd291bGQgc3RhcnQgb3Zlci4gVGhpcyB3YXkgdGhlCisgICAgICAgIGJyb3dzZXIgY2FuIGRl Y2lkZSB0byBoYW5kbGUgdGhlIHN1YnNlcXVlbnQgZm9jdXMgY2hhbmdlcyBhbW9uZyBpdHMKKyAg ICAgICAgd2lkZ2V0cy4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEVm bC5jcHA6IGNhbGwgZXdrX3ZpZXcncyB2aXJ0dWFsIG1ldGhvZCB0bworICAgICAgICBnaXZlIGl0 IGEgY2hhbmNlIHRvIGdyYWIgZm9jdXMKKyAgICAgICAgKFdlYkNvcmU6OkNocm9tZUNsaWVudEVm bDo6Y2FuVGFrZUZvY3VzKToKKyAgICAgICAgKiBld2svZXdrX3ByaXZhdGUuaDoKKyAgICAgICAg KiBld2svZXdrX3ZpZXcuY3BwOiBhZGQgdmlydHVhbCBtZXRob2QKKyAgICAgICAgKGV3a192aWV3 X2ZvY3VzX2Nhbl9jeWNsZSk6CisgICAgICAgICogZXdrL2V3a192aWV3Lmg6IGFkZCBmb2N1cyBk aXJlY3Rpb24gZW51bSBhbmQgdmlydHVhbCBtZXRob2QKKwogMjAxMS0wOS0yNCAgQWRhbSBCYXJ0 aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIEFsd2F5cyBlbmFibGUgRU5BQkxFKE9G RkxJTkVfV0VCX0FQUExJQ0FUSU9OUykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL1dl YkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEVmbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJD b3JlU3VwcG9ydC9DaHJvbWVDbGllbnRFZmwuY3BwCmluZGV4IGQxMTEwYzNhNjhjYWQzMDUxYTAx MmNmZTVkZTE1ODc1Y2I1NzlhMDIuLjA3NTUwMTU1N2I4ZDA2YjNjMjM3OGFjZGYwMzYxNDQzYjQy MWYzMzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0Nocm9t ZUNsaWVudEVmbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQ2hy b21lQ2xpZW50RWZsLmNwcApAQCAtMjM2LDExICsyMzYsMTUgQEAgdm9pZCBDaHJvbWVDbGllbnRF Zmw6OmNsb3NlV2luZG93U29vbigpCiAgICAgZXdrX3ZpZXdfd2luZG93X2Nsb3NlKG1fdmlldyk7 CiB9CiAKLWJvb2wgQ2hyb21lQ2xpZW50RWZsOjpjYW5UYWtlRm9jdXMoRm9jdXNEaXJlY3Rpb24p Citib29sIENocm9tZUNsaWVudEVmbDo6Y2FuVGFrZUZvY3VzKEZvY3VzRGlyZWN0aW9uIGNvcmVE aXJlY3Rpb24pCiB7CiAgICAgLy8gVGhpcyBpcyBjYWxsZWQgd2hlbiBjeWNsaW5nIHRocm91Z2gg bGlua3MvZm9jdXNhYmxlIG9iamVjdHMgYW5kIHdlCiAgICAgLy8gcmVhY2ggdGhlIGxhc3QgZm9j dXNhYmxlIG9iamVjdC4KLSAgICByZXR1cm4gZmFsc2U7CisgICAgQVNTRVJUKGNvcmVEaXJlY3Rp b24gPT0gRm9jdXNEaXJlY3Rpb25Gb3J3YXJkIHx8IGNvcmVEaXJlY3Rpb24gPT0gRm9jdXNEaXJl Y3Rpb25CYWNrd2FyZCk7CisKKyAgICBFd2tfRm9jdXNfRGlyZWN0aW9uIGRpcmVjdGlvbiA9IHN0 YXRpY19jYXN0PEV3a19Gb2N1c19EaXJlY3Rpb24+KGNvcmVEaXJlY3Rpb24pOworCisgICAgcmV0 dXJuICFld2tfdmlld19mb2N1c19jYW5fY3ljbGUobV92aWV3LCBkaXJlY3Rpb24pOwogfQogCiB2 b2lkIENocm9tZUNsaWVudEVmbDo6dGFrZUZvY3VzKEZvY3VzRGlyZWN0aW9uKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19wcml2YXRlLmggYi9Tb3VyY2UvV2ViS2l0L2Vm bC9ld2svZXdrX3ByaXZhdGUuaAppbmRleCA5YzgzYTkzM2YwYjk2NjhjMDE0YjZkYjQ2ZDMxYTgw NTAwNDU5MTUwLi5lMTliMjQ4YjM2NGIyZmZlMzFiMDlmMTJmYTdiYmZhNmQ2MjY3NzczIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ByaXZhdGUuaAorKysgYi9Tb3VyY2Uv V2ViS2l0L2VmbC9ld2svZXdrX3ByaXZhdGUuaApAQCAtMTM5LDYgKzEzOSw4IEBAIHZvaWQqIGV3 a192aWV3X3Byb3RvY29sX2hhbmRsZXJfcmVzb3VyY2VfZ2V0KEV2YXNfT2JqZWN0KiBvLCBzaXpl X3QqIGJ5dGVzUmVhZCwKIHZvaWQgZXdrX3ZpZXdfZWRpdG9yX2NsaWVudF9jb250ZW50c19jaGFu Z2VkKEV2YXNfT2JqZWN0KiBvKTsKIHZvaWQgZXdrX3ZpZXdfZWRpdG9yX2NsaWVudF9zZWxlY3Rp b25fY2hhbmdlZChFdmFzX09iamVjdCogbyk7CiAKK2Jvb2wgZXdrX3ZpZXdfZm9jdXNfY2FuX2N5 Y2xlKEV2YXNfT2JqZWN0ICpvLCBFd2tfRm9jdXNfRGlyZWN0aW9uIGRpcmVjdGlvbik7CisKICNp ZiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkKIHZvaWQgZXdrX3ZpZXdfanNfd2luZG93X29i amVjdF9jbGVhcihFdmFzX09iamVjdCogbywgRXZhc19PYmplY3QqIGZyYW1lKTsKICNlbmRpZgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcCBiL1NvdXJjZS9X ZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKaW5kZXggNDgyNGNiY2EyYTA1NTkxZGQ1ZGE2YjIx ODJiMTZiNDM1MTk2MWRmMi4uOWMxZjQxZDc0ZmIwNGMwYzY1MzQ2ZjZhMzgwM2RjODNkZmU3YjEw ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCkBAIC0zMTA3LDYgKzMxMDcsMTggQEAg dm9pZCBld2tfdmlld19hZGRfY29uc29sZV9tZXNzYWdlKEV2YXNfT2JqZWN0KiBvLCBjb25zdCBj aGFyKiBtZXNzYWdlLCB1bnNpZ25lZAogICAgIHNkLT5hcGktPmFkZF9jb25zb2xlX21lc3NhZ2Uo c2QsIG1lc3NhZ2UsIGxpbmVOdW1iZXIsIHNvdXJjZUlEKTsKIH0KIAorYm9vbCBld2tfdmlld19m b2N1c19jYW5fY3ljbGUoRXZhc19PYmplY3QqIG8sIEV3a19Gb2N1c19EaXJlY3Rpb24gZGlyZWN0 aW9uKQoreworICAgIERCRygibz0lcCBkaXJlY3Rpb249JWQiLCBvLCBkaXJlY3Rpb24pOworICAg IEVXS19WSUVXX1NEX0dFVF9PUl9SRVRVUk4obywgc2QsIGZhbHNlKTsKKyAgICBFSU5BX1NBRkVU WV9PTl9OVUxMX1JFVFVSTl9WQUwoc2QtPmFwaSwgZmFsc2UpOworCisgICAgaWYgKCFzZC0+YXBp LT5mb2N1c19jYW5fY3ljbGUpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIHJldHVybiBz ZC0+YXBpLT5mb2N1c19jYW5fY3ljbGUoc2QsIGRpcmVjdGlvbik7Cit9CisKIHZvaWQgZXdrX3Zp ZXdfcnVuX2phdmFzY3JpcHRfYWxlcnQoRXZhc19PYmplY3QqIG8sIEV2YXNfT2JqZWN0KiBmcmFt ZSwgY29uc3QgY2hhciogbWVzc2FnZSkKIHsKICAgICBEQkcoIm89JXAgZnJhbWU9JXAgbWVzc2Fn ZT0lcyIsIG8sIGZyYW1lLCBtZXNzYWdlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L2V3ay9ld2tfdmlldy5oIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmgKaW5kZXgg ZWRhYzk1MmY4YjIxMzc4NWVkOTVjNmI3ZjZmMzVjMDg4ZmI3ZjM4NC4uZTZkMDQ1MTdiM2M2YjA2 ZmQwZTViODIxYTI3NWU2MmNhNGMwZmMyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwv ZXdrL2V3a192aWV3LmgKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmgKQEAg LTEwNCw2ICsxMDQsMTUgQEAgdHlwZWRlZiB2b2lkKiAoKkV3a19WaWV3X1Jlc291cmNlX0hhbmRs ZXJfQ2IpKGNvbnN0IGNoYXIgKiwgc2l6ZV90ICosIGNoYXIgKiosIHYKIAogLy8vIENyZWF0ZXMg YSB0eXBlIG5hbWUgZm9yIEBhIF9Fd2tfVmlld19TbWFydF9DbGFzcy4KIHR5cGVkZWYgc3RydWN0 IF9Fd2tfVmlld19TbWFydF9DbGFzcyBFd2tfVmlld19TbWFydF9DbGFzczsKKworLy8gRGVmaW5l cyB0aGUgZGlyZWN0aW9uIG9mIGZvY3VzIGNoYW5nZS4gS2VlcCBpbiBzeW5jIHdpdGgKKy8vIFdl YkNvcmU6OkZvY3VzRGlyZWN0aW9uLgorZW51bSBfRXdrX0ZvY3VzX0RpcmVjdGlvbiB7CisgICAg RVdLX0ZPQ1VTX0RJUkVDVElPTl9GT1JXQVJEID0gMSwKKyAgICBFV0tfRk9DVVNfRElSRUNUSU9O X0JBQ0tXQVJELAorfTsKK3R5cGVkZWYgZW51bSBfRXdrX0ZvY3VzX0RpcmVjdGlvbiBFd2tfRm9j dXNfRGlyZWN0aW9uOworCiAvLy8gRXdrIHZpZXcncyBjbGFzcywgdG8gYmUgb3ZlcnJpZGRlbiBi eSBzdWItY2xhc3Nlcy4KIHN0cnVjdCBfRXdrX1ZpZXdfU21hcnRfQ2xhc3MgewogICAgIEV2YXNf U21hcnRfQ2xhc3Mgc2M7IC8qKjwgQWxsIGJ1dCAnZGF0YScgaXMgZnJlZSB0byBiZSBjaGFuZ2Vk LiAqLwpAQCAtMTQ5LDEzICsxNTgsMTQgQEAgc3RydWN0IF9Fd2tfVmlld19TbWFydF9DbGFzcyB7 CiAgICAgRWluYV9Cb29sICgqcnVuX29wZW5fcGFuZWwpKEV3a19WaWV3X1NtYXJ0X0RhdGEgKnNk LCBFdmFzX09iamVjdCAqZnJhbWUsIEVpbmFfQm9vbCBhbGxvd3NfbXVsdGlwbGVfZmlsZXMsIGNv bnN0IGNoYXIgKmFjY2VwdF90eXBlcywgRWluYV9MaXN0ICoqc2VsZWN0ZWRfZmlsZW5hbWVzKTsK IAogICAgIEVpbmFfQm9vbCAoKm5hdmlnYXRpb25fcG9saWN5X2RlY2lzaW9uKShFd2tfVmlld19T bWFydF9EYXRhICpzZCwgRXdrX0ZyYW1lX1Jlc291cmNlX1JlcXVlc3QgKnJlcXVlc3QpOworICAg IEVpbmFfQm9vbCAoKmZvY3VzX2Nhbl9jeWNsZSkoRXdrX1ZpZXdfU21hcnRfRGF0YSAqc2QsIEV3 a19Gb2N1c19EaXJlY3Rpb24gZGlyZWN0aW9uKTsKIH07CiAKIC8qKgogICogVGhlIHZlcnNpb24g eW91IGhhdmUgdG8gcHV0IGludG8gdGhlIHZlcnNpb24gZmllbGQKICAqIGluIHRoZSBAYSBFd2tf Vmlld19TbWFydF9DbGFzcyBzdHJ1Y3R1cmUuCiAgKi8KLSNkZWZpbmUgRVdLX1ZJRVdfU01BUlRf Q0xBU1NfVkVSU0lPTiAxVUwKKyNkZWZpbmUgRVdLX1ZJRVdfU01BUlRfQ0xBU1NfVkVSU0lPTiAy VUwKIAogLyoqCiAgKiBJbml0aWFsaXplcyBhIHdob2xlIEBhIEV3a19WaWV3X1NtYXJ0X0NsYXNz IHN0cnVjdHVyZS4KQEAgLTE2Nyw3ICsxNzcsNyBAQCBzdHJ1Y3QgX0V3a19WaWV3X1NtYXJ0X0Ns YXNzIHsKICAqIEBzZWUgRVdLX1ZJRVdfU01BUlRfQ0xBU1NfSU5JVF9WRVJTSU9OCiAgKiBAc2Vl IEVXS19WSUVXX1NNQVJUX0NMQVNTX0lOSVRfTkFNRV9WRVJTSU9OCiAgKi8KLSNkZWZpbmUgRVdL X1ZJRVdfU01BUlRfQ0xBU1NfSU5JVChzbWFydF9jbGFzc19pbml0KSB7c21hcnRfY2xhc3NfaW5p dCwgRVdLX1ZJRVdfU01BUlRfQ0xBU1NfVkVSU0lPTiwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwg MCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwg MCwgMCwgMCwgMCwgMH0KKyNkZWZpbmUgRVdLX1ZJRVdfU01BUlRfQ0xBU1NfSU5JVChzbWFydF9j bGFzc19pbml0KSB7c21hcnRfY2xhc3NfaW5pdCwgRVdLX1ZJRVdfU01BUlRfQ0xBU1NfVkVSU0lP TiwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwg MCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMCwgMH0KIAogLyoqCiAgKiBJ bml0aWFsaXplcyB0byB6ZXJvIGEgd2hvbGUgQGEgRXdrX1ZpZXdfU21hcnRfQ2xhc3Mgc3RydWN0 dXJlLgo=