68696 2011-09-23 07:42:20 -0700 [Qt][WK2] QtFileDownloader ctor shouldn't call QtFileDownloader::onReadyRead() 2011-09-27 17:23:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 68962 1 jesus jesus oldest_to_newest 472225 0 jesus 2011-09-23 07:42:20 -0700 [Qt][WK2] QtFileDownloader ctor shouldn't call QtFileDownloader::onReadyRead() 472228 1 108473 jesus 2011-09-23 07:50:06 -0700 Created attachment 108473 Patch 472235 2 108473 kling 2011-09-23 07:53:55 -0700 Comment on attachment 108473 Patch r=me 472241 3 108473 jesus 2011-09-23 08:05:41 -0700 Comment on attachment 108473 Patch Clearing flags on attachment: 108473 Committed r95804: <http://trac.webkit.org/changeset/95804> 472242 4 jesus 2011-09-23 08:05:48 -0700 All reviewed patches have been landed. Closing bug. 472247 5 jesus 2011-09-23 08:12:23 -0700 Just clarifying this fix a bit: The Download object was holding a NULL pointer to QtFileDownloader because QtFileDownloader ctor was starting everything by calling onReadyRead(). So even before the return of the ctor QtFileDownloader was calling functions from Download that were trying to call back functions from a null QtFileDownloader, crashing WebProcess. Now we call the ctor and then QtFileDownloader::start(). 108473 2011-09-23 07:50:06 -0700 2011-09-23 08:05:41 -0700 Patch bug-68696-20110923114951.patch text/plain 3946 jesus U3VidmVyc2lvbiBSZXZpc2lvbjogOTU3MTUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA2Njc4NzdjM2YwNTRlZmZh NDVkZDU5NzkzYzkxYjhlZTM0NjViMTVmLi43NWY1ZTUwNTI1YjQyMjhiNzllMjM5NTIyNTkyNWI1 ODc3Y2Q3YjNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDktMjMgIEplc3Vz IFNhbmNoZXotUGFsZW5jaWEgIDxqZXN1cy5wYWxlbmNpYUBvcGVuYm9zc2Eub3JnPgorCisgICAg ICAgIFtRdF1bV0syXSBRdEZpbGVEb3dubG9hZGVyIGN0b3Igc2hvdWxkbid0IGNhbGwgUXRGaWxl RG93bmxvYWRlcjo6b25SZWFkeVJlYWQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9Njg2OTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBJbnN0ZWFkIG9mIGNvbm5lY3Rpbmcgc2lnbmFscyBhbmQgY2FsbGlu ZyBRdEZpbGVEb3dubG9hZGVyOjpvblJlYWR5UmVhZCgpCisgICAgICAgIG9uIGl0cyBjb25zdHJ1 Y3RvciwgUXRGaWxlRG93bmxvYWRlciB3aWxsIG5vdyBoYW5kbGUgdGhpcyBpbiBzdGFydCgpLgor CisgICAgICAgICogV2ViUHJvY2Vzcy9Eb3dubG9hZHMvcXQvRG93bmxvYWRRdC5jcHA6CisgICAg ICAgIChXZWJLaXQ6OkRvd25sb2FkOjpzdGFydCk6CisgICAgICAgICogV2ViUHJvY2Vzcy9Eb3du bG9hZHMvcXQvUXRGaWxlRG93bmxvYWRlci5jcHA6CisgICAgICAgIChXZWJLaXQ6OlF0RmlsZURv d25sb2FkZXI6OlF0RmlsZURvd25sb2FkZXIpOgorICAgICAgICAoV2ViS2l0OjpRdEZpbGVEb3du bG9hZGVyOjpzdGFydCk6CisgICAgICAgICogV2ViUHJvY2Vzcy9Eb3dubG9hZHMvcXQvUXRGaWxl RG93bmxvYWRlci5oOgorCiAyMDExLTA5LTIyICBBbHBoYSBMYW0gIDxoY2xhbUBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4 MDgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0Rvd25sb2Fkcy9xdC9E b3dubG9hZFF0LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvRG93bmxvYWRzL3F0L0Rv d25sb2FkUXQuY3BwCmluZGV4IDViOGZmMjliNjhiY2EzMWVmNjI5NDBiODNiNTI4Zjk4NzAyOGQw NTQuLjllZTk5OTVlODBlODgwZGRhNmQyN2M5YTNiNTBmMGMxNjFkZWEwZTAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvRG93bmxvYWRzL3F0L0Rvd25sb2FkUXQuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvRG93bmxvYWRzL3F0L0Rvd25sb2FkUXQuY3Bw CkBAIC00Niw2ICs0Niw3IEBAIHZvaWQgRG93bmxvYWQ6OnN0YXJ0KFdlYlBhZ2UqIGluaXRpYXRp bmdXZWJQYWdlKQogICAgIEFTU0VSVCghbV9xdERvd25sb2FkZXIpOwogCiAgICAgbV9xdERvd25s b2FkZXIgPSBuZXcgUXRGaWxlRG93bmxvYWRlcih0aGlzLCBhZG9wdFB0cihtYW5hZ2VyLT5nZXQo bV9yZXF1ZXN0LnRvTmV0d29ya1JlcXVlc3QoKSkpKTsKKyAgICBtX3F0RG93bmxvYWRlci0+c3Rh cnQoKTsKIH0KIAogdm9pZCBEb3dubG9hZDo6c3RhcnRXaXRoSGFuZGxlKFdlYlBhZ2UqIGluaXRp YXRpbmdQYWdlLCBSZXNvdXJjZUhhbmRsZSogaGFuZGxlLCBjb25zdCBSZXNvdXJjZVJlcXVlc3Qm IGluaXRpYWxSZXF1ZXN0LCBjb25zdCBSZXNvdXJjZVJlc3BvbnNlJiByZXNwKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Eb3dubG9hZHMvcXQvUXRGaWxlRG93bmxvYWRl ci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0Rvd25sb2Fkcy9xdC9RdEZpbGVEb3du bG9hZGVyLmNwcAppbmRleCBkMDRkYjA1NWQ1MWFiNjExMjJmNTk0ZmQxNzZlN2VmNDQyZjU5NTRh Li5jOTM2YjA4ZTcwZjkwNGNmNGI1YjMzNmY1NGI3MjY5NzdkYmVkMGY5IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0Rvd25sb2Fkcy9xdC9RdEZpbGVEb3dubG9hZGVyLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0Rvd25sb2Fkcy9xdC9RdEZpbGVEb3du bG9hZGVyLmNwcApAQCAtNDMsMTIgKzQzLDYgQEAgUXRGaWxlRG93bmxvYWRlcjo6UXRGaWxlRG93 bmxvYWRlcihEb3dubG9hZCogZG93bmxvYWQsIFBhc3NPd25QdHI8UU5ldHdvcmtSZXBseT4KICAg ICAsIG1fZXJyb3IoUU5ldHdvcmtSZXBseTo6Tm9FcnJvcikKICAgICAsIG1faGVhZGVyc1JlYWQo ZmFsc2UpCiB7Ci0gICAgY29ubmVjdChtX3JlcGx5LmdldCgpLCBTSUdOQUwocmVhZHlSZWFkKCkp LCBTTE9UKG9uUmVhZHlSZWFkKCkpKTsKLSAgICBjb25uZWN0KG1fcmVwbHkuZ2V0KCksIFNJR05B TChmaW5pc2hlZCgpKSwgU0xPVChvbkZpbmlzaGVkKCkpKTsKLSAgICBjb25uZWN0KG1fcmVwbHku Z2V0KCksIFNJR05BTChlcnJvcihRTmV0d29ya1JlcGx5OjpOZXR3b3JrRXJyb3IpKSwgU0xPVChv bkVycm9yKFFOZXR3b3JrUmVwbHk6Ok5ldHdvcmtFcnJvcikpKTsKLQotICAgIC8vIENhbGwgb25S ZWFkeVJlYWQganVzdCBpbiBjYXNlIHNvbWUgZGF0YSBpcyBhbHJlYWR5IHdhaXRpbmcuCi0gICAg b25SZWFkeVJlYWQoKTsKIH0KIAogUXRGaWxlRG93bmxvYWRlcjo6flF0RmlsZURvd25sb2FkZXIo KQpAQCAtNTksNiArNTMsMTYgQEAgUXRGaWxlRG93bmxvYWRlcjo6flF0RmlsZURvd25sb2FkZXIo KQogICAgIGFib3J0RG93bmxvYWRXcml0aW5nQW5kRW1pdEVycm9yKFF0RmlsZURvd25sb2FkZXI6 OkRvd25sb2FkRXJyb3JBYm9ydGVkKTsKIH0KIAordm9pZCBRdEZpbGVEb3dubG9hZGVyOjpzdGFy dCgpCit7CisgICAgY29ubmVjdChtX3JlcGx5LmdldCgpLCBTSUdOQUwocmVhZHlSZWFkKCkpLCBT TE9UKG9uUmVhZHlSZWFkKCkpKTsKKyAgICBjb25uZWN0KG1fcmVwbHkuZ2V0KCksIFNJR05BTChm aW5pc2hlZCgpKSwgU0xPVChvbkZpbmlzaGVkKCkpKTsKKyAgICBjb25uZWN0KG1fcmVwbHkuZ2V0 KCksIFNJR05BTChlcnJvcihRTmV0d29ya1JlcGx5OjpOZXR3b3JrRXJyb3IpKSwgU0xPVChvbkVy cm9yKFFOZXR3b3JrUmVwbHk6Ok5ldHdvcmtFcnJvcikpKTsKKworICAgIC8vIENhbGwgb25SZWFk eVJlYWQganVzdCBpbiBjYXNlIHNvbWUgZGF0YSBpcyBhbHJlYWR5IHdhaXRpbmcuCisgICAgb25S ZWFkeVJlYWQoKTsKK30KKwogdm9pZCBRdEZpbGVEb3dubG9hZGVyOjpkZXRlcm1pbmVGaWxlbmFt ZSgpCiB7CiAgICAgQVNTRVJUKCFtX2Rlc3RpbmF0aW9uRmlsZSk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0Rvd25sb2Fkcy9xdC9RdEZpbGVEb3dubG9hZGVyLmggYi9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0Rvd25sb2Fkcy9xdC9RdEZpbGVEb3dubG9hZGVyLmgK aW5kZXggNzkzOGMxZWQwZGI5ZTgzM2I0ZWMxMWE2ZGYxYWM1NjQyODhmNTNjMC4uYjZiOGJhMjhi ZWE5ZjhhYjFkNjk0Yzg0MzM0MTQ0YTRhMmM5ZDE1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9Eb3dubG9hZHMvcXQvUXRGaWxlRG93bmxvYWRlci5oCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvRG93bmxvYWRzL3F0L1F0RmlsZURvd25sb2FkZXIuaApAQCAt NDYsNiArNDYsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB+UXRGaWxlRG93bmxvYWRlcigpOwog ICAgIHZvaWQgZGVjaWRlZERlc3RpbmF0aW9uKGNvbnN0IFFTdHJpbmcmIGRlY2lkZWRGaWxlUGF0 aCwgYm9vbCBhbGxvd092ZXJ3cml0ZSk7CiAgICAgdm9pZCBjYW5jZWwoKTsKKyAgICB2b2lkIHN0 YXJ0KCk7CiAKICAgICBlbnVtIERvd25sb2FkRXJyb3IgewogICAgICAgICBEb3dubG9hZEVycm9y QWJvcnRlZCA9IDAsCg==