68680 2011-09-23 00:07:31 -0700 Let TestWebKitAPI and webkit_unit_tests work for chromium-win 2011-09-28 10:46:04 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 68678 0 wangxianzhu webkit-unassigned dglazkov tony webkit.review.bot oldest_to_newest 472095 0 wangxianzhu 2011-09-23 00:07:31 -0700 Bug 67756 and bug 68206 let TestWebKitAPI work on Chromium. However the run-api-tests script still doesn't work on chromium-win, because determineBaseProductDir() doesn't return correct value for chromium-win. I left a FIXME at http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitdirs.pm?rev=95647#L164. 472097 1 108446 wangxianzhu 2011-09-23 00:17:05 -0700 Created attachment 108446 patch I guessed the baseProductDir according to run-chromium-webkit-unit-tests.py, but I haven't tested it because I haven't a Windows build environment. 473207 2 108446 tony 2011-09-26 11:01:06 -0700 Comment on attachment 108446 patch View in context: https://bugs.webkit.org/attachment.cgi?id=108446&action=review > Tools/Scripts/webkitdirs.pm:164 > - # FIXME: set the correct baseProductDir for chromium-win. > + $baseProductDir = "$sourceDir/Source/WebKit/chromium"; I think this is $sourceDir/Source/WebKit/chromium/build after chromium r102514. 473647 3 108781 wangxianzhu 2011-09-26 19:55:14 -0700 Created attachment 108781 patch v2 The change in chromium also affected run-chromium-webkit-unit-tests. Fixed it by the way. 474115 4 108781 tony 2011-09-27 11:46:02 -0700 Comment on attachment 108781 patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=108781&action=review > Tools/Scripts/run-chromium-webkit-unit-tests:-38 > -# Allow running this script from any directory. > -my $sourceRootDir = File::Spec->catfile($FindBin::Bin, "../.."); > -chdir($sourceRootDir); Why was this removed? Did it no longer work? 474489 5 wangxianzhu 2011-09-27 21:58:50 -0700 (In reply to comment #4) > (From update of attachment 108781 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=108781&action=review > > > Tools/Scripts/run-chromium-webkit-unit-tests:-38 > > -# Allow running this script from any directory. > > -my $sourceRootDir = File::Spec->catfile($FindBin::Bin, "../.."); > > -chdir($sourceRootDir); > > Why was this removed? Did it no longer work? This is no longer needed because we use productDir() to find the executable. I've verified that there is no test depending on cwd. webkit_unit_test can be run from any dir. 474830 6 108781 webkit.review.bot 2011-09-28 10:45:59 -0700 Comment on attachment 108781 patch v2 Clearing flags on attachment: 108781 Committed r96235: <http://trac.webkit.org/changeset/96235> 474831 7 webkit.review.bot 2011-09-28 10:46:04 -0700 All reviewed patches have been landed. Closing bug. 108446 2011-09-23 00:17:05 -0700 2011-09-26 19:55:14 -0700 patch 68680 text/plain 1118 wangxianzhu SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk1Nzg2KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTMgQEAKKzIwMTEtMDktMjMgIFhpYW56aHUgV2FuZyAgPHdhbmd4aWFuemh1QGNocm9taXVt Lm9yZz4KKworICAgICAgICBMZXQgVGVzdFdlYktpdEFQSSB3b3JrIGZvciBjaHJvbWl1bS13aW4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4NjgwCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdGRpcnMucG06CisgICAgICAgIChkZXRlcm1pbmVCYXNlUHJvZHVjdERpcik6CisKIDIw MTEtMDktMjIgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg ZW5hYmxlIE5SV1QgZm9yIHJ1bi13ZWJraXQtdGVzdHMgb24gTGlvbgpJbmRleDogVG9vbHMvU2Ny aXB0cy93ZWJraXRkaXJzLnBtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0ZGly cy5wbQkocmV2aXNpb24gOTU3MjQpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0JKHdv cmtpbmcgY29weSkKQEAgLTE2MSw3ICsxNjEsNyBAQCBzdWIgZGV0ZXJtaW5lQmFzZVByb2R1Y3RE aXIKICAgICAgICAgfSBlbHNpZiAoaXNEYXJ3aW4oKSkgewogICAgICAgICAgICAgJGJhc2VQcm9k dWN0RGlyID0gIiRzb3VyY2VEaXIvU291cmNlL1dlYktpdC9jaHJvbWl1bS94Y29kZWJ1aWxkIjsK ICAgICAgICAgfSBlbHNpZiAoaXNXaW5kb3dzKCkgfHwgaXNDeWd3aW4oKSkgewotICAgICAgICAg ICAgIyBGSVhNRTogc2V0IHRoZSBjb3JyZWN0IGJhc2VQcm9kdWN0RGlyIGZvciBjaHJvbWl1bS13 aW4uCisgICAgICAgICAgICAkYmFzZVByb2R1Y3REaXIgPSAiJHNvdXJjZURpci9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtIjsKICAgICAgICAgfQogICAgIH0KIAo= 108781 2011-09-26 19:55:14 -0700 2011-09-28 10:45:59 -0700 patch v2 68680a text/plain 2186 wangxianzhu SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk2MDY3KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTQgQEAKKzIwMTEtMDktMjYgIFhpYW56aHUgV2FuZyAgPHdhbmd4aWFuemh1QGNocm9taXVt Lm9yZz4KKworICAgICAgICBMZXQgVGVzdFdlYktpdEFQSSBhbmQgd2Via2l0X3VuaXRfdGVzdHMg d29yayBmb3IgY2hyb21pdW0td2luCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD02ODY4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogU2NyaXB0cy9ydW4tY2hyb21pdW0td2Via2l0LXVuaXQtdGVzdHM6Cisg ICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAoZGV0ZXJtaW5lQmFzZVBy b2R1Y3REaXIpOgorCiAyMDExLTA5LTI2ICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgZ2FyZGVuLW8tbWF0aWMgc2hvdWxkIGJlIHByZXR0eSBpbiBP cGVuIFNhbnMuCkluZGV4OiBUb29scy9TY3JpcHRzL3J1bi1jaHJvbWl1bS13ZWJraXQtdW5pdC10 ZXN0cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3J1bi1jaHJvbWl1bS13ZWJraXQtdW5p dC10ZXN0cwkocmV2aXNpb24gOTYwNjApCisrKyBUb29scy9TY3JpcHRzL3J1bi1jaHJvbWl1bS13 ZWJraXQtdW5pdC10ZXN0cwkod29ya2luZyBjb3B5KQpAQCAtMzMsMTkgKzMzLDcgQEAgdXNlIEZp bmRCaW47CiB1c2UgbGliICRGaW5kQmluOjpCaW47CiB1c2Ugd2Via2l0ZGlyczsKIAotIyBBbGxv dyBydW5uaW5nIHRoaXMgc2NyaXB0IGZyb20gYW55IGRpcmVjdG9yeS4KLW15ICRzb3VyY2VSb290 RGlyID0gRmlsZTo6U3BlYy0+Y2F0ZmlsZSgkRmluZEJpbjo6QmluLCAiLi4vLi4iKTsKLWNoZGly KCRzb3VyY2VSb290RGlyKTsKLQorcHVzaChAQVJHViwgIi0tY2hyb21pdW0iKTsKIHNldENvbmZp Z3VyYXRpb24oKTsKLQotbXkgJHBhdGhUb0JpbmFyeTsKLWlmIChpc0RhcndpbigpKSB7Ci0gICAg JHBhdGhUb0JpbmFyeSA9ICJTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3hjb2RlYnVpbGQvIiAuIGNv bmZpZ3VyYXRpb24oKSAuICIvd2Via2l0X3VuaXRfdGVzdHMiOwotfSBlbHNpZiAoaXNDeWd3aW4o KSB8fCBpc1dpbmRvd3MoKSkgewotICAgICRwYXRoVG9CaW5hcnkgPSAiU291cmNlL1dlYktpdC9j aHJvbWl1bS8iIC4gY29uZmlndXJhdGlvbigpIC4gIi93ZWJraXRfdW5pdF90ZXN0cy5leGUiOwot fSBlbHNpZiAoaXNMaW51eCgpKSB7Ci0gICAgJHBhdGhUb0JpbmFyeSA9ICJvdXQvIiAuIGNvbmZp Z3VyYXRpb24oKSAuICIvd2Via2l0X3VuaXRfdGVzdHMiOwotfQotCitteSAkcGF0aFRvQmluYXJ5 ID0gcHJvZHVjdERpcigpIC4gIi93ZWJraXRfdW5pdF90ZXN0cyI7CiBleGl0IHN5c3RlbSAoJHBh dGhUb0JpbmFyeSwgQEFSR1YpOwpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQkocmV2aXNpb24gOTYwNjAp CisrKyBUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0JKHdvcmtpbmcgY29weSkKQEAgLTE2MSw3 ICsxNjEsNyBAQCBzdWIgZGV0ZXJtaW5lQmFzZVByb2R1Y3REaXIKICAgICAgICAgfSBlbHNpZiAo aXNEYXJ3aW4oKSkgewogICAgICAgICAgICAgJGJhc2VQcm9kdWN0RGlyID0gIiRzb3VyY2VEaXIv U291cmNlL1dlYktpdC9jaHJvbWl1bS94Y29kZWJ1aWxkIjsKICAgICAgICAgfSBlbHNpZiAoaXNX aW5kb3dzKCkgfHwgaXNDeWd3aW4oKSkgewotICAgICAgICAgICAgIyBGSVhNRTogc2V0IHRoZSBj b3JyZWN0IGJhc2VQcm9kdWN0RGlyIGZvciBjaHJvbWl1bS13aW4uCisgICAgICAgICAgICAkYmFz ZVByb2R1Y3REaXIgPSAiJHNvdXJjZURpci9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL2J1aWxkIjsK ICAgICAgICAgfQogICAgIH0KIAo=