68678 2011-09-22 21:47:02 -0700 Run TestWebKitAPI on Chromium buildbots 2011-09-29 19:24:50 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 68680 0 wangxianzhu webkit-unassigned dglazkov fishd levin peter rniwa tony webkit.review.bot oldest_to_newest 472065 0 wangxianzhu 2011-09-22 21:47:02 -0700 Bug 67756 and bug 68206 let TestWebKitAPI work on Chromium. It's good to also have it run on Chromium buildbots. 472100 1 108447 wangxianzhu 2011-09-23 00:27:16 -0700 Created attachment 108447 patch 472288 2 108447 fishd 2011-09-23 09:50:50 -0700 Comment on attachment 108447 patch View in context: https://bugs.webkit.org/attachment.cgi?id=108447&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:640 > + or platform == 'chromium-mac' or platform == 'chromium-win' or platform == 'chromium-linux') perhaps this should use platform.startswith('chromium-') instead? 472292 3 peter 2011-09-23 09:54:26 -0700 (In reply to comment #2) > (From update of attachment 108447 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=108447&action=review > > > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:640 > > + or platform == 'chromium-mac' or platform == 'chromium-win' or platform == 'chromium-linux') > > perhaps this should use platform.startswith('chromium-') instead? That wouldn't work for the Android bot, as it uses chromium-android as its platform identifier. Maybe it would be better to add an exception for that bot, given that various other bots have "chromium-cg-mac" as its platform (even though we're switching to Skia). 472313 4 108447 tony 2011-09-23 10:33:19 -0700 Comment on attachment 108447 patch r-'ing based on review feedback. I like Peter's suggestion (platform.startswith('chromium-') and platform != 'chromium-android')). 472750 5 108582 wangxianzhu 2011-09-24 04:01:46 -0700 Created attachment 108582 patch v2 (requires the patch to bug 68680 to be landed first) The new patch has only one difference from the suggested change: startswith('chromium') instead of startswith('chromium-') to keep consistent with other startwith() s in the file. Note: this patch needs to be landed after the patch to bug 68680 otherwise it would break chromium-win buildbot. 475189 6 108582 webkit.review.bot 2011-09-28 19:36:39 -0700 Comment on attachment 108582 patch v2 (requires the patch to bug 68680 to be landed first) Clearing flags on attachment: 108582 Committed r96289: <http://trac.webkit.org/changeset/96289> 475190 7 webkit.review.bot 2011-09-28 19:36:44 -0700 All reviewed patches have been landed. Closing bug. 475534 8 rniwa 2011-09-29 11:04:19 -0700 TestWebKitAPI has been failing on cr-win bots ever since it was enabled: http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29 475809 9 wangxianzhu 2011-09-29 18:54:35 -0700 (In reply to comment #8) > TestWebKitAPI has been failing on cr-win bots ever since it was enabled: > http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29 The log shows: Running build-api-tests 'Tools\Scripts\build-api-tests' is not recognized as an internal or external command, operable program or batch file. Compiling TestWebKitAPI failed! Why is 'Tools\Scripts\build-api-tests' missing? 475831 10 wangxianzhu 2011-09-29 19:24:50 -0700 bug 69121. I think I've found where the problem is. 108447 2011-09-23 00:27:16 -0700 2011-09-24 04:01:46 -0700 patch 67678 text/plain 1704 wangxianzhu SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk1Nzg3KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTIgQEAKKzIwMTEtMDktMjMgIFhpYW56aHUgV2FuZyAgPHdhbmd4aWFuemh1QGNocm9taXVt Lm9yZz4KKworICAgICAgICBSdW4gVGVzdFdlYktpdEFQSSBvbiBDaHJvbWl1bSBidWlsZGJvdHMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4Njc4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNs YXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnOgorCiAyMDExLTA5 LTIyICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIGVuYWJs ZSBOUldUIGZvciBydW4td2Via2l0LXRlc3RzIG9uIExpb24KSW5kZXg6IFRvb2xzL0J1aWxkU2xh dmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVy LmNmZwkocmV2aXNpb24gOTU3MjQpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53 ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCSh3b3JraW5nIGNvcHkpCkBAIC0zNzAsNiArMzcw LDggQEAgY2xhc3MgUnVuVW5pdFRlc3RzKHNoZWxsLlRlc3QpOgogICAgICAgICBwbGF0Zm9ybSA9 IHNlbGYuZ2V0UHJvcGVydHkoJ3BsYXRmb3JtJykKICAgICAgICAgaWYgcGxhdGZvcm0gPT0gJ3dp bic6CiAgICAgICAgICAgICBzZWxmLnNldENvbW1hbmQoc2VsZi5jb21tYW5kICsgWyctLW5vLWJ1 aWxkJ10pCisgICAgICAgIGlmIHBsYXRmb3JtLnN0YXJ0c3dpdGgoJ2Nocm9taXVtJyk6CisgICAg ICAgICAgICBzZWxmLnNldENvbW1hbmQoc2VsZi5jb21tYW5kICsgWyctLWNocm9taXVtJ10pCiAg ICAgICAgIHJldHVybiBzaGVsbC5UZXN0LnN0YXJ0KHNlbGYpCiAKIApAQCAtNjM0LDcgKzYzNiw4 IEBAIGNsYXNzIEJ1aWxkRmFjdG9yeShGYWN0b3J5KToKICAgICAgICAgICAgIHNlbGYuYWRkU3Rl cCh0cmlnZ2VyLlRyaWdnZXIsIHNjaGVkdWxlck5hbWVzPXRyaWdnZXJzKQogCiBkZWYgdW5pdFRl c3RzU3VwcG9ydGVkKGNvbmZpZ3VyYXRpb24sIHBsYXRmb3JtKToKLSAgICByZXR1cm4gcGxhdGZv cm0gPT0gJ3dpbicgb3IgKHBsYXRmb3JtLnN0YXJ0c3dpdGgoJ21hYycpIGFuZCBwbGF0Zm9ybSAh PSAnbWFjLWxlb3BhcmQnKQorICAgIHJldHVybiAocGxhdGZvcm0gPT0gJ3dpbicgb3IgKHBsYXRm b3JtLnN0YXJ0c3dpdGgoJ21hYycpIGFuZCBwbGF0Zm9ybSAhPSAnbWFjLWxlb3BhcmQnKQorICAg ICAgICAgICAgb3IgcGxhdGZvcm0gPT0gJ2Nocm9taXVtLW1hYycgb3IgcGxhdGZvcm0gPT0gJ2No cm9taXVtLXdpbicgb3IgcGxhdGZvcm0gPT0gJ2Nocm9taXVtLWxpbnV4JykKIAogY2xhc3MgVGVz dEZhY3RvcnkoRmFjdG9yeSk6CiAgICAgVGVzdENsYXNzID0gUnVuV2ViS2l0VGVzdHMK 108582 2011-09-24 04:01:46 -0700 2011-09-28 19:36:39 -0700 patch v2 (requires the patch to bug 68680 to be landed first) 68678 text/plain 1684 wangxianzhu SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk1Nzg3KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTIgQEAKKzIwMTEtMDktMjMgIFhpYW56aHUgV2FuZyAgPHdhbmd4aWFuemh1QGNocm9taXVt Lm9yZz4KKworICAgICAgICBSdW4gVGVzdFdlYktpdEFQSSBvbiBDaHJvbWl1bSBidWlsZGJvdHMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4Njc4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNs YXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnOgorCiAyMDExLTA5 LTIyICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIGVuYWJs ZSBOUldUIGZvciBydW4td2Via2l0LXRlc3RzIG9uIExpb24KSW5kZXg6IFRvb2xzL0J1aWxkU2xh dmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVy LmNmZwkocmV2aXNpb24gOTU3MjQpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53 ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCSh3b3JraW5nIGNvcHkpCkBAIC0zNzAsNiArMzcw LDggQEAgY2xhc3MgUnVuVW5pdFRlc3RzKHNoZWxsLlRlc3QpOgogICAgICAgICBwbGF0Zm9ybSA9 IHNlbGYuZ2V0UHJvcGVydHkoJ3BsYXRmb3JtJykKICAgICAgICAgaWYgcGxhdGZvcm0gPT0gJ3dp bic6CiAgICAgICAgICAgICBzZWxmLnNldENvbW1hbmQoc2VsZi5jb21tYW5kICsgWyctLW5vLWJ1 aWxkJ10pCisgICAgICAgIGlmIHBsYXRmb3JtLnN0YXJ0c3dpdGgoJ2Nocm9taXVtJyk6CisgICAg ICAgICAgICBzZWxmLnNldENvbW1hbmQoc2VsZi5jb21tYW5kICsgWyctLWNocm9taXVtJ10pCiAg ICAgICAgIHJldHVybiBzaGVsbC5UZXN0LnN0YXJ0KHNlbGYpCiAKIApAQCAtNjM0LDcgKzYzNiw4 IEBAIGNsYXNzIEJ1aWxkRmFjdG9yeShGYWN0b3J5KToKICAgICAgICAgICAgIHNlbGYuYWRkU3Rl cCh0cmlnZ2VyLlRyaWdnZXIsIHNjaGVkdWxlck5hbWVzPXRyaWdnZXJzKQogCiBkZWYgdW5pdFRl c3RzU3VwcG9ydGVkKGNvbmZpZ3VyYXRpb24sIHBsYXRmb3JtKToKLSAgICByZXR1cm4gcGxhdGZv cm0gPT0gJ3dpbicgb3IgKHBsYXRmb3JtLnN0YXJ0c3dpdGgoJ21hYycpIGFuZCBwbGF0Zm9ybSAh PSAnbWFjLWxlb3BhcmQnKQorICAgIHJldHVybiAocGxhdGZvcm0gPT0gJ3dpbicgb3IgKHBsYXRm b3JtLnN0YXJ0c3dpdGgoJ21hYycpIGFuZCBwbGF0Zm9ybSAhPSAnbWFjLWxlb3BhcmQnKQorICAg ICAgICAgICAgb3IgKHBsYXRmb3JtLnN0YXJ0c3dpdGgoJ2Nocm9taXVtJykgYW5kIHBsYXRmb3Jt ICE9ICdjaHJvbWl1bS1hbmRyb2lkJykpCiAKIGNsYXNzIFRlc3RGYWN0b3J5KEZhY3RvcnkpOgog ICAgIFRlc3RDbGFzcyA9IFJ1bldlYktpdFRlc3RzCg==