68676 2011-09-22 20:28:42 -0700 GetScopedVar should have value profiling 2011-09-22 23:58:50 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 68677 1 fpizlo webkit-unassigned webkit.review.bot oldest_to_newest 472039 0 fpizlo 2011-09-22 20:28:42 -0700 The GetScopedVar in the DFG currently has no value profiling information available to it. 472042 1 fpizlo 2011-09-22 20:32:17 -0700 This blocks https://bugs.webkit.org/show_bug.cgi?id=68677 because we don't want to turn off static speculation when we are actively emitting heap loads while having zero information about what they load. 472066 2 108439 fpizlo 2011-09-22 21:47:40 -0700 Created attachment 108439 the patch Performance neutral. 472067 3 108439 oliver 2011-09-22 21:48:57 -0700 Comment on attachment 108439 the patch r=me 472093 4 108439 webkit.review.bot 2011-09-22 23:58:46 -0700 Comment on attachment 108439 the patch Clearing flags on attachment: 108439 Committed r95786: <http://trac.webkit.org/changeset/95786> 472094 5 webkit.review.bot 2011-09-22 23:58:50 -0700 All reviewed patches have been landed. Closing bug. 108439 2011-09-22 21:47:40 -0700 2011-09-22 23:58:46 -0700 the patch getscope_patch_1.diff text/plain 7305 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTU3ODIpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjYgQEAK KzIwMTEtMDktMjIgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBH ZXRTY29wZWRWYXIgc2hvdWxkIGhhdmUgdmFsdWUgcHJvZmlsaW5nCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODY3NgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgQWRkZWQgR2V0U2NvcGVkVmFy IHZhbHVlIHByb2ZpbGluZyBhbmQgcHJlZGljdGluIHByb3BhZ2F0aW9uLgorICAgICAgICBBZGRl ZCBHZXRTY29wZUNoYWluIHRvIENTRS4KKworICAgICAgICAqIGRmZy9ERkdCeXRlQ29kZVBhcnNl ci5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6Qnl0ZUNvZGVQYXJzZXI6OnBhcnNlQmxvY2spOgor ICAgICAgICAqIGRmZy9ERkdHcmFwaC5oOgorICAgICAgICAoSlNDOjpERkc6OkdyYXBoOjpwcmVk aWN0KToKKyAgICAgICAgKiBkZmcvREZHTm9kZS5oOgorICAgICAgICAoSlNDOjpERkc6Ok5vZGU6 Omhhc1ByZWRpY3Rpb24pOgorICAgICAgICAqIGRmZy9ERkdQcm9wYWdhdG9yLmNwcDoKKyAgICAg ICAgKEpTQzo6REZHOjpQcm9wYWdhdG9yOjpwcm9wYWdhdGVOb2RlUHJlZGljdGlvbnMpOgorICAg ICAgICAoSlNDOjpERkc6OlByb3BhZ2F0b3I6OmdldFNjb3BlQ2hhaW5Mb2FkRWxpbWluYXRpb24p OgorICAgICAgICAoSlNDOjpERkc6OlByb3BhZ2F0b3I6OnBlcmZvcm1Ob2RlQ1NFKToKKyAgICAg ICAgKiBqaXQvSklUUHJvcGVydHlBY2Nlc3MuY3BwOgorICAgICAgICAoSlNDOjpKSVQ6OmVtaXRf b3BfZ2V0X3Njb3BlZF92YXIpOgorCiAyMDExLTA5LTIyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0Bh cHBsZS5jb20+CiAKICAgICAgICAgUFBDIGJ1aWxkIGZpeCwgcGFydCAzLgpJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHAJKHJldmlzaW9u IDk1NzgyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCeXRlQ29kZVBhcnNlci5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTExMTksOCArMTExOSw5IEBAIGJvb2wgQnl0ZUNvZGVQYXJz ZXI6OnBhcnNlQmxvY2sodW5zaWduZWQKICAgICAgICAgICAgIGludCBzbG90ID0gY3VycmVudElu c3RydWN0aW9uWzJdLnUub3BlcmFuZDsKICAgICAgICAgICAgIGludCBkZXB0aCA9IGN1cnJlbnRJ bnN0cnVjdGlvblszXS51Lm9wZXJhbmQ7CiAgICAgICAgICAgICBOb2RlSW5kZXggZ2V0U2NvcGVD aGFpbiA9IGFkZFRvR3JhcGgoR2V0U2NvcGVDaGFpbiwgT3BJbmZvKGRlcHRoKSk7Ci0gICAgICAg ICAgICBOb2RlSW5kZXggZ2V0U2NvcGVkVmFyID0gYWRkVG9HcmFwaChHZXRTY29wZWRWYXIsIE9w SW5mbyhzbG90KSwgZ2V0U2NvcGVDaGFpbik7CisgICAgICAgICAgICBOb2RlSW5kZXggZ2V0U2Nv cGVkVmFyID0gYWRkVG9HcmFwaChHZXRTY29wZWRWYXIsIE9wSW5mbyhzbG90KSwgT3BJbmZvKFBy ZWRpY3ROb25lKSwgZ2V0U2NvcGVDaGFpbik7CiAgICAgICAgICAgICBzZXQoZHN0LCBnZXRTY29w ZWRWYXIpOworICAgICAgICAgICAgc3Ryb25nbHlQcmVkaWN0KGdldFNjb3BlZFZhcik7CiAgICAg ICAgICAgICBORVhUX09QQ09ERShvcF9nZXRfc2NvcGVkX3Zhcik7CiAgICAgICAgIH0KICAgICAg ICAgY2FzZSBvcF9wdXRfc2NvcGVkX3ZhcjogewpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdHcmFwaC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHR3JhcGguaAkocmV2aXNpb24gOTU3ODIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZn L0RGR0dyYXBoLmgJKHdvcmtpbmcgY29weSkKQEAgLTE5Niw2ICsxOTYsNyBAQCBwdWJsaWM6CiAg ICAgICAgIGNhc2UgQ2FsbDoKICAgICAgICAgY2FzZSBDb25zdHJ1Y3Q6CiAgICAgICAgIGNhc2Ug R2V0QnlPZmZzZXQ6CisgICAgICAgIGNhc2UgR2V0U2NvcGVkVmFyOgogICAgICAgICAgICAgcmV0 dXJuIG5vZGUucHJlZGljdChwcmVkaWN0aW9uLCBzb3VyY2UpOwogICAgICAgICBkZWZhdWx0Ogog ICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdOb2RlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdO b2RlLmgJKHJldmlzaW9uIDk1NzgyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdO b2RlLmgJKHdvcmtpbmcgY29weSkKQEAgLTYyNCw2ICs2MjQsNyBAQCBzdHJ1Y3QgTm9kZSB7CiAg ICAgICAgIGNhc2UgQ2FsbDoKICAgICAgICAgY2FzZSBDb25zdHJ1Y3Q6CiAgICAgICAgIGNhc2Ug R2V0QnlPZmZzZXQ6CisgICAgICAgIGNhc2UgR2V0U2NvcGVkVmFyOgogICAgICAgICAgICAgcmV0 dXJuIHRydWU7CiAgICAgICAgIGRlZmF1bHQ6CiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7Cklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1Byb3BhZ2F0b3IuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHUHJvcGFnYXRvci5jcHAJKHJldmlz aW9uIDk1NzgyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdQcm9wYWdhdG9yLmNw cAkod29ya2luZyBjb3B5KQpAQCAtNDcxLDcgKzQ3MSw3IEBAIHByaXZhdGU6CiAgICAgICAgICAg ICBjaGFuZ2VkIHw9IG1lcmdlVXNlKG5vZGUuY2hpbGQxKCksIFByZWRpY3RPYmplY3RVbmtub3du IHwgU3Ryb25nUHJlZGljdGlvblRhZyk7CiAgICAgICAgICAgICBjaGFuZ2VkIHw9IG5vZGUucHJl ZGljdChtX3VzZXNbbV9jb21waWxlSW5kZXhdICYgflByZWRpY3Rpb25UYWdNYXNrLCBTdHJvbmdQ cmVkaWN0aW9uKTsKICAgICAgICAgICAgIGlmIChpc1N0cm9uZ1ByZWRpY3Rpb24obm9kZS5nZXRQ cmVkaWN0aW9uKCkpKQotICAgICAgICAgICAgICAgIGNoYW5nZWQgfD0gc2V0UHJlZGljdGlvbihu b2RlLmdldFByZWRpY3Rpb24oKSk7CisgICAgICAgICAgICAgICAgY2hhbmdlZCB8PSBtZXJnZVBy ZWRpY3Rpb24obm9kZS5nZXRQcmVkaWN0aW9uKCkpOwogICAgICAgICAgICAgYnJlYWs7CiAgICAg ICAgIH0KICAgICAgICAgICAgIApAQCAtNDg5LDcgKzQ4OSw3IEBAIHByaXZhdGU6CiAgICAgICAg IGNhc2UgR2V0QnlPZmZzZXQ6IHsKICAgICAgICAgICAgIGNoYW5nZWQgfD0gbm9kZS5wcmVkaWN0 KG1fdXNlc1ttX2NvbXBpbGVJbmRleF0gJiB+UHJlZGljdGlvblRhZ01hc2ssIFN0cm9uZ1ByZWRp Y3Rpb24pOwogICAgICAgICAgICAgaWYgKGlzU3Ryb25nUHJlZGljdGlvbihub2RlLmdldFByZWRp Y3Rpb24oKSkpCi0gICAgICAgICAgICAgICAgY2hhbmdlZCB8PSBzZXRQcmVkaWN0aW9uKG5vZGUu Z2V0UHJlZGljdGlvbigpKTsKKyAgICAgICAgICAgICAgICBjaGFuZ2VkIHw9IG1lcmdlUHJlZGlj dGlvbihub2RlLmdldFByZWRpY3Rpb24oKSk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAg fQogICAgICAgICAgICAgCkBAIC01MDQsNyArNTA0LDcgQEAgcHJpdmF0ZToKICAgICAgICAgICAg IGNoYW5nZWQgfD0gbWVyZ2VVc2UobV9ncmFwaC5tX3ZhckFyZ0NoaWxkcmVuW25vZGUuZmlyc3RD aGlsZCgpXSwgUHJlZGljdE9iamVjdFVua25vd24gfCBTdHJvbmdQcmVkaWN0aW9uVGFnKTsKICAg ICAgICAgICAgIGNoYW5nZWQgfD0gbm9kZS5wcmVkaWN0KG1fdXNlc1ttX2NvbXBpbGVJbmRleF0g JiB+UHJlZGljdGlvblRhZ01hc2ssIFN0cm9uZ1ByZWRpY3Rpb24pOwogICAgICAgICAgICAgaWYg KGlzU3Ryb25nUHJlZGljdGlvbihub2RlLmdldFByZWRpY3Rpb24oKSkpCi0gICAgICAgICAgICAg ICAgY2hhbmdlZCB8PSBzZXRQcmVkaWN0aW9uKG5vZGUuZ2V0UHJlZGljdGlvbigpKTsKKyAgICAg ICAgICAgICAgICBjaGFuZ2VkIHw9IG1lcmdlUHJlZGljdGlvbihub2RlLmdldFByZWRpY3Rpb24o KSk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQogICAgICAgICAgICAgCkBAIC01Mjcs NiArNTI3LDE5IEBAIHByaXZhdGU6CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQogICAg ICAgICAgICAgCisgICAgICAgIGNhc2UgR2V0U2NvcGVkVmFyOiB7CisgICAgICAgICAgICBjaGFu Z2VkIHw9IG5vZGUucHJlZGljdChtX3VzZXNbbV9jb21waWxlSW5kZXhdICYgflByZWRpY3Rpb25U YWdNYXNrLCBTdHJvbmdQcmVkaWN0aW9uKTsKKyAgICAgICAgICAgIFByZWRpY3RlZFR5cGUgcHJl ZGljdGlvbiA9IG5vZGUuZ2V0UHJlZGljdGlvbigpOworICAgICAgICAgICAgaWYgKGlzU3Ryb25n UHJlZGljdGlvbihwcmVkaWN0aW9uKSkKKyAgICAgICAgICAgICAgICBjaGFuZ2VkIHw9IG1lcmdl UHJlZGljdGlvbihwcmVkaWN0aW9uKTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICB9Cisg ICAgICAgICAgICAKKyAgICAgICAgY2FzZSBHZXRTY29wZUNoYWluOiB7CisgICAgICAgICAgICBj aGFuZ2VkIHw9IHNldFByZWRpY3Rpb24obWFrZVByZWRpY3Rpb24oUHJlZGljdENlbGxPdGhlciwg U3Ryb25nUHJlZGljdGlvbikpOworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIH0KKyAgICAg ICAgICAgIAogICAgICAgICBjYXNlIFB1dEJ5VmFsOgogICAgICAgICBjYXNlIFB1dEJ5VmFsQWxp YXM6CiAgICAgICAgIGNhc2UgUHV0QnlJZDoKQEAgLTUzNSw3ICs1NDgsNiBAQCBwcml2YXRlOgog ICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KIAotICAgICAgICBjYXNlIEdldFNjb3BlQ2hh aW46CiAgICAgICAgIGNhc2UgR2V0Q2FsbGVlOiB7CiAgICAgICAgICAgICBjaGFuZ2VkIHw9IHNl dFByZWRpY3Rpb24obWFrZVByZWRpY3Rpb24oUHJlZGljdE9iamVjdE90aGVyLCBTdHJvbmdQcmVk aWN0aW9uKSk7CiAgICAgICAgICAgICBicmVhazsKQEAgLTU4Nyw3ICs1OTksNiBAQCBwcml2YXRl OgogICAgICAgICBjYXNlIFJlc29sdmU6CiAgICAgICAgIGNhc2UgUmVzb2x2ZUJhc2U6CiAgICAg ICAgIGNhc2UgUmVzb2x2ZUJhc2VTdHJpY3RQdXQ6Ci0gICAgICAgIGNhc2UgR2V0U2NvcGVkVmFy OgogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICAKICAgICAgICAgLy8gVGhpcyBnZXRz IGlnbm9yZWQgYmVjYXVzZSBpdCBkb2Vzbid0IGRvIGFueXRoaW5nLgpAQCAtOTc2LDYgKzk4Nywx OCBAQCBwcml2YXRlOgogICAgICAgICByZXR1cm4gTm9Ob2RlOwogICAgIH0KICAgICAKKyAgICBO b2RlSW5kZXggZ2V0U2NvcGVDaGFpbkxvYWRFbGltaW5hdGlvbih1bnNpZ25lZCBkZXB0aCkKKyAg ICB7CisgICAgICAgIE5vZGVJbmRleCBzdGFydCA9IHN0YXJ0SW5kZXhGb3JDaGlsZHJlbigpOwor ICAgICAgICBmb3IgKE5vZGVJbmRleCBpbmRleCA9IGVuZEluZGV4Rm9yUHVyZUNTRSgpOyBpbmRl eC0tID4gc3RhcnQ7KSB7CisgICAgICAgICAgICBOb2RlJiBub2RlID0gbV9ncmFwaFtpbmRleF07 CisgICAgICAgICAgICBpZiAobm9kZS5vcCA9PSBHZXRTY29wZUNoYWluCisgICAgICAgICAgICAg ICAgJiYgbm9kZS5zY29wZUNoYWluRGVwdGgoKSA9PSBkZXB0aCkKKyAgICAgICAgICAgICAgICBy ZXR1cm4gaW5kZXg7CisgICAgICAgIH0KKyAgICAgICAgcmV0dXJuIE5vTm9kZTsKKyAgICB9Cisg ICAgCiAgICAgdm9pZCBwZXJmb3JtU3Vic3RpdHV0aW9uKE5vZGVJbmRleCYgY2hpbGQpCiAgICAg ewogICAgICAgICAvLyBDaGVjayBpZiB0aGlzIG9wZXJhbmQgaXMgYWN0dWFsbHkgdW51c2VkLgpA QCAtMTA2Nyw2ICsxMDkwLDEwIEBAIHByaXZhdGU6CiAgICAgICAgICAgICBzZXRSZXBsYWNlbWVu dChwdXJlQ1NFKG5vZGUpKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgCisgICAg ICAgIGNhc2UgR2V0U2NvcGVDaGFpbjoKKyAgICAgICAgICAgIHNldFJlcGxhY2VtZW50KGdldFNj b3BlQ2hhaW5Mb2FkRWxpbWluYXRpb24obm9kZS5zY29wZUNoYWluRGVwdGgoKSkpOworICAgICAg ICAgICAgYnJlYWs7CisKICAgICAgICAgLy8gSGFuZGxlIG5vZGVzIHRoYXQgYXJlIGNvbmRpdGlv bmFsbHkgcHVyZTogdGhlc2UgYXJlIHB1cmUsIGFuZCBjYW4KICAgICAgICAgLy8gYmUgQ1NFJ2Qs IHNvIGxvbmcgYXMgdGhlIHByZWRpY3Rpb24gaXMgdGhlIG9uZSB3ZSB3YW50LgogICAgICAgICBj YXNlIFZhbHVlQWRkOgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRQcm9wZXJ0 eUFjY2Vzcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRQ cm9wZXJ0eUFjY2Vzcy5jcHAJKHJldmlzaW9uIDk1NzgyKQorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL2ppdC9KSVRQcm9wZXJ0eUFjY2Vzcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk2NSw2ICs5 NjUsNyBAQCB2b2lkIEpJVDo6ZW1pdF9vcF9nZXRfc2NvcGVkX3ZhcihJbnN0cnVjCiAgICAgbG9h ZFB0cihBZGRyZXNzKHJlZ1QwLCBPQkpFQ1RfT0ZGU0VUT0YoU2NvcGVDaGFpbk5vZGUsIG9iamVj dCkpLCByZWdUMCk7CiAgICAgbG9hZFB0cihBZGRyZXNzKHJlZ1QwLCBKU1ZhcmlhYmxlT2JqZWN0 OjpvZmZzZXRPZlJlZ2lzdGVycygpKSwgcmVnVDApOwogICAgIGxvYWRQdHIoQWRkcmVzcyhyZWdU MCwgY3VycmVudEluc3RydWN0aW9uWzJdLnUub3BlcmFuZCAqIHNpemVvZihSZWdpc3RlcikpLCBy ZWdUMCk7CisgICAgZW1pdFZhbHVlUHJvZmlsaW5nU2l0ZShGaXJzdFByb2ZpbGluZ1NpdGUpOwog ICAgIGVtaXRQdXRWaXJ0dWFsUmVnaXN0ZXIoY3VycmVudEluc3RydWN0aW9uWzFdLnUub3BlcmFu ZCk7CiB9CiAK