68673 2011-09-22 18:09:13 -0700 enable NRWT for run-webkit-tests on Lion 2011-09-23 17:08:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke darin eric simon.fraser webkit.review.bot wsiegrist oldest_to_newest 471993 0 dpranke 2011-09-22 18:09:13 -0700 enable NRWT for run-webkit-tests on Lion 471994 1 108435 dpranke 2011-09-22 18:09:55 -0700 Created attachment 108435 Patch 471997 2 dpranke 2011-09-22 18:14:58 -0700 I don't actually have a Lion box handy to test this and make sure it works; it seems like we should probably test this somewhere before we just land this and the bot picks it up automatically (IIRC how the bot is configured) ... 471998 3 108435 eric 2011-09-22 18:17:56 -0700 Comment on attachment 108435 Patch LGTM. 471999 4 eric 2011-09-22 18:18:26 -0700 I just don't have a lion box yet, that's why this hasn't been flipped. But assuming new-run-webkit-tests works fine stand-alone on lion, this should work just fine. 472051 5 108435 webkit.review.bot 2011-09-22 20:59:25 -0700 Comment on attachment 108435 Patch Clearing flags on attachment: 108435 Committed r95781: <http://trac.webkit.org/changeset/95781> 472052 6 webkit.review.bot 2011-09-22 20:59:29 -0700 All reviewed patches have been landed. Closing bug. 472296 7 darin 2011-09-23 10:08:48 -0700 I think this should be changed to a “deny” list instead of an “allow” list for OS X versions. When we are working on future versions post-Lion it is no good to fall back to the old run-webkit-tests! 472328 8 dpranke 2011-09-23 10:51:25 -0700 (In reply to comment #7) > I think this should be changed to a “deny” list instead of an “allow” list for OS X versions. When we are working on future versions post-Lion it is no good to fall back to the old run-webkit-tests! Makes sense. We should probably change this to a deny list, period. 472633 9 eric 2011-09-23 17:08:45 -0700 I strongly support using a blacklist instead of a whitelist. However, you should note I tried that and failed once: http://trac.webkit.org/changeset/90440/trunk/Tools/Scripts/run-webkit-tests Had to roll out the blacklist due to webkitdir.pm's behavior of removing arguments (or not removing arguments) based on if isGtk/isPort() whatever being called: http://trac.webkit.org/changeset/90449/trunk/Tools/Scripts/run-webkit-tests 108435 2011-09-22 18:09:55 -0700 2011-09-22 20:59:25 -0700 Patch bug-68673-20110922180953.patch text/plain 1250 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogOTU3MTgKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhYzU4OWFjN2JjYmU5OTNkZjY0ZTliMzMzMGU3NjY1MTVl NmI2MzcwLi43ODIzNDVjNjU3MmU0N2U4MTY0NTk1ZmY3ZTE4OWJjNzI1ZmJmZGQzIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDktMjIgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgZW5hYmxlIE5SV1QgZm9yIHJ1bi13ZWJraXQtdGVzdHMgb24gTGlvbgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njg2NzMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLXdlYmtp dC10ZXN0czoKKyAgICAgICAgKHVzZU5ld1J1bldlYktpdFRlc3RzKToKKwogMjAxMS0wOS0yMSAg QW5uYSBDYXZlbmRlciAgPGFubmFjY0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVXBkYXRlIGNv bW1pdHRlcnMucHkgd2l0aCBhIG5ldyBjb250cmlidXRvciBjb250YWN0ICAgICAgICAKZGlmZiAt LWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cyBiL1Rvb2xzL1NjcmlwdHMvcnVu LXdlYmtpdC10ZXN0cwppbmRleCA1ZTJlODAxODE5MmUwODY5Y2Y5ODc2NDRkZGNhYjlkNDNkNTc0 NDMwLi4xMjE2ZjM1ZTZjNDZmMjRhNTY5Mzc4YmM1OTdhMTQ3MTk3ZDhhMjNjIDEwMDc1NQotLS0g YS9Ub29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4t d2Via2l0LXRlc3RzCkBAIC05MCw3ICs5MCw3IEBAIHN1YiB1c2VOZXdSdW5XZWJLaXRUZXN0cygp CiAgICAgICAgIHJldHVybiAoIWlzRGFyd2luKCkgYW5kICFpc0FSTSgpIGFuZCAoZ2V0UXRWZXJz aW9uKCkgbmUgIjQuOCIpKTsKICAgICB9CiAKLSAgICByZXR1cm4gKChpc0xlb3BhcmQoKSBvciBp c1Nub3dMZW9wYXJkKCkgb3IgaXNHdGsoKSkgYW5kICF1c2luZ1dlYktpdDIoKSBhbmQgIXVzaW5n TGVha3MoKSk7CisgICAgcmV0dXJuICgoaXNMZW9wYXJkKCkgb3IgaXNTbm93TGVvcGFyZCgpIG9y IGlzTGlvbigpIG9yIGlzR3RrKCkpIGFuZCAhdXNpbmdXZWJLaXQyKCkgYW5kICF1c2luZ0xlYWtz KCkpOwogfQogCiBteSAkaGFybmVzc05hbWUgPSAib2xkLXJ1bi13ZWJraXQtdGVzdHMiOwo=