68669 2011-09-22 17:33:13 -0700 Remove unneeded type conversion from background bleed code 2011-09-23 09:59:11 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 darin darin aroben webkit.review.bot oldest_to_newest 471969 0 darin 2011-09-22 17:33:13 -0700 Remove unneeded type conversion from background bleed code 471971 1 108429 darin 2011-09-22 17:33:55 -0700 Created attachment 108429 Patch 471975 2 108429 ggaren 2011-09-22 17:38:09 -0700 Comment on attachment 108429 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108429&action=review r=me > Source/WebCore/rendering/RenderBoxModelObject.cpp:593 > + adjustedRect.inflateX(-ceil(1 / transform.xScale())); > + adjustedRect.inflateY(-ceil(1 / transform.yScale())); Maybe 1.0 would be clearer here. 471982 3 108429 darin 2011-09-22 17:44:51 -0700 Comment on attachment 108429 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108429&action=review >> Source/WebCore/rendering/RenderBoxModelObject.cpp:593 >> + adjustedRect.inflateY(-ceil(1 / transform.yScale())); > > Maybe 1.0 would be clearer here. I like the 1 fine. Using 1.0 would subtly impose a conversion to double if the other type happened to be float. I prefer to just leave it off. 472035 4 108429 webkit.review.bot 2011-09-22 20:20:19 -0700 Comment on attachment 108429 Patch Clearing flags on attachment: 108429 Committed r95778: <http://trac.webkit.org/changeset/95778> 472036 5 webkit.review.bot 2011-09-22 20:20:23 -0700 All reviewed patches have been landed. Closing bug. 472173 6 aroben 2011-09-23 05:16:40 -0700 Looks like this broke 32-bit builds, with warnings like the following: WebCore/rendering/RenderBoxModelObject.cpp: In function 'WebCore::LayoutRect WebCore::backgroundRectAdjustedForBleedAvoidance(WebCore::GraphicsContext*, const WebCore::LayoutRect&, WebCore::BackgroundBleedAvoidance)': WebCore/rendering/RenderBoxModelObject.cpp:592: warning: implicit conversion shortens 64-bit value into a 32-bit value WebCore/rendering/RenderBoxModelObject.cpp:593: warning: implicit conversion shortens 64-bit value into a 32-bit value 472291 7 darin 2011-09-23 09:54:01 -0700 (In reply to comment #6) > Looks like this broke 32-bit builds, with warnings like the following: > > > WebCore/rendering/RenderBoxModelObject.cpp: In function 'WebCore::LayoutRect WebCore::backgroundRectAdjustedForBleedAvoidance(WebCore::GraphicsContext*, const WebCore::LayoutRect&, WebCore::BackgroundBleedAvoidance)': > WebCore/rendering/RenderBoxModelObject.cpp:592: warning: implicit conversion shortens 64-bit value into a 32-bit value > WebCore/rendering/RenderBoxModelObject.cpp:593: warning: implicit conversion shortens 64-bit value into a 32-bit value I’ll fix that right now. 472293 8 darin 2011-09-23 09:55:30 -0700 I’ll fix this by adding a cast. But that warning seems pointless. And this has nothing to do with 32 vs. 64-bit builds. The type float is always 32 and the type double is always 64. I think it might even be a compiler bug. 472294 9 darin 2011-09-23 09:59:11 -0700 (In reply to comment #6) > Looks like this broke 32-bit builds Thanks for the heads up, and thanks for not just rolling it out! 108429 2011-09-22 17:33:55 -0700 2011-09-22 20:20:19 -0700 Patch bug-68669-20110922173355.patch text/plain 1886 darin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk1NzY1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDktMjIgIERhcmluIEFk bGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSB1bm5lZWRlZCB0eXBlIGNv bnZlcnNpb24gZnJvbSBiYWNrZ3JvdW5kIGJsZWVkIGNvZGUKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4NjY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmpl Y3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6YmFja2dyb3VuZFJlY3RBZGp1c3RlZEZvckJsZWVk QXZvaWRhbmNlKTogVXNlIGNlaWwgaW5zdGVhZCBvZiBjZWlsZgorICAgICAgICBhbmQgZWxpbWlu YXRlIHN1cGVyZmxvdXMgY29udmVyc2lvbiB0byBmbG9hdCBhbmQgdXNlIG9mIEZsb2F0U2l6ZS4g QWxzbyBhZGRlZAorICAgICAgICBhICJ3aHkiIGNvbW1lbnQuCisKIDIwMTEtMDktMjIgIEFuZGVy cyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtlIHN1cmUgdG8g dXBkYXRlIHNjcm9sbGJhcnMgaW4gU2Nyb2xsVmlldzo6c2V0RnJhbWVSZWN0CkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5jcHAJKHJl dmlzaW9uIDk1NzYxKQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveE1vZGVs T2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTg2LDEyICs1ODYsMTEgQEAgc3RhdGljIExh eW91dFJlY3QgYmFja2dyb3VuZFJlY3RBZGp1c3RlZAogICAgIGlmIChibGVlZEF2b2lkYW5jZSAh PSBCYWNrZ3JvdW5kQmxlZWRTaHJpbmtCYWNrZ3JvdW5kKQogICAgICAgICByZXR1cm4gYm9yZGVy UmVjdDsKIAorICAgIC8vIFdlIHNocmluayB0aGUgcmVjdGFuZ2xlIGJ5IG9uZSBwaXhlbCBvbiBl YWNoIHNpZGUgYmVjYXVzZSB0aGUgYmxlZWQgaXMgb25lIHBpeGVsIG1heGltdW0uCisgICAgQWZm aW5lVHJhbnNmb3JtIHRyYW5zZm9ybSA9IGNvbnRleHQtPmdldENUTSgpOwogICAgIExheW91dFJl Y3QgYWRqdXN0ZWRSZWN0ID0gYm9yZGVyUmVjdDsKLSAgICAvLyBXZSBuZWVkIHRvIHNocmluayB0 aGUgYm9yZGVyIGJ5IG9uZSBkZXZpY2UgcGl4ZWwgb24gZWFjaCBzaWRlLgotICAgIEFmZmluZVRy YW5zZm9ybSBjdG0gPSBjb250ZXh0LT5nZXRDVE0oKTsKLSAgICBGbG9hdFNpemUgY29udGV4dFNj YWxlKHN0YXRpY19jYXN0PGZsb2F0PihjdG0ueFNjYWxlKCkpLCBzdGF0aWNfY2FzdDxmbG9hdD4o Y3RtLnlTY2FsZSgpKSk7Ci0gICAgYWRqdXN0ZWRSZWN0LmluZmxhdGVYKC1jZWlsZigxIC8gY29u dGV4dFNjYWxlLndpZHRoKCkpKTsKLSAgICBhZGp1c3RlZFJlY3QuaW5mbGF0ZVkoLWNlaWxmKDEg LyBjb250ZXh0U2NhbGUuaGVpZ2h0KCkpKTsKKyAgICBhZGp1c3RlZFJlY3QuaW5mbGF0ZVgoLWNl aWwoMSAvIHRyYW5zZm9ybS54U2NhbGUoKSkpOworICAgIGFkanVzdGVkUmVjdC5pbmZsYXRlWSgt Y2VpbCgxIC8gdHJhbnNmb3JtLnlTY2FsZSgpKSk7CiAgICAgcmV0dXJuIGFkanVzdGVkUmVjdDsK IH0KIAo=