68667 2011-09-22 17:23:31 -0700 Use AffineTransform scale functions in ShadowBlur::adjustBlurRadius 2011-09-23 13:17:04 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 68722 1 darin darin jchaffraix simon.fraser webkit.review.bot oldest_to_newest 471958 0 darin 2011-09-22 17:23:31 -0700 Use AffineTransform scale functions in ShadowBlur::adjustBlurRadius 471960 1 108425 darin 2011-09-22 17:24:51 -0700 Created attachment 108425 Patch 471961 2 darin 2011-09-22 17:25:36 -0700 Simon, please let me know if you think the new code will not do the same thing as the existing code. 471966 3 108425 simon.fraser 2011-09-22 17:29:23 -0700 Comment on attachment 108425 Patch Looks right to me. 472054 4 108425 webkit.review.bot 2011-09-22 21:09:30 -0700 Comment on attachment 108425 Patch Clearing flags on attachment: 108425 Committed r95782: <http://trac.webkit.org/changeset/95782> 472055 5 webkit.review.bot 2011-09-22 21:09:34 -0700 All reviewed patches have been landed. Closing bug. 472431 6 108425 jchaffraix 2011-09-23 13:01:24 -0700 Comment on attachment 108425 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108425&action=review > Source/WebCore/platform/graphics/ShadowBlur.cpp:359 > + m_blurRadius.scale(1 / transform.xScale(), 1 / transform.yScale()); This line is failing on the Intel Debug bot. Here is the message: ShadowBlur.cpp:359: warning: implicit conversion shortens 64-bit value into a 32-bit value ShadowBlur.cpp:359: warning: implicit conversion shortens 64-bit value into a 32-bit value xScale() and yScale() return a double that gets rounded to a float in FloatSize::scale(). Should I file a follow-up bug to fix the bot? 472432 7 simon.fraser 2011-09-23 13:04:29 -0700 Yes please (or just post a patch here). 108425 2011-09-22 17:24:51 -0700 2011-09-23 13:01:24 -0700 Patch bug-68667-20110922172450.patch text/plain 2531 darin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk1NzY1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDktMjIgIERhcmluIEFk bGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFVzZSBBZmZpbmVUcmFuc2Zvcm0gc2Nh bGUgZnVuY3Rpb25zIGluIFNoYWRvd0JsdXI6OmFkanVzdEJsdXJSYWRpdXMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4NjY3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9T aGFkb3dCbHVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNoYWRvd0JsdXI6OmFkanVzdEJsdXJS YWRpdXMpOiBVc2UgQWZmaW5lVHJhbnNmb3JtOjp4U2NhbGUgYW5kCisgICAgICAgIEFmZmluZVRy YW5zZm9ybTo6eVNjYWxlIGluc3RlYWQgb2YgdGhlIGN1c3RvbSBjb2RlIGhlcmUgdGhhdCBzZWVt cyB0byBkbworICAgICAgICB0aGUgc2FtZSB0aGluZy4KKwogMjAxMS0wOS0yMiAgQW5kZXJzIENh cmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2Ugc3VyZSB0byB1cGRh dGUgc2Nyb2xsYmFycyBpbiBTY3JvbGxWaWV3OjpzZXRGcmFtZVJlY3QKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1NoYWRvd0JsdXIuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1NoYWRvd0JsdXIuY3BwCShyZXZpc2lvbiA5 NTc2MSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1NoYWRvd0JsdXIuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0zNTUsMzAgKzM1NSw4IEBAIHZvaWQgU2hhZG93Qmx1cjo6YWRq dXN0Qmx1clJhZGl1cyhHcmFwaGkKICAgICBpZiAoIW1fc2hhZG93c0lnbm9yZVRyYW5zZm9ybXMp CiAgICAgICAgIHJldHVybjsKIAotICAgIGNvbnN0IEFmZmluZVRyYW5zZm9ybSB0cmFuc2Zvcm0g PSBjb250ZXh0LT5nZXRDVE0oKTsKLQotICAgIC8vIEFkanVzdCBibHVyIGlmIHdlJ3JlIHNjYWxp bmcsIHNpbmNlIHRoZSByYWRpdXMgbXVzdCBub3QgYmUgYWZmZWN0ZWQgYnkgdHJhbnNmb3JtYXRp b25zLgotICAgIC8vIEZJWE1FOiB1c2UgQWZmaW5lVHJhbnNmb3JtOjppc0lkZW50aXR5T3JUcmFu c2xhdGlvbk9yRmxpcHBlZCgpPwotICAgIGlmICh0cmFuc2Zvcm0uaXNJZGVudGl0eSgpKQotICAg ICAgICByZXR1cm47Ci0KLSAgICAvLyBDYWxjdWxhdGUgdHJhbnNmb3JtZWQgdW5pdCB2ZWN0b3Jz LgotICAgIGNvbnN0IEZsb2F0UXVhZCB1bml0UXVhZChGbG9hdFBvaW50KDAsIDApLCBGbG9hdFBv aW50KDEsIDApLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICBGbG9hdFBvaW50KDAsIDEp LCBGbG9hdFBvaW50KDEsIDEpKTsKLSAgICBjb25zdCBGbG9hdFF1YWQgdHJhbnNmb3JtZWRVbml0 UXVhZCA9IHRyYW5zZm9ybS5tYXBRdWFkKHVuaXRRdWFkKTsKLQotICAgIC8vIENhbGN1bGF0ZSBY IGF4aXMgc2NhbGUgZmFjdG9yLgotICAgIGNvbnN0IEZsb2F0U2l6ZSB4VW5pdENoYW5nZSA9IHRy YW5zZm9ybWVkVW5pdFF1YWQucDIoKSAtIHRyYW5zZm9ybWVkVW5pdFF1YWQucDEoKTsKLSAgICBj b25zdCBmbG9hdCB4QXhpc1NjYWxlID0gc3FydGYoeFVuaXRDaGFuZ2Uud2lkdGgoKSAqIHhVbml0 Q2hhbmdlLndpZHRoKCkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKyB4VW5p dENoYW5nZS5oZWlnaHQoKSAqIHhVbml0Q2hhbmdlLmhlaWdodCgpKTsKLQotICAgIC8vIENhbGN1 bGF0ZSBZIGF4aXMgc2NhbGUgZmFjdG9yLgotICAgIGNvbnN0IEZsb2F0U2l6ZSB5VW5pdENoYW5n ZSA9IHRyYW5zZm9ybWVkVW5pdFF1YWQucDMoKSAtIHRyYW5zZm9ybWVkVW5pdFF1YWQucDEoKTsK LSAgICBjb25zdCBmbG9hdCB5QXhpc1NjYWxlID0gc3FydGYoeVVuaXRDaGFuZ2Uud2lkdGgoKSAq IHlVbml0Q2hhbmdlLndpZHRoKCkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg KyB5VW5pdENoYW5nZS5oZWlnaHQoKSAqIHlVbml0Q2hhbmdlLmhlaWdodCgpKTsKLQotICAgIC8v IFNjYWxlIGJsdXIgcmFkaXVzCi0gICAgbV9ibHVyUmFkaXVzLnNjYWxlKDEgLyB4QXhpc1NjYWxl LCAxIC8geUF4aXNTY2FsZSk7CisgICAgQWZmaW5lVHJhbnNmb3JtIHRyYW5zZm9ybSA9IGNvbnRl eHQtPmdldENUTSgpOworICAgIG1fYmx1clJhZGl1cy5zY2FsZSgxIC8gdHJhbnNmb3JtLnhTY2Fs ZSgpLCAxIC8gdHJhbnNmb3JtLnlTY2FsZSgpKTsKIH0KIAogSW50U2l6ZSBTaGFkb3dCbHVyOjpi bHVycmVkRWRnZVNpemUoKSBjb25zdAo=