68666 2011-09-22 17:16:10 -0700 Refactor checks for antialiasing lines to share a single function 2011-09-22 19:59:50 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 darin darin webkit.review.bot oldest_to_newest 471956 0 darin 2011-09-22 17:16:10 -0700 Refactor checks for antialiasing lines to share a single function 471957 1 108424 darin 2011-09-22 17:20:30 -0700 Created attachment 108424 Patch 472032 2 108424 webkit.review.bot 2011-09-22 19:59:46 -0700 Comment on attachment 108424 Patch Clearing flags on attachment: 108424 Committed r95777: <http://trac.webkit.org/changeset/95777> 472033 3 webkit.review.bot 2011-09-22 19:59:50 -0700 All reviewed patches have been landed. Closing bug. 108424 2011-09-22 17:20:30 -0700 2011-09-22 19:59:46 -0700 Patch bug-68666-20110922172029.patch text/plain 5767 darin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk1NzY1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDktMjIgIERhcmluIEFk bGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJlZmFjdG9yIGNoZWNrcyBmb3IgYW50 aWFsaWFzaW5nIGxpbmVzIHRvIHNoYXJlIGEgc2luZ2xlIGZ1bmN0aW9uCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODY2NgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2Nr LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjpwYWludENvbHVtblJ1bGVzKTog Q2FsbCBzaG91bGRBbnRpYWxpYXNMaW5lcy4KKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94 TW9kZWxPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQm94TW9kZWxPYmplY3Q6 OnBhaW50Qm9yZGVyKTogRGl0dG8uCisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCb3hNb2RlbE9i amVjdDo6c2hvdWxkQW50aWFsaWFzTGluZXMpOiBBZGRlZC4KKyAgICAgICAgKiByZW5kZXJpbmcv UmVuZGVyQm94TW9kZWxPYmplY3QuaDogQWRkZWQgc2hvdWxkQW50aWFsaWFzTGluZXMgZnVuY3Rp b24uCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlcklubGluZS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpSZW5kZXJJbmxpbmU6OnBhaW50T3V0bGluZUZvckxpbmUpOiBDYWxsIHNob3VsZEFudGlh bGlhc0xpbmVzLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUYWJsZUNlbGwuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyVGFibGVDZWxsOjpwYWludENvbGxhcHNlZEJvcmRlcik6IERp dHRvLgorCiAyMDExLTA5LTIyICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+ CiAKICAgICAgICAgTWFrZSBzdXJlIHRvIHVwZGF0ZSBzY3JvbGxiYXJzIGluIFNjcm9sbFZpZXc6 OnNldEZyYW1lUmVjdApJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2Nr LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2su Y3BwCShyZXZpc2lvbiA5NTc2MSkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJC bG9jay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIzNDIsOCArMjM0Miw3IEBAIHZvaWQgUmVuZGVy QmxvY2s6OnBhaW50Q29sdW1uUnVsZXMoUGFpbnQKICAgICBMYXlvdXRVbml0IHJ1bGVBZGQgPSBs b2dpY2FsTGVmdE9mZnNldEZvckNvbnRlbnQoKTsKICAgICBMYXlvdXRVbml0IHJ1bGVMb2dpY2Fs TGVmdCA9IHN0eWxlKCktPmlzTGVmdFRvUmlnaHREaXJlY3Rpb24oKSA/IDAgOiBjb250ZW50TG9n aWNhbFdpZHRoKCk7CiAKLSAgICBjb25zdCBBZmZpbmVUcmFuc2Zvcm0mIGN1cnJlbnRDVE0gPSBw YWludEluZm8uY29udGV4dC0+Z2V0Q1RNKCk7Ci0gICAgYm9vbCBhbnRpYWxpYXMgPSAhY3VycmVu dENUTS5pc0lkZW50aXR5T3JUcmFuc2xhdGlvbk9yRmxpcHBlZCgpOworICAgIGJvb2wgYW50aWFs aWFzID0gc2hvdWxkQW50aWFsaWFzTGluZXMocGFpbnRJbmZvLmNvbnRleHQpOwogCiAgICAgZm9y ICh1bnNpZ25lZCBpID0gMDsgaSA8IGNvbENvdW50OyBpKyspIHsKICAgICAgICAgTGF5b3V0UmVj dCBjb2xSZWN0ID0gY29sdW1uUmVjdEF0KGNvbEluZm8sIGkpOwpJbmRleDogU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuY3BwCShyZXZpc2lvbiA5 NTc2MSkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTE1MzcsMTAgKzE1MzcsNiBAQCB2b2lkIFJlbmRlckJveE1v ZGVsT2JqZWN0OjpwYWludEJvcmRlcihjCiAgICAgUm91bmRlZFJlY3Qgb3V0ZXJCb3JkZXIgPSBz dHlsZS0+Z2V0Um91bmRlZEJvcmRlckZvcihyZWN0LCBpbmNsdWRlTG9naWNhbExlZnRFZGdlLCBp bmNsdWRlTG9naWNhbFJpZ2h0RWRnZSk7CiAgICAgUm91bmRlZFJlY3QgaW5uZXJCb3JkZXIgPSBz dHlsZS0+Z2V0Um91bmRlZElubmVyQm9yZGVyRm9yKHJlY3QsIGluY2x1ZGVMb2dpY2FsTGVmdEVk Z2UsIGluY2x1ZGVMb2dpY2FsUmlnaHRFZGdlKTsKIAotICAgIGNvbnN0IEFmZmluZVRyYW5zZm9y bSYgY3VycmVudENUTSA9IGdyYXBoaWNzQ29udGV4dC0+Z2V0Q1RNKCk7Ci0gICAgLy8gRklYTUU6 IHRoaXMgaXNuJ3QgcXVpdGUgY29ycmVjdC4gV2UgbWF5IHdhbnQgdG8gYW50aWFsaWFzIHdoZW4g c2NhbGVkIGJ5IGEgbm9uLWludGVncmFsIHZhbHVlLCBvciB3aGVuIHRoZSB0cmFuc2xhdGlvbiBp cyBub24taW50ZWdyYWwuCi0gICAgYm9vbCBhbnRpYWxpYXMgPSAhY3VycmVudENUTS5pc0lkZW50 aXR5T3JUcmFuc2xhdGlvbk9yRmxpcHBlZCgpOwotICAgIAogICAgIGJvb2wgaGF2ZUFscGhhQ29s b3IgPSBmYWxzZTsKICAgICBib29sIGhhdmVBbGxTb2xpZEVkZ2VzID0gdHJ1ZTsKICAgICBib29s IGFsbEVkZ2VzVmlzaWJsZSA9IHRydWU7CkBAIC0xNjI2LDYgKzE2MjIsNyBAQCB2b2lkIFJlbmRl ckJveE1vZGVsT2JqZWN0OjpwYWludEJvcmRlcihjCiAgICAgICAgIGdyYXBoaWNzQ29udGV4dC0+ Y2xpcE91dFJvdW5kZWRSZWN0KGlubmVyQm9yZGVyKTsKICAgICB9CiAKKyAgICBib29sIGFudGlh bGlhcyA9IHNob3VsZEFudGlhbGlhc0xpbmVzKGdyYXBoaWNzQ29udGV4dCk7ICAgIAogICAgIGlm IChoYXZlQWxwaGFDb2xvcikKICAgICAgICAgcGFpbnRUcmFuc2x1Y2VudEJvcmRlclNpZGVzKGdy YXBoaWNzQ29udGV4dCwgc3R5bGUsIG91dGVyQm9yZGVyLCBpbm5lckJvcmRlciwgZWRnZXMsIGJs ZWVkQXZvaWRhbmNlLCBpbmNsdWRlTG9naWNhbExlZnRFZGdlLCBpbmNsdWRlTG9naWNhbFJpZ2h0 RWRnZSwgYW50aWFsaWFzKTsKICAgICBlbHNlCkBAIC0yNDc1LDQgKzI0NzIsMTEgQEAgdm9pZCBS ZW5kZXJCb3hNb2RlbE9iamVjdDo6c2V0Q29udGludWF0aQogICAgIH0KIH0KIAorYm9vbCBSZW5k ZXJCb3hNb2RlbE9iamVjdDo6c2hvdWxkQW50aWFsaWFzTGluZXMoR3JhcGhpY3NDb250ZXh0KiBj b250ZXh0KQoreworICAgIC8vIEZJWE1FOiBXZSBtYXkgd2FudCB0byBub3QgYW50aWFsaWFzIHdo ZW4gc2NhbGVkIGJ5IGFuIGludGVncmFsIHZhbHVlLAorICAgIC8vIGFuZCB3ZSBtYXkgd2FudCB0 byBhbnRpYWxpYXMgd2hlbiB0cmFuc2xhdGVkIGJ5IGEgbm9uLWludGVncmFsIHZhbHVlLgorICAg IHJldHVybiAhY29udGV4dC0+Z2V0Q1RNKCkuaXNJZGVudGl0eU9yVHJhbnNsYXRpb25PckZsaXBw ZWQoKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpJbmRleDogU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmgJKHJldmlzaW9uIDk1NzYxKQor KysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmgJKHdvcmtp bmcgY29weSkKQEAgLTE5MCw2ICsxOTAsOCBAQCBwcm90ZWN0ZWQ6CiAgICAgUmVuZGVyQm94TW9k ZWxPYmplY3QqIGNvbnRpbnVhdGlvbigpIGNvbnN0OwogICAgIHZvaWQgc2V0Q29udGludWF0aW9u KFJlbmRlckJveE1vZGVsT2JqZWN0Kik7CiAKKyAgICBzdGF0aWMgYm9vbCBzaG91bGRBbnRpYWxp YXNMaW5lcyhHcmFwaGljc0NvbnRleHQqKTsKKwogcHJpdmF0ZToKICAgICB2aXJ0dWFsIGJvb2wg aXNCb3hNb2RlbE9iamVjdCgpIGNvbnN0IHsgcmV0dXJuIHRydWU7IH0KIApJbmRleDogU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlcklubGluZS5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlcklubGluZS5jcHAJKHJldmlzaW9uIDk1NzYxKQorKysg U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlcklubGluZS5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTE0MjEsOCArMTQyMSw3IEBAIHZvaWQgUmVuZGVySW5saW5lOjpwYWludE91dGxpbmVGb3JM aW5lKEcKICAgICBMYXlvdXRVbml0IG91dGxpbmVXaWR0aCA9IHN0eWxlVG9Vc2UtPm91dGxpbmVX aWR0aCgpOwogICAgIEVCb3JkZXJTdHlsZSBvdXRsaW5lU3R5bGUgPSBzdHlsZVRvVXNlLT5vdXRs aW5lU3R5bGUoKTsKIAotICAgIGNvbnN0IEFmZmluZVRyYW5zZm9ybSYgY3VycmVudENUTSA9IGdy YXBoaWNzQ29udGV4dC0+Z2V0Q1RNKCk7Ci0gICAgYm9vbCBhbnRpYWxpYXMgPSAhY3VycmVudENU TS5pc0lkZW50aXR5T3JUcmFuc2xhdGlvbk9yRmxpcHBlZCgpOworICAgIGJvb2wgYW50aWFsaWFz ID0gc2hvdWxkQW50aWFsaWFzTGluZXMoZ3JhcGhpY3NDb250ZXh0KTsKIAogICAgIExheW91dFVu aXQgb2Zmc2V0ID0gc3R5bGUoKS0+b3V0bGluZU9mZnNldCgpOwogCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxsLmNwcAkocmV2aXNpb24gOTU3NjEpCisr KyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxsLmNwcAkod29ya2luZyBj b3B5KQpAQCAtOTQ0LDggKzk0NCw3IEBAIHZvaWQgUmVuZGVyVGFibGVDZWxsOjpwYWludENvbGxh cHNlZEJvcmQKICAgICBib3JkZXJzLmFkZEJvcmRlcihsZWZ0VmFsLCBCU0xlZnQsIHJlbmRlckxl ZnQsIHgsIHksIHggKyBsZWZ0V2lkdGgsIHkgKyBoLCBsZWZ0U3R5bGUpOwogICAgIGJvcmRlcnMu YWRkQm9yZGVyKHJpZ2h0VmFsLCBCU1JpZ2h0LCByZW5kZXJSaWdodCwgeCArIHcgLSByaWdodFdp ZHRoLCB5LCB4ICsgdywgeSArIGgsIHJpZ2h0U3R5bGUpOwogCi0gICAgY29uc3QgQWZmaW5lVHJh bnNmb3JtJiBjdXJyZW50Q1RNID0gZ3JhcGhpY3NDb250ZXh0LT5nZXRDVE0oKTsKLSAgICBib29s IGFudGlhbGlhcyA9ICFjdXJyZW50Q1RNLmlzSWRlbnRpdHlPclRyYW5zbGF0aW9uT3JGbGlwcGVk KCk7CisgICAgYm9vbCBhbnRpYWxpYXMgPSBzaG91bGRBbnRpYWxpYXNMaW5lcyhncmFwaGljc0Nv bnRleHQpOwogICAgIAogICAgIGZvciAoQ29sbGFwc2VkQm9yZGVyKiBib3JkZXIgPSBib3JkZXJz Lm5leHRCb3JkZXIoKTsgYm9yZGVyOyBib3JkZXIgPSBib3JkZXJzLm5leHRCb3JkZXIoKSkgewog ICAgICAgICBpZiAoYm9yZGVyLT5ib3JkZXJWYWx1ZSA9PSAqdGFibGUoKS0+Y3VycmVudEJvcmRl clN0eWxlKCkpCg==