68654 2011-09-22 13:45:18 -0700 We should add support for OVERRIDE and FINAL annotations 2011-10-11 22:51:57 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 69904 1 jamesr andersca andersca darin jamesr thakis oldest_to_newest 471836 0 jamesr 2011-09-22 13:45:18 -0700 These C++11 annotations are useful for detecting programming errors. We've gained a lot of utility from these in the Chromium repo, and I've locally written plenty of bugs that these would catch. MSVS2005, recent clangs, and GCC 4.7+ support these annotations. We should be able to define these annotations as no-ops on other compilers and still get broad coverage from developers and across the buildbots. 471846 1 108396 andersca 2011-09-22 13:55:42 -0700 Created attachment 108396 Patch 471857 2 108400 andersca 2011-09-22 14:08:48 -0700 Created attachment 108400 Patch 471906 3 108400 hyatt 2011-09-22 15:31:37 -0700 Comment on attachment 108400 Patch r=me 471924 4 darin 2011-09-22 16:08:10 -0700 Can’t wait! 472286 5 andersca 2011-09-23 09:48:05 -0700 Committed r95823: <http://trac.webkit.org/changeset/95823> 108396 2011-09-22 13:55:42 -0700 2011-09-22 14:08:45 -0700 Patch bug-68654-20110922135541.patch text/plain 1622 andersca SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTU3NTApCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTEtMDktMjIgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAg ICAgICBXZSBzaG91bGQgYWRkIHN1cHBvcnQgZm9yIE9WRVJSSURFIGFuZCBGSU5BTCBhbm5vdGF0 aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njg2 NTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQg T1ZFUlJJREUgYW5kIEZJTkFMIG1hY3JvcyBmb3IgY29tcGlsZXJzIHRoYXQgc3VwcG9ydCB0aGVt LgorCisgICAgICAgICogd3RmL0NvbXBpbGVyLmg6CisKIDIwMTEtMDktMjIgIE9saXZlciBIdW50 ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgZ2V0X3Njb3BlZF92YXIg aW4gdGhlIERGRwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9Db21waWxlci5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvQ29tcGlsZXIuaAkocmV2aXNp b24gOTU3NDgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0NvbXBpbGVyLmgJKHdvcmtp bmcgY29weSkKQEAgLTM0LDYgKzM0LDExIEBACiAvKiBDT01QSUxFUihDTEFORykgLSBDbGFuZyAg Ki8KICNpZiBkZWZpbmVkKF9fY2xhbmdfXykKICNkZWZpbmUgV1RGX0NPTVBJTEVSX0NMQU5HIDEK KworI2lmbmRlZiBfX2hhc19leHRlbnNpb24KKyNkZWZpbmUgX19oYXNfZXh0ZW5zaW9uIF9faGFz X2ZlYXR1cmUgLyogQ29tcGF0aWJpbGl0eSB3aXRoIG9sZGVyIHZlcnNpb25zIG9mIGNsYW5nICov CisjZW5kaWYKKwogI2VuZGlmCiAKIC8qIENPTVBJTEVSKE1TVkMpIC0gTWljcm9zb2Z0IFZpc3Vh bCBDKysgKi8KQEAgLTE4OSw1ICsxOTQsMjYgQEAKICNkZWZpbmUgV0FSTl9VTlVTRURfUkVUVVJO CiAjZW5kaWYKIAorLyogT1ZFUlJJREUgKi8KKworI2lmbmRlZiBPVkVSUklERQorI2lmIChDT01Q SUxFUihDTEFORykgJiYgX19oYXNfZXh0ZW5zaW9uKGN4eF9vdmVycmlkZV9jb250cm9sKSkgfHwg Q09NUElMRVIoTVNWQykKKyNkZWZpbmUgT1ZFUlJJREUgb3ZlcnJpZGUKKyNlbHNlCisjZGVmaW5l IE9WRVJSSURFCisjZW5kaWYKKyNlbmRpZgorCisvKiBGSU5BTCAqLworCisjaWZuZGVmIEZJTkFM CisjaWYgQ09NUElMRVIoQ0xBTkcpICYmIF9faGFzX2V4dGVuc2lvbihjeHhfb3ZlcnJpZGVfY29u dHJvbCkKKyNkZWZpbmUgRklOQUwgZmluYWwKKyNlbGlmIENPTVBJTEVSKE1TVkMpCisjZGVmaW5l IEZJTkFMIHNlYWxlZAorI2Vsc2UKKyNkZWZpbmUgRklOQUwKKyNlbmRpZgorI2VuZGlmCiAKICNl bmRpZiAvKiBXVEZfQ29tcGlsZXJfaCAqLwo= 108400 2011-09-22 14:08:48 -0700 2011-09-22 15:31:37 -0700 Patch bug-68654-20110922140847.patch text/plain 1671 andersca SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTU3NTApCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTEtMDktMjIgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAg ICAgICBXZSBzaG91bGQgYWRkIHN1cHBvcnQgZm9yIE9WRVJSSURFIGFuZCBGSU5BTCBhbm5vdGF0 aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njg2 NTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQg T1ZFUlJJREUgYW5kIEZJTkFMIG1hY3JvcyBmb3IgY29tcGlsZXJzIHRoYXQgc3VwcG9ydCB0aGVt LgorCisgICAgICAgICogd3RmL0NvbXBpbGVyLmg6CisKIDIwMTEtMDktMjIgIE9saXZlciBIdW50 ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgZ2V0X3Njb3BlZF92YXIg aW4gdGhlIERGRwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9Db21waWxlci5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvQ29tcGlsZXIuaAkocmV2aXNp b24gOTU3NDgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0NvbXBpbGVyLmgJKHdvcmtp bmcgY29weSkKQEAgLTM0LDYgKzM0LDExIEBACiAvKiBDT01QSUxFUihDTEFORykgLSBDbGFuZyAg Ki8KICNpZiBkZWZpbmVkKF9fY2xhbmdfXykKICNkZWZpbmUgV1RGX0NPTVBJTEVSX0NMQU5HIDEK KworI2lmbmRlZiBfX2hhc19leHRlbnNpb24KKyNkZWZpbmUgX19oYXNfZXh0ZW5zaW9uIF9faGFz X2ZlYXR1cmUgLyogQ29tcGF0aWJpbGl0eSB3aXRoIG9sZGVyIHZlcnNpb25zIG9mIGNsYW5nICov CisjZW5kaWYKKwogI2VuZGlmCiAKIC8qIENPTVBJTEVSKE1TVkMpIC0gTWljcm9zb2Z0IFZpc3Vh bCBDKysgKi8KQEAgLTE4OSw1ICsxOTQsMzIgQEAKICNkZWZpbmUgV0FSTl9VTlVTRURfUkVUVVJO CiAjZW5kaWYKIAorLyogT1ZFUlJJREUgKi8KKworI2lmbmRlZiBPVkVSUklERQorI2lmIENPTVBJ TEVSKENMQU5HKQorI2lmIF9faGFzX2V4dGVuc2lvbihjeHhfb3ZlcnJpZGVfY29udHJvbCkKKyNk ZWZpbmUgT1ZFUlJJREUgb3ZlcnJpZGUKKyNlbmRpZgorI2VsaWYgQ09NUElMRVIoTVNWQykKKyNk ZWZpbmUgT1ZFUlJJREUgb3ZlcnJpZGUKKyNlbHNlCisjZGVmaW5lIE9WRVJSSURFCisjZW5kaWYK KyNlbmRpZgorCisvKiBGSU5BTCAqLworCisjaWZuZGVmIEZJTkFMCisjaWYgQ09NUElMRVIoQ0xB TkcpCisjaWYgX19oYXNfZXh0ZW5zaW9uKGN4eF9vdmVycmlkZV9jb250cm9sKQorI2RlZmluZSBG SU5BTCBmaW5hbAorI2VuZGlmCisjZWxpZiBDT01QSUxFUihNU1ZDKQorI2RlZmluZSBGSU5BTCBz ZWFsZWQKKyNlbHNlCisjZGVmaW5lIEZJTkFMCisjZW5kaWYKKyNlbmRpZgogCiAjZW5kaWYgLyog V1RGX0NvbXBpbGVyX2ggKi8K