68641 2011-09-22 11:02:37 -0700 Text drawn via -webkit-background-clip:text should be non-blurry with all scaling techniques 2011-10-14 14:56:35 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 70151 1 bdakin darin aroben bdakin darin simon.fraser oldest_to_newest 471716 0 bdakin 2011-09-22 11:02:37 -0700 This is a followup bug from https://bugs.webkit.org/show_bug.cgi?id=67415 . RenderBoxModelObject has a static function named createDeviceScaledImageBuffer(). That function should take page scale, page zoom, and transforms from ancestors into account as well. 471965 1 108428 darin 2011-09-22 17:29:02 -0700 Created attachment 108428 Patch 471968 2 108428 simon.fraser 2011-09-22 17:32:47 -0700 Comment on attachment 108428 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108428&action=review r=me, perhaps with a little more thought about the naming. > Source/WebCore/platform/graphics/GraphicsContext.h:418 > + PassOwnPtr<ImageBuffer> createCompatibleBuffer(const IntSize&) const; I'm not sure that "compatible" says enough about the intent. It needs to communicate "appropriately scaled", or use a term like "resolution" or "scale". Maybe createScaledBuffer()? 471970 3 bdakin 2011-09-22 17:33:49 -0700 Looks good! It would be nice to add a test for this at some point. DumpRenderTree and WebKitTestRunner both have a scalePageBy function that tests the Page::setPageScaleFactor(). 471983 4 108428 darin 2011-09-22 17:45:55 -0700 Comment on attachment 108428 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108428&action=review >> Source/WebCore/platform/graphics/GraphicsContext.h:418 >> + PassOwnPtr<ImageBuffer> createCompatibleBuffer(const IntSize&) const; > > I'm not sure that "compatible" says enough about the intent. It needs to communicate "appropriately scaled", or use a term like "resolution" or "scale". Maybe createScaledBuffer()? Maybe createCompatiblyScaledBuffer? Part of why I named it this way is that eventually it might need to do something more than just scale--maybe set up an appropriate color space or something--but that’s a vague thought at the moment. 471985 5 darin 2011-09-22 17:46:56 -0700 Before landing I probably should add a test. I also wonder whether it’s a bad policy for this to make a smaller buffer when things are scaled down. I think I should check for overflow. I wonder whether I need to add any rules about maximum buffer sizes. Probably already handled at the ImageBuffer level. 483668 6 bdakin 2011-10-13 17:15:46 -0700 (In reply to comment #5) > Before landing I probably should add a test. > > I also wonder whether it’s a bad policy for this to make a smaller buffer when things are scaled down. > > I think I should check for overflow. > > I wonder whether I need to add any rules about maximum buffer sizes. Probably already handled at the ImageBuffer level. I made a test for this, and I would like to check it in along with your patch. I'm just wondering if you have any further thoughts regarding the other possible changes you mentioned. I will think them over myself too. 483675 7 bdakin 2011-10-13 17:26:43 -0700 It seems like ImageBuffer takes care of overflow…of course we would end up with something of a strange size if we overflowed so much that we had a different positive number when performing the size * scale calculations in GraphicsContext. But ImageBuffer will at least protect us from crashing and and negative sizes. 483679 8 bdakin 2011-10-13 17:28:35 -0700 I also haven't been able to see any problems with creating a smaller image buffer when things are scaled down. 484078 9 bdakin 2011-10-14 11:14:13 -0700 Committed change with revision 97481. 484130 10 bdakin 2011-10-14 11:45:51 -0700 And a Leopard build fix with revision 97487. 108428 2011-09-22 17:29:02 -0700 2011-09-22 17:45:55 -0700 Patch bug-68641-20110922172902.patch text/plain 4673 darin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk1NzY1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDktMjIgIERhcmluIEFk bGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFRleHQgZHJhd24gdmlhIC13ZWJraXQt YmFja2dyb3VuZC1jbGlwOnRleHQgc2hvdWxkIGJlIG5vbi1ibHVycnkgd2l0aCBhbGwgc2NhbGlu ZyB0ZWNobmlxdWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02ODY0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6Y3JlYXRlQ29tcGF0aWJsZUJ1ZmZlcik6IEFsbG9jYXRl IGEgYnVmZmVyIGJhc2VkIG9uIHRoZSBzY2FsZQorICAgICAgICBmYWN0b3Igb2YgdGhlIGNvbnRl eHQuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0Lmg6IEFkZGVk IGNyZWF0ZUNvbXBhdGlibGVCdWZmZXIuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94 TW9kZWxPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQm94TW9kZWxPYmplY3Q6 OnBhaW50RmlsbExheWVyRXh0ZW5kZWQpOiBVc2UgY3JlYXRlQ29tcGF0aWJsZUJ1ZmZlci4KKwog MjAxMS0wOS0yMiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAg ICAgIE1ha2Ugc3VyZSB0byB1cGRhdGUgc2Nyb2xsYmFycyBpbiBTY3JvbGxWaWV3OjpzZXRGcmFt ZVJlY3QKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29u dGV4dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv R3JhcGhpY3NDb250ZXh0LmNwcAkocmV2aXNpb24gOTU3NjEpCisrKyBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03 NDUsNCArNzQ1LDIzIEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0OjphZGp1c3RMaW5lVG9QaXhlbEIK ICAgICB9CiB9CiAKK1Bhc3NPd25QdHI8SW1hZ2VCdWZmZXI+IEdyYXBoaWNzQ29udGV4dDo6Y3Jl YXRlQ29tcGF0aWJsZUJ1ZmZlcihjb25zdCBJbnRTaXplJiBzaXplKSBjb25zdAoreworICAgIC8v IE1ha2UgdGhlIGJ1ZmZlciBsYXJnZXIgaWYgdGhlIGNvbnRleHQncyB0cmFuc2Zvcm0gaXMgc2Nh bGluZyBpdCBzbyB3ZSBuZWVkIGEgaGlnaGVyCisgICAgLy8gcmVzb2x1dGlvbiB0aGFuIG9uZSBw aXhlbCBwZXIgdW5pdC4gQWxzbyBzZXQgdXAgYSBjb3JyZXNwb25kaW5nIHNjYWxlIGZhY3RvciBv biB0aGUKKyAgICAvLyBncmFwaGljcyBjb250ZXh0LgorCisgICAgQWZmaW5lVHJhbnNmb3JtIHRy YW5zZm9ybSA9IGdldENUTSgpOworICAgIEludFNpemUgc2NhbGVkU2l6ZShzaXplLndpZHRoKCkg KiB0cmFuc2Zvcm0ueFNjYWxlKCksIHNpemUuaGVpZ2h0KCkgKiB0cmFuc2Zvcm0ueVNjYWxlKCkp OworCisgICAgT3duUHRyPEltYWdlQnVmZmVyPiBidWZmZXIgPSBJbWFnZUJ1ZmZlcjo6Y3JlYXRl KHNjYWxlZFNpemUpOworICAgIGlmICghYnVmZmVyKQorICAgICAgICByZXR1cm4gbnVsbHB0cjsK KworICAgIGJ1ZmZlci0+Y29udGV4dCgpLT5zY2FsZShGbG9hdFNpemUoc3RhdGljX2Nhc3Q8Zmxv YXQ+KHNjYWxlZFNpemUud2lkdGgoKSkgLyBzaXplLndpZHRoKCksCisgICAgICAgIHN0YXRpY19j YXN0PGZsb2F0PihzY2FsZWRTaXplLmhlaWdodCgpKSAvIHNpemUuaGVpZ2h0KCkpKTsKKworICAg IHJldHVybiBidWZmZXIucmVsZWFzZSgpOworfQorCiB9CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuaAkocmV2aXNpb24gOTU3 NjEpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQu aAkod29ya2luZyBjb3B5KQpAQCAtNDEzLDYgKzQxMywxMCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAgICAgICAgIHZvaWQgc2V0Q1RNKGNvbnN0IEFmZmluZVRyYW5zZm9ybSYpOwogICAgICAgICBB ZmZpbmVUcmFuc2Zvcm0gZ2V0Q1RNKCkgY29uc3Q7CiAKKyAgICAgICAgLy8gQ3JlYXRlIGFuIGlt YWdlIGJ1ZmZlciBjb21wYXRpYmxlIHdpdGggdGhpcyBjb250ZXh0LCB3aXRoIHN1aXRhYmxlIHJl c29sdXRpb24KKyAgICAgICAgLy8gZm9yIGRyYXdpbmcgaW50byB0aGUgYnVmZmVyIGFuZCB0aGVu IGludG8gdGhpcyBjb250ZXh0LgorICAgICAgICBQYXNzT3duUHRyPEltYWdlQnVmZmVyPiBjcmVh dGVDb21wYXRpYmxlQnVmZmVyKGNvbnN0IEludFNpemUmKSBjb25zdDsKKwogI2lmIE9TKFdJTkNF KSAmJiAhUExBVEZPUk0oUVQpCiAgICAgICAgIHZvaWQgc2V0Qml0bWFwKFBhc3NSZWZQdHI8U2hh cmVkQml0bWFwPik7CiAgICAgICAgIGNvbnN0IEFmZmluZVRyYW5zZm9ybSYgYWZmaW5lVHJhbnNm b3JtKCkgY29uc3Q7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9k ZWxPYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJCb3hNb2RlbE9iamVjdC5jcHAJKHJldmlzaW9uIDk1NzYxKQorKysgU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTk1 LDI0ICs1OTUsNiBAQCBzdGF0aWMgTGF5b3V0UmVjdCBiYWNrZ3JvdW5kUmVjdEFkanVzdGVkCiAg ICAgcmV0dXJuIGFkanVzdGVkUmVjdDsKIH0KIAotc3RhdGljIFBhc3NPd25QdHI8SW1hZ2VCdWZm ZXI+IGNyZWF0ZURldmljZVNjYWxlZEltYWdlQnVmZmVyKEludFNpemUgaW1hZ2VTaXplLCBmbG9h dCBkZXZpY2VTY2FsZUZhY3RvcikKLXsKLSAgICAvLyBUbyBjcmVhdGUgYW4gaW1hZ2Ugb2YgdGhl IGFwcHJvcHJpYXRlIHJlc29sdXRpb24sIHdlIG5lZWQgdG8gc2NhbGUgaW1hZ2VSZWN0J3Mgc2l6 ZQotICAgIC8vIGJ5IHRoZSBkZXZpY2Ugc2NhbGUgZmFjdG9yLgotICAgIEludFNpemUgc2NhbGVk SW1hZ2VTaXplID0gaW1hZ2VTaXplOwotICAgIHNjYWxlZEltYWdlU2l6ZS5zY2FsZShkZXZpY2VT Y2FsZUZhY3Rvcik7Ci0KLSAgICBPd25QdHI8SW1hZ2VCdWZmZXI+IHNjYWxlZEltYWdlQnVmZmVy ID0gSW1hZ2VCdWZmZXI6OmNyZWF0ZShzY2FsZWRJbWFnZVNpemUpOwotICAgIGlmICghc2NhbGVk SW1hZ2VCdWZmZXIpCi0gICAgICAgIHJldHVybiBudWxscHRyOwotCi0gICAgLy8gU2NhbGUgdGhl IHdob2xlIGNvbnRleHQgYnkgdGhlIGRldmljZSBzY2FsZSBmYWN0b3Igc28gdGhhdCBhbGwgb2Yg dGhlIGNsaXBzIHNldCB1cCBhdCAKLSAgICAvLyB0aGUgYXBwcm9wcmlhdGUgc2l6ZS4KLSAgICBz Y2FsZWRJbWFnZUJ1ZmZlci0+Y29udGV4dCgpLT5zY2FsZShGbG9hdFNpemUoZGV2aWNlU2NhbGVG YWN0b3IsIGRldmljZVNjYWxlRmFjdG9yKSk7Ci0KLSAgICByZXR1cm4gc2NhbGVkSW1hZ2VCdWZm ZXIucmVsZWFzZSgpOwotfQotCiB2b2lkIFJlbmRlckJveE1vZGVsT2JqZWN0OjpwYWludEZpbGxM YXllckV4dGVuZGVkKGNvbnN0IFBhaW50SW5mbyYgcGFpbnRJbmZvLCBjb25zdCBDb2xvciYgY29s b3IsIGNvbnN0IEZpbGxMYXllciogYmdMYXllciwgY29uc3QgTGF5b3V0UmVjdCYgcmVjdCwKICAg ICBCYWNrZ3JvdW5kQmxlZWRBdm9pZGFuY2UgYmxlZWRBdm9pZGFuY2UsIElubGluZUZsb3dCb3gq IGJveCwgY29uc3QgTGF5b3V0U2l6ZSYgYm94U2l6ZSwgQ29tcG9zaXRlT3BlcmF0b3Igb3AsIFJl bmRlck9iamVjdCogYmFja2dyb3VuZE9iamVjdCkKIHsKQEAgLTcwNiw3ICs2ODgsNyBAQCB2b2lk IFJlbmRlckJveE1vZGVsT2JqZWN0OjpwYWludEZpbGxMYXllCiAgICAgICAgIG1hc2tSZWN0Lmlu dGVyc2VjdChwYWludEluZm8ucmVjdCk7CiAgICAgICAgIAogICAgICAgICAvLyBOb3cgY3JlYXRl IHRoZSBtYXNrLgotICAgICAgICBPd25QdHI8SW1hZ2VCdWZmZXI+IG1hc2tJbWFnZSA9IGNyZWF0 ZURldmljZVNjYWxlZEltYWdlQnVmZmVyKG1hc2tSZWN0LnNpemUoKSwgV2ViQ29yZTo6ZGV2aWNl U2NhbGVGYWN0b3IoZnJhbWUoKSkpOworICAgICAgICBPd25QdHI8SW1hZ2VCdWZmZXI+IG1hc2tJ bWFnZSA9IGNvbnRleHQtPmNyZWF0ZUNvbXBhdGlibGVCdWZmZXIobWFza1JlY3Quc2l6ZSgpKTsK ICAgICAgICAgaWYgKCFtYXNrSW1hZ2UpCiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIAo=