68634 2011-09-22 10:18:54 -0700 [GTK] Fix coding style bits in ResourceHandleSoup.cpp 2011-09-26 02:04:12 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 svillar svillar webkit.review.bot oldest_to_newest 471661 0 svillar 2011-09-22 10:18:54 -0700 The following coding style errors should be fixed: Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:33: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:865: Use 0 instead of NULL. [readability/null] [5] 471667 1 108355 svillar 2011-09-22 10:23:50 -0700 Created attachment 108355 Patch 471668 2 108355 pnormand 2011-09-22 10:25:51 -0700 Comment on attachment 108355 Patch 0 is not a proper sentinel 471674 3 108357 svillar 2011-09-22 10:30:54 -0700 Created attachment 108357 Patch 473009 4 108357 svillar 2011-09-26 00:48:55 -0700 Comment on attachment 108357 Patch I'll let the commit-queue land this stupid bug I used to demonstrate some of the webkit-patch capabilities. 473029 5 108357 webkit.review.bot 2011-09-26 02:04:07 -0700 Comment on attachment 108357 Patch Clearing flags on attachment: 108357 Committed r95938: <http://trac.webkit.org/changeset/95938> 473030 6 webkit.review.bot 2011-09-26 02:04:12 -0700 All reviewed patches have been landed. Closing bug. 108355 2011-09-22 10:23:50 -0700 2011-09-22 10:30:49 -0700 Patch bug-68634-20110922192349.patch text/plain 1712 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ5NDkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiMTY3ZjM3YzBjYTRjYmQ4 NGY2OWE3MDJkYzA2MjNjNGZjYmY2ODQ5Li4wNGNjNTRhYTYyMTJlNjgxNGNkMTA1MjBkYWU5YTRh OWZjNDVmOTRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDktMjIgIFNlcmdp byBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gRml4 IGNvZGluZyBzdHlsZSBiaXRzIGluIFJlc291cmNlSGFuZGxlU291cC5jcHAKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4NjM0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4K KworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6OmRlZmF1bHRTZXNzaW9uKToKKwog MjAxMS0wOS0xMiAgU2hpbnlhIEthd2FuYWthICA8c2hpbnlha0Bnb29nbGUuY29tPgogCiAgICAg ICAgIENoYXJhY3RlcnMgYmV5b25kIFUrMTAwMDAgc2hvdWxkIGJlIGRlbGV0ZWQgYnkgb25lIHBy ZXNzaW5nIGRlbGV0ZSBrZXkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwCmluZGV4IDkwOWI1MzRlYWJi NTMzN2MyNjA3OGJjZDJiZmYwMjAzYTJhYzlmOGQuLjZiODhhZjk1YzQ5NWJlNDFkMmYwMjEwNmVh NWJkMTI3MzY3ZTFmMjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwCkBAIC0yOCw5ICsyOCw5IEBA CiAjaW5jbHVkZSAiUmVzb3VyY2VIYW5kbGUuaCIKIAogI2luY2x1ZGUgIkJhc2U2NC5oIgorI2lu Y2x1ZGUgIkNhY2hlZFJlc291cmNlTG9hZGVyLmgiCiAjaW5jbHVkZSAiQ2hyb21lQ2xpZW50Lmgi CiAjaW5jbHVkZSAiQ29va2llSmFyU291cC5oIgotI2luY2x1ZGUgIkNhY2hlZFJlc291cmNlTG9h ZGVyLmgiCiAjaW5jbHVkZSAiRmlsZVN5c3RlbS5oIgogI2luY2x1ZGUgIkZyYW1lLmgiCiAjaW5j bHVkZSAiR093blB0clNvdXAuaCIKQEAgLTg2Miw3ICs4NjIsNyBAQCBTb3VwU2Vzc2lvbiogUmVz b3VyY2VIYW5kbGU6OmRlZmF1bHRTZXNzaW9uKCkKICAgICAgICAgZ19vYmplY3Rfc2V0KHNlc3Np b24sCiAgICAgICAgICAgICAgICAgICAgICBTT1VQX1NFU1NJT05fTUFYX0NPTk5TLCBtYXhDb25u ZWN0aW9ucywKICAgICAgICAgICAgICAgICAgICAgIFNPVVBfU0VTU0lPTl9NQVhfQ09OTlNfUEVS X0hPU1QsIG1heENvbm5lY3Rpb25zUGVySG9zdCwgCi0gICAgICAgICAgICAgICAgICAgICBOVUxM KTsKKyAgICAgICAgICAgICAgICAgICAgIDApOwogICAgIH0KIAogICAgIHJldHVybiBzZXNzaW9u Owo= 108357 2011-09-22 10:30:54 -0700 2011-09-26 02:04:07 -0700 Patch bug-68634-20110922193053.patch text/plain 1389 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ5NDkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiMTY3ZjM3YzBjYTRjYmQ4 NGY2OWE3MDJkYzA2MjNjNGZjYmY2ODQ5Li4wNGNjNTRhYTYyMTJlNjgxNGNkMTA1MjBkYWU5YTRh OWZjNDVmOTRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDktMjIgIFNlcmdp byBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gRml4 IGNvZGluZyBzdHlsZSBiaXRzIGluIFJlc291cmNlSGFuZGxlU291cC5jcHAKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4NjM0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4K KworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6OmRlZmF1bHRTZXNzaW9uKToKKwog MjAxMS0wOS0xMiAgU2hpbnlhIEthd2FuYWthICA8c2hpbnlha0Bnb29nbGUuY29tPgogCiAgICAg ICAgIENoYXJhY3RlcnMgYmV5b25kIFUrMTAwMDAgc2hvdWxkIGJlIGRlbGV0ZWQgYnkgb25lIHBy ZXNzaW5nIGRlbGV0ZSBrZXkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwCmluZGV4IDkwOWI1MzRlYWJi NTMzN2MyNjA3OGJjZDJiZmYwMjAzYTJhYzlmOGQuLjhjZWQwMjI5NTgwOTI2MjM2MTBhZTNiYjgz ZTExYzhmZDcxYzBhZTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwCkBAIC0yOCw5ICsyOCw5IEBA CiAjaW5jbHVkZSAiUmVzb3VyY2VIYW5kbGUuaCIKIAogI2luY2x1ZGUgIkJhc2U2NC5oIgorI2lu Y2x1ZGUgIkNhY2hlZFJlc291cmNlTG9hZGVyLmgiCiAjaW5jbHVkZSAiQ2hyb21lQ2xpZW50Lmgi CiAjaW5jbHVkZSAiQ29va2llSmFyU291cC5oIgotI2luY2x1ZGUgIkNhY2hlZFJlc291cmNlTG9h ZGVyLmgiCiAjaW5jbHVkZSAiRmlsZVN5c3RlbS5oIgogI2luY2x1ZGUgIkZyYW1lLmgiCiAjaW5j bHVkZSAiR093blB0clNvdXAuaCIK