68631 2011-09-22 09:42:30 -0700 Web Inspector: InspectorStyleSheet should use stylesheet's original url, not final one. 2011-09-23 08:21:48 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 vsevik vsevik apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 471637 0 vsevik 2011-09-22 09:42:30 -0700 InspectorStyleSheet should use stylesheet's original url, not final one. See also: https://code.google.com/p/chromium/issues/detail?id=94196 471706 1 108362 vsevik 2011-09-22 10:56:06 -0700 Created attachment 108362 Patch 472205 2 108362 yurys 2011-09-23 06:40:49 -0700 Comment on attachment 108362 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108362&action=review > LayoutTests/http/tests/inspector/elements-test.js:229 > +InspectorTest.getMatchedStylePropertyTreeItem = function(propertyName) getMatchedStylePropertyTreeItem -> getStylePropertyTreeItemForName 472252 3 108362 webkit.review.bot 2011-09-23 08:21:43 -0700 Comment on attachment 108362 Patch Clearing flags on attachment: 108362 Committed r95806: <http://trac.webkit.org/changeset/95806> 472253 4 webkit.review.bot 2011-09-23 08:21:48 -0700 All reviewed patches have been landed. Closing bug. 108362 2011-09-22 10:56:06 -0700 2011-09-23 08:21:43 -0700 Patch bug-68631-20110922215604.patch text/plain 6892 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogOTU3MTUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBkYmM2ZDdlMDM2MWUwYjVmYzM1ZjY2 ZjNkODMyMzYyMDgxZTYwNjdlLi5mNTdlNzRkZmIyYjhiN2JlYWVlYmY3ZDRkYjdiNjFiNDlmYWY4 MTQ4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDktMjIgIFZzZXZvbG9kIFZsYXNvdiAg PHZzZXZpa0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogSW5zcGVjdG9y U3R5bGVTaGVldCBzaG91bGQgdXNlIHN0eWxlc2hlZXQncyBvcmlnaW5hbCB1cmwsIG5vdCBmaW5h bCBvbmUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 ODYzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog aHR0cC90ZXN0cy9pbnNwZWN0b3IvZWxlbWVudHMtdGVzdC5qczoKKyAgICAgICAgKGluaXRpYWxp emVfRWxlbWVudFRlc3QuSW5zcGVjdG9yVGVzdC5nZXRFbGVtZW50U3R5bGVQcm9wZXJ0eVRyZWVJ dGVtKToKKyAgICAgICAgKGluaXRpYWxpemVfRWxlbWVudFRlc3QuSW5zcGVjdG9yVGVzdC5nZXRN YXRjaGVkU3R5bGVQcm9wZXJ0eVRyZWVJdGVtKToKKyAgICAgICAgKGluaXRpYWxpemVfRWxlbWVu dFRlc3QuSW5zcGVjdG9yVGVzdC5nZXRGaXJzdFByb3BlcnR5VHJlZUl0ZW1Gb3JTZWN0aW9uKToK KyAgICAgICAgKiBodHRwL3Rlc3RzL2luc3BlY3Rvci9zdHlsZXMvcmVzb3VyY2VzL3N0eWxlcy1y ZWRpcmVjdGVkLWNzcy5jc3M6IEFkZGVkLgorICAgICAgICAoZGl2KToKKyAgICAgICAgKiBodHRw L3Rlc3RzL2luc3BlY3Rvci9zdHlsZXMvcmVzb3VyY2VzL3N0eWxlcy1yZWRpcmVjdGVkLWNzcy5w aHA6IEFkZGVkLgorICAgICAgICAqIGh0dHAvdGVzdHMvaW5zcGVjdG9yL3N0eWxlcy9zdHlsZXMt cmVkaXJlY3RlZC1jc3MtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBodHRwL3Rlc3Rz L2luc3BlY3Rvci9zdHlsZXMvc3R5bGVzLXJlZGlyZWN0ZWQtY3NzLmh0bWw6IEFkZGVkLgorCiAy MDExLTA5LTIyICBBbHBoYSBMYW0gIDxoY2xhbUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4MDgxCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci9lbGVtZW50cy10ZXN0LmpzIGIvTGF5b3V0 VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3IvZWxlbWVudHMtdGVzdC5qcwppbmRleCBjMmNlMTFh MzdiZWI3OTg5NDE0NzNjNzY4MjM2NjBhZGZmNmNkNmE2Li44YTMxOWUyMzkzZGRkMDZjZjM4NWJj OGQxYzBhZGI1ODc4MzFmNWIwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2lu c3BlY3Rvci9lbGVtZW50cy10ZXN0LmpzCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5z cGVjdG9yL2VsZW1lbnRzLXRlc3QuanMKQEAgLTIyMiw3ICsyMjIsMjQgQEAgSW5zcGVjdG9yVGVz dC5nZXRFbGVtZW50U3R5bGVQcm9wZXJ0eVRyZWVJdGVtID0gZnVuY3Rpb24ocHJvcGVydHlOYW1l KQogewogICAgIHZhciBzdHlsZVNlY3Rpb25zID0gV2ViSW5zcGVjdG9yLnBhbmVscy5lbGVtZW50 cy5zaWRlYmFyUGFuZXMuc3R5bGVzLnNlY3Rpb25zWzBdOwogICAgIHZhciBlbGVtZW50U3R5bGVT ZWN0aW9uID0gc3R5bGVTZWN0aW9uc1sxXTsKLSAgICB2YXIgb3V0bGluZSA9IGVsZW1lbnRTdHls ZVNlY3Rpb24ucHJvcGVydGllc1RyZWVPdXRsaW5lOworICAgIHJldHVybiBJbnNwZWN0b3JUZXN0 LmdldEZpcnN0UHJvcGVydHlUcmVlSXRlbUZvclNlY3Rpb24oZWxlbWVudFN0eWxlU2VjdGlvbiwg cHJvcGVydHlOYW1lKTsKK307CisKKy8vIEZJWE1FOiB0aGlzIHJldHVybnMgdGhlIGZpcnN0IHRy ZWUgaXRlbSBmb3VuZCAobWF5IGZhaWwgZm9yIHNhbWUtbmFtZWQgcHJvcGVydGllcyBpbiBhIHN0 eWxlKS4KK0luc3BlY3RvclRlc3QuZ2V0TWF0Y2hlZFN0eWxlUHJvcGVydHlUcmVlSXRlbSA9IGZ1 bmN0aW9uKHByb3BlcnR5TmFtZSkKK3sKKyAgICB2YXIgc3R5bGVTZWN0aW9ucyA9IFdlYkluc3Bl Y3Rvci5wYW5lbHMuZWxlbWVudHMuc2lkZWJhclBhbmVzLnN0eWxlcy5zZWN0aW9uc1swXTsKKyAg ICBmb3IgKHZhciBpID0gMTsgaSA8IHN0eWxlU2VjdGlvbnMubGVuZ3RoOyArK2kpIHsKKyAgICAg ICAgdmFyIHRyZWVJdGVtID0gSW5zcGVjdG9yVGVzdC5nZXRGaXJzdFByb3BlcnR5VHJlZUl0ZW1G b3JTZWN0aW9uKHN0eWxlU2VjdGlvbnNbaV0sIHByb3BlcnR5TmFtZSk7CisgICAgICAgIGlmICh0 cmVlSXRlbSkKKyAgICAgICAgICAgIHJldHVybiB0cmVlSXRlbTsKKyAgICB9CisgICAgcmV0dXJu IG51bGw7Cit9OworCitJbnNwZWN0b3JUZXN0LmdldEZpcnN0UHJvcGVydHlUcmVlSXRlbUZvclNl Y3Rpb24gPSBmdW5jdGlvbihzZWN0aW9uLCBwcm9wZXJ0eU5hbWUpCit7CisgICAgdmFyIG91dGxp bmUgPSBzZWN0aW9uLnByb3BlcnRpZXNUcmVlT3V0bGluZTsKICAgICBmb3IgKHZhciBpID0gMDsg aSA8IG91dGxpbmUuY2hpbGRyZW4ubGVuZ3RoOyArK2kpIHsKICAgICAgICAgdmFyIHRyZWVJdGVt ID0gb3V0bGluZS5jaGlsZHJlbltpXTsKICAgICAgICAgaWYgKHRyZWVJdGVtLm5hbWUgPT09IHBy b3BlcnR5TmFtZSkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9y L3N0eWxlcy9yZXNvdXJjZXMvc3R5bGVzLXJlZGlyZWN0ZWQtY3NzLmNzcyBiL0xheW91dFRlc3Rz L2h0dHAvdGVzdHMvaW5zcGVjdG9yL3N0eWxlcy9yZXNvdXJjZXMvc3R5bGVzLXJlZGlyZWN0ZWQt Y3NzLmNzcwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwLi44OTU5NjBjMjI1NjQ0MzE5NTI4ODUxMTZmMzAxMzU0Zjg2OTQ1 Njc4Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3Iv c3R5bGVzL3Jlc291cmNlcy9zdHlsZXMtcmVkaXJlY3RlZC1jc3MuY3NzCkBAIC0wLDAgKzEsNCBA QAorZGl2IHsKKyAgICBiYWNrZ3JvdW5kLWNvbG9yOiByZWQ7Cit9CisKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL3N0eWxlcy9yZXNvdXJjZXMvc3R5bGVzLXJl ZGlyZWN0ZWQtY3NzLnBocCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL3N0eWxl cy9yZXNvdXJjZXMvc3R5bGVzLXJlZGlyZWN0ZWQtY3NzLnBocApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi40ODk3OWNk ZDIxYTYxYmI5ZWM0NmQ1NmExZWM5NDE4NjA5NGRlNWUxCi0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3Ivc3R5bGVzL3Jlc291cmNlcy9zdHlsZXMtcmVk aXJlY3RlZC1jc3MucGhwCkBAIC0wLDAgKzEsMyBAQAorPD9waHAKKyAgICBoZWFkZXIoIkxvY2F0 aW9uOiBzdHlsZXMtcmVkaXJlY3RlZC1jc3MuY3NzIik7Cis/PgpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3Ivc3R5bGVzL3N0eWxlcy1yZWRpcmVjdGVkLWNzcy1l eHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci9zdHlsZXMvc3R5 bGVzLXJlZGlyZWN0ZWQtY3NzLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5jN2NmMDcwM2I4ZDNj NDYwMGY5NGQxYTAyNTg2YzZlMjc1OWU0ZDY5Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvaHR0cC90ZXN0cy9pbnNwZWN0b3Ivc3R5bGVzL3N0eWxlcy1yZWRpcmVjdGVkLWNzcy1leHBl Y3RlZC50eHQKQEAgLTAsMCArMSw0IEBACitUZXN0cyB0aGF0IHN0eWxlcyBpbiByZWRpcmVjdGVk IGNzcyBhcmUgZWRpdGFibGUuCisKK0J1ZyA2ODYzMQordGVzdApkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3Ivc3R5bGVzL3N0eWxlcy1yZWRpcmVjdGVkLWNzcy5o dG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3Ivc3R5bGVzL3N0eWxlcy1yZWRp cmVjdGVkLWNzcy5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjhmMmJiYjI2NGU4NzJiYWYwNzZhMjIxZjRlZDYx YjNkMjcxZTZiYWQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2lu c3BlY3Rvci9zdHlsZXMvc3R5bGVzLXJlZGlyZWN0ZWQtY3NzLmh0bWwKQEAgLTAsMCArMSwzMyBA QAorPGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0icmVzb3VyY2Vz L3N0eWxlcy1yZWRpcmVjdGVkLWNzcy5waHAiIHR5cGU9InRleHQvY3NzIj4KKzxzY3JpcHQgc3Jj PSIuLi9pbnNwZWN0b3ItdGVzdC5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vZWxlbWVu dHMtdGVzdC5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0PgorCitmdW5jdGlvbiB0ZXN0KCkKK3sKKyAg ICBJbnNwZWN0b3JUZXN0LnNlbGVjdE5vZGVBbmRXYWl0Rm9yU3R5bGVzKCJ0ZXN0X2RpdiIsIHN0 ZXAxKTsKKworICAgIGZ1bmN0aW9uIHN0ZXAxKCkKKyAgICB7CisgICAgICAgIHZhciB0cmVlSXRl bSA9IEluc3BlY3RvclRlc3QuZ2V0TWF0Y2hlZFN0eWxlUHJvcGVydHlUcmVlSXRlbSgiYmFja2dy b3VuZC1jb2xvciIpOworICAgICAgICB0cmVlSXRlbS5wcm9wZXJ0eS5zZXREaXNhYmxlZCh0cnVl LCBzdGVwMik7CisgICAgfQorCisgICAgZnVuY3Rpb24gc3RlcDIobmV3U3R5bGUpCisgICAgewor ICAgICAgICBJbnNwZWN0b3JUZXN0LmFzc2VydFRydWUoISFuZXdTdHlsZSwgIkNvdWxkIG5vdCBk aXNhYmxlIHN0eWxlIGluIHJlZGlyZWN0ZWQgY3NzLiIpOworICAgICAgICBJbnNwZWN0b3JUZXN0 LmNvbXBsZXRlVGVzdCgpOworICAgIH0KK30KKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25s b2FkPSJydW5UZXN0KCkiPgorPHA+VGVzdHMgdGhhdCBzdHlsZXMgaW4gcmVkaXJlY3RlZCBjc3Mg YXJlIGVkaXRhYmxlLjwvcD4KKzxhIGhyZWY9Imh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD02ODYzMSI+QnVnIDY4NjMxPC9hPgorCis8ZGl2IGlkPSJ0ZXN0X2RpdiI+dGVz dDwvZGl2PgorPC9ib2R5PgorPC9odG1sPgorCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGRhMDNlMmQ0MWNkYmEz MmVjYTQ4YzBkNTUwNTBjMzkzMzBlNjk3ZS4uMjk3ZGNlY2M0Y2RkYWJhMTIzMGJlNjRjMGJhZTIz YjRlYjg3MWFiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTA5LTIyICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEluc3BlY3RvclN0eWxlU2hlZXQgc2hvdWxkIHVzZSBzdHlsZXNoZWV0J3Mgb3JpZ2luYWwg dXJsLCBub3QgZmluYWwgb25lLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Njg2MzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUZXN0OiBodHRwL3Rlc3RzL2luc3BlY3Rvci9zdHlsZXMvc3R5bGVzLXJlZGly ZWN0ZWQtY3NzLmh0bWwKKworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JTdHlsZVNoZWV0 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvclN0eWxlU2hlZXQ6OnJlc291cmNlU3R5 bGVTaGVldFRleHQpOgorCiAyMDExLTA5LTIyICBBbHBoYSBMYW0gIDxoY2xhbUBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4 MDgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yU3R5bGVT aGVldC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yU3R5bGVTaGVldC5j cHAKaW5kZXggOTBkYzMwYzMzNDE2ODMzMzQ3OTJlNDVjYWM2ZTllM2VkNDRjNGIwMi4uMDYzOWMy ZmM5MDMyNjMzNWQ4N2IzYmRhYjVhMzMzNjI3YTFiNzUwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclN0eWxlU2hlZXQuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9JbnNwZWN0b3JTdHlsZVNoZWV0LmNwcApAQCAtMTAwMyw3ICsxMDAzLDcg QEAgYm9vbCBJbnNwZWN0b3JTdHlsZVNoZWV0OjpyZXNvdXJjZVN0eWxlU2hlZXRUZXh0KFN0cmlu ZyogcmVzdWx0KSBjb25zdAogCiAgICAgU3RyaW5nIGVycm9yOwogICAgIGJvb2wgYmFzZTY0RW5j b2RlZDsKLSAgICBJbnNwZWN0b3JQYWdlQWdlbnQ6OnJlc291cmNlQ29udGVudCgmZXJyb3IsIG93 bmVyRG9jdW1lbnQoKS0+ZnJhbWUoKSwgbV9wYWdlU3R5bGVTaGVldC0+ZmluYWxVUkwoKSwgcmVz dWx0LCAmYmFzZTY0RW5jb2RlZCk7CisgICAgSW5zcGVjdG9yUGFnZUFnZW50OjpyZXNvdXJjZUNv bnRlbnQoJmVycm9yLCBvd25lckRvY3VtZW50KCktPmZyYW1lKCksIEtVUkwoUGFyc2VkVVJMU3Ry aW5nLCBtX3BhZ2VTdHlsZVNoZWV0LT5ocmVmKCkpLCByZXN1bHQsICZiYXNlNjRFbmNvZGVkKTsK ICAgICByZXR1cm4gZXJyb3IuaXNFbXB0eSgpICYmICFiYXNlNjRFbmNvZGVkOwogfQogCg==