68626 2011-09-22 09:10:26 -0700 Remove all uses of FindSafari 2011-09-22 10:52:07 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows 7 RESOLVED FIXED PlatformOnly P2 Normal --- 68628 1 aroben aroben sfalken oldest_to_newest 471607 0 aroben 2011-09-22 09:10:26 -0700 FindSafari isn't really needed anymore. It originally had two jobs: 1) Print out commands that could be used to launch Safari with a nightly version of WebKit 2) Print out the path to Safari (1) isn't needed anymore; we have WebKit.exe for launching Safari with nightly builds. And (2) isn't needed, either; we can just use regtool to pull the values out of the registry much more easily. 471608 1 108343 aroben 2011-09-22 09:13:48 -0700 Created attachment 108343 Remove all uses of FindSafari 471695 2 aroben 2011-09-22 10:52:07 -0700 Committed r95733: <http://trac.webkit.org/changeset/95733> 108343 2011-09-22 09:13:48 -0700 2011-09-22 10:06:51 -0700 Remove all uses of FindSafari bug-68626-20110922121353.patch text/plain 4134 aroben U3VidmVyc2lvbiBSZXZpc2lvbjogOTU3MTUKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzNjI1OTZjNDhjZjBkMGMxMGU1ZDYxMGZlYzIxNDg1MmZm YTczYjAxLi40NGMyZjE5YmEzNjAzZmQyMTlhNGRhOTcxODk4Mzc0NmYwMTA0OTVhIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjgg QEAKIDIwMTEtMDktMjIgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCisgICAgICAg IFJlbW92ZSBhbGwgdXNlcyBvZiBGaW5kU2FmYXJpCisKKyAgICAgICAgSXQgaXNuJ3QgcmVhbGx5 IG5lZWRlZCBhbnltb3JlLgorCisgICAgICAgIEZpeGVzIDxodHRwOi8vd2Via2l0Lm9yZy9iLzY4 NjI2Pi4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFNjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHM6IE1vdmVkIHJlYWQvd3JpdGVSZWdpc3RyeVN0 cmluZyBmcm9tIGhlcmUgdG8gd2Via2l0ZGlycy5wbS4KKworICAgICAgICAqIFNjcmlwdHMvcnVu LXdlYmtpdC1uaWdodGx5LmNtZDogUmVtb3ZlZC4gVGhpcyB1c2VkIHRvIGJlIHVzZWQgdG8gbGF1 bmNoIG5pZ2h0bHkgYnVpbGRzIG9mCisgICAgICAgIFdlYktpdCwgYnV0IG5vdyB3ZSB1c2UgV2Vi S2l0LmV4ZSBmb3IgdGhhdC4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAg ICAgICAgKGluc3RhbGxlZFNhZmFyaVBhdGgpOiBDaGFuZ2VkIHRvIHVzZSByZWFkUmVnaXN0cnlT dHJpbmcgaW5zdGVhZCBvZiBpbnZva2luZyBGaW5kU2FmYXJpIHRvCisgICAgICAgIGRvIHRoZSBz YW1lIHRoaW5nLgorCisgICAgICAgIChyZWFkUmVnaXN0cnlTdHJpbmcpOgorICAgICAgICAod3Jp dGVSZWdpc3RyeVN0cmluZyk6CisgICAgICAgIE1vdmVkIGhlcmUgZnJvbSBvbGQtcnVuLXdlYmtp dC10ZXN0cy4KKworMjAxMS0wOS0yMiAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CisK ICAgICAgICAgVXNlIHRoZSAiZGlyZWN0IG9iamVjdCIgZm9ybSBvZiBzeXN0ZW0oKSB0byBydW4g V2ViS2l0LmV4ZQogCiAgICAgICAgIFRoaXMgcHJldmVudHMgdGhlIHNoZWxsIGZyb20gcGFyc2lu ZyAoYW5kIHBvc3NpYmx5IHNwbGl0dGluZywgaWYgaXQgY29udGFpbnMgc3BhY2VzKSB0aGUKZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMgYi9Ub29scy9TY3Jp cHRzL29sZC1ydW4td2Via2l0LXRlc3RzCmluZGV4IGQ0NmNjYTg5Mzg4NmZiMDBmNjQ0OTY0MDdl NjU2YjQxMjhlNjZjNTIuLmVkNWQ4NTJlNDI0MWFhYmUwZTg1YzgwNjUxOWI5YTUxNTcyZmE0M2Eg MTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMKKysrIGIvVG9v bHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0cwpAQCAtMjcxMiwyNSArMjcxMiw2IEBAIHN1 YiBjcmVhdGVEZWJ1Z2dlckNvbW1hbmRGaWxlKCkKICAgICByZXR1cm4gJGNvbW1hbmRGaWxlOwog fQogCi1zdWIgcmVhZFJlZ2lzdHJ5U3RyaW5nKCQpCi17Ci0gICAgbXkgKCR2YWx1ZU5hbWUpID0g QF87Ci0gICAgY2hvbXAobXkgJHN0cmluZyA9IGByZWd0b29sIC0td293MzIgZ2V0ICIkdmFsdWVO YW1lImApOwotICAgIHJldHVybiAkc3RyaW5nOwotfQotCi1zdWIgd3JpdGVSZWdpc3RyeVN0cmlu ZygkJCkKLXsKLSAgICBteSAoJHZhbHVlTmFtZSwgJHN0cmluZykgPSBAXzsKLQotICAgIG15ICRl cnJvciA9IHN5c3RlbSAicmVndG9vbCIsICItLXdvdzMyIiwgInNldCIsICItcyIsICR2YWx1ZU5h bWUsICRzdHJpbmc7Ci0KLSAgICAjIE9uIFdpbmRvd3MgVmlzdGEvNyB3aXRoIFVBQyBlbmFibGVk LCByZWd0b29sIHdpbGwgZmFpbCB0byBtb2RpZnkgdGhlIHJlZ2lzdHJ5LCBidXQgd2lsbCBzdGls bAotICAgICMgcmV0dXJuIGEgc3VjY2Vzc2Z1bCBleGl0IGNvZGUuIFNvIHdlIGRvdWJsZS1jaGVj ayBoZXJlIHRoYXQgdGhlIHZhbHVlIHdlIHRyaWVkIHRvIHdyaXRlIHRvIHRoZQotICAgICMgcmVn aXN0cnkgd2FzIHJlYWxseSB3cml0dGVuLgotICAgIHJldHVybiAhJGVycm9yICYmIHJlYWRSZWdp c3RyeVN0cmluZygkdmFsdWVOYW1lKSBlcSAkc3RyaW5nOwotfQotCiBzdWIgc2V0VXBXaW5kb3dz Q3Jhc2hMb2dTYXZpbmcoKQogewogICAgIHJldHVybiB1bmxlc3MgaXNDeWd3aW4oKTsKZGlmZiAt LWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC1uaWdodGx5LmNtZCBiL1Rvb2xzL1Njcmlw dHMvcnVuLXdlYmtpdC1uaWdodGx5LmNtZApkZWxldGVkIGZpbGUgbW9kZSAxMDA3NTUKaW5kZXgg OTI0MTc4YWJjMjlhYjY2MTM2ZDA4MTBjOGEyZDdhOWEyODFjODMxZC4uMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMAotLS0gYS9Ub29scy9TY3JpcHRzL3J1bi13ZWJraXQt bmlnaHRseS5jbWQKKysrIC9kZXYvbnVsbApAQCAtMSwxMCArMCwwIEBACi1AZWNobyBvZmYKLXNl dCBzY3JpcHQ9JVRNUCVccnVuLXdlYmtpdC1uaWdodGx5Mi5jbWQKLXNldCB2c3ZhcnM9JVZTODBD T01OVE9PTFMlXHZzdmFyczMyLmJhdAotaWYgZXhpc3QgIiV2c3ZhcnMlIiAoCi0gICAgY29weSAi JXZzdmFycyUiICIlc2NyaXB0JSIKLSkgZWxzZSAoCi0gICAgZGVsICIlc2NyaXB0JSIKLSkKLUZp bmRTYWZhcmkuZXhlICUxIC9wcmludFNhZmFyaUxhdW5jaGVyID4+ICIlc2NyaXB0JSIKLWNhbGwg IiVzY3JpcHQlIgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9v bHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IDEzMTMzYjY3OWYxYzJjN2FhOWQ2MmMwOGQ5 ZDljOWJmNmM1YjI3MGQuLjQyY2M1MDljNTk3NzJhYjI4NDMyNTE4OWNmMjUyNmM2YTg5YTFmODUg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdGRpcnMucG0KQEAgLTU2NSw3ICs1NjUsNyBAQCBzdWIgaW5zdGFsbGVkU2FmYXJp UGF0aAogICAgIGlmIChpc0FwcGxlTWFjV2ViS2l0KCkpIHsKICAgICAgICAgJHNhZmFyaUJ1bmRs ZSA9ICIvQXBwbGljYXRpb25zL1NhZmFyaS5hcHAiOwogICAgIH0gZWxzaWYgKGlzQXBwbGVXaW5X ZWJLaXQoKSkgewotICAgICAgICAkc2FmYXJpQnVuZGxlID0gYCIkY29uZmlndXJhdGlvblByb2R1 Y3REaXIvRmluZFNhZmFyaS5leGUiYDsKKyAgICAgICAgJHNhZmFyaUJ1bmRsZSA9IHJlYWRSZWdp c3RyeVN0cmluZygiL0hLTE0vU09GVFdBUkUvQXBwbGUgQ29tcHV0ZXIsIEluYy4vU2FmYXJpL0lu c3RhbGxEaXIiKTsKICAgICAgICAgJHNhZmFyaUJ1bmRsZSA9fiBzL1tcclxuXSskLy87CiAgICAg ICAgICRzYWZhcmlCdW5kbGUgPSBgY3lncGF0aCAtdSAnJHNhZmFyaUJ1bmRsZSdgIGlmIGlzQ3ln d2luKCk7CiAgICAgICAgICRzYWZhcmlCdW5kbGUgPX4gcy9bXHJcbl0rJC8vOwpAQCAtMjE0MSw0 ICsyMTQxLDIzIEBAIHN1YiBydW5UZXN0V2ViS2l0QVBJCiAgICAgcmV0dXJuIDE7CiB9CiAKK3N1 YiByZWFkUmVnaXN0cnlTdHJpbmcKK3sKKyAgICBteSAoJHZhbHVlTmFtZSkgPSBAXzsKKyAgICBj aG9tcChteSAkc3RyaW5nID0gYHJlZ3Rvb2wgLS13b3czMiBnZXQgIiR2YWx1ZU5hbWUiYCk7Cisg ICAgcmV0dXJuICRzdHJpbmc7Cit9CisKK3N1YiB3cml0ZVJlZ2lzdHJ5U3RyaW5nCit7CisgICAg bXkgKCR2YWx1ZU5hbWUsICRzdHJpbmcpID0gQF87CisKKyAgICBteSAkZXJyb3IgPSBzeXN0ZW0g InJlZ3Rvb2wiLCAiLS13b3czMiIsICJzZXQiLCAiLXMiLCAkdmFsdWVOYW1lLCAkc3RyaW5nOwor CisgICAgIyBPbiBXaW5kb3dzIFZpc3RhLzcgd2l0aCBVQUMgZW5hYmxlZCwgcmVndG9vbCB3aWxs IGZhaWwgdG8gbW9kaWZ5IHRoZSByZWdpc3RyeSwgYnV0IHdpbGwgc3RpbGwKKyAgICAjIHJldHVy biBhIHN1Y2Nlc3NmdWwgZXhpdCBjb2RlLiBTbyB3ZSBkb3VibGUtY2hlY2sgaGVyZSB0aGF0IHRo ZSB2YWx1ZSB3ZSB0cmllZCB0byB3cml0ZSB0byB0aGUKKyAgICAjIHJlZ2lzdHJ5IHdhcyByZWFs bHkgd3JpdHRlbi4KKyAgICByZXR1cm4gISRlcnJvciAmJiByZWFkUmVnaXN0cnlTdHJpbmcoJHZh bHVlTmFtZSkgZXEgJHN0cmluZzsKK30KKwogMTsK