68615 2011-09-22 06:19:33 -0700 [Gtk] Title attribute is not respected on option elements 2011-09-23 07:13:11 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 27864 0 bpwv64 webkit-unassigned mrobinson webkit.review.bot oldest_to_newest 471518 0 bpwv64 2011-09-22 06:19:33 -0700 If I create an <option> element with title="option's title text" in a <select>, the tooltip will not be shown in GTK. 471520 1 108324 bpwv64 2011-09-22 06:20:50 -0700 Created attachment 108324 HTML testcase attached. 471525 2 108326 bpwv64 2011-09-22 06:29:15 -0700 Created attachment 108326 Patch. 471616 3 108326 mrobinson 2011-09-22 09:19:59 -0700 Comment on attachment 108326 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=108326&action=review Looks good to me, but I have a few ChangeLog nits below. > Source/WebCore/ChangeLog:3 > + [Gtk] Respect Title attribute on Option elements. This line should be the bug title: [Gtk] Title attribute is not respected on option elements > Source/WebCore/ChangeLog:8 > + Set Tooltip on menuitem widget created from GTKAction. Watch you capilization here. Probably better to say something like: Set tooltip on PopupMenuGtk items created from GtkActions. > Source/WebCore/ChangeLog:13 > + * platform/gtk/GtkPopupMenu.cpp: > + (WebCore::GtkPopupMenu::appendItem): > + * platform/gtk/PopupMenuGtk.cpp: > + (WebCore::PopupMenuGtk::createGtkActionForMenuItem): Please fill these out. 472083 4 108443 bpwv64 2011-09-22 22:59:44 -0700 Created attachment 108443 Updated Patch 472218 5 108443 webkit.review.bot 2011-09-23 07:13:07 -0700 Comment on attachment 108443 Updated Patch Clearing flags on attachment: 108443 Committed r95800: <http://trac.webkit.org/changeset/95800> 472219 6 webkit.review.bot 2011-09-23 07:13:11 -0700 All reviewed patches have been landed. Closing bug. 108324 2011-09-22 06:20:50 -0700 2011-09-22 06:20:50 -0700 HTML testcase attached. testcase.html text/html 416 bpwv64 PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFs Ly9FTiIgImh0dHA6Ly93d3cudzMub3JnL1RSL2h0bWw0L2xvb3NlLmR0ZCI+CjxodG1sPgo8aGVh ZD4KPG1ldGEgaHR0cC1lcXVpdj0iQ29udGVudC1UeXBlIiBjb250ZW50PSJ0ZXh0L2h0bWw7IGNo YXJzZXQ9VVRGLTgiPgo8dGl0bGU+SW5zZXJ0IHRpdGxlIGhlcmU8L3RpdGxlPgo8L2hlYWQ+Cjxi b2R5Pgo8Zm9ybSBhY3Rpb249IiI+CjxzZWxlY3Q+CiAgICA8b3B0aW9uIHRpdGxlPSJ0b29sdGlw IGZvciAnb3B0aW9uIDEnIj5vcHRpb24gMTwvb3B0aW9uPgogICAgPG9wdGlvbiB0aXRsZT0idG9v bHRpcCBmb3IgJ29wdGlvbiAyJyI+b3B0aW9uIDI8L29wdGlvbj4KPC9zZWxlY3Q+Cgo8L2Zvcm0+ CjwvYm9keT4KPC9odG1sPgo= 108326 2011-09-22 06:29:15 -0700 2011-09-22 22:59:44 -0700 Patch. patch.diff text/plain 2444 bpwv64 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk1NzE0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDktMjIgIERlZXBhayBT aGVydmVnaGFyICA8YnB3djY0QG1vdG9yb2xhLmNvbT4KKworICAgICAgICBbR3RrXSBSZXNwZWN0 IFRpdGxlIGF0dHJpYnV0ZSBvbiBPcHRpb24gZWxlbWVudHMuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODYxNQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNldCBUb29sdGlwIG9uIG1lbnVpdGVtIHdpZGdl dCBjcmVhdGVkIGZyb20gR1RLQWN0aW9uLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL0d0a1Bv cHVwTWVudS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHdGtQb3B1cE1lbnU6OmFwcGVuZEl0ZW0p OgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9Qb3B1cE1lbnVHdGsuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UG9wdXBNZW51R3RrOjpjcmVhdGVHdGtBY3Rpb25Gb3JNZW51SXRlbSk6CisKIDIwMTEt MDktMjIgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCiAgICAgICAgIENTUzog SW1wbGVtZW50ICdmb250JyBwcm9wZXJ0eSBpbiBDU1NDb21wdXRlZFN0eWxlLgpJbmRleDogU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0d0a1BvcHVwTWVudS5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0d0a1BvcHVwTWVudS5jcHAJKHJldmlzaW9uIDk1 NzEwKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0d0a1BvcHVwTWVudS5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTY0LDYgKzY0LDcgQEAgdm9pZCBHdGtQb3B1cE1lbnU6OmFwcGVuZFNl cGFyYXRvcigpCiB2b2lkIEd0a1BvcHVwTWVudTo6YXBwZW5kSXRlbShHdGtBY3Rpb24qIGFjdGlv bikKIHsKICAgICBHdGtXaWRnZXQqIG1lbnVJdGVtID0gZ3RrX2FjdGlvbl9jcmVhdGVfbWVudV9p dGVtKGFjdGlvbik7CisgICAgZ3RrX3dpZGdldF9zZXRfdG9vbHRpcF90ZXh0KG1lbnVJdGVtLCBn dGtfYWN0aW9uX2dldF90b29sdGlwKGFjdGlvbikpOwogICAgIGdfc2lnbmFsX2Nvbm5lY3QobWVu dUl0ZW0sICJzZWxlY3QiLCBHX0NBTExCQUNLKEd0a1BvcHVwTWVudTo6c2VsZWN0SXRlbUNhbGxi YWNrKSwgdGhpcyk7CiAgICAgZ3RrX21lbnVfc2hlbGxfYXBwZW5kKEdUS19NRU5VX1NIRUxMKG1f cG9wdXAuZ2V0KCkpLCBtZW51SXRlbSk7CiAgICAgZ3RrX3dpZGdldF9zaG93KG1lbnVJdGVtKTsK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Qb3B1cE1lbnVHdGsuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Qb3B1cE1lbnVHdGsuY3BwCShy ZXZpc2lvbiA5NTcxMCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Qb3B1cE1lbnVH dGsuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NCw3ICs1NCw3IEBAIFBvcHVwTWVudUd0azo6flBv cHVwTWVudUd0aygpCiBHdGtBY3Rpb24qIFBvcHVwTWVudUd0azo6Y3JlYXRlR3RrQWN0aW9uRm9y TWVudUl0ZW0oaW50IGl0ZW1JbmRleCkKIHsKICAgICBHT3duUHRyPGNoYXI+IGFjdGlvbk5hbWUo Z19zdHJkdXBfcHJpbnRmKCJwb3B1cC1tZW51LWFjdGlvbi0lZCIsIGl0ZW1JbmRleCkpOwotICAg IEd0a0FjdGlvbiogYWN0aW9uID0gZ3RrX2FjdGlvbl9uZXcoYWN0aW9uTmFtZS5nZXQoKSwgY2xp ZW50KCktPml0ZW1UZXh0KGl0ZW1JbmRleCkudXRmOCgpLmRhdGEoKSwgMCwgMCk7CisgICAgR3Rr QWN0aW9uKiBhY3Rpb24gPSBndGtfYWN0aW9uX25ldyhhY3Rpb25OYW1lLmdldCgpLCBjbGllbnQo KS0+aXRlbVRleHQoaXRlbUluZGV4KS51dGY4KCkuZGF0YSgpLCBjbGllbnQoKS0+aXRlbVRvb2xU aXAoaXRlbUluZGV4KS51dGY4KCkuZGF0YSgpLCAwKTsKICAgICBnX29iamVjdF9zZXRfZGF0YShH X09CSkVDVChhY3Rpb24pLCAicG9wdXAtbWVudS1hY3Rpb24taW5kZXgiLCBHSU5UX1RPX1BPSU5U RVIoaXRlbUluZGV4KSk7CiAgICAgZ19zaWduYWxfY29ubmVjdChhY3Rpb24sICJhY3RpdmF0ZSIs IEdfQ0FMTEJBQ0sobWVudUl0ZW1BY3RpdmF0ZWQpLCB0aGlzKTsKICAgICAvLyBGSVhNRTogQXBw bHkgdGhlIFBvcHVwTWVudVN0eWxlIGZyb20gY2xpZW50KCktPml0ZW1TdHlsZShpKQo= 108443 2011-09-22 22:59:44 -0700 2011-09-23 07:13:07 -0700 Updated Patch patch.diff text/plain 2639 bpwv64 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk1NzgzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDktMjIgIERlZXBhayBT aGVydmVnaGFyICA8YnB3djY0QG1vdG9yb2xhLmNvbT4KKworICAgICAgICBbR3RrXSBUaXRsZSBh dHRyaWJ1dGUgaXMgbm90IHJlc3BlY3RlZCBvbiBvcHRpb24gZWxlbWVudHMuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODYxNQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNldCB0b29sdGlwIG9uIFBvcHVw TWVudUd0ayBpdGVtcyBjcmVhdGVkIGZyb20gR3RrQWN0aW9ucy4KKworICAgICAgICAqIHBsYXRm b3JtL2d0ay9HdGtQb3B1cE1lbnUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3RrUG9wdXBNZW51 OjphcHBlbmRJdGVtKTogQWRkZWQgYSBjYWxsIHRvIGd0a193aWRnZXRfc2V0X3Rvb2x0aXBfdGV4 dCgpCisgICAgICAgICAgICB0byBzZXQgdGhlIHRvb2x0aXAgb24gbWVudWl0ZW0uIFRvb2x0aXAg dGV4dCBpcyByZXRyaWV2ZWQgZnJvbSBHdGtBY3Rpb24uCisgICAgICAgICogcGxhdGZvcm0vZ3Rr L1BvcHVwTWVudUd0ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQb3B1cE1lbnVHdGs6OmNyZWF0 ZUd0a0FjdGlvbkZvck1lbnVJdGVtKTogUGFzcyB0aGUgdG9vbHRpcCB0ZXh0CisgICAgICAgICAg ICBmcm9tIGNsaWVudCB3aGVuIGNyZWF0aW5nIGEgR3RrQWN0aW9uLgorCiAyMDExLTA5LTIyICBU b255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgaW1wbGVtZW50IC13ZWJr aXQtZmxleC1vcmRlcgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0d0a1BvcHVw TWVudS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0d0a1Bv cHVwTWVudS5jcHAJKHJldmlzaW9uIDk1NzgzKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3RrL0d0a1BvcHVwTWVudS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY1LDYgKzY1LDcgQEAgdm9p ZCBHdGtQb3B1cE1lbnU6OmFwcGVuZFNlcGFyYXRvcigpCiB2b2lkIEd0a1BvcHVwTWVudTo6YXBw ZW5kSXRlbShHdGtBY3Rpb24qIGFjdGlvbikKIHsKICAgICBHdGtXaWRnZXQqIG1lbnVJdGVtID0g Z3RrX2FjdGlvbl9jcmVhdGVfbWVudV9pdGVtKGFjdGlvbik7CisgICAgZ3RrX3dpZGdldF9zZXRf dG9vbHRpcF90ZXh0KG1lbnVJdGVtLCBndGtfYWN0aW9uX2dldF90b29sdGlwKGFjdGlvbikpOwog ICAgIGdfc2lnbmFsX2Nvbm5lY3QobWVudUl0ZW0sICJzZWxlY3QiLCBHX0NBTExCQUNLKEd0a1Bv cHVwTWVudTo6c2VsZWN0SXRlbUNhbGxiYWNrKSwgdGhpcyk7CiAgICAgZ3RrX21lbnVfc2hlbGxf YXBwZW5kKEdUS19NRU5VX1NIRUxMKG1fcG9wdXAuZ2V0KCkpLCBtZW51SXRlbSk7CiAgICAgZ3Rr X3dpZGdldF9zaG93KG1lbnVJdGVtKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0 ay9Qb3B1cE1lbnVHdGsuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2d0ay9Qb3B1cE1lbnVHdGsuY3BwCShyZXZpc2lvbiA5NTc4MykKKysrIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2d0ay9Qb3B1cE1lbnVHdGsuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NCw3ICs1 NCw3IEBAIFBvcHVwTWVudUd0azo6flBvcHVwTWVudUd0aygpCiBHdGtBY3Rpb24qIFBvcHVwTWVu dUd0azo6Y3JlYXRlR3RrQWN0aW9uRm9yTWVudUl0ZW0oaW50IGl0ZW1JbmRleCkKIHsKICAgICBH T3duUHRyPGNoYXI+IGFjdGlvbk5hbWUoZ19zdHJkdXBfcHJpbnRmKCJwb3B1cC1tZW51LWFjdGlv bi0lZCIsIGl0ZW1JbmRleCkpOwotICAgIEd0a0FjdGlvbiogYWN0aW9uID0gZ3RrX2FjdGlvbl9u ZXcoYWN0aW9uTmFtZS5nZXQoKSwgY2xpZW50KCktPml0ZW1UZXh0KGl0ZW1JbmRleCkudXRmOCgp LmRhdGEoKSwgMCwgMCk7CisgICAgR3RrQWN0aW9uKiBhY3Rpb24gPSBndGtfYWN0aW9uX25ldyhh Y3Rpb25OYW1lLmdldCgpLCBjbGllbnQoKS0+aXRlbVRleHQoaXRlbUluZGV4KS51dGY4KCkuZGF0 YSgpLCBjbGllbnQoKS0+aXRlbVRvb2xUaXAoaXRlbUluZGV4KS51dGY4KCkuZGF0YSgpLCAwKTsK ICAgICBnX29iamVjdF9zZXRfZGF0YShHX09CSkVDVChhY3Rpb24pLCAicG9wdXAtbWVudS1hY3Rp b24taW5kZXgiLCBHSU5UX1RPX1BPSU5URVIoaXRlbUluZGV4KSk7CiAgICAgZ19zaWduYWxfY29u bmVjdChhY3Rpb24sICJhY3RpdmF0ZSIsIEdfQ0FMTEJBQ0sobWVudUl0ZW1BY3RpdmF0ZWQpLCB0 aGlzKTsKICAgICAvLyBGSVhNRTogQXBwbHkgdGhlIFBvcHVwTWVudVN0eWxlIGZyb20gY2xpZW50 KCktPml0ZW1TdHlsZShpKQo=