68600 2011-09-22 01:23:01 -0700 [GTK] REGRESSION: Empathy crashes when switching theme 2011-09-26 05:05:16 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Major --- 0 gdesmott gustavo darin gustavo mrobinson oldest_to_newest 471424 0 gdesmott 2011-09-22 01:23:01 -0700 Original bug report: https://bugzilla.gnome.org/show_bug.cgi?id=659782 - Open empathy's preference dialog - Select an Adium theme - Select a classic theme like "Clean" ==24172== Invalid read of size 8 ==24172== at 0xBACE007: WebKit::core(_WebKitWebView*) (in /home/cassidy/usr/lib64/libwebkitgtk-3.0.so.0.9.0) ==24172== by 0xBAADC45: WebKit::GtkAdjustmentWatcher::adjustmentValueChanged(_GtkAdjustment*) (in /home/cassidy/usr/lib64/libwebkitgtk-3.0.so.0.9.0) ==24172== by 0xF62B543: g_cclosure_marshal_VOID__VOID (gmarshal.c:85) ==24172== by 0xF62998A: g_closure_invoke (gclosure.c:774) ==24172== by 0xF6454DA: signal_emit_unlocked_R (gsignal.c:3272) ==24172== by 0xF64441C: g_signal_emit_valist (gsignal.c:3003) ==24172== by 0xF644985: g_signal_emit (gsignal.c:3060) ==24172== by 0xCF8C1BE: gtk_adjustment_value_changed (gtkadjustment.c:764) ==24172== by 0xCF8B729: gtk_adjustment_set_value (gtkadjustment.c:445) ==24172== by 0x50124B: chat_text_view_scroll_cb (empathy-chat-text-view.c:687) ==24172== by 0xFED4012: g_timeout_dispatch (gmain.c:3907) ==24172== by 0xFED0A22: g_main_dispatch (gmain.c:2441) ==24172== by 0xFED1F68: g_main_context_dispatch (gmain.c:3011) ==24172== by 0xFED2415: g_main_context_iterate (gmain.c:3089) ==24172== by 0xFED2B6E: g_main_loop_run (gmain.c:3297) ==24172== by 0xD0C0F60: gtk_main (gtkmain.c:1362) ==24172== by 0xCF9591D: gtk_application_run_mainloop (gtkapplication.c:115) ==24172== by 0xF34AEC8: g_application_run (gapplication.c:1323) ==24172== by 0x4594C4: main (empathy.c:838) ==24172== Address 0x224a3f38 is 40 bytes inside a block of size 656 free'd ==24172== at 0x4C282ED: free (vg_replace_malloc.c:366) ==24172== by 0xFEDA7BD: g_free (gmem.c:263) ==24172== by 0xFEF3E03: g_slice_free1 (gslice.c:907) ==24172== by 0xF64A875: g_type_free_instance (gtype.c:1930) ==24172== by 0xF63359A: g_object_unref (gobject.c:2759) ==24172== by 0xF62E5E2: g_object_run_dispose (gobject.c:947) ==24172== by 0xD26C429: gtk_widget_destroy (gtkwidget.c:3837) ==24172== by 0x45420A: preferences_preview_theme_changed_cb (empathy-preferences.c:717) ==24172== by 0xF62B543: g_cclosure_marshal_VOID__VOID (gmarshal.c:85) ==24172== by 0xF62998A: g_closure_invoke (gclosure.c:774) ==24172== by 0xF6454DA: signal_emit_unlocked_R (gsignal.c:3272) ==24172== by 0xF64441C: g_signal_emit_valist (gsignal.c:3003) ==24172== by 0xF644985: g_signal_emit (gsignal.c:3060) ==24172== by 0x46D479: theme_manager_emit_changed_idle_cb (empathy-theme-manager.c:92) ==24172== by 0xFED516E: g_idle_dispatch (gmain.c:4801) ==24172== by 0xFED0A22: g_main_dispatch (gmain.c:2441) ==24172== by 0xFED1F68: g_main_context_dispatch (gmain.c:3011) ==24172== by 0xFED2415: g_main_context_iterate (gmain.c:3089) ==24172== by 0xFED2B6E: g_main_loop_run (gmain.c:3297) ==24172== by 0xD0C0F60: gtk_main (gtkmain.c:1362) This uses to work fine so that's probably a WebKit regression. 471928 1 108415 gustavo 2011-09-22 16:13:18 -0700 Created attachment 108415 Patch 473057 2 108415 gustavo 2011-09-26 05:05:08 -0700 Comment on attachment 108415 Patch Clearing flags on attachment: 108415 Committed r95940: <http://trac.webkit.org/changeset/95940> 473058 3 gustavo 2011-09-26 05:05:16 -0700 All reviewed patches have been landed. Closing bug. 108415 2011-09-22 16:13:18 -0700 2011-09-26 05:05:08 -0700 Patch bug-68600-20110922201316.patch text/plain 3405 gustavo U3VidmVyc2lvbiBSZXZpc2lvbjogOTU3NjEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3Rr L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCA0YmE3Yzk1NGFl MWE0YTM2YTVkZDJjNjQ4NjExNTY4ODNlMWE2Y2MwLi5hOWZiMGQ1ZWRiZjMyZTljN2FlZGUxZTM5 NjY5NTA2MTE1ZjkwMTA2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAgQEAKIDIwMTEt MDktMjIgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJvcmEu Y29tPgogCisgICAgICAgIFJFR1JFU1NJT046IEVtcGF0aHkgY3Jhc2hlcyB3aGVuIHN3aXRjaGlu ZyB0aGVtZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 Njg2MDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IHdlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfdmlld19zZXRf c2Nyb2xsX2FkanVzdG1lbnRzKTogdXNlIHRoZSBleGlzdGluZworICAgICAgICBzZXR7SG9yaXpv bnRhbCxWZXJ0aWNhbH1BZGp1c3RtZW50IGZ1bmN0aW9ucywgc28gdGhlIGNvZGUgaXMgbm90Cisg ICAgICAgIGR1cGxpY2F0ZWQKKyAgICAgICAgKHdlYmtpdF93ZWJfdmlld19kaXNwb3NlKTogdW5z ZXQgdGhlIGFkanVzdG1lbnRzIGR1cmluZyBkaXNwb3NlLAorICAgICAgICB0byBhdm9pZCBsYXRl IGFkanVzdG1lbnQgY2hhbmdlIG5vdGlmaWNhdGlvbnMgaGl0dGluZyB0aGUKKyAgICAgICAgYWRq dXN0bWVudCB3YXRjaGVyCisKKzIwMTEtMDktMjIgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGd1 c3Rhdm8ubm9yb25oYUBjb2xsYWJvcmEuY29tPgorCiAgICAgICAgIFJlbW92ZSB1c2VsZXNzIGVt cHR5IFdlYktpdCBuYW1lc3BhY2UuCiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWGFuIExvcGV6Lgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwIGIv U291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCmluZGV4IDc0MmM0MjE1 NTZlMTlmYTI0MzQyMmFmYzY4MTM0YzZhNWM3NmMyMmMuLmMxNjllNjlhNGIzZWQxMzhjMzRiOWVj ZjM5YWVkZWU3YzNlNzU1ZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93 ZWJraXR3ZWJ2aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vi dmlldy5jcHAKQEAgLTQyNyw3ICs0MjcsNiBAQCBzdGF0aWMgZ2Jvb2xlYW4gd2Via2l0X3dlYl92 aWV3X3BvcHVwX21lbnVfaGFuZGxlcihHdGtXaWRnZXQqIHdpZGdldCkKICAgICByZXR1cm4gd2Vi a2l0X3dlYl92aWV3X2ZvcndhcmRfY29udGV4dF9tZW51X2V2ZW50KFdFQktJVF9XRUJfVklFVyh3 aWRnZXQpLCBldmVudCk7CiB9CiAKLSNpZm5kZWYgR1RLX0FQSV9WRVJTSU9OXzIKIHN0YXRpYyB2 b2lkIHNldEhvcml6b250YWxBZGp1c3RtZW50KFdlYktpdFdlYlZpZXcqIHdlYlZpZXcsIEd0a0Fk anVzdG1lbnQqIGFkanVzdG1lbnQpCiB7CiAgICAgLy8gVGhpcyBtYXkgYmUgY2FsbGVkIGFmdGVy IHRoZSBwYWdlIGhhcyBiZWVuIGRlc3Ryb3llZCwgaW4gd2hpY2ggY2FzZSB3ZSBkbyBub3RoaW5n LgpAQCAtNDQ0LDYgKzQ0Myw3IEBAIHN0YXRpYyB2b2lkIHNldFZlcnRpY2FsQWRqdXN0bWVudChX ZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCBHdGtBZGp1c3RtZW50KiBhZGp1c3RtCiAgICAgICAgIHN0 YXRpY19jYXN0PFdlYktpdDo6Q2hyb21lQ2xpZW50Kj4ocGFnZS0+Y2hyb21lKCktPmNsaWVudCgp KS0+YWRqdXN0bWVudFdhdGNoZXIoKS0+c2V0VmVydGljYWxBZGp1c3RtZW50KGFkanVzdG1lbnQp OwogfQogCisjaWZuZGVmIEdUS19BUElfVkVSU0lPTl8yCiBzdGF0aWMgR3RrQWRqdXN0bWVudCog Z2V0SG9yaXpvbnRhbEFkanVzdG1lbnQoV2ViS2l0V2ViVmlldyogd2ViVmlldykKIHsKICAgICBQ YWdlKiBwYWdlID0gY29yZSh3ZWJWaWV3KTsKQEAgLTEwMzksMTQgKzEwMzksOCBAQCBzdGF0aWMg dm9pZCB3ZWJraXRfd2ViX3ZpZXdfcmVhbGl6ZShHdGtXaWRnZXQqIHdpZGdldCkKICNpZmRlZiBH VEtfQVBJX1ZFUlNJT05fMgogc3RhdGljIHZvaWQgd2Via2l0X3dlYl92aWV3X3NldF9zY3JvbGxf YWRqdXN0bWVudHMoV2ViS2l0V2ViVmlldyogd2ViVmlldywgR3RrQWRqdXN0bWVudCogaG9yaXpv bnRhbEFkanVzdG1lbnQsIEd0a0FkanVzdG1lbnQqIHZlcnRpY2FsQWRqdXN0bWVudCkKIHsKLSAg ICAvLyBUaGlzIG1heSBiZSBjYWxsZWQgYWZ0ZXIgdGhlIHBhZ2UgaGFzIGJlZW4gZGVzdHJveWVk LCBpbiB3aGljaCBjYXNlIHdlIGRvIG5vdGhpbmcuCi0gICAgUGFnZSogcGFnZSA9IGNvcmUod2Vi Vmlldyk7Ci0gICAgaWYgKCFwYWdlKQotICAgICAgICByZXR1cm47Ci0KLSAgICBXZWJLaXQ6OkNo cm9tZUNsaWVudCogY2xpZW50ID0gc3RhdGljX2Nhc3Q8V2ViS2l0OjpDaHJvbWVDbGllbnQqPihw YWdlLT5jaHJvbWUoKS0+Y2xpZW50KCkpOwotICAgIGNsaWVudC0+YWRqdXN0bWVudFdhdGNoZXIo KS0+c2V0SG9yaXpvbnRhbEFkanVzdG1lbnQoaG9yaXpvbnRhbEFkanVzdG1lbnQpOwotICAgIGNs aWVudC0+YWRqdXN0bWVudFdhdGNoZXIoKS0+c2V0VmVydGljYWxBZGp1c3RtZW50KHZlcnRpY2Fs QWRqdXN0bWVudCk7CisgICAgc2V0SG9yaXpvbnRhbEFkanVzdG1lbnQod2ViVmlldywgaG9yaXpv bnRhbEFkanVzdG1lbnQpOworICAgIHNldFZlcnRpY2FsQWRqdXN0bWVudCh3ZWJWaWV3LCB2ZXJ0 aWNhbEFkanVzdG1lbnQpOwogfQogI2VuZGlmCiAKQEAgLTEzMDcsNiArMTMwMSwxMSBAQCBzdGF0 aWMgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfZGlzcG9zZShHT2JqZWN0KiBvYmplY3QpCiAKICAgICBw cml2LT5kaXNwb3NpbmcgPSBUUlVFOwogCisgICAgLy8gTWFrZSBzdXJlIEd0a0FkanVzdG1lbnRX YXRjaGVyIHdvbid0IGJlIHJlYWN0aW5nIHRvIGFkanVzdG1lbnQgY2hhbmdlcyBhZnRlciB0aGUK KyAgICAvLyBXZWJWaWV3IGlzIGRlc3Ryb3llZC4KKyAgICBzZXRIb3Jpem9udGFsQWRqdXN0bWVu dCh3ZWJWaWV3LCAwKTsKKyAgICBzZXRWZXJ0aWNhbEFkanVzdG1lbnQod2ViVmlldywgMCk7CisK ICAgICAvLyBUaGVzZSBzbWFydCBwb2ludGVycyBhcmUgY2xlYXJlZCBtYW51YWxseSwgYmVjYXVz ZSBzb21lIGNsZWFudXAgb3BlcmF0aW9ucyBhcmUKICAgICAvLyB2ZXJ5IHNlbnNpdGl2ZSB0byB0 aGVpciB2YWx1ZS4gV2UgbWF5IGNyYXNoIGlmIHRoZXNlIGFyZSBkb25lIGluIHRoZSB3cm9uZyBv cmRlci4KICAgICBwcml2LT5iYWNrRm9yd2FyZExpc3QuY2xlYXIoKTsK