68594 2011-09-21 23:26:57 -0700 [EFL] Remove useless assignment code in _ewk_tiled_backing_store_zoom_set_internal. 2011-09-28 19:51:22 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 0 hyuki.kim webkit-unassigned gyuyoung.kim gyuyoung.kim leandro lucas.de.marchi rakuco ryuan.choi webkit.review.bot oldest_to_newest 471371 0 hyuki.kim 2011-09-21 23:26:57 -0700 As the 1st assignment of local variable bx in _ewk_tiled_backing_store_zoom_set_internal isn't effective at all, this patch just removes it. 471373 1 108280 hyuki.kim 2011-09-21 23:28:58 -0700 Created attachment 108280 Patch. 471514 2 108280 lucas.de.marchi 2011-09-22 06:09:53 -0700 Comment on attachment 108280 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=108280&action=review > Source/WebKit/efl/ChangeLog:7 > + [EFL] Remove useless assignment code in _ewk_tiled_backing_store_zoom_set_internal. > + https://bugs.webkit.org/show_bug.cgi?id=68594 > + > + As the 1st assignment of local variable bx in _ewk_tiled_backing_store_zoom_set_internal > + isn't effective at all, this patch just removes it. Are you using any static analyzer tool? Could you mention it here? I think patches like this would be better to be applied all together instead of going through each function and opening a separate bug. 471519 3 hyuki.kim 2011-09-22 06:19:34 -0700 > Are you using any static analyzer tool? Could you mention it here? > > I think patches like this would be better to be applied all together instead of going through each function and opening a separate bug. No, Unfortunately, static analyzer didn't detect it ever before. I noticed this while I was checking the way to reduce number of calling smart calculate on ewk's tiled backing store. 471644 4 rakuco 2011-09-22 09:47:36 -0700 LGTM. 474436 5 108280 gyuyoung.kim 2011-09-27 19:13:14 -0700 Comment on attachment 108280 Patch. LGTM. 1503 line is unneeded code. 475200 6 108280 webkit.review.bot 2011-09-28 19:51:17 -0700 Comment on attachment 108280 Patch. Clearing flags on attachment: 108280 Committed r96291: <http://trac.webkit.org/changeset/96291> 475201 7 webkit.review.bot 2011-09-28 19:51:22 -0700 All reviewed patches have been landed. Closing bug. 108280 2011-09-21 23:28:58 -0700 2011-09-28 19:51:17 -0700 Patch. 0922_remove_useless_assign.patch text/plain 2116 hyuki.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBlYmJlYWYxLi42NWE4NGQxIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTEtMDktMjEgIEt3YW5nSHl1ayBLaW0gIDxoeXVraS5raW1Ac2Ft c3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gUmVtb3ZlIHVzZWxlc3MgYXNzaWdubWVudCBjb2Rl IGluIF9ld2tfdGlsZWRfYmFja2luZ19zdG9yZV96b29tX3NldF9pbnRlcm5hbC4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4NTk0CisKKyAgICAgICAg QXMgdGhlIDFzdCBhc3NpZ25tZW50IG9mIGxvY2FsIHZhcmlhYmxlIGJ4IGluIF9ld2tfdGlsZWRf YmFja2luZ19zdG9yZV96b29tX3NldF9pbnRlcm5hbAorICAgICAgICBpc24ndCBlZmZlY3RpdmUg YXQgYWxsLCB0aGlzIHBhdGNoIGp1c3QgcmVtb3ZlcyBpdC4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGV3ay9ld2tfdGlsZWRfYmFja2luZ19zdG9y ZS5jOgorICAgICAgICAoX2V3a190aWxlZF9iYWNraW5nX3N0b3JlX3pvb21fc2V0X2ludGVybmFs KToKKwogMjAxMS0wOS0yMSAgTHVjYXMgRGUgTWFyY2hpICA8bHVjYXMuZGVtYXJjaGlAcHJvZnVz aW9uLm1vYmk+CiAKICAgICAgICAgW0VGTF0gUmV2ZXJ0IHBvaW50ZXIgb3BlcmF0b3IgY29kaW5n IHN0eWxlIGluIGV3awpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a190aWxl ZF9iYWNraW5nX3N0b3JlLmMgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3RpbGVkX2JhY2tp bmdfc3RvcmUuYwppbmRleCA3NmE5OWY4Li5iMzI1MTM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2VmbC9ld2svZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmUuYworKysgYi9Tb3VyY2UvV2ViS2l0 L2VmbC9ld2svZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmUuYwpAQCAtMTUwMCw4ICsxNTAwLDYgQEAg c3RhdGljIEVpbmFfQm9vbCBfZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmVfem9vbV9zZXRfaW50ZXJu YWwoRXdrX1RpbGVkX0JhY2tpbmdfU3QKIAogICAgIEV2YXNfQ29vcmQgbmV3X3ggPSBjeCArIChw cml2LT52aWV3Lm9mZnNldC5jdXIueCAtIGN4KSAqIHNjYWxlOwogICAgIEV2YXNfQ29vcmQgbmV3 X3kgPSBjeSArIChwcml2LT52aWV3Lm9mZnNldC5jdXIueSAtIGN5KSAqIHNjYWxlOwotICAgIEV2 YXNfQ29vcmQgYnggPSBjeCArIChwcml2LT52aWV3Lm9mZnNldC5iYXNlLnggLSBjeCkgKiBzY2Fs ZTsKLSAgICBFdmFzX0Nvb3JkIGJ5ID0gY3kgKyAocHJpdi0+dmlldy5vZmZzZXQuYmFzZS55IC0g Y3kpICogc2NhbGU7CiAKICAgICBFdmFzX0Nvb3JkIG1vZGVsX3dpZHRoID0gcHJpdi0+bW9kZWwu d2lkdGggKiBzY2FsZTsKICAgICBFdmFzX0Nvb3JkIG1vZGVsX2hlaWdodCA9IHByaXYtPm1vZGVs LmhlaWdodCAqIHNjYWxlOwpAQCAtMTUxNiwxMCArMTUxNCwxMCBAQCBzdGF0aWMgRWluYV9Cb29s IF9ld2tfdGlsZWRfYmFja2luZ19zdG9yZV96b29tX3NldF9pbnRlcm5hbChFd2tfVGlsZWRfQmFj a2luZ19TdAogICAgIGVsc2UgaWYgKC1uZXdfeSArIHByaXYtPnZpZXcuaCA+PSBtb2RlbF9oZWln aHQpCiAgICAgICAgIG5ld195ID0gLW1vZGVsX2hlaWdodCArIHByaXYtPnZpZXcuaDsKIAotICAg IGJ4ID0gbmV3X3ggJSB0dzsKLSAgICBwcml2LT5tb2RlbC5iYXNlLmNvbCA9IC0gbmV3X3ggLyB0 dzsKLSAgICBieSA9IG5ld195ICUgdGg7Ci0gICAgcHJpdi0+bW9kZWwuYmFzZS5yb3cgPSAtIG5l d195IC8gdGg7CisgICAgRXZhc19Db29yZCBieCA9IG5ld194ICUgdHc7CisgICAgRXZhc19Db29y ZCBieSA9IG5ld195ICUgdGg7CisgICAgcHJpdi0+bW9kZWwuYmFzZS5jb2wgPSAtbmV3X3ggLyB0 dzsKKyAgICBwcml2LT5tb2RlbC5iYXNlLnJvdyA9IC1uZXdfeSAvIHRoOwogCiAgICAgcHJpdi0+ Y2hhbmdlZC5zaXplID0gRUlOQV9UUlVFOwogICAgIHByaXYtPmNoYW5nZWQubW9kZWwgPSBFSU5B X1RSVUU7Cg==